133790 2014-06-12 02:05:18 -0700 Buildfix if LLINT_SLOW_PATH_TRACING is enabled 2014-07-15 03:50:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 evab.u-szeged webkit-unassigned barraclough commit-queue evab.u-szeged fpizlo ggaren mark.lam mhahnenberg oliver ossy oldest_to_newest 1015056 0 evab.u-szeged 2014-06-12 02:05:18 -0700 After enabling LLINT_SLOW_PATH_TRACING in Source/JavaScriptCore/llint/LLIntCommon.h, I got the following build fail: WebKit/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:461:73: error: 'class JSC::JSStack' has no member named 'end' JSStack::end() was removed by r159605. 1015057 1 232937 evab.u-szeged 2014-06-12 02:07:50 -0700 Created attachment 232937 Patch 1022199 2 evab.u-szeged 2014-07-14 04:51:52 -0700 Could someone review this patch for me? Thanks! 1022260 3 232937 mark.lam 2014-07-14 11:16:05 -0700 Comment on attachment 232937 Patch r=me 1022435 4 232937 commit-queue 2014-07-15 03:50:18 -0700 Comment on attachment 232937 Patch Clearing flags on attachment: 232937 Committed r171104: <http://trac.webkit.org/changeset/171104> 1022436 5 commit-queue 2014-07-15 03:50:22 -0700 All reviewed patches have been landed. Closing bug. 232937 2014-06-12 02:07:50 -0700 2014-07-15 03:50:18 -0700 Patch bug-133790-20140612110726.patch text/plain 1809 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5ODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MWIyNTI1MGQxN2U0NGVmN2IxNzY2YjZmNGRiNmRhZWYyODBiMTE5Li44YjllNjE4NGM5ZGQxZTJi YTE3ZWUzOGI2M2ViMzNiY2IwZTYxYWY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNC0wNi0xMiAgRXZhIEJhbGF6c2ZhbHZpICA8ZXZhYi51LXN6ZWdlZEBw YXJ0bmVyLnNhbXN1bmcuY29tPgorCisgICAgICAgIEJ1aWxkZml4IGlmIExMSU5UX1NMT1dfUEFU SF9UUkFDSU5HIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzMzc5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogbGxpbnQvTExJbnRTbG93UGF0aHMuY3BwOgorICAgICAgICAoSlNDOjpM TEludDo6TExJTlRfU0xPV19QQVRIX0RFQ0wpOgorCiAyMDE0LTA2LTEyICBDc2FiYSBPc3p0cm9n b27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0gT25lIG1vcmUgVVJUQkYg YWZ0ZXIgcjE2OTgyMyB0byBtYWtlIEFSTTY0IGJ1aWxkIGhhcHB5IHRvby4KZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludFNsb3dQYXRocy5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRTbG93UGF0aHMuY3BwCmluZGV4IDVhMTA5NjgxYmVi YzlmODJlMTRhMGY3ZGVlN2I4MmQ3MjIxN2NkNzIuLmZmMWE5Yjc4YWZmOGNmNWUwNjU4YjVjZmU2 MTA2ZjA3ZDQwMjU4ZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9M TEludFNsb3dQYXRocy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50 U2xvd1BhdGhzLmNwcApAQCAtNDU4LDkgKzQ1OCwxNCBAQCBMTElOVF9TTE9XX1BBVEhfREVDTChz dGFja19jaGVjaykKICAgICBkYXRhTG9nRigiQ29kZUJsb2NrID0gJXAuXG4iLCBleGVjLT5jb2Rl QmxvY2soKSk7CiAgICAgZGF0YUxvZ0YoIk51bSBjYWxsZWUgcmVnaXN0ZXJzID0gJXUuXG4iLCBl eGVjLT5jb2RlQmxvY2soKS0+bV9udW1DYWxsZWVSZWdpc3RlcnMpOwogICAgIGRhdGFMb2dGKCJO dW0gdmFycyA9ICV1LlxuIiwgZXhlYy0+Y29kZUJsb2NrKCktPm1fbnVtVmFycyk7Ci0gICAgZGF0 YUxvZ0YoIkN1cnJlbnQgZW5kIGlzIGF0ICVwLlxuIiwgZXhlYy0+dm0oKS5pbnRlcnByZXRlci0+ c3RhY2soKS5lbmQoKSk7CisKKyNpZiBFTkFCTEUoTExJTlRfQ19MT09QKQorICAgIGRhdGFMb2dG KCJDdXJyZW50IGVuZCBpcyBhdCAlcC5cbiIsIGV4ZWMtPnZtKCkuanNTdGFja0xpbWl0KCkpOwor I2Vsc2UKKyAgICBkYXRhTG9nRigiQ3VycmVudCBlbmQgaXMgYXQgJXAuXG4iLCBleGVjLT52bSgp LnN0YWNrTGltaXQoKSk7CiAjZW5kaWYKIAorI2VuZGlmCiAgICAgLy8gVGhpcyBzdGFjayBjaGVj ayBpcyBkb25lIGluIHRoZSBwcm9sb2d1ZSBmb3IgYSBmdW5jdGlvbiBjYWxsLCBhbmQgdGhlCiAg ICAgLy8gQ2FsbEZyYW1lIGlzIG5vdCBjb21wbGV0ZWx5IHNldCB1cCB5ZXQuIEZvciBleGFtcGxl LCBpZiB0aGUgZnJhbWUgbmVlZHMKICAgICAvLyBhbiBhY3RpdmF0aW9uIG9iamVjdCwgdGhlIGFj dGl2YXRpb24gb2JqZWN0IHdpbGwgb25seSBiZSBzZXQgdXAgYWZ0ZXIK