13379 2007-04-17 22:23:38 -0700 REGRESSION: Cannot add an option to a selected popup 2007-04-28 18:51:20 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://srufaculty.sru.edu/david.dailey/javascript/stringtimer.html InRadar, NeedsReduction, Regression P1 Normal --- 1 ap mitz oldest_to_newest 14381 0 ap 2007-04-17 22:23:38 -0700 Steps to reproduce: 1) Open http://srufaculty.sru.edu/david.dailey/javascript/stringtimer.html 2) Click on the empty popup after "array_join" button 3) Click on the "array_join" button Result: the popup changes its width, but remains empty. clicking on it for the first time doesn't make popup menu appear, but at a second attempt, it appears. For this particular page, this is a regression, because it is not possible to focus this pop-up in shipping Safari (it's disabled). I'm not sure how much of the current behavior is due to new issues in WebKit, though. Works fine in Firefox. The popup button is focusable there, like in ToT WebKit. 13181 1 darin 2007-04-23 08:39:12 -0700 <rdar://problem/5153024> 12025 2 14246 mitz 2007-04-28 11:47:59 -0700 Created attachment 14246 Let the client know that the popup closed, if it never opened. Includes a manual test. 12044 3 darin 2007-04-28 18:51:20 -0700 Sending OpenSource/WebCore/ChangeLog Adding OpenSource/WebCore/manual-tests/update-empty-popup.html Sending OpenSource/WebCore/platform/mac/PopupMenuMac.mm Transmitting file data ... Committed revision 21171. 14246 2007-04-28 11:47:59 -0700 2007-04-28 11:57:14 -0700 Let the client know that the popup closed, if it never opened. 13379_r1.patch text/plain 2709 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTE2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDctMDQtMjggIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzc5CisgICAgICAgICAg UkVHUkVTU0lPTjogQ2Fubm90IGFkZCBhbiBvcHRpb24gdG8gYSBzZWxlY3RlZCBwb3B1cAorCisg ICAgICAgICogbWFudWFsLXRlc3RzL3VwZGF0ZS1lbXB0eS1wb3B1cC5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBwbGF0Zm9ybS9tYWMvUG9wdXBNZW51TWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6 UG9wdXBNZW51OjpzaG93KTogQWRkZWQgYSBjYWxsIHRvIHRoZSBjbGllbnQncyBoaWRlUG9wdXAo KQorICAgICAgICBjYWxsYmFjayBiZWZvcmUgcmV0dXJuaW5nIGluIHRoZSBjYXNlIHRoYXQgdGhl IG1lbnUgaXMgZW1wdHkuIE90aGVyd2lzZQorICAgICAgICB0aGUgY2xpZW50IHRoaW5rcyB0aGF0 IHRoZSBtZW51IHN0YXllZCBvcGVuLgorCiAyMDA3LTA0LTI4ICBNYXJrIFJvd2UgIDxtcm93ZUBh cHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4LiAgQ2hhbmdlIHVzZSBvZiBuaWwgdG8gMCBp biBDKysgc291cmNlIGZpbGUuCkluZGV4OiBXZWJDb3JlL21hbnVhbC10ZXN0cy91cGRhdGUtZW1w dHktcG9wdXAuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy91cGRhdGUt ZW1wdHktcG9wdXAuaHRtbAkocmV2aXNpb24gMCkKKysrIFdlYkNvcmUvbWFudWFsLXRlc3RzL3Vw ZGF0ZS1lbXB0eS1wb3B1cC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI4IEBACis8IURP Q1RZUEUgSFRNTCBQVUJMSUMgIi0vL1czQy8vRFREIEhUTUwgNC4wMS8vRU4iCisgICAgICAgICJo dHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9zdHJpY3QuZHRkIj4KKzxodG1sIGxhbmc9ImVuIj4K KzxoZWFkPgorPC9oZWFkPgorPGJvZHk+Cis8cD48Yj5CVUcgSUQ6PC9iPiA8YSBocmVmPSJodHRw Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM3OSI+QnVnemlsbGEgYnVnIDEz Mzc5PC9hPiBSRUdSRVNTSU9OOiBDYW5ub3QgYWRkIGFuIG9wdGlvbiB0byBhIHNlbGVjdGVkIHBv cHVwPC9wPgorCis8cCBpZD0idGVzdCIgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6c2t5Ymx1ZTsg cGFkZGluZzozcHg7Ij48Yj5TVEVQUyBUTyBURVNUOjwvYj4gCisxLiBDbGljayBvbiB0aGUgZW1w dHkgcG9wdXAgYnV0dG9uLjxicj4KKzIuIENsaWNrIG9uIHRoZSBUZXN0IGJ1dHRvbi4KKzwvcD4K KworPHAgaWQ9InN1Y2Nlc3MiIHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOnBhbGVncmVlbjsgcGFk ZGluZzozcHg7Ij48Yj5URVNUIFBBU1M6PC9iPiAKK1RoZSBwb3B1cCBidXR0b24gd2lsbCBjaGFu Z2UgdG8gZGlzcGxheSB0aGUgd29yZCBTVUNDRVNTLgorPC9wPgorCis8cCBpZD0iZmFpbHVyZSIg c3R5bGU9ImJhY2tncm91bmQtY29sb3I6I0ZGMzMwMDsgcGFkZGluZzozcHg7Ij48Yj5URVNUIEZB SUw6PC9iPiAgCitUaGUgcG9wdXAgYnV0dG9uIHdpbGwgYmVjb21lIHdpZGVyIGJ1dCB3aWxsIG5v dCBkaXNwbGF5IGFueSB0ZXh0LiBDbGlja2luZyB0aGUgcG9wdXAKK29uY2Ugd2lsbCBub3QgYnJp bmcgdXAgdGhlIG1lbnUuCis8L3A+CisKKzxzZWxlY3QgaWQ9InNlbGVjdCI+PC9zZWxlY3Q+Cis8 YnI+Cis8aW5wdXQgdHlwZT0iYnV0dG9uIiBvbmNsaWNrPSdkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgic2VsZWN0IikuYWRkKG5ldyBPcHRpb24oIlNVQ0NFU1MiKSknIHZhbHVlPSJUZXN0Ij4KKwor PC9ib2R5PgorPC9odG1sPgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUG9wdXBNZW51TWFj Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbWFjL1BvcHVwTWVudU1hYy5tbQko cmV2aXNpb24gMjExNjcpCisrKyBXZWJDb3JlL3BsYXRmb3JtL21hYy9Qb3B1cE1lbnVNYWMubW0J KHdvcmtpbmcgY29weSkKQEAgLTEwMCw4ICsxMDAsMTEgQEAgdm9pZCBQb3B1cE1lbnU6OnNob3co Y29uc3QgSW50UmVjdCYgciwgRgogewogICAgIHBvcHVsYXRlKCk7CiAgICAgaW50IG51bUl0ZW1z ID0gW21fcG9wdXAuZ2V0KCkgbnVtYmVyT2ZJdGVtc107Ci0gICAgaWYgKG51bUl0ZW1zIDw9IDAp CisgICAgaWYgKG51bUl0ZW1zIDw9IDApIHsKKyAgICAgICAgaWYgKGNsaWVudCgpKQorICAgICAg ICAgICAgY2xpZW50KCktPmhpZGVQb3B1cCgpOwogICAgICAgICByZXR1cm47CisgICAgfQogICAg IEFTU0VSVChudW1JdGVtcyA+IGluZGV4KTsKIAogICAgIC8vIFdvcmthcm91bmQgZm9yIGNyYXp5 IGJ1ZyB3aGVyZSBhIHNlbGVjdGVkIGluZGV4IG9mIC0xIGZvciBhIG1lbnUgd2l0aCBvbmx5IDEg aXRlbSB3aWxsIGNhdXNlIGEgYmxhbmsgbWVudS4K