133786 2014-06-11 23:01:57 -0700 Fix build break on EFL and GTK ports since r169820 2014-06-11 23:38:54 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 133667 1 gyuyoung.kim gyuyoung.kim commit-queue gyuyoung.kim lucas.de.marchi ossy oldest_to_newest 1015030 0 gyuyoung.kim 2014-06-11 23:01:57 -0700 SSIA. Below build error occurs now. /home/webkit/slaves/perfbot/buildslave/efl-linux-64-release-wk2-perf/build/Source/WebKit2/WebProcess/Plugins/PluginView.cpp: In member function 'void WebKit::PluginView::pluginSnapshotTimerFired()': /home/webkit/slaves/perfbot/buildslave/efl-linux-64-release-wk2-perf/build/Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1693:40: error: 'class WebKit::WebPage' has no member named 'plugInIntersectsSearchRect' /home/webkit/slaves/perfbot/buildslave/efl-linux-64-release-wk2-perf/build/Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1707:96: error: 'isAlmostSolidColor' was not declared in this scope /home/webkit/slaves/perfbot/buildslave/efl-linux-64-release-wk2-perf/build/Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1721:20: error: 'class WebKit::WebPage' has no member named 'plugInIsPrimarySize' ICECC[5040] 22:12:29: Compiled on 10.6.11.36 1015031 1 232933 gyuyoung.kim 2014-06-11 23:03:12 -0700 Created attachment 232933 Patch 1015038 2 232933 gyuyoung.kim 2014-06-11 23:36:46 -0700 Comment on attachment 232933 Patch Clearing flags on attachment: 232933 Committed r169881: <http://trac.webkit.org/changeset/169881> 1015039 3 gyuyoung.kim 2014-06-11 23:38:54 -0700 All reviewed patches have been landed. Closing bug. 232933 2014-06-11 23:03:12 -0700 2014-06-11 23:36:46 -0700 Patch bug-133786-20140612150246.patch text/plain 3069 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5ODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDBkNWRkOTIzN2YyMDM0 MTUyZGVkMjU1NDVmZDljZGExMDk3YTJkNC4uZWI2NGQ0MjNlZWZhYTBhMzY0ZWRiNzE0NmIxMzU4 NzA4MDZlOGUyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE0LTA2LTExICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKKyAgICAgICAgRml4IGJ1aWxk IGJyZWFrIG9uIEVGTCBhbmQgR1RLIHBvcnRzIHNpbmNlIHIxNjk4MjAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzc4NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVOQUJMRV9QUklNQVJZX1NOQVBTSE9U VEVEX1BMVUdJTl9IRVVSSVNUSUMgbWFjcm8gYXJlIG1pc3NpbmcgaW4gUGx1Z2luVmlldzo6cGx1 Z2luU25hcHNob3RUaW1lckZpcmVkKCkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMv UGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6OnBsdWdpblNuYXBz aG90VGltZXJGaXJlZCk6CisKKzIwMTQtMDYtMTEgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtp bUBzYW1zdW5nLmNvbT4KKwogICAgICAgICBGaXggYnVpbGQgYnJlYWsgb24gRUZMIHBvcnQgc2lu Y2UgcjE2OTg2OQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTMzNzg1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lu cy9QbHVnaW5WaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVn aW5WaWV3LmNwcAppbmRleCA1NGEwMjM0YjUyNTk5ODhmNGQ4Y2YxYTJjODU2MjgzODQwMDdiZmQy Li42YmYwNTA5ZDBjNjIzMTRmYjQwZDk3MzA1NTFmN2RlMDFjNzYyM2M3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCkBAIC0xNjg5LDYg KzE2ODksNyBAQCB2b2lkIFBsdWdpblZpZXc6OnBsdWdpblNuYXBzaG90VGltZXJGaXJlZCgpCiB7 CiAgICAgQVNTRVJUKG1fcGx1Z2luKTsKIAorI2lmIEVOQUJMRShQUklNQVJZX1NOQVBTSE9UVEVE X1BMVUdJTl9IRVVSSVNUSUMpCiAgICAgSFRNTFBsdWdJbkltYWdlRWxlbWVudCogcGx1Z0luSW1h Z2VFbGVtZW50ID0gdG9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50KG1fcGx1Z2luRWxlbWVudC5nZXQo KSk7CiAgICAgYm9vbCBpc1BsdWdJbk9uU2NyZWVuID0gbV93ZWJQYWdlLT5wbHVnSW5JbnRlcnNl Y3RzU2VhcmNoUmVjdCgqcGx1Z0luSW1hZ2VFbGVtZW50KTsKICAgICBpZiAoIW1fY291bnRTbmFw c2hvdFJldHJpZXMpCkBAIC0xNjk2LDYgKzE2OTcsNyBAQCB2b2lkIFBsdWdpblZpZXc6OnBsdWdp blNuYXBzaG90VGltZXJGaXJlZCgpCiAKICAgICBib29sIHBsdWdJbkNhbWVPblNjcmVlbiA9IGlz UGx1Z0luT25TY3JlZW4gJiYgbV9kaWRQbHVnSW5TdGFydE9mZlNjcmVlbjsKICAgICBib29sIHNu YXBzaG90Rm91bmQgPSBmYWxzZTsKKyNlbmRpZgogCiAgICAgaWYgKG1fcGx1Z2luLT5zdXBwb3J0 c1NuYXBzaG90dGluZygpKSB7CiAgICAgICAgIC8vIFNuYXBzaG90IG1pZ2h0IGJlIDAgaWYgcGx1 Z2luIHNpemUgaXMgMHgwLgpAQCAtMTcwNCw4ICsxNzA2LDEwIEBAIHZvaWQgUGx1Z2luVmlldzo6 cGx1Z2luU25hcHNob3RUaW1lckZpcmVkKCkKICAgICAgICAgaWYgKHNuYXBzaG90KQogICAgICAg ICAgICAgc25hcHNob3RJbWFnZSA9IHNuYXBzaG90LT5jcmVhdGVJbWFnZSgpOwogICAgICAgICBt X3BsdWdpbkVsZW1lbnQtPnVwZGF0ZVNuYXBzaG90KHNuYXBzaG90SW1hZ2UuZ2V0KCkpOworI2lm IEVOQUJMRShQUklNQVJZX1NOQVBTSE9UVEVEX1BMVUdJTl9IRVVSSVNUSUMpCiAgICAgICAgIGJv b2wgc25hcHNob3RJc0FsbW9zdFNvbGlkQ29sb3IgPSBpc0FsbW9zdFNvbGlkQ29sb3IodG9CaXRt YXBJbWFnZShzbmFwc2hvdEltYWdlLmdldCgpKSk7CiAgICAgICAgIHNuYXBzaG90Rm91bmQgPSBz bmFwc2hvdEltYWdlICYmICFzbmFwc2hvdElzQWxtb3N0U29saWRDb2xvcjsKKyNlbmRpZgogCiAj aWYgUExBVEZPUk0oQ09DT0EpCiAgICAgICAgIHVuc2lnbmVkIG1heGltdW1TbmFwc2hvdFJldHJp ZXMgPSBmcmFtZSgpID8gZnJhbWUoKS0+c2V0dGluZ3MoKS5tYXhpbXVtUGx1Z0luU25hcHNob3RB dHRlbXB0cygpIDogMDsKQEAgLTE3MTYsMTIgKzE3MjAsMTUgQEAgdm9pZCBQbHVnaW5WaWV3Ojpw bHVnaW5TbmFwc2hvdFRpbWVyRmlyZWQoKQogICAgICAgICB9CiAjZW5kaWYKICAgICB9CisKKyNp ZiBFTkFCTEUoUFJJTUFSWV9TTkFQU0hPVFRFRF9QTFVHSU5fSEVVUklTVElDKQogICAgIHVuc2ln bmVkIGNhbmRpZGF0ZUFyZWEgPSAwOwogICAgIGJvb2wgbm9TbmFwc2hvdEZvdW5kQWZ0ZXJNYXhS ZXRyaWVzID0gbV9jb3VudFNuYXBzaG90UmV0cmllcyA9PSBmcmFtZSgpLT5zZXR0aW5ncygpLm1h eGltdW1QbHVnSW5TbmFwc2hvdEF0dGVtcHRzKCkgJiYgIWlzUGx1Z0luT25TY3JlZW4gJiYgIXNu YXBzaG90Rm91bmQ7CiAgICAgaWYgKG1fd2ViUGFnZS0+cGx1Z0luSXNQcmltYXJ5U2l6ZSgqcGx1 Z0luSW1hZ2VFbGVtZW50LCBjYW5kaWRhdGVBcmVhKQogICAgICAgICAmJiAobm9TbmFwc2hvdEZv dW5kQWZ0ZXJNYXhSZXRyaWVzIHx8IHBsdWdJbkNhbWVPblNjcmVlbikpCiAgICAgICAgIG1fcGx1 Z2luRWxlbWVudC0+c2V0RGlzcGxheVN0YXRlKEhUTUxQbHVnSW5FbGVtZW50OjpQbGF5aW5nKTsK ICAgICBlbHNlCisjZW5kaWYKICAgICAgICAgbV9wbHVnaW5FbGVtZW50LT5zZXREaXNwbGF5U3Rh dGUoSFRNTFBsdWdJbkVsZW1lbnQ6OkRpc3BsYXlpbmdTbmFwc2hvdCk7CiB9CiAK