133776 2014-06-11 16:51:42 -0700 Remove XHRReplayData::addHeader 2014-06-18 12:36:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1014978 0 andersca 2014-06-11 16:51:42 -0700 Remove XHRReplayData::addHeader 1014979 1 232920 andersca 2014-06-11 16:52:53 -0700 Created attachment 232920 Patch 1014980 2 andersca 2014-06-11 16:58:06 -0700 Committed r169861: <http://trac.webkit.org/changeset/169861> 1016519 3 232920 darin 2014-06-18 12:36:58 -0700 Comment on attachment 232920 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232920&action=review > Source/WebCore/inspector/InspectorResourceAgent.cpp:489 > m_pendingXHRReplayData.set(client, xhrReplayData); Shouldn’t this be calling xhrReplayData.release()? 232920 2014-06-11 16:52:53 -0700 2014-06-18 12:36:58 -0700 Patch bug-133776-20140611165229.patch text/plain 5221 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5ODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjY0ODBiMTllM2QxNWVi NTdjMjQ3YzFiNjM2MWU3MWM0MWMwYWEwMS4uM2ZhNWEzYjhhZWQyOTgzMGJkYjk5ZWFiZTMyZTAz ZjVkNGY3YTA3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE0LTA2LTExICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUmVtb3ZlIFhIUlJl cGxheURhdGE6OmFkZEhlYWRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTMzNzc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSnVzdCBwYXNzIHRoZSBIVFRQIGhlYWRlciBtYXAgdG8gWEhSUmVwbGF5RGF0 YTo6Y3JlYXRlIGRpcmVjdGx5LgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclJlc291 cmNlQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yUmVzb3VyY2VBZ2VudDo6 d2lsbExvYWRYSFIpOgorICAgICAgICAqIGluc3BlY3Rvci9OZXR3b3JrUmVzb3VyY2VzRGF0YS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpYSFJSZXBsYXlEYXRhOjpjcmVhdGUpOgorICAgICAgICAo V2ViQ29yZTo6WEhSUmVwbGF5RGF0YTo6WEhSUmVwbGF5RGF0YSk6CisgICAgICAgIChXZWJDb3Jl OjpYSFJSZXBsYXlEYXRhOjphZGRIZWFkZXIpOiBEZWxldGVkLgorICAgICAgICAqIGluc3BlY3Rv ci9OZXR3b3JrUmVzb3VyY2VzRGF0YS5oOgorCisyMDE0LTA2LTExICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgTW92ZSBzb21lIEhUVFAgaGVhZGVyIGZp ZWxkIGFjY2Vzc29ycyB0byBSZXNvdXJjZVJlcXVlc3RCYXNlLmNwcAogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzNzczCiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJjZUFnZW50LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJjZUFnZW50LmNwcAppbmRleCAwNDZm ZjA1MWNkODAxNmFmMjNhNmNlYTI1ZTM0ZWRjNWUxMmNkNmI3Li5kYTEwZmZkMTU0MzVlZTkzNzUx M2MyZmE3ODcwYzM1YjM5MDA3MTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yUmVzb3VyY2VBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3BwCkBAIC00ODQsOSArNDg0LDggQEAgdm9pZCBJ bnNwZWN0b3JSZXNvdXJjZUFnZW50Ojpkb2N1bWVudFRocmVhZGFibGVMb2FkZXJTdGFydGVkTG9h ZGluZ0ZvckNsaWVudCh1bnMKIAogdm9pZCBJbnNwZWN0b3JSZXNvdXJjZUFnZW50Ojp3aWxsTG9h ZFhIUihUaHJlYWRhYmxlTG9hZGVyQ2xpZW50KiBjbGllbnQsIGNvbnN0IFN0cmluZyYgbWV0aG9k LCBjb25zdCBVUkwmIHVybCwgYm9vbCBhc3luYywgUGFzc1JlZlB0cjxGb3JtRGF0YT4gZm9ybURh dGEsIGNvbnN0IEhUVFBIZWFkZXJNYXAmIGhlYWRlcnMsIGJvb2wgaW5jbHVkZUNyZWRlbnRpYWxz KQogewotICAgIFJlZlB0cjxYSFJSZXBsYXlEYXRhPiB4aHJSZXBsYXlEYXRhID0gWEhSUmVwbGF5 RGF0YTo6Y3JlYXRlKG1ldGhvZCwgdXJsLCBhc3luYywgZm9ybURhdGEsIGluY2x1ZGVDcmVkZW50 aWFscyk7Ci0gICAgZm9yIChjb25zdCBhdXRvJiBoZWFkZXIgOiBoZWFkZXJzKQotICAgICAgICB4 aHJSZXBsYXlEYXRhLT5hZGRIZWFkZXIoaGVhZGVyLmtleSwgaGVhZGVyLnZhbHVlKTsKKyAgICBS ZWZQdHI8WEhSUmVwbGF5RGF0YT4geGhyUmVwbGF5RGF0YSA9IFhIUlJlcGxheURhdGE6OmNyZWF0 ZShtZXRob2QsIHVybCwgYXN5bmMsIGZvcm1EYXRhLCBoZWFkZXJzLCBpbmNsdWRlQ3JlZGVudGlh bHMpOworCiAgICAgbV9wZW5kaW5nWEhSUmVwbGF5RGF0YS5zZXQoY2xpZW50LCB4aHJSZXBsYXlE YXRhKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL05ldHdvcmtS ZXNvdXJjZXNEYXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9OZXR3b3JrUmVzb3Vy Y2VzRGF0YS5jcHAKaW5kZXggYzRkMjcwMjM4MTUzN2YyMjQ3YWNmMWE2MzhmNDA1NjczYTQ2ZWYy MS4uNWI4MzQ5ZDUyODViY2U3MTZiOTljZGYzNDg1MzAxZWNkNGRmYTAxMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvTmV0d29ya1Jlc291cmNlc0RhdGEuY3BwCkBAIC01MSwy MSArNTEsMTggQEAgdXNpbmcgbmFtZXNwYWNlIEluc3BlY3RvcjsKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAogCi1QYXNzUmVmUHRyPFhIUlJlcGxheURhdGE+IFhIUlJlcGxheURhdGE6OmNyZWF0ZShj b25zdCBTdHJpbmcgJm1ldGhvZCwgY29uc3QgVVJMJiB1cmwsIGJvb2wgYXN5bmMsIFBhc3NSZWZQ dHI8Rm9ybURhdGE+IGZvcm1EYXRhLCBib29sIGluY2x1ZGVDcmVkZW50aWFscykKK1Bhc3NSZWZQ dHI8WEhSUmVwbGF5RGF0YT4gWEhSUmVwbGF5RGF0YTo6Y3JlYXRlKGNvbnN0IFN0cmluZyAmbWV0 aG9kLCBjb25zdCBVUkwmIHVybCwgYm9vbCBhc3luYywgUGFzc1JlZlB0cjxGb3JtRGF0YT4gZm9y bURhdGEsIGNvbnN0IEhUVFBIZWFkZXJNYXAmIGhlYWRlcnMsIGJvb2wgaW5jbHVkZUNyZWRlbnRp YWxzKQogewotICAgIHJldHVybiBhZG9wdFJlZihuZXcgWEhSUmVwbGF5RGF0YShtZXRob2QsIHVy bCwgYXN5bmMsIGZvcm1EYXRhLCBpbmNsdWRlQ3JlZGVudGlhbHMpKTsKKyAgICByZXR1cm4gYWRv cHRSZWYobmV3IFhIUlJlcGxheURhdGEobWV0aG9kLCB1cmwsIGFzeW5jLCBmb3JtRGF0YSwgaGVh ZGVycywgaW5jbHVkZUNyZWRlbnRpYWxzKSk7CiB9CiAKLXZvaWQgWEhSUmVwbGF5RGF0YTo6YWRk SGVhZGVyKGNvbnN0IEF0b21pY1N0cmluZyYga2V5LCBjb25zdCBTdHJpbmcmIHZhbHVlKQotewot ICAgIG1faGVhZGVycy5zZXQoa2V5LCB2YWx1ZSk7Ci19CiAKLVhIUlJlcGxheURhdGE6OlhIUlJl cGxheURhdGEoY29uc3QgU3RyaW5nICZtZXRob2QsIGNvbnN0IFVSTCYgdXJsLCBib29sIGFzeW5j LCBQYXNzUmVmUHRyPEZvcm1EYXRhPiBmb3JtRGF0YSwgYm9vbCBpbmNsdWRlQ3JlZGVudGlhbHMp CitYSFJSZXBsYXlEYXRhOjpYSFJSZXBsYXlEYXRhKGNvbnN0IFN0cmluZyAmbWV0aG9kLCBjb25z dCBVUkwmIHVybCwgYm9vbCBhc3luYywgUGFzc1JlZlB0cjxGb3JtRGF0YT4gZm9ybURhdGEsIGNv bnN0IEhUVFBIZWFkZXJNYXAmIGhlYWRlcnMsIGJvb2wgaW5jbHVkZUNyZWRlbnRpYWxzKQogICAg IDogbV9tZXRob2QobWV0aG9kKQogICAgICwgbV91cmwodXJsKQogICAgICwgbV9hc3luYyhhc3lu YykKICAgICAsIG1fZm9ybURhdGEoZm9ybURhdGEpCisgICAgLCBtX2hlYWRlcnMoaGVhZGVycykK ICAgICAsIG1faW5jbHVkZUNyZWRlbnRpYWxzKGluY2x1ZGVDcmVkZW50aWFscykKIHsKIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9OZXR3b3JrUmVzb3VyY2VzRGF0YS5o IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmgKaW5kZXgg YjcwYTA2MGY3ZjAxZjg0YTM4Mzc5YjViNGM3NTI5NWY5MThiODQ5ZS4uYzIzNjk1ZDFmYzE2OTNi OTUxMTVhMDQ1MGM3MGFjYzA4ZTBkMDk2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmgKQEAgLTUxLDkgKzUxLDggQEAgY2xhc3MgVGV4dFJl c291cmNlRGVjb2RlcjsKIAogY2xhc3MgWEhSUmVwbGF5RGF0YSA6IHB1YmxpYyBSZWZDb3VudGVk PFhIUlJlcGxheURhdGE+IHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxYSFJSZXBs YXlEYXRhPiBjcmVhdGUoY29uc3QgU3RyaW5nICZtZXRob2QsIGNvbnN0IFVSTCYsIGJvb2wgYXN5 bmMsIFBhc3NSZWZQdHI8Rm9ybURhdGE+LCBib29sIGluY2x1ZGVDcmVkZW50aWFscyk7CisgICAg c3RhdGljIFBhc3NSZWZQdHI8WEhSUmVwbGF5RGF0YT4gY3JlYXRlKGNvbnN0IFN0cmluZyAmbWV0 aG9kLCBjb25zdCBVUkwmLCBib29sIGFzeW5jLCBQYXNzUmVmUHRyPEZvcm1EYXRhPiwgY29uc3Qg SFRUUEhlYWRlck1hcCYgaGVhZGVycywgYm9vbCBpbmNsdWRlQ3JlZGVudGlhbHMpOwogCi0gICAg dm9pZCBhZGRIZWFkZXIoY29uc3QgQXRvbWljU3RyaW5nJiBrZXksIGNvbnN0IFN0cmluZyYgdmFs dWUpOwogICAgIGNvbnN0IFN0cmluZyYgbWV0aG9kKCkgY29uc3QgeyByZXR1cm4gbV9tZXRob2Q7 IH0KICAgICBjb25zdCBVUkwmIHVybCgpIGNvbnN0IHsgcmV0dXJuIG1fdXJsOyB9CiAgICAgYm9v bCBhc3luYygpIGNvbnN0IHsgcmV0dXJuIG1fYXN5bmM7IH0KQEAgLTYxLDEzICs2MCwxMyBAQCBw dWJsaWM6CiAgICAgY29uc3QgSFRUUEhlYWRlck1hcCYgaGVhZGVycygpIGNvbnN0IHsgcmV0dXJu IG1faGVhZGVyczsgfQogICAgIGJvb2wgaW5jbHVkZUNyZWRlbnRpYWxzKCkgY29uc3QgeyByZXR1 cm4gbV9pbmNsdWRlQ3JlZGVudGlhbHM7IH0KIHByaXZhdGU6Ci0gICAgWEhSUmVwbGF5RGF0YShj b25zdCBTdHJpbmcgJm1ldGhvZCwgY29uc3QgVVJMJiwgYm9vbCBhc3luYywgUGFzc1JlZlB0cjxG b3JtRGF0YT4sIGJvb2wgaW5jbHVkZUNyZWRlbnRpYWxzKTsKKyAgICBYSFJSZXBsYXlEYXRhKGNv bnN0IFN0cmluZyAmbWV0aG9kLCBjb25zdCBVUkwmLCBib29sIGFzeW5jLCBQYXNzUmVmUHRyPEZv cm1EYXRhPiwgY29uc3QgSFRUUEhlYWRlck1hcCYgaGVhZGVycywgYm9vbCBpbmNsdWRlQ3JlZGVu dGlhbHMpOwogCiAgICAgU3RyaW5nIG1fbWV0aG9kOwogICAgIFVSTCBtX3VybDsKICAgICBib29s IG1fYXN5bmM7CiAgICAgUmVmUHRyPEZvcm1EYXRhPiBtX2Zvcm1EYXRhOwotICAgIEhUVFBIZWFk ZXJNYXAgbV9oZWFkZXJzOworICAgIGNvbnN0IEhUVFBIZWFkZXJNYXAgbV9oZWFkZXJzOwogICAg IGJvb2wgbV9pbmNsdWRlQ3JlZGVudGlhbHM7CiB9OwogCg==