133775 2014-06-11 16:06:34 -0700 Keep CFDataRefs in SharedBuffer instead of merging them 2014-06-11 17:47:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki ap beidson commit-queue kling psolanki oldest_to_newest 1014973 0 psolanki 2014-06-11 16:06:34 -0700 Keep CFDataRefs in SharedBuffer instead of merging them 1014974 1 232919 psolanki 2014-06-11 16:15:53 -0700 Created attachment 232919 Patch 1014975 2 232919 ap 2014-06-11 16:30:24 -0700 Comment on attachment 232919 Patch There is a case for (count == 1) above the modified code, should it be updated in the same way too? r=me assuming that there is a measurable improvement somewhere. 1014976 3 ap 2014-06-11 16:31:07 -0700 > There is a case for (count == 1) above the modified code, should it be updated in the same way too? No, I misread that code. 1014996 4 psolanki 2014-06-11 17:41:36 -0700 (In reply to comment #2) > (From update of attachment 232919 [details]) > r=me assuming that there is a measurable improvement somewhere. Thanks for the review. By itself this will not improve performance but next up I would like to pass the SharedBuffer all the way down to IPC message send so that we can avoid merging the CFData and directly write to the IPC message. 1014999 5 232919 commit-queue 2014-06-11 17:47:20 -0700 Comment on attachment 232919 Patch Clearing flags on attachment: 232919 Committed r169868: <http://trac.webkit.org/changeset/169868> 1015000 6 commit-queue 2014-06-11 17:47:23 -0700 All reviewed patches have been landed. Closing bug. 232919 2014-06-11 16:15:53 -0700 2014-06-11 17:47:20 -0700 Patch bug-133775-20140611161528.patch text/plain 2305 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWVlY2FmZjhkMTY5Mzll MTU5ODRkNGFmZDhmYzE3YjFiMzQ4M2JhOC4uNDE1MmUzM2JhNjdmNGZiODBlZmVmMzdhY2ExYWI2 YzJiNzg1NzgxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA2LTExICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBLZWVwIENGRGF0YVJl ZnMgaW4gU2hhcmVkQnVmZmVyIGluc3RlYWQgb2YgbWVyZ2luZyB0aGVtCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM3NzUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnN0ZWFkIG9mIG1lcmdpbmcgdGhl IENGRGF0YVJlZnMgaW50byBvbmUgYnVmZmVyLCBzYXZlIHRoZW0gaW4gYXMgQ0ZEYXRhUmVmcyBp bgorICAgICAgICBTaGFyZWRCdWZmZXIuIFRoZXkgd2lsbCBnZXQgbWVyZ2VkIHdoZW4gY29kZSBj YWxscyBidWZmZXIoKSBsYXRlciBvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBu byBmdW5jdGlvbmFsIGNoYW5nZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL1Jl c291cmNlSGFuZGxlQ0ZOZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6 OmhhbmRsZURhdGFBcnJheSk6CisKIDIwMTQtMDYtMTEgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hh bUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gQXZvaWQgZGVhZGxvY2sgd2l0aCBBVkZvdW5k YXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVz b3VyY2VIYW5kbGVDRk5ldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nm L1Jlc291cmNlSGFuZGxlQ0ZOZXQuY3BwCmluZGV4IDAxNTkwMmFjNDllMTU3ZjUyNjhlMTY2N2U0 YWExNmRkMDBiZDZjNTUuLjgwODM5YmU1ZTFhOTU0NmYxNzMzZjQ3YWE3OWM2ZDY5YWMxNDFlMDUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VI YW5kbGVDRk5ldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9S ZXNvdXJjZUhhbmRsZUNGTmV0LmNwcApAQCAtNjQwLDE4ICs2NDAsMTEgQEAgdm9pZCBSZXNvdXJj ZUhhbmRsZTo6aGFuZGxlRGF0YUFycmF5KENGQXJyYXlSZWYgZGF0YUFycmF5KQogICAgICAgICBy ZXR1cm47CiAgICAgfQogCi0gICAgQ0ZJbmRleCB0b3RhbFNpemUgPSAwOwotICAgIENGSW5kZXgg aW5kZXg7Ci0gICAgZm9yIChpbmRleCA9IDA7IGluZGV4IDwgY291bnQ7IGluZGV4KyspCi0gICAg ICAgIHRvdGFsU2l6ZSArPSBDRkRhdGFHZXRMZW5ndGgoc3RhdGljX2Nhc3Q8Q0ZEYXRhUmVmPihD RkFycmF5R2V0VmFsdWVBdEluZGV4KGRhdGFBcnJheSwgaW5kZXgpKSk7Ci0KLSAgICBSZXRhaW5Q dHI8Q0ZNdXRhYmxlRGF0YVJlZj4gbWVyZ2VkRGF0YSA9IGFkb3B0Q0YoQ0ZEYXRhQ3JlYXRlTXV0 YWJsZShrQ0ZBbGxvY2F0b3JEZWZhdWx0LCB0b3RhbFNpemUpKTsKLSAgICBmb3IgKGluZGV4ID0g MDsgaW5kZXggPCBjb3VudDsgaW5kZXgrKykgewotICAgICAgICBDRkRhdGFSZWYgZGF0YSA9IHN0 YXRpY19jYXN0PENGRGF0YVJlZj4oQ0ZBcnJheUdldFZhbHVlQXRJbmRleChkYXRhQXJyYXksIGlu ZGV4KSk7Ci0gICAgICAgIENGRGF0YUFwcGVuZEJ5dGVzKG1lcmdlZERhdGEuZ2V0KCksIENGRGF0 YUdldEJ5dGVQdHIoZGF0YSksIENGRGF0YUdldExlbmd0aChkYXRhKSk7Ci0gICAgfQorICAgIFJl ZlB0cjxTaGFyZWRCdWZmZXI+IHNoYXJlZEJ1ZmZlciA9IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKCk7 CisgICAgZm9yIChDRkluZGV4IGluZGV4ID0gMDsgaW5kZXggPCBjb3VudDsgaW5kZXgrKykKKyAg ICAgICAgc2hhcmVkQnVmZmVyLT5hcHBlbmQoc3RhdGljX2Nhc3Q8Q0ZEYXRhUmVmPihDRkFycmF5 R2V0VmFsdWVBdEluZGV4KGRhdGFBcnJheSwgaW5kZXgpKSk7CiAKLSAgICBjbGllbnQoKS0+ZGlk UmVjZWl2ZUJ1ZmZlcih0aGlzLCBTaGFyZWRCdWZmZXI6OndyYXBDRkRhdGEobWVyZ2VkRGF0YS5n ZXQoKSksIC0xKTsKKyAgICBjbGllbnQoKS0+ZGlkUmVjZWl2ZUJ1ZmZlcih0aGlzLCBzaGFyZWRC dWZmZXIsIC0xKTsKIH0KICNlbmRpZgogCg==