133766 2014-06-11 14:17:46 -0700 Implement swipeWithEvent for non-fluid swipes 2014-06-11 15:47:59 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca simon.fraser oldest_to_newest 1014913 0 thorton 2014-06-11 14:17:46 -0700 <rdar://problem/17126889> 1014914 1 232904 thorton 2014-06-11 14:21:37 -0700 Created attachment 232904 patch 1014915 2 232904 andersca 2014-06-11 14:24:32 -0700 Comment on attachment 232904 patch View in context: https://bugs.webkit.org/attachment.cgi?id=232904&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:1188 > + if ([self shouldIgnoreMouseEvents]) > + return; > + > + if (!_data->_allowsBackForwardNavigationGestures) > + return; > + > + if ([event deltaX] > 0.0) > + _data->_page->goBack(); > + else if ([event deltaX] < 0.0) > + _data->_page->goForward(); Dot syntax. Should we call super if we can't swipe? 1014965 3 thorton 2014-06-11 15:47:59 -0700 http://trac.webkit.org/changeset/169850 232904 2014-06-11 14:21:37 -0700 2014-06-11 14:24:32 -0700 patch swipewithevent.diff text/plain 1429 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4YzA1MTJlLi42MTA5ZWE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDYtMTEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgSW1wbGVtZW50IHN3aXBlV2l0aEV2ZW50IGZvciBub24tZmx1aWQgc3dpcGVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM3NjYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAgKC1bV0tWaWV3IHN3aXBlV2l0aEV2ZW50Ol0p OgorICAgICAgICBPbiBub24tZmx1aWQgc3dpcGVzLCBnbyBiYWNrIG9yIGZvcndhcmQgZGVwZW5k aW5nIG9uIHRoZSBzd2lwZSBkaXJlY3Rpb24uCisKIDIwMTQtMDYtMTEgIEVucmljYSBDYXN1Y2Np ICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJLaXQyIGlPUzogVW5hYmxlIHRvIG9w ZW4gVUkgbWVudSBmb3IgIm9wZW4gaW4gbmV3IHRhYiIgZm9yIGxpbmtzIG9uIHlhaG9vLmNvbS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbSBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQppbmRleCAyMmVjN2Ey Li4xYmI1MWUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1t CkBAIC0xMTc0LDYgKzExNzQsMjAgQEAgTkFUSVZFX01PVVNFX0VWRU5UX0hBTkRMRVIocmlnaHRN b3VzZVVwKQogICAgIF9kYXRhLT5fcGFnZS0+aGFuZGxlV2hlZWxFdmVudCh3ZWJFdmVudCk7CiB9 CiAKKy0gKHZvaWQpc3dpcGVXaXRoRXZlbnQ6KE5TRXZlbnQgKilldmVudAoreworICAgIGlmIChb c2VsZiBzaG91bGRJZ25vcmVNb3VzZUV2ZW50c10pCisgICAgICAgIHJldHVybjsKKworICAgIGlm ICghX2RhdGEtPl9hbGxvd3NCYWNrRm9yd2FyZE5hdmlnYXRpb25HZXN0dXJlcykKKyAgICAgICAg cmV0dXJuOworCisgICAgaWYgKFtldmVudCBkZWx0YVhdID4gMC4wKQorICAgICAgICBfZGF0YS0+ X3BhZ2UtPmdvQmFjaygpOworICAgIGVsc2UgaWYgKFtldmVudCBkZWx0YVhdIDwgMC4wKQorICAg ICAgICBfZGF0YS0+X3BhZ2UtPmdvRm9yd2FyZCgpOworfQorCiAtICh2b2lkKW1vdXNlTW92ZWQ6 KE5TRXZlbnQgKilldmVudAogewogICAgIGlmIChbc2VsZiBzaG91bGRJZ25vcmVNb3VzZUV2ZW50 c10pCg==