133753 2014-06-11 11:45:42 -0700 Change the order of the alias analysis passes to align with the opt pipeline of LLVM 2014-06-16 12:28:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 juergen webkit-unassigned atrick commit-queue oldest_to_newest 1014829 0 juergen 2014-06-11 11:45:42 -0700 Change the order of the alias analysis passes to align with the opt pipeline of LLVM 1014834 1 232880 juergen 2014-06-11 11:55:35 -0700 Created attachment 232880 Patch 1014855 2 232880 ggaren 2014-06-11 12:41:39 -0700 Comment on attachment 232880 Patch Seems reasonable. Is this a speedup, or just a cleanup? 1014858 3 juergen 2014-06-11 12:45:27 -0700 I didn't check if there is a speedup, but I feel more comfortable using an order that is used and tested by the default LLVM opt pipeline. 1015324 4 atrick 2014-06-12 20:27:00 -0700 The AA implementations are queried in reverse order, last added, first queried. For C++, we query BasicAA first for correctness. It may actually disagree with TBAA! If TBAA says objects can't alias, but they are obviously derived from the same pointer, then TBAA is wrong and we want to catch that. For JS, that's not an issue and it makes sense to query TBAA first instead since it is probably faster. However, if we can't measure any compile time difference, then I agree with Juergen, that it's a bit less risky to be consistent with the C++ optimizer. 1015927 5 232880 commit-queue 2014-06-16 12:28:18 -0700 Comment on attachment 232880 Patch Clearing flags on attachment: 232880 Committed r170022: <http://trac.webkit.org/changeset/170022> 1015928 6 commit-queue 2014-06-16 12:28:20 -0700 All reviewed patches have been landed. Closing bug. 232880 2014-06-11 11:55:35 -0700 2014-06-16 12:28:18 -0700 Patch bug-133753-20140611115510.patch text/plain 2028 juergen U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 MGM5ZWU5MTMyNDI1OTk1YjJhNjE4ZDJmYzNmYjA3ZDI3YTE4MjFmLi5iZjk2YWE1YjVjNWRmNTQy ZjA5ZjY1ODY5N2E3YjZkODJhYWQzY2IxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNC0wNi0xMSAgSnVlcmdlbiBSaWJ1dHprYSAgPGp1ZXJnZW5AYXBwbGUu Y29tPgorCisgICAgICAgIENoYW5nZSB0aGUgb3JkZXIgb2YgdGhlIGFsaWFzIGFuYWx5c2lzIHBh c3NlcyB0byBhbGlnbiB3aXRoIHRoZSBvcHQgcGlwZWxpbmUgb2YgTExWTQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzNzUzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG9yZGVyIGluIHdoaWNoIHRo ZSBhbGlhcyBhbmFseXNpcyBwYXNzZXMgYXJlIGFkZGVkIGFmZmVjdHMgYWxzbyB0aGUKKyAgICAg ICAgb3JkZXIgaW4gd2hpY2ggdGhleSBhcmUgdXRpbGl6ZWQuIENoYW5nZSB0aGUgb3JkZXIgdG8g YWxpZ24gd2l0aCB0aGUKKyAgICAgICAgb25lIHVzZSBieSBMTFZNIGl0c2VsZi4gVGhlIGxhc3Qg YWxpYXMgYW5hbHlzaXMgcGFzcyBhZGRlZCB3aWxsIGJlCisgICAgICAgIGV2YWx1YXRlZCBmaXJz dC4gV2l0aCB0aGlzIGNoYW5nZSB3ZSBmaXJzdCBwZXJmb3JtIGEgYmFzaWMgYWxpYXMKKyAgICAg ICAgYW5hbHlzaXMgYW5kIHRoZW4gdXNlIHRoZSB0eXBlLWJhc2VkIGFsaWFzIGFuYWx5c2lzIChp ZiByZXF1aXJlZCkuCisKKyAgICAgICAgKiBmdGwvRlRMQ29tcGlsZS5jcHA6CisgICAgICAgIChK U0M6OkZUTDo6Y29tcGlsZSk6CisKIDIwMTQtMDYtMTAgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBw bGUuY29tPgogCiAgICAgICAgIEFzc2VydGlvbiBmYWlsdXJlIGF0IEpTQzo6U3RydWN0dXJlOjpj aGVja09mZnNldENvbnNpc3RlbmN5KCkgY29uc3QgKyAyMzQuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZnRsL0ZUTENvbXBpbGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2Z0bC9GVExDb21waWxlLmNwcAppbmRleCBjYmEyNzI4ZGYwZjEzNzk3MDE4MDQ4NGM0YmEyYjhl OTM1ZDcxOThmLi5mMzhiMWFmZjMxYjUxZGNhMjJiODUwMWVhNTNmMzU2ZTFkZjRjODMxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTENvbXBpbGUuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQ29tcGlsZS5jcHAKQEAgLTUyNiw4ICs1MjYsOCBA QCB2b2lkIGNvbXBpbGUoU3RhdGUmIHN0YXRlLCBTYWZlcG9pbnQ6OlJlc3VsdCYgc2FmZXBvaW50 UmVzdWx0KQogICAgICAgICAgICAgbGx2bS0+QWRkUHJvbW90ZU1lbW9yeVRvUmVnaXN0ZXJQYXNz KG1vZHVsZVBhc3Nlcyk7CiAgICAgICAgICAgICBsbHZtLT5BZGRDb25zdGFudFByb3BhZ2F0aW9u UGFzcyhtb2R1bGVQYXNzZXMpOwogICAgICAgICAgICAgbGx2bS0+QWRkSW5zdHJ1Y3Rpb25Db21i aW5pbmdQYXNzKG1vZHVsZVBhc3Nlcyk7Ci0gICAgICAgICAgICBsbHZtLT5BZGRCYXNpY0FsaWFz QW5hbHlzaXNQYXNzKG1vZHVsZVBhc3Nlcyk7CiAgICAgICAgICAgICBsbHZtLT5BZGRUeXBlQmFz ZWRBbGlhc0FuYWx5c2lzUGFzcyhtb2R1bGVQYXNzZXMpOworICAgICAgICAgICAgbGx2bS0+QWRk QmFzaWNBbGlhc0FuYWx5c2lzUGFzcyhtb2R1bGVQYXNzZXMpOwogICAgICAgICAgICAgbGx2bS0+ QWRkR1ZOUGFzcyhtb2R1bGVQYXNzZXMpOwogICAgICAgICAgICAgbGx2bS0+QWRkQ0ZHU2ltcGxp ZmljYXRpb25QYXNzKG1vZHVsZVBhc3Nlcyk7CiAgICAgICAgICAgICBsbHZtLT5BZGREZWFkU3Rv cmVFbGltaW5hdGlvblBhc3MobW9kdWxlUGFzc2VzKTsK