133749 2014-06-11 10:46:53 -0700 WebKit2 iOS: Unable to open UI menu for "open in new tab" for links on yahoo.com 2014-06-18 11:01:29 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 1014802 0 enrica 2014-06-11 10:46:53 -0700 This is a problem on iPad only. Tap and hold on a link on the yahoo page does not show the link menu popover. <rdar://problem/17165992> 1014804 1 232873 enrica 2014-06-11 10:49:32 -0700 Created attachment 232873 Patch 1014812 2 enrica 2014-06-11 11:06:56 -0700 Committed revision 169813. 1016494 3 232873 darin 2014-06-18 11:01:29 -0700 Comment on attachment 232873 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232873&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1698 > + info.url = [(NSURL *)linkElement->document().completeURL(stripLeadingAndTrailingHTMLSpaces(linkElement->getAttribute(HTMLNames::hrefAttr))) absoluteString]; What does “encoded” mean? Why is conversion to an NSURL the best way to do this? Why is absoluteString the right method to use rather than, say, the userVisibleString function? 232873 2014-06-11 10:49:32 -0700 2014-06-18 11:01:29 -0700 Patch nomenuonyahoo.txt text/plain 1703 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTgxMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA2LTExICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViS2l0MiBpT1M6IFVuYWJs ZSB0byBvcGVuIFVJIG1lbnUgZm9yICJvcGVuIGluIG5ldyB0YWIiIGZvciBsaW5rcyBvbiB5YWhv by5jb20uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzM3NDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3MTY1OTkyPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBVUkwgcmV0dXJuZWQgdG8gdGhl IFVJUHJvY2VzcyBhcyBzdHJpbmcgbmVlZHMgdG8gYmUgZW5jb2RlZC4KKworICAgICAgICAqIFdl YlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2Vi UGFnZTo6Z2V0UG9zaXRpb25JbmZvcm1hdGlvbik6CisKIDIwMTQtMDYtMTEgIEFudHRpIEtvaXZp c3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFdyYXAgTlNVUkxSZXF1ZXN0IGluIGJ1 bmRsZSBBUEkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2Vi UGFnZUlPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvaW9zL1dlYlBhZ2VJT1MubW0JKHJldmlzaW9uIDE2OTc1NSkKKysrIFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkod29ya2luZyBjb3B5KQpAQCAt MTY5NSw3ICsxNjk1LDcgQEAgdm9pZCBXZWJQYWdlOjpnZXRQb3NpdGlvbkluZm9ybWF0aW9uKGNv bgogICAgICAgICAgICAgICAgIGVsZW1lbnRJc0xpbmtPckltYWdlID0gdHJ1ZTsKICAgICAgICAg ICAgIH0KICAgICAgICAgICAgIGlmIChsaW5rRWxlbWVudCkKLSAgICAgICAgICAgICAgICBpbmZv LnVybCA9IGxpbmtFbGVtZW50LT5kb2N1bWVudCgpLmNvbXBsZXRlVVJMKHN0cmlwTGVhZGluZ0Fu ZFRyYWlsaW5nSFRNTFNwYWNlcyhsaW5rRWxlbWVudC0+Z2V0QXR0cmlidXRlKEhUTUxOYW1lczo6 aHJlZkF0dHIpKSk7CisgICAgICAgICAgICAgICAgaW5mby51cmwgPSBbKE5TVVJMICopbGlua0Vs ZW1lbnQtPmRvY3VtZW50KCkuY29tcGxldGVVUkwoc3RyaXBMZWFkaW5nQW5kVHJhaWxpbmdIVE1M U3BhY2VzKGxpbmtFbGVtZW50LT5nZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpocmVmQXR0cikpKSBh YnNvbHV0ZVN0cmluZ107CiAgICAgICAgICAgICBpbmZvLnRpdGxlID0gZWxlbWVudC0+ZmFzdEdl dEF0dHJpYnV0ZShIVE1MTmFtZXM6OnRpdGxlQXR0cikuc3RyaW5nKCk7CiAgICAgICAgICAgICBp ZiAoZWxlbWVudC0+cmVuZGVyZXIoKSkKICAgICAgICAgICAgICAgICBpbmZvLmJvdW5kcyA9IGVs ZW1lbnQtPnJlbmRlcmVyKCktPmFic29sdXRlQm91bmRpbmdCb3hSZWN0KHRydWUpOwo=