133725 2014-06-11 00:57:52 -0700 [GTK] Remove view mode API 2014-06-12 00:38:46 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 133724 1 cgarcia webkit-unassigned berto bunhere cdumez commit-queue gustavo gyuyoung.kim mrobinson sergio oldest_to_newest 1014684 0 cgarcia 2014-06-11 00:57:52 -0700 It currently does nothing because support for view source mode was removed from WebCore. 1014685 1 232852 cgarcia 2014-06-11 00:59:22 -0700 Created attachment 232852 Patch 1014686 2 commit-queue 2014-06-11 01:01:33 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1015053 3 cgarcia 2014-06-12 00:38:46 -0700 Committed r169884: <http://trac.webkit.org/changeset/169884> 232852 2014-06-11 00:59:22 -0700 2014-06-11 06:51:26 -0700 Patch wk2-remove-view-mode.diff text/plain 7200 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxMzFiM2MyLi4zMTVjZTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTQtMDYtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIFJlbW92ZSB2aWV3IG1vZGUgQVBJCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM3MjUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBjdXJyZW50bHkgZG9lcyBub3RoaW5n IGJlY2F1c2Ugc3VwcG9ydCBmb3IgdmlldyBzb3VyY2UgbW9kZSB3YXMKKyAgICAgICAgcmVtb3Zl ZCBmcm9tIFdlYkNvcmUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJW aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdTZXRQcm9wZXJ0eSk6CisgICAgICAgICh3 ZWJraXRXZWJWaWV3R2V0UHJvcGVydHkpOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2NsYXNz X2luaXQpOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X3NldF92aWV3X21vZGUpOiBEZWxldGVk LgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2dldF92aWV3X21vZGUpOiBEZWxldGVkLgorICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuaDoKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0OgorCisyMDE0LTA2LTEx ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBb R1RLXSBVc2UgYSBkaWZmZXJlbnQgdXNlciBhZ2VudCBzdHJpbmcgZGVwZW5kaW5nIG9uIHRoZSBz aXRlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI2 ODEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 V2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJW aWV3LmNwcAppbmRleCBhZWIyMWY2Li43MDM5ZDU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcApAQCAtMTM4LDggKzEzOCw3IEBA IGVudW0gewogICAgIFBST1BfRkFWSUNPTiwKICAgICBQUk9QX1VSSSwKICAgICBQUk9QX1pPT01f TEVWRUwsCi0gICAgUFJPUF9JU19MT0FESU5HLAotICAgIFBST1BfVklFV19NT0RFCisgICAgUFJP UF9JU19MT0FESU5HCiB9OwogCiB0eXBlZGVmIEhhc2hNYXA8dWludDY0X3QsIEdSZWZQdHI8V2Vi S2l0V2ViUmVzb3VyY2U+ID4gTG9hZGluZ1Jlc291cmNlc01hcDsKQEAgLTU0Niw5ICs1NDUsNiBA QCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3U2V0UHJvcGVydHkoR09iamVjdCogb2JqZWN0LCBn dWludCBwcm9wSWQsIGNvbnN0IEdWYWx1ZQogICAgIGNhc2UgUFJPUF9aT09NX0xFVkVMOgogICAg ICAgICB3ZWJraXRfd2ViX3ZpZXdfc2V0X3pvb21fbGV2ZWwod2ViVmlldywgZ192YWx1ZV9nZXRf ZG91YmxlKHZhbHVlKSk7CiAgICAgICAgIGJyZWFrOwotICAgIGNhc2UgUFJPUF9WSUVXX01PREU6 Ci0gICAgICAgIHdlYmtpdF93ZWJfdmlld19zZXRfdmlld19tb2RlKHdlYlZpZXcsIHN0YXRpY19j YXN0PFdlYktpdFZpZXdNb2RlPihnX3ZhbHVlX2dldF9lbnVtKHZhbHVlKSkpOwotICAgICAgICBi cmVhazsKICAgICBkZWZhdWx0OgogICAgICAgICBHX09CSkVDVF9XQVJOX0lOVkFMSURfUFJPUEVS VFlfSUQob2JqZWN0LCBwcm9wSWQsIHBhcmFtU3BlYyk7CiAgICAgfQpAQCAtNTgzLDkgKzU3OSw2 IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdHZXRQcm9wZXJ0eShHT2JqZWN0KiBvYmplY3Qs IGd1aW50IHByb3BJZCwgR1ZhbHVlKiB2YWx1CiAgICAgY2FzZSBQUk9QX0lTX0xPQURJTkc6CiAg ICAgICAgIGdfdmFsdWVfc2V0X2Jvb2xlYW4odmFsdWUsIHdlYmtpdF93ZWJfdmlld19pc19sb2Fk aW5nKHdlYlZpZXcpKTsKICAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBQUk9QX1ZJRVdfTU9ERToK LSAgICAgICAgZ192YWx1ZV9zZXRfZW51bSh2YWx1ZSwgd2Via2l0X3dlYl92aWV3X2dldF92aWV3 X21vZGUod2ViVmlldykpOwotICAgICAgICBicmVhazsKICAgICBkZWZhdWx0OgogICAgICAgICBH X09CSkVDVF9XQVJOX0lOVkFMSURfUFJPUEVSVFlfSUQob2JqZWN0LCBwcm9wSWQsIHBhcmFtU3Bl Yyk7CiAgICAgfQpAQCAtNzY4LDIxICs3NjEsNiBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3Zp ZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdFQktJVF9Q QVJBTV9SRUFEQUJMRSkpOwogCiAgICAgLyoqCi0gICAgICogV2ViS2l0V2ViVmlldzp2aWV3LW1v ZGU6Ci0gICAgICoKLSAgICAgKiBUaGUgI1dlYktpdFZpZXdNb2RlIHRoYXQgaXMgdXNlZCB0byBk aXNwbGF5IHRoZSBjb250ZW50cyBvZiBhICNXZWJLaXRXZWJWaWV3LgotICAgICAqIFNlZSBhbHNv IHdlYmtpdF93ZWJfdmlld19zZXRfdmlld19tb2RlKCkuCi0gICAgICovCi0gICAgZ19vYmplY3Rf Y2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShnT2JqZWN0Q2xhc3MsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBQUk9QX1ZJRVdfTU9ERSwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGdfcGFyYW1fc3BlY19lbnVtKCJ2aWV3LW1vZGUiLAotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlZpZXcgTW9kZSIsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJU aGUgdmlldyBtb2RlIHRvIGRpc3BsYXkgdGhlIHdlYiB2aWV3IGNvbnRlbnRzIiksCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXRUJLSVRfVFlQ RV9WSUVXX01PREUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBXRUJLSVRfVklFV19NT0RFX1dFQiwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdFQktJVF9QQVJBTV9SRUFEV1JJVEUpKTsK LQotICAgIC8qKgogICAgICAqIFdlYktpdFdlYlZpZXc6OmxvYWQtY2hhbmdlZDoKICAgICAgKiBA d2ViX3ZpZXc6IHRoZSAjV2ViS2l0V2ViVmlldyBvbiB3aGljaCB0aGUgc2lnbmFsIGlzIGVtaXR0 ZWQKICAgICAgKiBAbG9hZF9ldmVudDogdGhlICNXZWJLaXRMb2FkRXZlbnQKQEAgLTMwMjksMzgg KzMwMDcsNiBAQCBXZWJLaXREb3dubG9hZCogd2Via2l0X3dlYl92aWV3X2Rvd25sb2FkX3VyaShX ZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBjb25zdCBjaGFyKgogfQogCiAvKioKLSAqIHdlYmtpdF93 ZWJfdmlld19zZXRfdmlld19tb2RlOgotICogQHdlYl92aWV3OiBhICNXZWJLaXRXZWJWaWV3Ci0g KiBAdmlld19tb2RlOiBhICNXZWJLaXRWaWV3TW9kZQotICoKLSAqIFNldCB0aGUgdmlldyBtb2Rl IG9mIEB3ZWJfdmlldyB0byBAdmlld19tb2RlLiBUaGlzIG1ldGhvZCBzaG91bGQgYmUgY2FsbGVk Ci0gKiBiZWZvcmUgbG9hZGluZyBuZXcgY29udGVudHMgb24gQHdlYl92aWV3IHNvIHRoYXQgdGhl IG5ldyAjV2ViS2l0Vmlld01vZGUgd2lsbAotICogYmUgYXBwbGllZCB0byB0aGUgbmV3IGNvbnRl bnRzLgotICovCi12b2lkIHdlYmtpdF93ZWJfdmlld19zZXRfdmlld19tb2RlKFdlYktpdFdlYlZp ZXcqIHdlYlZpZXcsIFdlYktpdFZpZXdNb2RlIHZpZXdNb2RlKQotewotICAgIGdfcmV0dXJuX2lm X2ZhaWwoV0VCS0lUX0lTX1dFQl9WSUVXKHdlYlZpZXcpKTsKLQotICAgIGlmICh2aWV3TW9kZSA9 PSBXRUJLSVRfVklFV19NT0RFX1NPVVJDRSkKLSAgICAgICAgZ193YXJuaW5nKCJXRUJLSVRfVklF V19NT0RFX1NPVVJDRSBoYXMgYmVlbiBkZXByZWNhdGVkIGFuZCBpcyBubyBsb25nZXIgc3VwcG9y dGVkLiIpOwotfQotCi0vKioKLSAqIHdlYmtpdF93ZWJfdmlld19nZXRfdmlld19tb2RlOgotICog QHdlYl92aWV3OiBhICNXZWJLaXRXZWJWaWV3Ci0gKgotICogR2V0IHRoZSB2aWV3IG1vZGUgb2Yg QHdlYl92aWV3LgotICoKLSAqIFJldHVybnM6IHRoZSAjV2ViS2l0Vmlld01vZGUgb2YgQHdlYl92 aWV3LgotICovCi1XZWJLaXRWaWV3TW9kZSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3ZpZXdfbW9kZShX ZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQotewotICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJ VF9JU19XRUJfVklFVyh3ZWJWaWV3KSwgV0VCS0lUX1ZJRVdfTU9ERV9XRUIpOwotCi0gICAgcmV0 dXJuIFdFQktJVF9WSUVXX01PREVfV0VCOwotfQotCi0vKioKICAqIHdlYmtpdF93ZWJfdmlld19n ZXRfdGxzX2luZm86CiAgKiBAd2ViX3ZpZXc6IGEgI1dlYktpdFdlYlZpZXcKICAqIEBjZXJ0aWZp Y2F0ZTogKG91dCkgKHRyYW5zZmVyIG5vbmUpOiByZXR1cm4gbG9jYXRpb24gZm9yIGEgI0dUbHND ZXJ0aWZpY2F0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViVmlldy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 V2ViVmlldy5oCmluZGV4IDk1YzU0M2IuLjk4MGY0NTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmgKQEAgLTE1MCwxOSArMTUwLDYgQEAg dHlwZWRlZiBlbnVtIHsKIH0gV2ViS2l0SW5zZWN1cmVDb250ZW50RXZlbnQ7CiAKIC8qKgotICog V2ViS2l0Vmlld01vZGU6Ci0gKiBAV0VCS0lUX1ZJRVdfTU9ERV9XRUI6IFRoZSBub3JtYWwgdmll dyBtb2RlIHRvIGRpc3BsYXkgd2ViIGNvbnRlbnRzLgotICogQFdFQktJVF9WSUVXX01PREVfU09V UkNFOiBUaGUgc291cmNlIG1vZGUgdG8gZGlzcGxheSB3ZWIgc291cmNlIGNvZGUuIERlcHJlY2F0 ZWQ6IDIuNi4KLSAqCi0gKiBFbnVtIHZhbHVlcyB0byBzcGVjaWZ5IHRoZSBkaWZmZXJlbnQgd2F5 cyBpbiB3aGljaCBhICNXZWJLaXRXZWJWaWV3Ci0gKiBjYW4gZGlzcGxheSBhIHdlYiBwYWdlLgot ICovCi10eXBlZGVmIGVudW0gewotICAgIFdFQktJVF9WSUVXX01PREVfV0VCLAotICAgIFdFQktJ VF9WSUVXX01PREVfU09VUkNFCi19IFdlYktpdFZpZXdNb2RlOwotCi0vKioKICAqIFdlYktpdFNu YXBzaG90T3B0aW9uczoKICAqIEBXRUJLSVRfU05BUFNIT1RfT1BUSU9OU19OT05FOiBEbyBub3Qg aW5jbHVkZSBhbnkgc3BlY2lhbCBvcHRpb25zLgogICogQFdFQktJVF9TTkFQU0hPVF9PUFRJT05T X0lOQ0xVREVfU0VMRUNUSU9OX0hJR0hMSUdIVElORzogV2hldGhlciB0byBpbmNsdWRlIGluIHRo ZQpAQCAtNDUwLDEzICs0MzcsNiBAQCBXRUJLSVRfQVBJIFdlYktpdERvd25sb2FkICoKIHdlYmtp dF93ZWJfdmlld19kb3dubG9hZF91cmkgICAgICAgICAgICAgICAgICAgICAgICAgKFdlYktpdFdl YlZpZXcgICAgICAgICAgICAgKndlYl92aWV3LAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAgICAgICAgICAgICAgICAqdXJp KTsKIAotV0VCS0lUX0FQSSB2b2lkCi13ZWJraXRfd2ViX3ZpZXdfc2V0X3ZpZXdfbW9kZSAgICAg ICAgICAgICAgICAgICAgICAgIChXZWJLaXRXZWJWaWV3ICAgICAgICAgICAgICp3ZWJfdmlldywK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdl YktpdFZpZXdNb2RlICAgICAgICAgICAgIHZpZXdfbW9kZSk7Ci0KLVdFQktJVF9BUEkgV2ViS2l0 Vmlld01vZGUKLXdlYmtpdF93ZWJfdmlld19nZXRfdmlld19tb2RlICAgICAgICAgICAgICAgICAg ICAgICAgKFdlYktpdFdlYlZpZXcgICAgICAgICAgICAgKndlYl92aWV3KTsKLQogV0VCS0lUX0FQ SSBnYm9vbGVhbgogd2Via2l0X3dlYl92aWV3X2dldF90bHNfaW5mbyAgICAgICAgICAgICAgICAg ICAgICAgICAoV2ViS2l0V2ViVmlldyAgICAgICAgICAgICAqd2ViX3ZpZXcsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHVGxzQ2VydGlmaWNh dGUgICAgICAgICAgKipjZXJ0aWZpY2F0ZSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Via2l0Mmd0ay1zZWN0aW9ucy50eHQgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0CmluZGV4 IGEwOThhMDAuLjQ3Yjg2NGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL2RvY3Mvd2Via2l0Mmd0ay1zZWN0aW9ucy50eHQKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dApAQCAtNzksNyAr NzksNiBAQCBXZWJLaXRXZWJWaWV3CiBXZWJLaXRMb2FkRXZlbnQKIFdlYktpdFBvbGljeURlY2lz aW9uVHlwZQogV2ViS2l0U2F2ZU1vZGUKLVdlYktpdFZpZXdNb2RlCiBXZWJLaXRJbnNlY3VyZUNv bnRlbnRFdmVudAogV2ViS2l0U25hcHNob3RPcHRpb25zCiBXZWJLaXRTbmFwc2hvdFJlZ2lvbgpA QCAtMTQyLDggKzE0MSw2IEBAIHdlYmtpdF93ZWJfdmlld19zYXZlX2ZpbmlzaAogd2Via2l0X3dl Yl92aWV3X3NhdmVfdG9fZmlsZQogd2Via2l0X3dlYl92aWV3X3NhdmVfdG9fZmlsZV9maW5pc2gK IHdlYmtpdF93ZWJfdmlld19kb3dubG9hZF91cmkKLXdlYmtpdF93ZWJfdmlld19zZXRfdmlld19t b2RlCi13ZWJraXRfd2ViX3ZpZXdfZ2V0X3ZpZXdfbW9kZQogd2Via2l0X3dlYl92aWV3X2dldF90 bHNfaW5mbwogd2Via2l0X3dlYl92aWV3X2dldF9zbmFwc2hvdAogd2Via2l0X3dlYl92aWV3X2dl dF9zbmFwc2hvdF9maW5pc2gK