133718 2014-06-10 21:19:20 -0700 DFG::ByteCodeParser should emit native call/construct only in FTL mode, since the DFG backend can't do anything about them and the presence of function checks just means less efficient code 2014-06-11 12:57:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo mmirman barraclough fpizlo ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 1014656 0 fpizlo 2014-06-10 21:19:20 -0700 ... 1014831 1 232878 mmirman 2014-06-11 11:48:06 -0700 Created attachment 232878 Added check for ftl mode before emitting native calls For branch ftlopt. Passed all tests, both 32 and 64 bit. 1014833 2 232878 fpizlo 2014-06-11 11:55:27 -0700 Comment on attachment 232878 Added check for ftl mode before emitting native calls Cool! I will land. 1014861 3 fpizlo 2014-06-11 12:57:16 -0700 Landed in http://trac.webkit.org/changeset/169819 232878 2014-06-11 11:48:06 -0700 2014-06-11 11:55:26 -0700 Added check for ftl mode before emitting native calls 0001-added-check-for-ftlmode-before-emitting-native-calls.patch text/plain 1613 mmirman ZGlmZiAtLWdpdCBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggOTk1NzkyZS4uZjc1ZGY1MCAxMDA2NDQKLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKQEAgLTAsMCArMCwxMSBAQAorMjAxNC0wNi0xMSAgTWF0dGhldyBNaXJtYW4gIDxtbWly bWFuQGFwcGxlLmNvbT4KKyAgICAgICAgRW5zdXJlZCBOYXRpdmUgQ2FsbHMgYW5kIENvbnN0cnVj dCBhbmQgYXNzb2NpYXRlZCBjaGVja3MgCisgICAgICAgIGFyZSBvbmx5IGVtaXR0ZWQgZHVyaW5n IGZ0bCBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTMzNzE4CisgICAgICAgIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KyAgICAgICAgCisgICAgICAgICogZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcDoKKyAgICAgICAg KEpTQzo6REZHOjpCeXRlQ29kZVBhcnNlcjo6aGFuZGxlQ2FsbCk6IEFkZGVkIGNoZWNrIGZvciBm dGwgbW9kZSAKKyAgICAgICAgYmVmb3JlIGF0dGFjaGluZyB0aGUgbmF0aXZlIGZ1bmN0aW9uIHRv IENhbGwgb3IgQ29uc3RydWN0LgorICAgICAgICAKZGlmZiAtLWdpdCBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcCBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0J5dGVDb2RlUGFyc2VyLmNwcAppbmRleCAwYWE4NmRiLi44NjUwNzFlIDEwMDY0NAotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCkBAIC0xMDYzLDExICsx MDYzLDEzIEBAIHZvaWQgQnl0ZUNvZGVQYXJzZXI6OmhhbmRsZUNhbGwoCiAgICAgICAgIGlmICht X2dyYXBoLmNvbXBpbGF0aW9uKCkpCiAgICAgICAgICAgICBtX2dyYXBoLmNvbXBpbGF0aW9uKCkt Pm5vdGljZUlubGluZWRDYWxsKCk7CiAgICAgICAgIHJldHVybjsKLSAgICB9IGVsc2UgaWYgKEpT RnVuY3Rpb24qIGZ1bmN0aW9uID0gY2FsbExpbmtTdGF0dXMuZnVuY3Rpb24oKSkKLSAgICAgICAg aWYgKGZ1bmN0aW9uLT5pc0hvc3RGdW5jdGlvbigpKSB7CisgICAgfSBlbHNlIGlmIChpc0ZUTCht X2dyYXBoLm1fcGxhbi5tb2RlKSkgeworICAgICAgICBKU0Z1bmN0aW9uKiBmdW5jdGlvbiA9IGNh bGxMaW5rU3RhdHVzLmZ1bmN0aW9uKCk7CisgICAgICAgIGlmIChmdW5jdGlvbiAmJiBmdW5jdGlv bi0+aXNIb3N0RnVuY3Rpb24oKSkgewogICAgICAgICAgICAgZW1pdEZ1bmN0aW9uQ2hlY2tzKGNh bGxMaW5rU3RhdHVzLCBjYWxsVGFyZ2V0LCByZWdpc3Rlck9mZnNldCwgc3BlY2lhbGl6YXRpb25L aW5kKTsKICAgICAgICAgICAgIGtub3duRnVuY3Rpb24gPSBmdW5jdGlvbjsKICAgICAgICAgfQor ICAgIH0KICAgICAKICAgICBhZGRDYWxsKHJlc3VsdCwgb3AsIGNhbGxUYXJnZXQsIGFyZ3VtZW50 Q291bnRJbmNsdWRpbmdUaGlzLCByZWdpc3Rlck9mZnNldCktPmdpdmVLbm93bkZ1bmN0aW9uKGtu b3duRnVuY3Rpb24pOwogfQo=