<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>133711</bug_id>
          
          <creation_ts>2014-06-10 18:35:12 -0700</creation_ts>
          <short_desc>Web Inspector: Typebuilder should handle an Array of $ref type string with enum.</short_desc>
          <delta_ts>2017-02-20 16:29:21 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>131596</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="James Craig">jcraig</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bburg</cc>
    
    <cc>inspector-bugzilla-changes</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1014615</commentid>
    <comment_count>0</comment_count>
    <who name="James Craig">jcraig</who>
    <bug_when>2014-06-10 18:35:12 -0700</bug_when>
    <thetext>via JoePeck, Typebuilder should handle an Array of $ref type string with enum.

1. Recognize when an array has a $ref which is a string with enums. In such cases we should probably have an Array&lt;String&gt; instead of Array&lt;Enum&gt;
2. In such cases allow Array::addItem(Type::Enum) instead of Array::addItem(String) which under the hood does pushString(getWebEnumConstantValue(enumValue)).
3. For this to work, we may need something special like &quot;EnumArray&quot;, or Array&lt;T1, T2&gt; where T1 is the storage, and T2 is the input.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1014617</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2014-06-10 18:36:09 -0700</bug_when>
    <thetext>&lt;rdar://problem/17262363&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1014619</commentid>
    <comment_count>2</comment_count>
    <who name="James Craig">jcraig</who>
    <bug_when>2014-06-10 18:38:23 -0700</bug_when>
    <thetext>Originally noticed when working on bug 130913.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1019093</commentid>
    <comment_count>3</comment_count>
    <who name="Brian Burg">burg</who>
    <bug_when>2014-06-27 14:30:59 -0700</bug_when>
    <thetext>As far as I remember, this is supported by the new code generator (if not from C++, at least in the JSON file). These issues are much harder to fix in the current generator because the ordering of enums, typedefs, etc is very fragile.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>