13371 2007-04-17 04:02:31 -0700 DumpRenderTree --pixel-tests renders each test twice 2007-11-14 10:33:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 14510 0 mitz 2007-04-17 04:02:31 -0700 Since WebKit is now supposed to paint on load (currently disabled because of <rdar://problem/5092361> but simulated by DumpRenderTree), DumpRenderTree ends up rendering each test to the window in addition to rendering to the offscreen buffer. 61126 1 17244 mitz 2007-11-13 16:20:00 -0800 Created attachment 17244 Paint only once (unless testing repaint) I verified that the painting code is run in --leaks mode simply by using Expose to bring in DRT's "offscreen" window and verifying that the tests are being rendered. I also verified that repaint tests work. 61133 2 17244 darin 2007-11-13 16:47:13 -0800 Comment on attachment 17244 Paint only once (unless testing repaint) r=me 61134 3 mitz 2007-11-13 16:50:14 -0800 Fixed in <http://trac.webkit.org/projects/webkit/changeset/27766>. 61210 4 eric 2007-11-14 10:33:44 -0800 Nice. 17244 2007-11-13 16:20:00 -0800 2007-11-13 16:47:13 -0800 Paint only once (unless testing repaint) 13371_r1.diff text/plain 4458 mitz SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI3NzYxKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMDctMTEtMTMgIERhbiBCZXJuc3RlaW4gIDxt aXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAtIGZpeCA8aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMz NzE+CisgICAgICAgICAgRHVtcFJlbmRlclRyZWUgLS1waXhlbC10ZXN0cyByZW5kZXJzIGVhY2gg dGVzdCB0d2ljZQorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVl Lm1tOgorICAgICAgICAoZHVtcFJlbmRlclRyZWUpOiBSZW1vdmVkIHRoZSAtLXBhaW50IG9wdGlv biBiZWNhdXNlIHRoZSBwYWludGluZyBjb2RlCisgICAgICAgIGlzIGFsd2F5cyBleGVyY2lzZWQg YXMgYSByZXN1bHQgb2YKKyAgICAgICAgLVtGcmFtZUxvYWREZWxlZ2F0ZSB3ZWJWaWV3OmRpZEZp bmlzaExvYWRGcm9tRnJhbWU6XQorICAgICAgICBjYWxsaW5nIC1kaXNwbGF5SWZOZWVkZWQuCisg ICAgICAgIChkdW1wKTogQ2hhbmdlZCB0byBhbHdheXMgZ3JhYiB0aGUgaW1hZ2UgZnJvbSB0aGUg d2luZG93IHNpbmNlIHRoZSB2aWV3CisgICAgICAgIGlzIGFsd2F5cyBkaXNwbGF5ZWQuCisgICAg ICAgIChydW5UZXN0KToKKyAgICAgICAgKGRpc3BsYXlXZWJWaWV3KToKKyAgICAgICAgKiBTY3Jp cHRzL3J1bi13ZWJraXQtdGVzdHM6IE5vIG5lZWQgdG8gcGFzcyAtLXBhaW50IHRvIER1bXBSZW5k ZXJUcmVlCisgICAgICAgIGJlY2F1c2UgaXQgYWx3YXlzIHBhaW50cy4KKwogMjAwNy0xMS0xMiAg QW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QWRlbGUuCkluZGV4OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRy ZWUubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBS ZW5kZXJUcmVlLm1tCShyZXZpc2lvbiAyNzc2MCkKKysrIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJU cmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQkod29ya2luZyBjb3B5KQpAQCAtMTI1LDEwICsxMjUs OCBAQCBzdGF0aWMgUmVzb3VyY2VMb2FkRGVsZWdhdGUgKnJlc291cmNlTG9hCiBQb2xpY3lEZWxl Z2F0ZSAqcG9saWN5RGVsZWdhdGU7CiAKIHN0YXRpYyBpbnQgZHVtcFBpeGVsczsKLXN0YXRpYyBp bnQgcGFpbnQ7CiBzdGF0aWMgaW50IGR1bXBBbGxQaXhlbHM7CiBzdGF0aWMgaW50IHRocmVhZGVk Owotc3RhdGljIEJPT0wgcmVhZEZyb21XaW5kb3c7CiBzdGF0aWMgaW50IHRlc3RSZXBhaW50RGVm YXVsdDsKIHN0YXRpYyBpbnQgcmVwYWludFN3ZWVwSG9yaXpvbnRhbGx5RGVmYXVsdDsKIHN0YXRp YyBpbnQgZHVtcFRyZWUgPSBZRVM7CkBAIC00NDEsNyArNDM5LDYgQEAgdm9pZCBkdW1wUmVuZGVy VHJlZShpbnQgYXJnYywgY29uc3QgY2hhcgogICAgICAgICB7Imhvcml6b250YWwtc3dlZXAiLCBu b19hcmd1bWVudCwgJnJlcGFpbnRTd2VlcEhvcml6b250YWxseURlZmF1bHQsIFlFU30sCiAgICAg ICAgIHsibm90cmVlIiwgbm9fYXJndW1lbnQsICZkdW1wVHJlZSwgTk99LAogICAgICAgICB7InBp eGVsLXRlc3RzIiwgbm9fYXJndW1lbnQsICZkdW1wUGl4ZWxzLCBZRVN9LAotICAgICAgICB7InBh aW50Iiwgbm9fYXJndW1lbnQsICZwYWludCwgWUVTfSwKICAgICAgICAgeyJyZXBhaW50Iiwgbm9f YXJndW1lbnQsICZ0ZXN0UmVwYWludERlZmF1bHQsIFlFU30sCiAgICAgICAgIHsidHJlZSIsIG5v X2FyZ3VtZW50LCAmZHVtcFRyZWUsIFlFU30sCiAgICAgICAgIHsidGhyZWFkZWQiLCBub19hcmd1 bWVudCwgJnRocmVhZGVkLCBZRVN9LApAQCAtOTAyLDcgKzg5OSw3IEBAIHZvaWQgZHVtcCgpCiAg ICAgICAgICAgICBOU0dyYXBoaWNzQ29udGV4dCogbnNDb250ZXh0ID0gW05TR3JhcGhpY3NDb250 ZXh0IGdyYXBoaWNzQ29udGV4dFdpdGhHcmFwaGljc1BvcnQ6Y2dDb250ZXh0IGZsaXBwZWQ6Tk9d OwogICAgICAgICAgICAgW05TR3JhcGhpY3NDb250ZXh0IHNldEN1cnJlbnRDb250ZXh0Om5zQ29u dGV4dF07CiAKLSAgICAgICAgICAgIGlmIChyZWFkRnJvbVdpbmRvdykgeworICAgICAgICAgICAg aWYgKCFsYXlvdXRUZXN0Q29udHJvbGxlci0+dGVzdFJlcGFpbnQoKSkgewogICAgICAgICAgICAg ICAgIE5TQml0bWFwSW1hZ2VSZXAgKmltYWdlUmVwOwogICAgICAgICAgICAgICAgIFt2aWV3IGRp c3BsYXlJZk5lZWRlZF07CiAgICAgICAgICAgICAgICAgW3ZpZXcgbG9ja0ZvY3VzXTsKQEAgLTkx MCw5ICs5MDcsNyBAQCB2b2lkIGR1bXAoKQogICAgICAgICAgICAgICAgIFt2aWV3IHVubG9ja0Zv Y3VzXTsKICAgICAgICAgICAgICAgICBbaW1hZ2VSZXAgZHJhd107CiAgICAgICAgICAgICAgICAg W2ltYWdlUmVwIHJlbGVhc2VdOwotICAgICAgICAgICAgfSBlbHNlIGlmICghbGF5b3V0VGVzdENv bnRyb2xsZXItPnRlc3RSZXBhaW50KCkpCi0gICAgICAgICAgICAgICAgW3ZpZXcgZGlzcGxheVJl Y3RJZ25vcmluZ09wYWNpdHk6TlNNYWtlUmVjdCgwLCAwLCB3ZWJWaWV3U2l6ZS53aWR0aCwgd2Vi Vmlld1NpemUuaGVpZ2h0KSBpbkNvbnRleHQ6bnNDb250ZXh0XTsKLSAgICAgICAgICAgIGVsc2Ug aWYgKCFsYXlvdXRUZXN0Q29udHJvbGxlci0+dGVzdFJlcGFpbnRTd2VlcEhvcml6b250YWxseSgp KSB7CisgICAgICAgICAgICB9IGVsc2UgaWYgKCFsYXlvdXRUZXN0Q29udHJvbGxlci0+dGVzdFJl cGFpbnRTd2VlcEhvcml6b250YWxseSgpKSB7CiAgICAgICAgICAgICAgICAgTlNSZWN0IGxpbmUg PSBOU01ha2VSZWN0KDAsIDAsIHdlYlZpZXdTaXplLndpZHRoLCAxKTsKICAgICAgICAgICAgICAg ICB3aGlsZSAobGluZS5vcmlnaW4ueSA8IHdlYlZpZXdTaXplLmhlaWdodCkgewogICAgICAgICAg ICAgICAgICAgICBbdmlldyBkaXNwbGF5UmVjdElnbm9yaW5nT3BhY2l0eTpsaW5lIGluQ29udGV4 dDpuc0NvbnRleHRdOwpAQCAtOTc2LDEyICs5NzEsOSBAQCB2b2lkIGR1bXAoKQogCiAgICAgICAg IHByaW50ZigiI0VPRlxuIik7CiAgICAgfQotICAgIAorCiAgICAgZmZsdXNoKHN0ZG91dCk7CiAK LSAgICBpZiAocGFpbnQpCi0gICAgICAgIGRpc3BsYXlXZWJWaWV3KCk7Ci0gICAgCiAgICAgZG9u ZSA9IFlFUzsKIH0KIApAQCAtMTAyMyw3ICsxMDE1LDYgQEAgc3RhdGljIHZvaWQgcnVuVGVzdChj b25zdCBjaGFyICpwYXRoT3JVUgogICAgIHRvcExvYWRpbmdGcmFtZSA9IG5pbDsKIAogICAgIGRv bmUgPSBOTzsKLSAgICByZWFkRnJvbVdpbmRvdyA9IE5POwogCiAgICAgaWYgKGRpc2FsbG93ZWRV UkxzKQogICAgICAgICBDRlNldFJlbW92ZUFsbFZhbHVlcyhkaXNhbGxvd2VkVVJMcyk7CkBAIC0x MTMyLDcgKzExMjMsNiBAQCB2b2lkIGRpc3BsYXlXZWJWaWV3KCkKICAgICBbW1tOU0NvbG9yIGJs YWNrQ29sb3JdIGNvbG9yV2l0aEFscGhhQ29tcG9uZW50OjAuNjZdIHNldF07CiAgICAgTlNSZWN0 RmlsbFVzaW5nT3BlcmF0aW9uKFt3ZWJWaWV3IGZyYW1lXSwgTlNDb21wb3NpdGVTb3VyY2VPdmVy KTsKICAgICBbd2ViVmlldyB1bmxvY2tGb2N1c107Ci0gICAgcmVhZEZyb21XaW5kb3cgPSBZRVM7 CiB9CiAKIEBpbXBsZW1lbnRhdGlvbiBEdW1wUmVuZGVyVHJlZVBhc3RlYm9hcmQKSW5kZXg6IFdl YktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRU b29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMJKHJldmlzaW9uIDI3NzYwKQorKysgV2ViS2l0 VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC00MTcsNyAr NDE3LDYgQEAgcHVzaCBAdG9vbEFyZ3MsICItLXBpeGVsLXRlc3RzIiBpZiAkcGl4ZQogcHVzaCBA dG9vbEFyZ3MsICItLXJlcGFpbnQiIGlmICRyZXBhaW50VGVzdHM7CiBwdXNoIEB0b29sQXJncywg Ii0taG9yaXpvbnRhbC1zd2VlcCIgaWYgJHJlcGFpbnRTd2VlcEhvcml6b250YWxseTsKIHB1c2gg QHRvb2xBcmdzLCAiLS10aHJlYWRlZCIgaWYgJHRocmVhZGVkOwotcHVzaCBAdG9vbEFyZ3MsICIt LXBhaW50IiBpZiAkc2hvdWxkQ2hlY2tMZWFrczsgIyBPdGhlcndpc2UsIERSVCB3b24ndCBleGVy Y2lzZSBwYWludGluZyBsZWFrcy4KIHB1c2ggQHRvb2xBcmdzLCAiLSI7CiAKIG15IEBkaWZmVG9v bEFyZ3MgPSAoKTsK