133682 2014-06-10 10:30:50 -0700 AX: iOS: Return the language for attributed text marker queries 2014-06-10 18:04:41 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 1014428 0 cfleizach 2014-06-10 10:30:50 -0700 If the client is asking for an attributed string for their text markers, we should include the language in that string (so that sub-document language choices can be made) <rdar://problem/16044100> 1014432 1 232794 cfleizach 2014-06-10 10:40:15 -0700 Created attachment 232794 patch 1014552 2 232794 mario 2014-06-10 15:11:42 -0700 Comment on attachment 232794 patch Lgtm, even with my limited knowledge of Objective-C 1014609 3 232794 commit-queue 2014-06-10 18:04:36 -0700 Comment on attachment 232794 patch Clearing flags on attachment: 232794 Committed r169784: <http://trac.webkit.org/changeset/169784> 1014610 4 commit-queue 2014-06-10 18:04:41 -0700 All reviewed patches have been landed. Closing bug. 232794 2014-06-10 10:40:15 -0700 2014-06-10 18:04:36 -0700 patch patch text/plain 2746 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTc0NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTA2LTEwICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKKyAgICAgICAgQVg6IGlPUzogUmV0dXJu IHRoZSBsYW5ndWFnZSBmb3IgYXR0cmlidXRlZCB0ZXh0IG1hcmtlciBxdWVyaWVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM2ODIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbGFuZ3VhZ2UgdG8g dGhlIGxpc3Qgb2Ygb2JqZWN0cyBiZWluZyByZXR1cm5lZCBmb3IgYXR0cmlidXRlZCB0ZXh0Lgor CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBw ZXJJT1MubW06CisgICAgICAgIChBWEF0dHJpYnV0ZVN0cmluZ1NldExhbmd1YWdlKToKKyAgICAg ICAgKEFYQXR0cmlidXRlZFN0cmluZ0FwcGVuZFRleHQpOgorCisyMDE0LTA2LTEwICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKICAgICAgICAgQVg6IFdLMjogaU9TOiB0 ZXh0IGVkaXRpbmcgZG9lcyBub3Qgd29yawogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTMzNjY2CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVySU9TLm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxpdHlPYmpl Y3RXcmFwcGVySU9TLm1tCShyZXZpc2lvbiAxNjk3NDcpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbQkod29ya2lu ZyBjb3B5KQpAQCAtMTA0LDYgKzEwNCw3IEBACiBzdGF0aWMgTlNTdHJpbmcgKiBjb25zdCBVSUFj Y2Vzc2liaWxpdHlUb2tlbkJvbGQgPSBAIlVJQWNjZXNzaWJpbGl0eVRva2VuQm9sZCI7CiBzdGF0 aWMgTlNTdHJpbmcgKiBjb25zdCBVSUFjY2Vzc2liaWxpdHlUb2tlbkl0YWxpYyA9IEAiVUlBY2Nl c3NpYmlsaXR5VG9rZW5JdGFsaWMiOwogc3RhdGljIE5TU3RyaW5nICogY29uc3QgVUlBY2Nlc3Np YmlsaXR5VG9rZW5VbmRlcmxpbmUgPSBAIlVJQWNjZXNzaWJpbGl0eVRva2VuVW5kZXJsaW5lIjsK K3N0YXRpYyBOU1N0cmluZyAqIGNvbnN0IFVJQWNjZXNzaWJpbGl0eVRva2VuTGFuZ3VhZ2UgPSBA IlVJQWNjZXNzaWJpbGl0eVRva2VuTGFuZ3VhZ2UiOwogCiBzdGF0aWMgQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXIqIEFjY2Vzc2liaWxpdHlVbmlnbm9yZWRBbmNlc3RvcihBY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlciAqd3JhcHBlcikKIHsKQEAgLTE2NjAsNiArMTY2MSwxOSBAQAogICAgIHJl dHVybiByZXN1bHQ7CiB9CiAKK3N0YXRpYyB2b2lkIEFYQXR0cmlidXRlU3RyaW5nU2V0TGFuZ3Vh Z2UoTlNNdXRhYmxlQXR0cmlidXRlZFN0cmluZyogYXR0clN0cmluZywgUmVuZGVyT2JqZWN0KiBy ZW5kZXJlciwgTlNSYW5nZSByYW5nZSkKK3sKKyAgICBpZiAoIXJlbmRlcmVyKQorICAgICAgICBy ZXR1cm47CisgICAgCisgICAgQWNjZXNzaWJpbGl0eU9iamVjdCogYXhPYmplY3QgPSByZW5kZXJl ci0+ZG9jdW1lbnQoKS5heE9iamVjdENhY2hlKCktPmdldE9yQ3JlYXRlKHJlbmRlcmVyKTsKKyAg ICBOU1N0cmluZyAqbGFuZ3VhZ2UgPSBheE9iamVjdC0+bGFuZ3VhZ2UoKTsKKyAgICBpZiAoW2xh bmd1YWdlIGxlbmd0aF0pCisgICAgICAgIFthdHRyU3RyaW5nIGFkZEF0dHJpYnV0ZTpVSUFjY2Vz c2liaWxpdHlUb2tlbkxhbmd1YWdlIHZhbHVlOmxhbmd1YWdlIHJhbmdlOnJhbmdlXTsKKyAgICBl bHNlCisgICAgICAgIFthdHRyU3RyaW5nIHJlbW92ZUF0dHJpYnV0ZTpVSUFjY2Vzc2liaWxpdHlU b2tlbkxhbmd1YWdlIHJhbmdlOnJhbmdlXTsKK30KKwogc3RhdGljIHZvaWQgQVhBdHRyaWJ1dGVT dHJpbmdTZXRCbG9ja3F1b3RlTGV2ZWwoTlNNdXRhYmxlQXR0cmlidXRlZFN0cmluZyogYXR0clN0 cmluZywgUmVuZGVyT2JqZWN0KiByZW5kZXJlciwgTlNSYW5nZSByYW5nZSkKIHsKICAgICBpbnQg cXVvdGVMZXZlbCA9IGJsb2NrcXVvdGVMZXZlbChyZW5kZXJlcik7CkBAIC0xNzUxLDYgKzE3NjUs NyBAQAogICAgIEFYQXR0cmlidXRlU3RyaW5nU2V0U3R5bGUoYXR0clN0cmluZywgbm9kZS0+cmVu ZGVyZXIoKSwgYXR0clN0cmluZ1JhbmdlKTsKICAgICBBWEF0dHJpYnV0ZVN0cmluZ1NldEhlYWRp bmdMZXZlbChhdHRyU3RyaW5nLCBub2RlLT5yZW5kZXJlcigpLCBhdHRyU3RyaW5nUmFuZ2UpOwog ICAgIEFYQXR0cmlidXRlU3RyaW5nU2V0QmxvY2txdW90ZUxldmVsKGF0dHJTdHJpbmcsIG5vZGUt PnJlbmRlcmVyKCksIGF0dHJTdHJpbmdSYW5nZSk7ICAgIAorICAgIEFYQXR0cmlidXRlU3RyaW5n U2V0TGFuZ3VhZ2UoYXR0clN0cmluZywgbm9kZS0+cmVuZGVyZXIoKSwgYXR0clN0cmluZ1Jhbmdl KTsKIH0KIAogCg==