133672 2014-06-09 20:36:34 -0700 [iOS] Wireless route picker control should use touch event handlers 2014-06-09 22:23:35 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson bfulgham calvaris commit-queue glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1014326 0 eric.carlson 2014-06-09 20:36:34 -0700 On iOS, only the wireless route picker <button> uses a 'click' event handler, all others listen for touch events. 1014327 1 eric.carlson 2014-06-09 20:37:00 -0700 <rdar://problem/17244013> 1014328 2 webkit-bug-importer 2014-06-09 20:37:38 -0700 <rdar://problem/17244970> 1014335 3 232766 eric.carlson 2014-06-09 21:30:52 -0700 Created attachment 232766 Proposed patch 1014336 4 232766 bfulgham 2014-06-09 21:47:53 -0700 Comment on attachment 232766 Proposed patch r=me 1014339 5 232766 commit-queue 2014-06-09 22:23:31 -0700 Comment on attachment 232766 Proposed patch Clearing flags on attachment: 232766 Committed r169741: <http://trac.webkit.org/changeset/169741> 1014340 6 commit-queue 2014-06-09 22:23:35 -0700 All reviewed patches have been landed. Closing bug. 232766 2014-06-09 21:30:52 -0700 2014-06-09 22:23:31 -0700 Proposed patch patch_2.txt text/plain 3015 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTY4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA2LTA5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFdpcmVsZXNz IHJvdXRlIHBpY2tlciBjb250cm9sIHNob3VsZCB1c2UgdG91Y2ggZXZlbnQgaGFuZGxlcnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzY3MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9t ZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanM6CisgICAgICAgIChDb250cm9sbGVySU9T LnByb3RvdHlwZS5jcmVhdGVDb250cm9scyk6IExpc3RlbiBmb3IgdG91Y2ggZXZlbnRzLgorICAg ICAgICAoQ29udHJvbGxlcklPUy5wcm90b3R5cGUuaGFuZGxlV2lyZWxlc3NQaWNrZXJCdXR0b25U b3VjaFN0YXJ0KTogTmV3LCBoYW5kbGUgdG91Y2ggc3RhcnQuCisgICAgICAgIChDb250cm9sbGVy SU9TLnByb3RvdHlwZS5oYW5kbGVXaXJlbGVzc1BpY2tlckJ1dHRvblRvdWNoRW5kKTogTmV3LCBo YW5kbGUgdG91Y2ggZW5kLgorICAgICAgICAoQ29udHJvbGxlcklPUy5wcm90b3R5cGUuaGFuZGxl V2lyZWxlc3NQaWNrZXJCdXR0b25Ub3VjaENhbmNlbCk6IE5ldywgaGFuZGxlIHRvdWNoIGNhbmNl bC4KKyAgICAgICAgKENvbnRyb2xsZXJJT1MucHJvdG90eXBlLmhhbmRsZVdpcmVsZXNzUGlja2Vy QnV0dG9uQ2xpY2tlZCk6IERlbGV0ZWQuCisKIDIwMTQtMDYtMDcgIERlYW4gSmFja3NvbiAgPGRp bm9AYXBwbGUuY29tPgogCiAgICAgICAgIFJlZ3Jlc3Npb24gcjE2ODM5NyAtIEZvcm0gbGF5b3V0 IGlzIGluY29ycmVjdCBvbiBPUyBYIFlvc2VtaXRlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcwkocmV2 aXNpb24gMTY5NjgyKQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNpT1MuanMJKHdvcmtpbmcgY29weSkKQEAgLTE0NCw3ICsxNDQsMTAgQEAgQ29u dHJvbGxlcklPUy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciB3aXJlbGVzc1RhcmdldFBpY2tl ciA9IHRoaXMuY29udHJvbHMud2lyZWxlc3NUYXJnZXRQaWNrZXIgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCdidXR0b24nKTsKICAgICAgICAgd2lyZWxlc3NUYXJnZXRQaWNrZXIuc2V0QXR0cmli dXRlKCdwc2V1ZG8nLCAnLXdlYmtpdC1tZWRpYS1jb250cm9scy13aXJlbGVzcy1wbGF5YmFjay1w aWNrZXItYnV0dG9uJyk7CiAgICAgICAgIHdpcmVsZXNzVGFyZ2V0UGlja2VyLnNldEF0dHJpYnV0 ZSgnYXJpYS1sYWJlbCcsIHRoaXMuVUlTdHJpbmcoJ0Nob29zZSBXaXJlbGVzcyBEaXNwbGF5Jykp OwotICAgICAgICB0aGlzLmxpc3RlbkZvcih3aXJlbGVzc1RhcmdldFBpY2tlciwgJ2NsaWNrJywg dGhpcy5oYW5kbGVXaXJlbGVzc1BpY2tlckJ1dHRvbkNsaWNrZWQpOworICAgICAgICB0aGlzLmxp c3RlbkZvcih3aXJlbGVzc1RhcmdldFBpY2tlciwgJ3RvdWNoc3RhcnQnLCB0aGlzLmhhbmRsZVdp cmVsZXNzUGlja2VyQnV0dG9uVG91Y2hTdGFydCk7CisgICAgICAgIHRoaXMubGlzdGVuRm9yKHdp cmVsZXNzVGFyZ2V0UGlja2VyLCAndG91Y2hlbmQnLCB0aGlzLmhhbmRsZVdpcmVsZXNzUGlja2Vy QnV0dG9uVG91Y2hFbmQpOworICAgICAgICB0aGlzLmxpc3RlbkZvcih3aXJlbGVzc1RhcmdldFBp Y2tlciwgJ3RvdWNoY2FuY2VsJywgdGhpcy5oYW5kbGVXaXJlbGVzc1BpY2tlckJ1dHRvblRvdWNo Q2FuY2VsKTsKKwogICAgICAgICBpZiAoIUNvbnRyb2xsZXJJT1MuZ1NpbXVsYXRlV2lyZWxlc3NQ bGF5YmFja1RhcmdldCkKICAgICAgICAgICAgIHdpcmVsZXNzVGFyZ2V0UGlja2VyLmNsYXNzTGlz dC5hZGQodGhpcy5DbGFzc05hbWVzLmhpZGRlbik7CiAKQEAgLTM5MywxMSArMzk2LDIxIEBAIENv bnRyb2xsZXJJT1MucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLnVwZGF0ZVdpcmVsZXNzVGFy Z2V0QXZhaWxhYmxlKCk7CiAgICAgfSwKIAotICAgIGhhbmRsZVdpcmVsZXNzUGlja2VyQnV0dG9u Q2xpY2tlZDogZnVuY3Rpb24oZXZlbnQpIHsKKyAgICBoYW5kbGVXaXJlbGVzc1BpY2tlckJ1dHRv blRvdWNoU3RhcnQ6IGZ1bmN0aW9uKCkgeworICAgICAgICB0aGlzLmNvbnRyb2xzLndpcmVsZXNz VGFyZ2V0UGlja2VyLmNsYXNzTGlzdC5hZGQoJ2FjdGl2ZScpOworICAgIH0sCisKKyAgICBoYW5k bGVXaXJlbGVzc1BpY2tlckJ1dHRvblRvdWNoRW5kOiBmdW5jdGlvbihldmVudCkgeworICAgICAg ICB0aGlzLmNvbnRyb2xzLndpcmVsZXNzVGFyZ2V0UGlja2VyLmNsYXNzTGlzdC5yZW1vdmUoJ2Fj dGl2ZScpOwogICAgICAgICB0aGlzLnZpZGVvLndlYmtpdFNob3dQbGF5YmFja1RhcmdldFBpY2tl cigpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LAogCisgICAgaGFuZGxlV2lyZWxlc3NQ aWNrZXJCdXR0b25Ub3VjaENhbmNlbDogZnVuY3Rpb24oZXZlbnQpIHsKKyAgICAgICAgdGhpcy5j b250cm9scy53aXJlbGVzc1RhcmdldFBpY2tlci5jbGFzc0xpc3QucmVtb3ZlKCdhY3RpdmUnKTsK KyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfSwKKwogICAgIGdldCBwYWdlU2NhbGVGYWN0b3Io KSB7CiAgICAgICAgIHJldHVybiB0aGlzLl9wYWdlU2NhbGVGYWN0b3I7CiAgICAgfSwK