133666 2014-06-09 16:47:31 -0700 AX: WK2: iOS: text editing does not work 2014-06-10 10:19:49 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 1014282 0 cfleizach 2014-06-09 16:47:31 -0700 The right accessibility hooks are not implemented to handle text editing on a WK2 only world <rdar://problem/17127741> 1014283 1 232748 cfleizach 2014-06-09 16:53:19 -0700 Created attachment 232748 patch 1014423 2 232748 mario 2014-06-10 10:17:21 -0700 Comment on attachment 232748 patch View in context: https://bugs.webkit.org/attachment.cgi?id=232748&action=review > Source/WebCore/ChangeLog:3 > + AX: WK2: iOS: text editing does not work with with what? :) 1014424 3 cfleizach 2014-06-10 10:18:04 -0700 (In reply to comment #2) > (From update of attachment 232748 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232748&action=review > > > Source/WebCore/ChangeLog:3 > > + AX: WK2: iOS: text editing does not work with > > with what? :) Doh! will fix. thanks 1014425 4 cfleizach 2014-06-10 10:19:49 -0700 http://trac.webkit.org/changeset/169747 232748 2014-06-09 16:53:19 -0700 2014-06-10 10:17:13 -0700 patch patch text/plain 3982 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTczMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA2LTA5ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFdLMjogaU9TOiB0 ZXh0IGVkaXRpbmcgZG9lcyBub3Qgd29yayB3aXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM2NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbiBXSzIsIGFsbCB0aGUgdGV4dCBlZGl0aW5nIGlzIGhh bmRsZWQgYnkgdGhlIFdlYlByb2Nlc3MsIHNvIHNlbGVjdGVkVGV4dFJhbmdlIGFuZCBzZXRTZWxl Y3RlZFRleHRSYW5nZQorICAgICAgICBuZWVkIHRvIGJlIGltcGxlbWVudGVkLCBhcyB3ZWxsIGFz IHBvc3RpbmcgdGhlIHJpZ2h0IHZhbHVlIGNoYW5nZSBub3RpZmljYXRpb24uCisKKyAgICAgICAg KiBhY2Nlc3NpYmlsaXR5L2lvcy9BWE9iamVjdENhY2hlSU9TLm1tOgorICAgICAgICAoV2ViQ29y ZTo6QVhPYmplY3RDYWNoZTo6cG9zdFBsYXRmb3JtTm90aWZpY2F0aW9uKToKKyAgICAgICAgKiBh Y2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5oOgorICAg ICAgICAqIGFjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVySU9T Lm1tOgorICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBwb3N0VmFsdWVD aGFuZ2VkTm90aWZpY2F0aW9uXSk6CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RX cmFwcGVyIF9hY2Nlc3NpYmlsaXR5U2VsZWN0ZWRUZXh0UmFuZ2VdKToKKyAgICAgICAgKC1bV2Vi QWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgX2FjY2Vzc2liaWxpdHlTZXRTZWxlY3RlZFRleHRS YW5nZTpdKToKKwogMjAxNC0wNi0wOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIFtpT1MgV2ViR0xdIEZpeCBFWFRfc2hhZGVyX3RleHR1cmVf bG9kLgpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pb3MvQVhPYmplY3RDYWNo ZUlPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lvcy9B WE9iamVjdENhY2hlSU9TLm1tCShyZXZpc2lvbiAxNjk2OTEpCisrKyBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2lvcy9BWE9iamVjdENhY2hlSU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC04 Miw4ICs4MiwxMCBAQAogICAgICAgICBjYXNlIEFYSW52YWxpZFN0YXR1c0NoYW5nZWQ6CiAgICAg ICAgICAgICBbb2JqLT53cmFwcGVyKCkgcG9zdEludmFsaWRTdGF0dXNDaGFuZ2VkTm90aWZpY2F0 aW9uXTsKICAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIEFYVmFsdWVDaGFuZ2VkOgor ICAgICAgICAgICAgW29iai0+d3JhcHBlcigpIHBvc3RWYWx1ZUNoYW5nZWROb3RpZmljYXRpb25d OworICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQVhTZWxlY3RlZENoaWxkcmVuQ2hh bmdlZDoKLSAgICAgICAgY2FzZSBBWFZhbHVlQ2hhbmdlZDoKICAgICAgICAgY2FzZSBBWENoZWNr ZWRTdGF0ZUNoYW5nZWQ6CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICBicmVhazsKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxpdHlPYmpl Y3RXcmFwcGVySU9TLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJJT1MuaAkocmV2aXNpb24gMTY5Njkx KQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXJJT1MuaAkod29ya2luZyBjb3B5KQpAQCAtNjIsNiArNjIsNyBAQAogLSAodm9p ZClwb3N0SW52YWxpZFN0YXR1c0NoYW5nZWROb3RpZmljYXRpb247CiAtICh2b2lkKXBvc3RMaXZl UmVnaW9uQ3JlYXRlZE5vdGlmaWNhdGlvbjsKIC0gKHZvaWQpcG9zdFNjcm9sbFN0YXR1c0NoYW5n ZU5vdGlmaWNhdGlvbjsKKy0gKHZvaWQpcG9zdFZhbHVlQ2hhbmdlZE5vdGlmaWNhdGlvbjsKIAog QGVuZAogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3Np YmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbQkocmV2 aXNpb24gMTY5NjkxKQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pb3MvV2ViQWNj ZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTE0NzksNiAr MTQ3OSwxMSBAQAogICAgIC8vIFRoZSBVSUtpdCBhY2Nlc3NpYmlsaXR5IHdyYXBwZXIgd2lsbCBv dmVycmlkZSBhbmQgcG9zdCBhcHByb3ByaWF0ZSBub3RpZmljYXRpb24uICAgICAgICAKIH0KIAor LSAodm9pZClwb3N0VmFsdWVDaGFuZ2VkTm90aWZpY2F0aW9uCit7CisgICAgLy8gVGhlIFVJS2l0 IGFjY2Vzc2liaWxpdHkgd3JhcHBlciB3aWxsIG92ZXJyaWRlIGFuZCBwb3N0IGFwcHJvcHJpYXRl IG5vdGlmaWNhdGlvbi4KK30KKwogLSAodm9pZClwb3N0U2Nyb2xsU3RhdHVzQ2hhbmdlTm90aWZp Y2F0aW9uCiB7CiAgICAgLy8gVGhlIFVJS2l0IGFjY2Vzc2liaWxpdHkgd3JhcHBlciB3aWxsIG92 ZXJyaWRlIGFuZCBwb3N0IGFwcHJvcHJpYXRlIG5vdGlmaWNhdGlvbi4KQEAgLTIwMzAsNiArMjAz NSwyNSBAQAogICAgIHJldHVybiBbc2VsZiBfc3RyaW5nRm9yUmFuZ2U6cmFuZ2UgYXR0cmlidXRl ZDpZRVNdOwogfQogCistIChOU1JhbmdlKV9hY2Nlc3NpYmlsaXR5U2VsZWN0ZWRUZXh0UmFuZ2UK K3sKKyAgICBpZiAoIVtzZWxmIF9wcmVwYXJlQWNjZXNzaWJpbGl0eUNhbGxdIHx8ICFtX29iamVj dC0+aXNUZXh0Q29udHJvbCgpKQorICAgICAgICByZXR1cm4gTlNNYWtlUmFuZ2UoTlNOb3RGb3Vu ZCwgMCk7CisgICAgCisgICAgUGxhaW5UZXh0UmFuZ2UgdGV4dFJhbmdlID0gbV9vYmplY3QtPnNl bGVjdGVkVGV4dFJhbmdlKCk7CisgICAgaWYgKHRleHRSYW5nZS5pc051bGwoKSkKKyAgICAgICAg cmV0dXJuIE5TTWFrZVJhbmdlKE5TTm90Rm91bmQsIDApOworICAgIHJldHVybiBOU01ha2VSYW5n ZSh0ZXh0UmFuZ2Uuc3RhcnQsIHRleHRSYW5nZS5sZW5ndGgpOyAgICAKK30KKworLSAodm9pZClf YWNjZXNzaWJpbGl0eVNldFNlbGVjdGVkVGV4dFJhbmdlOihOU1JhbmdlKXJhbmdlCit7CisgICAg aWYgKCFbc2VsZiBfcHJlcGFyZUFjY2Vzc2liaWxpdHlDYWxsXSB8fCAhbV9vYmplY3QtPmlzVGV4 dENvbnRyb2woKSkKKyAgICAgICAgcmV0dXJuOworICAgIAorICAgIG1fb2JqZWN0LT5zZXRTZWxl Y3RlZFRleHRSYW5nZShQbGFpblRleHRSYW5nZShyYW5nZS5sb2NhdGlvbiwgcmFuZ2UubGVuZ3Ro KSk7Cit9CisKIC8vIEEgY29udmVuaWVuY2UgbWV0aG9kIGZvciBnZXR0aW5nIHRoZSBhY2Nlc3Np YmlsaXR5IG9iamVjdHMgb2YgYSBOU1JhbmdlLiBDdXJyZW50bHkgdXNlZCBvbmx5IGJ5IERSVC4K IC0gKE5TQXJyYXkgKillbGVtZW50c0ZvclJhbmdlOihOU1JhbmdlKXJhbmdlCiB7Cg==