133659 2014-06-09 15:06:17 -0700 iOS WebKit: Crash in charactersAroundPosition 2014-06-09 16:20:51 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica commit-queue oldest_to_newest 1014243 0 enrica 2014-06-09 15:06:17 -0700 This is a crash introduced with http://trac.webkit.org/changeset/169500. When we compute the editor state information we don't need to compute the charactersAroundPosition if we are not in editable content. <rdar://problem/17220870> 1014245 1 232737 enrica 2014-06-09 15:15:26 -0700 Created attachment 232737 Patch 1014247 2 commit-queue 2014-06-09 15:16:32 -0700 Attachment 232737 did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:718: Missing space before ( in if( [whitespace/parens] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1014248 3 enrica 2014-06-09 15:19:14 -0700 I've already fixed the style issue. 1014249 4 232737 benjamin 2014-06-09 15:21:39 -0700 Comment on attachment 232737 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232737&action=review > Source/WebCore/editing/VisibleUnits.cpp:1843 > + if (index >= maxCharacters) > + break; Shouldn't this be after "characters[index++] = characterString[i];". You may want to change the for() loop into a while loop. Having a for() loop that breaks into the flow tends to add complexity. 1014270 5 enrica 2014-06-09 16:20:51 -0700 Committed revision 169728. 232737 2014-06-09 15:15:26 -0700 2014-06-09 15:21:38 -0700 Patch crashcharactersaroundposition.txt text/plain 4018 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTcxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA2LTA5ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgaU9TIFdlYktpdDogQ3Jhc2gg aW4gY2hhcmFjdGVyc0Fyb3VuZFBvc2l0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzNjU5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzIy MDg3MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF bnN1cmUgdGhhdCB3ZSBzdGF5IHdpdGhpbiB0aGUgdmVjdG9yIGJvdW5kYXJpZXMKKyAgICAgICAg d2hlbiByZXR1cm5pbmcgdGhlIGNoYXJhY3RlcnMgYXJvdW5kIHRoZSBwb3NpdGlvbi4KKworICAg ICAgICAqIGVkaXRpbmcvVmlzaWJsZVVuaXRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNoYXJh Y3RlcnNBcm91bmRQb3NpdGlvbik6CisKIDIwMTQtMDYtMDkgIEplciBOb2JsZSAgPGplci5ub2Js ZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY11bTVNFXSBFeGNlcHRpb24gdGhyb3duIGZyb20g fk1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQygpLgpJbmRleDogU291cmNlL1dl YkNvcmUvZWRpdGluZy9WaXNpYmxlVW5pdHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2VkaXRpbmcvVmlzaWJsZVVuaXRzLmNwcAkocmV2aXNpb24gMTY5NjYyKQorKysgU291cmNl L1dlYkNvcmUvZWRpdGluZy9WaXNpYmxlVW5pdHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODE1 LDcgKzE4MTUsOCBAQCBpbnQgZGlzdGFuY2VCZXR3ZWVuUG9zaXRpb25zKGNvbnN0IFZpc2liCiAK IHZvaWQgY2hhcmFjdGVyc0Fyb3VuZFBvc2l0aW9uKGNvbnN0IFZpc2libGVQb3NpdGlvbiYgcG9z aXRpb24sIFVDaGFyMzImIG9uZUFmdGVyLCBVQ2hhcjMyJiBvbmVCZWZvcmUsIFVDaGFyMzImIHR3 b0JlZm9yZSkKIHsKLSAgICBWZWN0b3I8VUNoYXIzMj4gY2hhcmFjdGVycygzKTsKKyAgICBjb25z dCBpbnQgbWF4Q2hhcmFjdGVycyA9IDM7CisgICAgVmVjdG9yPFVDaGFyMzI+IGNoYXJhY3RlcnMo bWF4Q2hhcmFjdGVycyk7CiAKICAgICBpZiAocG9zaXRpb24uaXNOdWxsKCkgfHwgaXNTdGFydE9m RG9jdW1lbnQocG9zaXRpb24pKQogICAgICAgICByZXR1cm47CkBAIC0xODM4LDYgKzE4MzksOCBA QCB2b2lkIGNoYXJhY3RlcnNBcm91bmRQb3NpdGlvbihjb25zdCBWaXNpCiAgICAgaWYgKHN0YXJ0 UG9zaXRpb24gIT0gZW5kUG9zaXRpb24pIHsKICAgICAgICAgU3RyaW5nIGNoYXJhY3RlclN0cmlu ZyA9IHBsYWluVGV4dChSYW5nZTo6Y3JlYXRlKHBvc2l0aW9uLmRlZXBFcXVpdmFsZW50KCkuYW5j aG9yTm9kZSgpLT5kb2N1bWVudCgpLCBzdGFydFBvc2l0aW9uLCBlbmRQb3NpdGlvbikuZ2V0KCkp LnJlcGxhY2Uobm9CcmVha1NwYWNlLCAnICcpOwogICAgICAgICBmb3IgKGludCBpID0gY2hhcmFj dGVyU3RyaW5nLmxlbmd0aCgpIC0gMSwgaW5kZXggPSAwOyBpID49IDA7IC0taSkgeworICAgICAg ICAgICAgaWYgKGluZGV4ID49IG1heENoYXJhY3RlcnMpCisgICAgICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgICAgICBpZiAoIWluZGV4ICYmIG5leHRQb3NpdGlvbi5pc051bGwoKSkKICAgICAg ICAgICAgICAgICBpbmRleCsrOwogICAgICAgICAgICAgY2hhcmFjdGVyc1tpbmRleCsrXSA9IGNo YXJhY3RlclN0cmluZ1tpXTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTcxOCkKKysrIFNv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisy MDE0LTA2LTA5ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAg aU9TIFdlYktpdDogQ3Jhc2ggaW4gY2hhcmFjdGVyc0Fyb3VuZFBvc2l0aW9uLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzNjU5CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xNzIyMDg3MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXZSBvbmx5IG5lZWQgdG8gY29tcHV0ZSBjaGFyYWN0ZXJzQXJvdW5k UG9zaXRpb24gd2hlbiB3ZSBhcmUgaW4KKyAgICAgICAgZWRpdGFibGUgY29udGVudC4KKworICAg ICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViUGFnZTo6ZWRpdG9yU3RhdGUpOgorCiAyMDE0LTA2LTA5ICBEYW5pZWwgQmF0ZXMgIDxkYWJh dGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBBdHRlbXB0IHRvIGZpeCB0aGUgRUZMIGFuZCBHVEsg YnVpbGRzIGFmdGVyIDxodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNjk3MTE+Cklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCShy ZXZpc2lvbiAxNjk2NjIpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcxNSw3ICs3MTUsOCBAQCBFZGl0b3JTdGF0ZSBX ZWJQYWdlOjplZGl0b3JTdGF0ZSgpIGNvbnN0CiAgICAgICAgIC8vIEZJWE1FOiBUaGUgZm9sbG93 aW5nIGNoZWNrIHNob3VsZCB0YWtlIGludG8gYWNjb3VudCB3cml0aW5nIGRpcmVjdGlvbi4KICAg ICAgICAgcmVzdWx0LmlzUmVwbGFjZUFsbG93ZWQgPSByZXN1bHQuaXNDb250ZW50RWRpdGFibGUg JiYgYXRCb3VuZGFyeU9mR3JhbnVsYXJpdHkoc2VsZWN0aW9uLnN0YXJ0KCksIFdvcmRHcmFudWxh cml0eSwgRGlyZWN0aW9uRm9yd2FyZCk7CiAgICAgICAgIHJlc3VsdC53b3JkQXRTZWxlY3Rpb24g PSBwbGFpblRleHRSZXBsYWNpbmdOb0JyZWFrU3BhY2Uod29yZFJhbmdlRnJvbVBvc2l0aW9uKHNl bGVjdGlvbi5zdGFydCgpKS5nZXQoKSk7Ci0gICAgICAgIGNoYXJhY3RlcnNBcm91bmRQb3NpdGlv bihzZWxlY3Rpb24uc3RhcnQoKSwgcmVzdWx0LmNoYXJhY3RlckFmdGVyU2VsZWN0aW9uLCByZXN1 bHQuY2hhcmFjdGVyQmVmb3JlU2VsZWN0aW9uLCByZXN1bHQudHdvQ2hhcmFjdGVyQmVmb3JlU2Vs ZWN0aW9uKTsKKyAgICAgICAgaWYoc2VsZWN0aW9uLmlzQ29udGVudEVkaXRhYmxlKCkpCisgICAg ICAgICAgICBjaGFyYWN0ZXJzQXJvdW5kUG9zaXRpb24oc2VsZWN0aW9uLnN0YXJ0KCksIHJlc3Vs dC5jaGFyYWN0ZXJBZnRlclNlbGVjdGlvbiwgcmVzdWx0LmNoYXJhY3RlckJlZm9yZVNlbGVjdGlv biwgcmVzdWx0LnR3b0NoYXJhY3RlckJlZm9yZVNlbGVjdGlvbik7CiAgICAgfSBlbHNlIGlmIChz ZWxlY3Rpb24uaXNSYW5nZSgpKSB7CiAgICAgICAgIHJlc3VsdC5jYXJldFJlY3RBdFN0YXJ0ID0g dmlldy0+Y29udGVudHNUb1Jvb3RWaWV3KFZpc2libGVQb3NpdGlvbihzZWxlY3Rpb24uc3RhcnQo KSkuYWJzb2x1dGVDYXJldEJvdW5kcygpKTsKICAgICAgICAgcmVzdWx0LmNhcmV0UmVjdEF0RW5k ID0gdmlldy0+Y29udGVudHNUb1Jvb3RWaWV3KFZpc2libGVQb3NpdGlvbihzZWxlY3Rpb24uZW5k KCkpLmFic29sdXRlQ2FyZXRCb3VuZHMoKSk7Cg==