133658 2014-06-09 14:56:12 -0700 Flash video controls hit-test incorrectly after changing topContentInset 2014-06-09 15:31:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin webkit-unassigned andersca bdakin sam thorton oldest_to_newest 1014238 0 bdakin 2014-06-09 14:56:12 -0700 Flash video controls hit-test incorrectly after changing topContentInset <rdar://problem/16978590> 1014240 1 232735 bdakin 2014-06-09 15:01:09 -0700 Created attachment 232735 Patch 1014241 2 232735 andersca 2014-06-09 15:02:25 -0700 Comment on attachment 232735 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232735&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2109 > + if (insetDidChange) { Can use an early return here instead. 1014242 3 232736 bdakin 2014-06-09 15:05:25 -0700 Created attachment 232736 Patch 1014253 4 bdakin 2014-06-09 15:31:44 -0700 Thanks Anders! http://trac.webkit.org/changeset/169724 232735 2014-06-09 15:01:09 -0700 2014-06-09 15:05:25 -0700 Patch for-review.txt text/plain 2901 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTcyMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA2LTA5ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBGbGFzaCB2aWRlbyBjb250cm9scyBo aXQtdGVzdCBpbmNvcnJlY3RseSBhZnRlciBjaGFuZ2luZyB0b3BDb250ZW50SW5zZXQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzY1OAorICAgICAg ICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjk3ODU5MD4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHRo ZSB0b3BDb250ZW50IGNoYW5nZXMsIHRoZSBQbHVnaW5WaWV3IG5lZWRzIHRvIGJlIGluZm9ybWVk LgorCisgICAgICAgIE5ldyBmdW5jdGlvbiBQbHVnaW5WaWV3Ojp0b3BDb250ZW50SW5zZXREaWRD aGFuZ2UoKSBjYWxscyB2aWV3R2VvbWV0cnlEaWRDaGFuZ2UoKS4KKyAgICAgICAgKiBXZWJQcm9j ZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6 OnRvcENvbnRlbnRJbnNldERpZENoYW5nZSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5z L1BsdWdpblZpZXcuaDoKKworICAgICAgICBDYWxsIHRvcENvbnRlbnRJbnNldERpZENoYW5nZSgp IGFmdGVyIHNldHRpbmcgYW4gaW5zZXQgb25seSBpZiBpdCBpcyBhIG5ldyBpbnNldC4KKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2U6OnNldFRvcENvbnRlbnRJbnNldCk6CisKIDIwMTQtMDYtMDkgIERhbmllbCBCYXRlcyAg PGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEFub3RoZXIgYXR0ZW1wdCB0byBmaXggdGhl IEVGTCBhbmQgR1RLIGJ1aWxkcyBhZnRlciA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2Vz ZXQvMTY5NzExPgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdp blZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lu cy9QbHVnaW5WaWV3LmNwcAkocmV2aXNpb24gMTY5NjkzKQorKysgU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzAsNiAr NDcwLDExIEBAIHZvaWQgUGx1Z2luVmlldzo6cGFnZVNjYWxlRmFjdG9yRGlkQ2hhbmcKICAgICB2 aWV3R2VvbWV0cnlEaWRDaGFuZ2UoKTsKIH0KIAordm9pZCBQbHVnaW5WaWV3Ojp0b3BDb250ZW50 SW5zZXREaWRDaGFuZ2UoKQoreworICAgIHZpZXdHZW9tZXRyeURpZENoYW5nZSgpOworfQorCiB2 b2lkIFBsdWdpblZpZXc6OnNldFBhZ2VTY2FsZUZhY3Rvcihkb3VibGUgc2NhbGVGYWN0b3IsIElu dFBvaW50KQogewogICAgIG1fcGFnZVNjYWxlRmFjdG9yID0gc2NhbGVGYWN0b3I7CkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmgJKHJldmlz aW9uIDE2OTY5MykKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5W aWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTk0LDYgKzk0LDggQEAgcHVibGljOgogICAgIGJvb2wg aGFuZGxlc1BhZ2VTY2FsZUZhY3RvcigpIGNvbnN0OwogCiAgICAgdm9pZCBwYWdlU2NhbGVGYWN0 b3JEaWRDaGFuZ2UoKTsKKyAgICB2b2lkIHRvcENvbnRlbnRJbnNldERpZENoYW5nZSgpOworCiAg ICAgdm9pZCB3ZWJQYWdlRGVzdHJveWVkKCk7CiAKICAgICBib29sIGhhbmRsZUVkaXRpbmdDb21t YW5kKGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUsIGNvbnN0IFN0cmluZyYgYXJndW1lbnQpOwpJ bmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAko cmV2aXNpb24gMTY5NjkzKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTAyLDcgKzIxMDIsMTQgQEAgdm9pZCBXZWJQ YWdlOjpzZXREcmF3c1RyYW5zcGFyZW50QmFja2dybwogCiB2b2lkIFdlYlBhZ2U6OnNldFRvcENv bnRlbnRJbnNldChmbG9hdCBjb250ZW50SW5zZXQpCiB7CisgICAgYm9vbCBpbnNldERpZENoYW5n ZSA9IGNvbnRlbnRJbnNldCAhPSBtX3BhZ2UtPnRvcENvbnRlbnRJbnNldCgpOworCiAgICAgbV9w YWdlLT5zZXRUb3BDb250ZW50SW5zZXQoY29udGVudEluc2V0KTsKKworICAgIGlmIChpbnNldERp ZENoYW5nZSkgeworICAgICAgICBmb3IgKGF1dG8qIHBsdWdpblZpZXcgOiBtX3BsdWdpblZpZXdz KQorICAgICAgICAgICAgcGx1Z2luVmlldy0+dG9wQ29udGVudEluc2V0RGlkQ2hhbmdlKCk7Cisg ICAgfQogfQogCiB2b2lkIFdlYlBhZ2U6OnZpZXdXaWxsU3RhcnRMaXZlUmVzaXplKCkK 232736 2014-06-09 15:05:25 -0700 2014-06-09 15:06:16 -0700 Patch for-review-2.txt text/plain 2858 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTcyMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA2LTA5ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBGbGFzaCB2aWRlbyBjb250cm9scyBo aXQtdGVzdCBpbmNvcnJlY3RseSBhZnRlciBjaGFuZ2luZyB0b3BDb250ZW50SW5zZXQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzY1OAorICAgICAg ICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjk3ODU5MD4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHRo ZSB0b3BDb250ZW50IGNoYW5nZXMsIHRoZSBQbHVnaW5WaWV3IG5lZWRzIHRvIGJlIGluZm9ybWVk LgorCisgICAgICAgIE5ldyBmdW5jdGlvbiBQbHVnaW5WaWV3Ojp0b3BDb250ZW50SW5zZXREaWRD aGFuZ2UoKSBjYWxscyB2aWV3R2VvbWV0cnlEaWRDaGFuZ2UoKS4KKyAgICAgICAgKiBXZWJQcm9j ZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6 OnRvcENvbnRlbnRJbnNldERpZENoYW5nZSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5z L1BsdWdpblZpZXcuaDoKKworICAgICAgICBDYWxsIHRvcENvbnRlbnRJbnNldERpZENoYW5nZSgp IGFmdGVyIHNldHRpbmcgYW4gaW5zZXQgb25seSBpZiBpdCBpcyBhIG5ldyBpbnNldC4KKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2U6OnNldFRvcENvbnRlbnRJbnNldCk6CisKIDIwMTQtMDYtMDkgIERhbmllbCBCYXRlcyAg PGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEFub3RoZXIgYXR0ZW1wdCB0byBmaXggdGhl IEVGTCBhbmQgR1RLIGJ1aWxkcyBhZnRlciA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2Vz ZXQvMTY5NzExPgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdp blZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lu cy9QbHVnaW5WaWV3LmNwcAkocmV2aXNpb24gMTY5NjkzKQorKysgU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzAsNiAr NDcwLDExIEBAIHZvaWQgUGx1Z2luVmlldzo6cGFnZVNjYWxlRmFjdG9yRGlkQ2hhbmcKICAgICB2 aWV3R2VvbWV0cnlEaWRDaGFuZ2UoKTsKIH0KIAordm9pZCBQbHVnaW5WaWV3Ojp0b3BDb250ZW50 SW5zZXREaWRDaGFuZ2UoKQoreworICAgIHZpZXdHZW9tZXRyeURpZENoYW5nZSgpOworfQorCiB2 b2lkIFBsdWdpblZpZXc6OnNldFBhZ2VTY2FsZUZhY3Rvcihkb3VibGUgc2NhbGVGYWN0b3IsIElu dFBvaW50KQogewogICAgIG1fcGFnZVNjYWxlRmFjdG9yID0gc2NhbGVGYWN0b3I7CkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmgJKHJldmlz aW9uIDE2OTY5MykKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5W aWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTk0LDYgKzk0LDggQEAgcHVibGljOgogICAgIGJvb2wg aGFuZGxlc1BhZ2VTY2FsZUZhY3RvcigpIGNvbnN0OwogCiAgICAgdm9pZCBwYWdlU2NhbGVGYWN0 b3JEaWRDaGFuZ2UoKTsKKyAgICB2b2lkIHRvcENvbnRlbnRJbnNldERpZENoYW5nZSgpOworCiAg ICAgdm9pZCB3ZWJQYWdlRGVzdHJveWVkKCk7CiAKICAgICBib29sIGhhbmRsZUVkaXRpbmdDb21t YW5kKGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUsIGNvbnN0IFN0cmluZyYgYXJndW1lbnQpOwpJ bmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAko cmV2aXNpb24gMTY5NjkzKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTAyLDcgKzIxMDIsMTMgQEAgdm9pZCBXZWJQ YWdlOjpzZXREcmF3c1RyYW5zcGFyZW50QmFja2dybwogCiB2b2lkIFdlYlBhZ2U6OnNldFRvcENv bnRlbnRJbnNldChmbG9hdCBjb250ZW50SW5zZXQpCiB7CisgICAgaWYgKGNvbnRlbnRJbnNldCA9 PSBtX3BhZ2UtPnRvcENvbnRlbnRJbnNldCgpKQorICAgICAgICByZXR1cm47CisKICAgICBtX3Bh Z2UtPnNldFRvcENvbnRlbnRJbnNldChjb250ZW50SW5zZXQpOworCisgICAgZm9yIChhdXRvKiBw bHVnaW5WaWV3IDogbV9wbHVnaW5WaWV3cykKKyAgICAgICAgcGx1Z2luVmlldy0+dG9wQ29udGVu dEluc2V0RGlkQ2hhbmdlKCk7CiB9CiAKIHZvaWQgV2ViUGFnZTo6dmlld1dpbGxTdGFydExpdmVS ZXNpemUoKQo=