13364 2007-04-16 10:56:18 -0700 REGRESSION: frame base URL is incorrect (some pages are not found) 2007-07-21 00:13:41 -0700 1 1 1 Unclassified WebKit Frames 523.x (Safari 3) Mac (Intel) OS X 10.4 RESOLVED FIXED http://www.peaceandlove.nu InRadar, Regression P1 Normal --- 1 william.bjorklund webkit-unassigned ap oldest_to_newest 14586 0 william.bjorklund 2007-04-16 10:56:18 -0700 Some linked pages return "not found" errors, though they are loaded without problem in other browsers. For example, the "English" button in the top right corner returns a 404 in Webkit but not in Firefox. Clicking on "Artister" in the menu and then on any artist name in the left column also returns a 404. 14519 1 ap 2007-04-16 11:54:38 -0700 URL in TOT WebKit: http://www.peaceandlove.nu/index.php?page=english Correct URL: http://www.peaceandlove.nu/2007/index.php?page=english Looks like this is caused by an incorrect calculation of frame base URL: <FRAME SRC="2007/index.php" NAME="contents" NORESIZE FRAMEBORDER="no"> 14522 2 ap 2007-04-16 11:57:13 -0700 *** Bug 13362 has been marked as a duplicate of this bug. *** 14551 3 beidson 2007-04-16 18:29:34 -0700 Turns out this bug is not related to 13362. I regressed that bug to between 16068 and 16085. Turns out this one works fine on 16085 but I can confirm its broken in current ToT. I'm going to regress this one, and reopen 16085. 14552 4 beidson 2007-04-16 19:24:54 -0700 Nevermind, I lied, I got confused with my multiple copies of webkit lying around. I think the original diagnosis was correct 14553 5 beidson 2007-04-16 19:38:24 -0700 I'd wager real money this was caused by http://trac.webkit.org/projects/webkit/changeset/16081 13284 6 14135 ap 2007-04-22 05:53:36 -0700 Created attachment 14135 reduced test case 13190 7 darin 2007-04-23 08:38:33 -0700 <rdar://problem/5153021> 4163 8 15609 beidson 2007-07-20 15:23:53 -0700 Created attachment 15609 Proposed fix - don't overwrite the (base)url if it's non-empty 4164 9 15609 darin 2007-07-20 15:34:49 -0700 Comment on attachment 15609 Proposed fix - don't overwrite the (base)url if it's non-empty Nonexistent has an "e" in it, not an "a". + (WebCore::Document::open): Only set the url and baseURL in document.open if the are still empty or about:blank "they are" r=me 4142 10 ap 2007-07-21 00:13:41 -0700 Landed by Brady in r24491. 14135 2007-04-22 05:53:36 -0700 2007-04-22 05:53:36 -0700 reduced test case 13364.zip application/zip 2042 ap UEsDBBQACAAIALiEljYAAAAAAAAAAAAAAAATABAAZnJhbWUtYmFzZS11cmwuaHRtbFVYDABSVytG HFcrRvUB9QGzyUwrSsxNVSguSrZVKkotzi8tSk4t1i8uTQKL6yYlFqfqlhbl6GWU5OYoKYAFk/KL UlKLbA3suABQSwcI4g5rlzkAAAA+AAAAUEsDBAoAAAAAANWEljYAAAAAAAAAAAAAAAAJABAAX19N QUNPU1gvVVgMAFJXK0ZSVytG9QH1AVBLAwQUAAgACAC4hJY2AAAAAAAAAAAAAAAAHgAQAF9fTUFD T1NYLy5fZnJhbWUtYmFzZS11cmwuaHRtbFVYDABSVytGHFcrRvUB9QFjYBVjZ2BiwAQgMU4gNgJi BSg/CCQR4hoRohiUnIFFDxgAAFBLBwhG2fANIwAAAFIAAABQSwMECgAAAAAA+4OWNgAAAAAAAAAA AAAAAAoAEAByZXNvdXJjZXMvVVgMAOpMK0a6VStG9QH1AVBLAwQUAAgACAD7g5Y2AAAAAAAAAAAA AAAAEwAQAHJlc291cmNlcy8uRFNfU3RvcmVVWAwAUlcrRrpVK0b1AfUB7ZixTsMwFEXvCxkisXhC jO4HgMQfWFUZmNmYaKAVQ1AlIHs2Phts3hUKSiuVqYjeIz2dyM6zncX2CwCb949XQADQwI13bKVh TKho88hjvGCJZ6xwgXb7WBNK7hle0eeM9Y/8ZW4tT31u7XCJJ7zlvu6m2zy03ablou9yzD6+2HNG IYQQ4rgxV3N62GUIIf4gZX+IdKIHt7G/outRTqAjnejBbXyvomu6oQMd6UQPbm5axuLDOLOxQrFA Rzr96pOFOBpOXKGc/9fYWf8LIf4xVi9uF3N8FwQTylkbc9yPk3ZcAir/WXg+ei/SiR7cuggIcSg+ AVBLBwhX/35h9AAAAAQYAABQSwMECgAAAAAA1YSWNgAAAAAAAAAAAAAAABMAEABfX01BQ09TWC9y ZXNvdXJjZXMvVVgMAFJXK0ZSVytG9QH1AVBLAwQUAAgACAD7g5Y2AAAAAAAAAAAAAAAAHgAQAF9f TUFDT1NYL3Jlc291cmNlcy8uXy5EU19TdG9yZVVYDABSVytGulUrRvUB9QFjYBVjZ2BiwAQgMU4g NgJiBSg/CFmBAxZNIAAAUEsHCA2OI3ccAAAAUgAAAFBLAwQUAAgACACVhJY2AAAAAAAAAAAAAAAA IAAQAHJlc291cmNlcy9zdWJmcmFtZS1iYXNlLXVybC5odG1sVVgMAFJXK0baVitG9QH1AU2PPw+C MBDF934K0ji0S+tuJVECiYlxEJnEoZTjT1IoacvAt5fGqNz08n65d+9EZeolRkJGnYXmiBtjKmlZ 5weNY8Hlipyy/eRjVBs1DzB6ZiYYCT38DaWNg+CgvokIL7kFZ2arwJV8E7jjzIPz5LfXgk81BOnO y0O2NzkAwRLT5/7FQh9KUbSO1GA9wXmRJGme4/UQaAdblJ0u1+KeBiT4t7Dgn+feUEsHCPT8PlOn AAAA5AAAAFBLAwQUAAgACACVhJY2AAAAAAAAAAAAAAAAKwAQAF9fTUFDT1NYL3Jlc291cmNlcy8u X3N1YmZyYW1lLWJhc2UtdXJsLmh0bWxVWAwAUlcrRtpWK0b1AfUBY2AVY2dgYsAEIDFOIDYCYgUo PwgkEeIaEaIYlJyBRQ8YAABQSwcIRtnwDSMAAABSAAAAUEsBAhUDFAAIAAgAuISWNuIOa5c5AAAA PgAAABMADAAAAAAAAAAAQKSBAAAAAGZyYW1lLWJhc2UtdXJsLmh0bWxVWAgAUlcrRhxXK0ZQSwEC FQMKAAAAAADVhJY2AAAAAAAAAAAAAAAACQAMAAAAAAAAAABA/UGKAAAAX19NQUNPU1gvVVgIAFJX K0ZSVytGUEsBAhUDFAAIAAgAuISWNkbZ8A0jAAAAUgAAAB4ADAAAAAAAAAAAQKSBwQAAAF9fTUFD T1NYLy5fZnJhbWUtYmFzZS11cmwuaHRtbFVYCABSVytGHFcrRlBLAQIVAwoAAAAAAPuDljYAAAAA AAAAAAAAAAAKAAwAAAAAAAAAAEDtQUABAAByZXNvdXJjZXMvVVgIAOpMK0a6VStGUEsBAhUDFAAI AAgA+4OWNlf/fmH0AAAABBgAABMADAAAAAAAAAAAQKSBeAEAAHJlc291cmNlcy8uRFNfU3RvcmVV WAgAUlcrRrpVK0ZQSwECFQMKAAAAAADVhJY2AAAAAAAAAAAAAAAAEwAMAAAAAAAAAABA/UG9AgAA X19NQUNPU1gvcmVzb3VyY2VzL1VYCABSVytGUlcrRlBLAQIVAxQACAAIAPuDljYNjiN3HAAAAFIA AAAeAAwAAAAAAAAAAECkgf4CAABfX01BQ09TWC9yZXNvdXJjZXMvLl8uRFNfU3RvcmVVWAgAUlcr RrpVK0ZQSwECFQMUAAgACACVhJY29Pw+U6cAAADkAAAAIAAMAAAAAAAAAABApIF2AwAAcmVzb3Vy Y2VzL3N1YmZyYW1lLWJhc2UtdXJsLmh0bWxVWAgAUlcrRtpWK0ZQSwECFQMUAAgACACVhJY2Rtnw DSMAAABSAAAAKwAMAAAAAAAAAABApIF7BAAAX19NQUNPU1gvcmVzb3VyY2VzLy5fc3ViZnJhbWUt YmFzZS11cmwuaHRtbFVYCABSVytG2lYrRlBLBQYAAAAACQAJAN0CAAAHBQAAAAA= 15609 2007-07-20 15:23:53 -0700 2007-07-20 15:34:49 -0700 Proposed fix - don't overwrite the (base)url if it's non-empty patch.txt text/plain 4554 beidson SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI0NDg5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDctMjAgIEJyYWR5IEVpZHNvbiAgPGJl aWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MTUzMDIxPiBhbmQgaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzNjQKKworICAgICAgICAqIGZhc3QvZnJhbWVzL2ZyYW1l LWJhc2UtdXJsLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mcmFtZXMvZnJh bWUtYmFzZS11cmwuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9mcmFtZXMvcmVzb3VyY2Vz L3N1YmZyYW1lLWJhc2UtdXJsLmh0bWw6IEFkZGVkLgorCiAyMDA3LTA3LTIwICBTYW0gV2Vpbmln ICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWl0ei4KSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvZnJhbWVzL3Jlc291cmNlcy9zdWJmcmFtZS1iYXNlLXVybC5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3Jlc291cmNlcy9zdWJmcmFtZS1i YXNlLXVybC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvcmVz b3VyY2VzL3N1YmZyYW1lLWJhc2UtdXJsLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMg QEAKKzxib2R5PgorPGEgaHJlZj0iZm9vYmFyLmh0bWwiPk5vbmV4aXN0YW50IFJlc291cmNlPC9h Pjxicj4KKzxzY3JpcHQ+Citkb2N1bWVudC5vcGVuKCk7Citkb2N1bWVudC5jbG9zZSgpOworCitp ZiAoL1wvcmVzb3VyY2VzXC9mb29iYXIuaHRtbCQvLnRlc3QoZG9jdW1lbnQuZ2V0RWxlbWVudHNC eVRhZ05hbWUoImEiKVswXS5ocmVmKSkKKyAgICBwYXJlbnQuZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoInRlc3RSZXN1bHQiKS5pbm5lckhUTUwgPSAiU1VDQ0VTUyIKKyAgICAKK2lmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9u ZSgpOworPC9zY3JpcHQ+Cis8L2JvZHk+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9m cmFtZS1iYXNlLXVybC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFz dC9mcmFtZXMvZnJhbWUtYmFzZS11cmwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvZmFzdC9mcmFtZXMvZnJhbWUtYmFzZS11cmwtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDkgQEAKK2h0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMzY0CisKK1RoaXMgdGVzdHMgdGhlIGJhc2UgdXJsIGluIGEgc3ViZnJhbWUgZG9jdW1l bnQgdGhhdCBzdGFydHMgb3V0IGxvYWRlZCBmcm9tIGEgcmVhbGx5LCBhZGRyZXNzYWJsZSByZXNv dXJjZSBidXQgdGhlbiB1bmRlcmdvZXMgYSBkb2N1bWVudC53cml0ZSAob3IgZG9jdW1lbnQub3Bl bikKKworVGhlIGxpbmsgaW4gdGhlIHN1YmZyYW1lIHJlbGF0aXZlIHRvIHRoaXMgZG9jdW1lbnQg c2hvdWxkIGJlICIvcmVzb3VyY2VzL2Zvb2Jhci5odG1sIiBhbmQgbm90ICJmb29iYXIuaHRtbCIK KworU1VDQ0VTUworCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLWJhc2Ut dXJsLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZnJhbWUtYmFz ZS11cmwuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZyYW1l LWJhc2UtdXJsLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTkgQEAKKzxodG1sPgorPGhl YWQ+Cis8dGl0bGU+VGVzdCBmb3IgMTMzNjQ8L3RpdGxlPgorPHNjcmlwdD4KK2lmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50 aWxEb25lKCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworfQorPC9z Y3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxhIGhyZWY9Imh0dHA6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMzY0Ij5odHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzM2NDwvYT48YnI+PGJyPgorVGhpcyB0ZXN0cyB0aGUgYmFzZSB1cmwgaW4gYSBzdWJm cmFtZSBkb2N1bWVudCB0aGF0IHN0YXJ0cyBvdXQgbG9hZGVkIGZyb20gYSByZWFsbHksIGFkZHJl c3NhYmxlIHJlc291cmNlIGJ1dCB0aGVuIHVuZGVyZ29lcyBhIGRvY3VtZW50LndyaXRlIChvciBk b2N1bWVudC5vcGVuKTxicj48YnI+CitUaGUgbGluayBpbiB0aGUgc3ViZnJhbWUgcmVsYXRpdmUg dG8gdGhpcyBkb2N1bWVudCBzaG91bGQgYmUgIi9yZXNvdXJjZXMvZm9vYmFyLmh0bWwiIGFuZCBu b3QgImZvb2Jhci5odG1sIjxicj48YnI+Cis8ZGl2IGlkPSJ0ZXN0UmVzdWx0Ij5GYWlsdXJlPC9k aXY+PGJyPgorPGlmcmFtZSBzcmM9InJlc291cmNlcy9zdWJmcmFtZS1iYXNlLXVybC5odG1sIj48 YnI+PGJyPgorPC9ib2R5PgorPC9oZWFkPgorCkluZGV4OiBXZWJDb3JlL2RvbS9Eb2N1bWVudC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCShyZXZpc2lvbiAyNDQ4 OSkKKysrIFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI1OCw4 ICsxMjU4LDEwIEBACiAgICAgLy8gVGhpcyBpcyB3b3JrIHRoYXQgd2Ugc2hvdWxkIHByb2JhYmx5 IGRvIGluIGNsZWFyKCksIGJ1dCB3ZSBjYW4ndCBoYXZlIGl0CiAgICAgLy8gaGFwcGVuIHdoZW4g aW1wbGljaXRPcGVuKCkgaXMgY2FsbGVkIHVubGVzcyB3ZSByZW9yZ2FuaXplIEZyYW1lIGNvZGUu CiAgICAgaWYgKERvY3VtZW50ICpwYXJlbnQgPSBwYXJlbnREb2N1bWVudCgpKSB7Ci0gICAgICAg IHNldFVSTChwYXJlbnQtPmJhc2VVUkwoKSk7Ci0gICAgICAgIHNldEJhc2VVUkwocGFyZW50LT5i YXNlVVJMKCkpOworICAgICAgICBpZiAobV91cmwuaXNFbXB0eSgpIHx8IG1fdXJsID09ICJhYm91 dDpibGFuayIpCisgICAgICAgICAgICBzZXRVUkwocGFyZW50LT5iYXNlVVJMKCkpOworICAgICAg ICBpZiAobV9iYXNlVVJMLmlzRW1wdHkoKSB8fCBtX2Jhc2VVUkwgPT0gImFib3V0OmJsYW5rIikK KyAgICAgICAgICAgIHNldEJhc2VVUkwocGFyZW50LT5iYXNlVVJMKCkpOwogICAgIH0KIAogICAg IGlmICgoZnJhbWUoKSAmJiBmcmFtZSgpLT5sb2FkZXIoKS0+aXNMb2FkaW5nTWFpblJlc291cmNl KCkpIHx8ICh0b2tlbml6ZXIoKSAmJiB0b2tlbml6ZXIoKS0+ZXhlY3V0aW5nU2NyaXB0KCkpKQpJ bmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJ KHJldmlzaW9uIDI0NDg5KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNiBAQAorMjAwNy0wNy0yMCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzUxNTMwMjE+IGFuZCBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzM2NAorCisgICAgICAgIFRoZSBpc3N1ZSBoZXJlIHdhcyB0aGF0IGlmIGEgZG9j dW1lbnQgaW4gYSBzdWJmcmFtZSB3YXMgbG9hZGVkIGZyb20gYSBVUkwsIGJ1dCB0aGVuIGEgc2Ny aXB0IGRpZCAKKyAgICAgICAgZG9jdW1lbnQub3BlbiBvciBkb2N1bWVudC53cml0ZSBkdXJpbmcg cGFyc2luZywgd2Ugd291bGQgb3ZlcndyaXRlIHRoZSBkb2N1bWVudCdzIHVybCBhbmQgYmFzZXVy bCAKKyAgICAgICAgd2l0aCB0aGUgcGFyZW50IGZyYW1lJ3MgdXJsLiAgV1JPTkchCisKKyAgICAg ICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6Om9wZW4p OiBPbmx5IHNldCB0aGUgdXJsIGFuZCBiYXNlVVJMIGluIGRvY3VtZW50Lm9wZW4gaWYgdGhlIGFy ZSBzdGlsbCBlbXB0eSBvciBhYm91dDpibGFuaworCiAyMDA3LTA3LTIwICBTYW0gV2VpbmlnICA8 c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQmV0aCBEYWtpbi4K