133633 2014-06-08 22:28:56 -0700 Fix WebGL EXT_shader_texture_lod for iOS 2014-06-09 16:33:05 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.khronos.org/registry/webgl/extensions/EXT_shader_texture_lod/ P2 Normal --- 1 pyalot achristensen achristensen commit-queue dino esprehn+autocc gyuyoung.kim jonlee kondapallykalyan pyalot roger_fong oldest_to_newest 1014065 0 pyalot 2014-06-08 22:28:56 -0700 The WebGL extension EXT_shader_texture_lod which mirrors the ES Extension http://www.khronos.org/registry/gles/extensions/EXT/EXT_shader_texture_lod.txt may now be implemented. The functionality is also part of OpenGL ES 3.0. Chrome ticket: https://code.google.com/p/chromium/issues/detail?id=344583 Firefox ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=965848 1014214 1 achristensen 2014-06-09 13:52:05 -0700 Changing title to reflect iOS. This was already implemented for other platforms in https://bugs.webkit.org/show_bug.cgi?id=128985 1014216 2 232732 achristensen 2014-06-09 13:55:23 -0700 Created attachment 232732 Patch 1014256 3 232739 achristensen 2014-06-09 15:42:26 -0700 Created attachment 232739 Patch 1014276 4 232739 commit-queue 2014-06-09 16:33:02 -0700 Comment on attachment 232739 Patch Clearing flags on attachment: 232739 Committed r169730: <http://trac.webkit.org/changeset/169730> 1014277 5 commit-queue 2014-06-09 16:33:05 -0700 All reviewed patches have been landed. Closing bug. 232732 2014-06-09 13:55:23 -0700 2014-06-09 15:42:22 -0700 Patch bug-133633-20140609135459.patch text/plain 2566 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTcxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA2LTA5ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2lPUyBXZWJH TF0gRml4IEVYVF9zaGFkZXJfdGV4dHVyZV9sb2QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM2MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IHRoZSBLaHJvbm9zIHRlc3QgKGFuZCBp biBMYXlvdXRUZXN0cyk6CisgICAgICAgIGNvbmZvcm1hbmNlL2V4dGVuc2lvbnMvZXh0LXNoYWRl ci10ZXh0dXJlLWxvZC5odG1sCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmlu Z0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0Ojpn ZXRFeHRlbnNpb24pOgorICAgICAgICBDb3JyZWN0ZWQgc2hhZGVyIHRleHR1cmUgbmFtZSB0byBt YXRjaCB2YWx1ZSBmcm9tIGdsR2V0U3RyaW5nKEdMX0VYVEVOU0lPTlMpIG9uIGlPUy4KKwogMjAx NC0wNi0wOSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lP U10gQW1hem9uIGFwcDogQ2Fubm90IGludGVyYWN0IHdpdGggcHJvZHVjdCBwYWdlIGFmdGVyIHRh cHBpbmcgb24gcHJvZHVjdCBpbWFnZQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv V2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCShyZXZpc2lvbiAxNjk2OTcpCisr KyBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC05MSw2ICs5MSwxMiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK KyNpZiBQTEFURk9STShJT1MpCitjb25zdCBjaGFyKiBzaGFkZXJUZXh0dXJlTE9ETmFtZSA9ICJH TF9FWFRfc2hhZGVyX3RleHR1cmVfbG9kIjsKKyNlbHNlCitjb25zdCBjaGFyKiBzaGFkZXJUZXh0 dXJlTE9ETmFtZSA9ICJHTF9BUkJfc2hhZGVyX3RleHR1cmVfbG9kIjsKKyNlbmRpZgorCiBjb25z dCBkb3VibGUgc2Vjb25kc0JldHdlZW5SZXN0b3JlQXR0ZW1wdHMgPSAxLjA7CiBjb25zdCBpbnQg bWF4R0xFcnJvcnNBbGxvd2VkVG9Db25zb2xlID0gMjU2OwogCkBAIC0yNDMxLDcgKzI0MzcsNyBA QCBXZWJHTEV4dGVuc2lvbiogV2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnCiAgICAgICAgIHJldHVy biBudWxscHRyOwogCiAgICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKG5hbWUsICJFWFRfc2hhZGVy X3RleHR1cmVfbG9kIikKLSAgICAgICAgJiYgbV9jb250ZXh0LT5nZXRFeHRlbnNpb25zKCktPnN1 cHBvcnRzKCJHTF9BUkJfc2hhZGVyX3RleHR1cmVfbG9kIikpIHsKKyAgICAgICAgJiYgbV9jb250 ZXh0LT5nZXRFeHRlbnNpb25zKCktPnN1cHBvcnRzKHNoYWRlclRleHR1cmVMT0ROYW1lKSkgewog ICAgICAgICBpZiAoIW1fZXh0U2hhZGVyVGV4dHVyZUxPRCkgewogICAgICAgICAgICAgbV9jb250 ZXh0LT5nZXRFeHRlbnNpb25zKCktPmVuc3VyZUVuYWJsZWQoIkdMX0VYVF9zaGFkZXJfdGV4dHVy ZV9sb2QiKTsKICAgICAgICAgICAgIG1fZXh0U2hhZGVyVGV4dHVyZUxPRCA9IHN0ZDo6bWFrZV91 bmlxdWU8RVhUU2hhZGVyVGV4dHVyZUxPRD4odGhpcyk7CkBAIC0zMDQ4LDcgKzMwNTQsNyBAQCBW ZWN0b3I8U3RyaW5nPiBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdlCiAgICAgICAgIHJlc3VsdC5h cHBlbmQoIk9FU190ZXh0dXJlX2hhbGZfZmxvYXRfbGluZWFyIik7CiAgICAgaWYgKG1fY29udGV4 dC0+Z2V0RXh0ZW5zaW9ucygpLT5zdXBwb3J0cygiR0xfT0VTX3N0YW5kYXJkX2Rlcml2YXRpdmVz IikpCiAgICAgICAgIHJlc3VsdC5hcHBlbmQoIk9FU19zdGFuZGFyZF9kZXJpdmF0aXZlcyIpOwot ICAgIGlmIChtX2NvbnRleHQtPmdldEV4dGVuc2lvbnMoKS0+c3VwcG9ydHMoIkdMX0FSQl9zaGFk ZXJfdGV4dHVyZV9sb2QiKSkKKyAgICBpZiAobV9jb250ZXh0LT5nZXRFeHRlbnNpb25zKCktPnN1 cHBvcnRzKHNoYWRlclRleHR1cmVMT0ROYW1lKSkKICAgICAgICAgcmVzdWx0LmFwcGVuZCgiRVhU X3NoYWRlcl90ZXh0dXJlX2xvZCIpOwogICAgIGlmIChtX2NvbnRleHQtPmdldEV4dGVuc2lvbnMo KS0+c3VwcG9ydHMoIkdMX0VYVF90ZXh0dXJlX2ZpbHRlcl9hbmlzb3Ryb3BpYyIpKQogICAgICAg ICByZXN1bHQuYXBwZW5kKCJXRUJLSVRfRVhUX3RleHR1cmVfZmlsdGVyX2FuaXNvdHJvcGljIik7 Cg== 232739 2014-06-09 15:42:26 -0700 2014-06-09 16:33:02 -0700 Patch bug-133633-20140609154201.patch text/plain 2478 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTcxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA2LTA5ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2lPUyBXZWJH TF0gRml4IEVYVF9zaGFkZXJfdGV4dHVyZV9sb2QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM2MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IHRoZSBLaHJvbm9zIHRlc3QgKGFuZCBp biBMYXlvdXRUZXN0cyk6CisgICAgICAgIGNvbmZvcm1hbmNlL2V4dGVuc2lvbnMvZXh0LXNoYWRl ci10ZXh0dXJlLWxvZC5odG1sCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmlu Z0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0Ojpn ZXRFeHRlbnNpb24pOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0Ojpn ZXRTdXBwb3J0ZWRFeHRlbnNpb25zKToKKyAgICAgICAgQWRkZWQgc2hhZGVyIHRleHR1cmUgbG9k IG5hbWUgdG8gbWF0Y2ggdmFsdWUgZnJvbSBnbEdldFN0cmluZyhHTF9FWFRFTlNJT05TKSBvbiBp T1MuCisKIDIwMTQtMDYtMDkgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAg ICAgICAgIFtpT1NdIEFtYXpvbiBhcHA6IENhbm5vdCBpbnRlcmFjdCB3aXRoIHByb2R1Y3QgcGFn ZSBhZnRlciB0YXBwaW5nIG9uIHByb2R1Y3QgaW1hZ2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkocmV2aXNpb24g MTY5Njk3KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250 ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQzMSw3ICsyNDMxLDcgQEAgV2ViR0xFeHRlbnNp b24qIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6ZwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAog ICAgIGlmIChlcXVhbElnbm9yaW5nQ2FzZShuYW1lLCAiRVhUX3NoYWRlcl90ZXh0dXJlX2xvZCIp Ci0gICAgICAgICYmIG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9ucygpLT5zdXBwb3J0cygiR0xfQVJC X3NoYWRlcl90ZXh0dXJlX2xvZCIpKSB7CisgICAgICAgICYmIChtX2NvbnRleHQtPmdldEV4dGVu c2lvbnMoKS0+c3VwcG9ydHMoIkdMX0VYVF9zaGFkZXJfdGV4dHVyZV9sb2QiKSB8fCBtX2NvbnRl eHQtPmdldEV4dGVuc2lvbnMoKS0+c3VwcG9ydHMoIkdMX0FSQl9zaGFkZXJfdGV4dHVyZV9sb2Qi KSkpIHsKICAgICAgICAgaWYgKCFtX2V4dFNoYWRlclRleHR1cmVMT0QpIHsKICAgICAgICAgICAg IG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9ucygpLT5lbnN1cmVFbmFibGVkKCJHTF9FWFRfc2hhZGVy X3RleHR1cmVfbG9kIik7CiAgICAgICAgICAgICBtX2V4dFNoYWRlclRleHR1cmVMT0QgPSBzdGQ6 Om1ha2VfdW5pcXVlPEVYVFNoYWRlclRleHR1cmVMT0Q+KHRoaXMpOwpAQCAtMzA0OCw3ICszMDQ4 LDcgQEAgVmVjdG9yPFN0cmluZz4gV2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZQogICAgICAgICBy ZXN1bHQuYXBwZW5kKCJPRVNfdGV4dHVyZV9oYWxmX2Zsb2F0X2xpbmVhciIpOwogICAgIGlmICht X2NvbnRleHQtPmdldEV4dGVuc2lvbnMoKS0+c3VwcG9ydHMoIkdMX09FU19zdGFuZGFyZF9kZXJp dmF0aXZlcyIpKQogICAgICAgICByZXN1bHQuYXBwZW5kKCJPRVNfc3RhbmRhcmRfZGVyaXZhdGl2 ZXMiKTsKLSAgICBpZiAobV9jb250ZXh0LT5nZXRFeHRlbnNpb25zKCktPnN1cHBvcnRzKCJHTF9B UkJfc2hhZGVyX3RleHR1cmVfbG9kIikpCisgICAgaWYgKG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9u cygpLT5zdXBwb3J0cygiR0xfRVhUX3NoYWRlcl90ZXh0dXJlX2xvZCIpIHx8IG1fY29udGV4dC0+ Z2V0RXh0ZW5zaW9ucygpLT5zdXBwb3J0cygiR0xfQVJCX3NoYWRlcl90ZXh0dXJlX2xvZCIpKQog ICAgICAgICByZXN1bHQuYXBwZW5kKCJFWFRfc2hhZGVyX3RleHR1cmVfbG9kIik7CiAgICAgaWYg KG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9ucygpLT5zdXBwb3J0cygiR0xfRVhUX3RleHR1cmVfZmls dGVyX2FuaXNvdHJvcGljIikpCiAgICAgICAgIHJlc3VsdC5hcHBlbmQoIldFQktJVF9FWFRfdGV4 dHVyZV9maWx0ZXJfYW5pc290cm9waWMiKTsK