133619 2014-06-08 14:20:18 -0700 [Mac] checkboxes and radio buttons animate incorrectly 2014-06-08 17:03:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino oldest_to_newest 1014029 0 dino 2014-06-08 14:20:18 -0700 [Mac] checkboxes and radio buttons animate incorrectly 1014031 1 232685 dino 2014-06-08 14:25:20 -0700 Created attachment 232685 Patch 1014032 2 232685 sam 2014-06-08 14:30:48 -0700 Comment on attachment 232685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232685&action=review > Source/WebCore/platform/mac/ThemeMac.mm:304 > +static const std::array<FloatSize, 3>& checkboxOffsets() I think this could use a comment explaining what they the offsets are used for. > Source/WebCore/platform/mac/ThemeMac.mm:332 > +static const std::array<FloatSize, 3>& radioOffsets() I think this could use a comment explaining what they the offsets are used for. 1014048 3 dino 2014-06-08 17:03:14 -0700 Committed r169685: <http://trac.webkit.org/changeset/169685> 232685 2014-06-08 14:25:20 -0700 2014-06-08 14:30:48 -0700 Patch bug-133619-20140609072454.patch text/plain 5155 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE0Y2YyMDE0MmUxMDMy NjRlMGNiZGZkNzhhMzE1YmQ0Y2RhMjBjYi4uYmY5ZjcyZjNkYzRlNzZjMmQ3YjlkNjY4MjFiOTA4 OWFiZWExN2ZjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE0LTA2LTA4ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbTWFjXSBjaGVja2JveGVzIGFu ZCByYWRpbyBidXR0b25zIGFuaW1hdGUgaW5jb3JyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzYxOQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMTY0Nzg2NzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQXMgbWFueSBwZW9wbGUgaGF2ZSBub3RpY2VkLCB0aGUgbmV3IGNoZWNrYm94ZXMgYW5k IHJhZGlvCisgICAgICAgIGJ1dHRvbnMganVtcCBhcm91bmQgZHVyaW5nIHRoZWlyIGFuaW1hdGlv bi4gVG8gZml4IHRoaXMKKyAgICAgICAgSSd2ZSBhZGRlZCB5ZXQgYW5vdGhlciBtYWdpYyBzZXQg b2YgbnVtYmVycyB0byBvdXIKKyAgICAgICAgbmF0aXZlIGZvcm0gcG9zaXRpb25pbmcgLSB0aGlz IHRpbWUgdGhlIHBsYWNlbWVudAorICAgICAgICBvZiB0aGUgY29udHJvbHMgd2hlbiByZW5kZXJp bmcgb24gdGhlIGFuaW1hdGVkIHBhdGguCisgICAgICAgIFRoaXMgaXMgcXVpdGUgYW5ub3lpbmcs IHNpbmNlIHRoZXJlIGRvZXNuJ3QgYXBwZWFyCisgICAgICAgIHRvIGJlIGFueSBwYXR0ZXJuIHRv IHRoZSBvZmZzZXRzIChvciBtYXJnaW5zKSBnaXZlbgorICAgICAgICBhIGNvbnRyb2wgc2l6ZSwg YW5kIHRoaXMgY2FzZSBhbHNvIG5lZWRlZCBhIHN1Yi1waXhlbAorICAgICAgICBvZmZzZXQgdG8g ZGlzcGxheSBjb3JyZWN0bHkgb24gcmV0aW5hIG1hY2hpbmVzLgorCisgICAgICAgICogcGxhdGZv cm0vbWFjL1RoZW1lTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6Y2hlY2tib3hNYXJnaW5zKTog QWRkIGNvbW1lbnQgc28gSSBrbm93IHdoYXQgdGhlIHZhbHVlcyBtZWFuLgorICAgICAgICAoV2Vi Q29yZTo6Y2hlY2tib3hPZmZzZXRzKTogQWRkIHRoZSBtYWdpYyB0cmFuc2xhdGlvbiB2YWx1ZXMg Zm9yIGFuaW1hdGVkIHN0YXRlcy4KKyAgICAgICAgKFdlYkNvcmU6OnJhZGlvTWFyZ2lucyk6IERp dHRvLgorICAgICAgICAoV2ViQ29yZTo6cmFkaW9PZmZzZXRzKToKKyAgICAgICAgKFdlYkNvcmU6 OnBhaW50VG9nZ2xlQnV0dG9uKTogUGFpbnQgd2l0aCB0aGVzZSBuZXcgb2Zmc2V0cy4KKwogMjAx NC0wNi0wNyAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVncmVz c2lvbiByMTY4Mzk3IC0gRm9ybSBsYXlvdXQgaXMgaW5jb3JyZWN0IG9uIE9TIFggWW9zZW1pdGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9UaGVtZU1hYy5tbSBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9UaGVtZU1hYy5tbQppbmRleCBmZmJhMjI4MjViNGY1 ZGM1ZjVjMjU1OGQxMGFlZTE0N2JlNTA5ZjJkLi44NDBhZDYzODllODNiMmE4ZWEyNmQyYjJlYWI1 MmU3NDYyNDkyMjgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVGhl bWVNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1RoZW1lTWFjLm1tCkBA IC0yODIsNiArMjgyLDcgQEAgc3RhdGljIGNvbnN0IGludCogY2hlY2tib3hNYXJnaW5zKE5TQ29u dHJvbFNpemUgY29udHJvbFNpemUpCiB7CiAgICAgc3RhdGljIGNvbnN0IGludCBtYXJnaW5zWzNd WzRdID0KICAgICB7CisgICAgICAgIC8vIHRvcCBsZWZ0IHJpZ2h0IGJvdHRvbQogICAgICAgICB7 IDMsIDQsIDQsIDIgfSwKICAgICAgICAgeyA0LCAzLCAzLCAzIH0sCiAgICAgICAgIHsgNCwgMywg MywgMyB9LApAQCAtMjk4LDcgKzI5OSwxNSBAQCBzdGF0aWMgTGVuZ3RoU2l6ZSBjaGVja2JveFNp emUoY29uc3QgRm9udCYgZm9udCwgY29uc3QgTGVuZ3RoU2l6ZSYgem9vbWVkU2l6ZSwgZgogICAg IC8vIFVzZSB0aGUgZm9udCBzaXplIHRvIGRldGVybWluZSB0aGUgaW50cmluc2ljIHdpZHRoIG9m IHRoZSBjb250cm9sLgogICAgIHJldHVybiBzaXplRnJvbUZvbnQoZm9udCwgem9vbWVkU2l6ZSwg em9vbUZhY3RvciwgY2hlY2tib3hTaXplcygpKTsKIH0KLSAgICAKKworI2lmIF9fTUFDX09TX1hf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMDAKK3N0YXRpYyBjb25zdCBzdGQ6OmFycmF5PEZs b2F0U2l6ZSwgMz4mIGNoZWNrYm94T2Zmc2V0cygpCit7CisgICAgc3RhdGljIGNvbnN0IHN0ZDo6 YXJyYXk8RmxvYXRTaXplLCAzPiBzaXplcyA9IHsgeyBGbG9hdFNpemUoMCwgMiksIEZsb2F0U2l6 ZSgyLCAxLjUpLCBGbG9hdFNpemUoMywgMykgfSB9OworICAgIHJldHVybiBzaXplczsKK30KKyNl bmRpZgorCiAvLyBSYWRpbyBCdXR0b25zCiAKIHN0YXRpYyBjb25zdCBzdGQ6OmFycmF5PEludFNp emUsIDM+JiByYWRpb1NpemVzKCkKQEAgLTMxMSw2ICszMjAsNyBAQCBzdGF0aWMgY29uc3QgaW50 KiByYWRpb01hcmdpbnMoTlNDb250cm9sU2l6ZSBjb250cm9sU2l6ZSkKIHsKICAgICBzdGF0aWMg Y29uc3QgaW50IG1hcmdpbnNbM11bNF0gPQogICAgIHsKKyAgICAgICAgLy8gdG9wIGxlZnQgcmln aHQgYm90dG9tCiAgICAgICAgIHsgMiwgMiwgNCwgMiB9LAogICAgICAgICB7IDMsIDIsIDMsIDIg fSwKICAgICAgICAgeyAxLCAwLCAyLCAwIH0sCkBAIC0zMTgsNiArMzI4LDE0IEBAIHN0YXRpYyBj b25zdCBpbnQqIHJhZGlvTWFyZ2lucyhOU0NvbnRyb2xTaXplIGNvbnRyb2xTaXplKQogICAgIHJl dHVybiBtYXJnaW5zW2NvbnRyb2xTaXplXTsKIH0KIAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9N SU5fUkVRVUlSRUQgPj0gMTAxMDAKK3N0YXRpYyBjb25zdCBzdGQ6OmFycmF5PEZsb2F0U2l6ZSwg Mz4mIHJhZGlvT2Zmc2V0cygpCit7CisgICAgc3RhdGljIGNvbnN0IHN0ZDo6YXJyYXk8RmxvYXRT aXplLCAzPiBzaXplcyA9IHsgeyBGbG9hdFNpemUoMCwgMiksIEZsb2F0U2l6ZSgxLCAyKSwgRmxv YXRTaXplKDAsIDEpIH0gfTsKKyAgICByZXR1cm4gc2l6ZXM7Cit9CisjZW5kaWYKKwogc3RhdGlj IExlbmd0aFNpemUgcmFkaW9TaXplKGNvbnN0IEZvbnQmIGZvbnQsIGNvbnN0IExlbmd0aFNpemUm IHpvb21lZFNpemUsIGZsb2F0IHpvb21GYWN0b3IpCiB7CiAgICAgLy8gSWYgdGhlIHdpZHRoIGFu ZCBoZWlnaHQgYXJlIGJvdGggc3BlY2lmaWVkLCB0aGVuIHdlIGhhdmUgbm90aGluZyB0byBkby4K QEAgLTQyMiwyMSArNDQwLDI0IEBAIHN0YXRpYyB2b2lkIHBhaW50VG9nZ2xlQnV0dG9uKENvbnRy b2xQYXJ0IGJ1dHRvblR5cGUsIENvbnRyb2xTdGF0ZXMqIGNvbnRyb2xTdGF0CiAKICAgICBMb2Nh bEN1cnJlbnRHcmFwaGljc0NvbnRleHQgbG9jYWxDb250ZXh0KGNvbnRleHQpOwogICAgIE5TVmll dyAqdmlldyA9IFRoZW1lTWFjOjplbnN1cmVkVmlldyhzY3JvbGxWaWV3LCBjb250cm9sU3RhdGVz KTsKLSAgICBib29sIGRyYXdTdGF0aWNhbGx5ID0gdHJ1ZTsKKwogI2lmIF9fTUFDX09TX1hfVkVS U0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMDAKLSAgICBkcmF3U3RhdGljYWxseSA9ICFbdG9nZ2xl QnV0dG9uQ2VsbCBfc3RhdGVBbmltYXRpb25SdW5uaW5nXTsKLSNlbmRpZgotICAgIGlmIChkcmF3 U3RhdGljYWxseSkKLSAgICAgICAgW3RvZ2dsZUJ1dHRvbkNlbGwgZHJhd1dpdGhGcmFtZTpOU1Jl Y3QoaW5mbGF0ZWRSZWN0KSBpblZpZXc6dmlld107Ci0gICAgZWxzZSB7Ci0gICAgICAgIC8vIEZJ WE1FOiBUaGlzIGlzbid0IHF1aXRlIGNvcnJlY3QgYXQgdGhlIG1vbWVudCBkdWUgdG8gdGhlIHdh eSB0aGUgdGljayBtYXJrIGV4dGVuZHMgb3V0IG9mIHRoZSBjb250cm9sLgorICAgIGlmIChbdG9n Z2xlQnV0dG9uQ2VsbCBfc3RhdGVBbmltYXRpb25SdW5uaW5nXSkgeworICAgICAgICAvLyBBcHBL aXQncyBkcmF3V2l0aEZyYW1lIGFwcGVhcnMgdG8gcmVuZGVyIHRoZSBjZWxsIGNlbnRlcmVkIGlu IHRoZQorICAgICAgICAvLyBwcm92aWRlZCByZWN0YW5nbGUvZnJhbWUsIHNvIHdlIG5lZWQgdG8g bWFudWFsbHkgcG9zaXRpb24gdGhlCisgICAgICAgIC8vIGFuaW1hdGVkIGNlbGwgYXQgdGhlIGNv cnJlY3QgbG9jYXRpb24uCiAgICAgICAgIGNvbnRleHQtPnRyYW5zbGF0ZShpbmZsYXRlZFJlY3Qu eCgpLCBpbmZsYXRlZFJlY3QueSgpKTsKICAgICAgICAgY29udGV4dC0+c2NhbGUoRmxvYXRTaXpl KDEsIC0xKSk7CiAgICAgICAgIGNvbnRleHQtPnRyYW5zbGF0ZSgwLCAtaW5mbGF0ZWRSZWN0Lmhl aWdodCgpKTsKLSNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTAwCisg ICAgICAgIEZsb2F0U2l6ZSBjb250cm9sT2Zmc2V0cyA9IGJ1dHRvblR5cGUgPT0gQ2hlY2tib3hQ YXJ0ID8gY2hlY2tib3hPZmZzZXRzKClbY29udHJvbFNpemVdIDogcmFkaW9PZmZzZXRzKClbY29u dHJvbFNpemVdOworICAgICAgICBjb250ZXh0LT50cmFuc2xhdGUoY29udHJvbE9mZnNldHMpOwog ICAgICAgICBbdG9nZ2xlQnV0dG9uQ2VsbCBfcmVuZGVyQ3VycmVudEFuaW1hdGlvbkZyYW1lSW5D b250ZXh0OmNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpIGF0TG9jYXRpb246TlNNYWtlUG9pbnQo MCwgMCldOworICAgIH0gZWxzZQorICAgICAgICBbdG9nZ2xlQnV0dG9uQ2VsbCBkcmF3V2l0aEZy YW1lOk5TUmVjdChpbmZsYXRlZFJlY3QpIGluVmlldzp2aWV3XTsKKyNlbHNlCisgICAgW3RvZ2ds ZUJ1dHRvbkNlbGwgZHJhd1dpdGhGcmFtZTpOU1JlY3QoaW5mbGF0ZWRSZWN0KSBpblZpZXc6dmll d107CiAjZW5kaWYKLSAgICB9CisKICAgICBib29sIG5lZWRzUmVwYWludCA9IGZhbHNlOwogICAg IGlmIChjb250cm9sU3RhdGVzLT5zdGF0ZXMoKSAmIENvbnRyb2xTdGF0ZXM6OkZvY3VzU3RhdGUp CiAgICAgICAgIG5lZWRzUmVwYWludCA9IGRyYXdDZWxsRm9jdXNSaW5nKHRvZ2dsZUJ1dHRvbkNl bGwsIGluZmxhdGVkUmVjdCwgdmlldyk7Cg==