133615 2014-06-07 22:49:22 -0700 ScriptExecutionContext::Task parameters should always be rvalue references 2014-06-18 11:05:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan andersca commit-queue darin esprehn+autocc kangil.han oldest_to_newest 1014014 0 zan 2014-06-07 22:49:22 -0700 ScriptExecutionContext::Task parameters should always be rvalue references 1014015 1 232679 zan 2014-06-07 22:58:47 -0700 Created attachment 232679 Patch 1016236 2 232679 darin 2014-06-17 13:43:12 -0700 Comment on attachment 232679 Patch Wait, I am not sure this is a good idea. If the object really is move-only then it seems strange to change it to &&. 1016244 3 darin 2014-06-17 14:06:53 -0700 Anders, what do you think of this from a coding style point of view? 1016249 4 andersca 2014-06-17 14:24:15 -0700 (In reply to comment #3) > Anders, what do you think of this from a coding style point of view? If it's move only it doesn't matter. I don't think it should be an rvalue reference in that case. 1016490 5 zan 2014-06-18 10:54:46 -0700 Committed r170106: <http://trac.webkit.org/changeset/170106> 1016499 6 zan 2014-06-18 11:05:14 -0700 Sorry, I missed the comments before landing. I'll revert these and other ScriptExecutionContext::Task&& parameters in one go, in a different bug. 232679 2014-06-07 22:58:47 -0700 2014-06-17 13:43:12 -0700 Patch bug-133615-20140607225822.patch text/plain 14555 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE0Y2YyMDE0MmUxMDMy NjRlMGNiZGZkNzhhMzE1YmQ0Y2RhMjBjYi4uZmU0NDZhODQxODhlZWUyYzFiNGYyZDMwMzZiNmRk NmRmNjBlZWNjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQyIEBACisyMDE0LTA2LTA3ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBTY3JpcHRFeGVjdXRp b25Db250ZXh0OjpUYXNrIHBhcmFtZXRlcnMgc2hvdWxkIGFsd2F5cyBiZSBydmFsdWUgcmVmZXJl bmNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMz NjE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2Ny aXB0RXhlY3V0aW9uQ29udGV4dDo6VGFzayBwYXJhbWV0ZXJzIHNob3VsZCBiZSBydmFsdWUgcmVm ZXJlbmNlcyBhcyB0aGUKKyAgICAgICAgcGFzc2VkLWluIG9iamVjdHMgYXJlIGFsd2F5cyBTY3Jp cHRFeGVjdXRpb25Db250ZXh0OjpUYXNrIHJ2YWx1ZXMgdGhhdCB3ZXJlCisgICAgICAgIGltcGxp Y2l0bHkgY29uc3RydWN0ZWQgZnJvbSBhIGxhbWJkYSBmdW5jdGlvbiBvciBydmFsdWVzIG9mIG9i amVjdHMgdGhhdAorICAgICAgICBkZXJpdmUgZnJvbSBTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpU YXNrLgorCisgICAgICAgIFRoaXMgaXNuJ3QgcmVhbGx5IG5lY2Vzc2FyeSBzaW5jZSBTY3JpcHRF eGVjdXRpb25Db250ZXh0OjpUYXNrIGlzIG5vbi1jb3B5YWJsZQorICAgICAgICBhbmQgd2UgaGF2 ZSB0byB1c2UgbW92ZSBzZW1hbnRpY3MgYW55d2F5LCBidXQgaXQgbWFrZXMgaXQgY2xlYXIgdGhh dCB0aGVzZQorICAgICAgICBvYmplY3RzIGFyZSBleHBpcmluZyBydmFsdWVzIHRoYXQgbXVzdCBi ZSBwcm9wZXJseSBkZWFsdCB3aXRoLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojpwb3N0VGFzayk6CisgICAgICAgICogZG9tL0RvY3Vt ZW50Lmg6CisgICAgICAgICogZG9tL1NjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaDoKKyAgICAgICAg KiB3b3JrZXJzL0RlZmF1bHRTaGFyZWRXb3JrZXJSZXBvc2l0b3J5LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlNoYXJlZFdvcmtlclByb3h5Ojpwb3N0VGFza1RvTG9hZGVyKToKKyAgICAgICAgKFdl YkNvcmU6OlNoYXJlZFdvcmtlclByb3h5Ojpwb3N0VGFza0Zvck1vZGVUb1dvcmtlckdsb2JhbFNj b3BlKToKKyAgICAgICAgKiB3b3JrZXJzL1dvcmtlckdsb2JhbFNjb3BlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Oldvcmtlckdsb2JhbFNjb3BlOjpwb3N0VGFzayk6CisgICAgICAgICogd29ya2Vy cy9Xb3JrZXJHbG9iYWxTY29wZS5oOgorICAgICAgICAqIHdvcmtlcnMvV29ya2VyTG9hZGVyUHJv eHkuaDoKKyAgICAgICAgKiB3b3JrZXJzL1dvcmtlck1lc3NhZ2luZ1Byb3h5LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Oldvcmtlck1lc3NhZ2luZ1Byb3h5Ojpwb3N0VGFza1RvTG9hZGVyKToKKyAg ICAgICAgKFdlYkNvcmU6Oldvcmtlck1lc3NhZ2luZ1Byb3h5Ojpwb3N0VGFza0Zvck1vZGVUb1dv cmtlckdsb2JhbFNjb3BlKToKKyAgICAgICAgKiB3b3JrZXJzL1dvcmtlck1lc3NhZ2luZ1Byb3h5 Lmg6CisgICAgICAgICogd29ya2Vycy9Xb3JrZXJSdW5Mb29wLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OldvcmtlclJ1bkxvb3A6OnBvc3RUYXNrKToKKyAgICAgICAgKFdlYkNvcmU6OldvcmtlclJ1 bkxvb3A6OnBvc3RUYXNrQW5kVGVybWluYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OldvcmtlclJ1 bkxvb3A6OnBvc3RUYXNrRm9yTW9kZSk6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJSdW5Mb29w OjpUYXNrOjpjcmVhdGUpOgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyUnVuTG9vcDo6VGFzazo6 VGFzayk6CisgICAgICAgICogd29ya2Vycy9Xb3JrZXJSdW5Mb29wLmg6CisKIDIwMTQtMDYtMDcg IERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFJlZ3Jlc3Npb24gcjE2 ODM5NyAtIEZvcm0gbGF5b3V0IGlzIGluY29ycmVjdCBvbiBPUyBYIFlvc2VtaXRlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcAppbmRleCAwMGM5ZmI3MGVkNjVkZTkxOGQ4MWQ2ZDVkM2E1MDUwYTM4Njc2 YmIwLi5kMjJhMTA0OTNlYWRmNTkyOTkzOGI0ODkxMWJjYmY4N2NhYzgwNzkyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAKQEAgLTQ4NzUsNyArNDg3NSw3IEBAIFNlY3VyaXR5T3JpZ2luKiBEb2N1 bWVudDo6dG9wT3JpZ2luKCkgY29uc3QKICAgICByZXR1cm4gdG9wRG9jdW1lbnQoKS5zZWN1cml0 eU9yaWdpbigpOwogfQogCi12b2lkIERvY3VtZW50Ojpwb3N0VGFzayhUYXNrIHRhc2spCit2b2lk IERvY3VtZW50Ojpwb3N0VGFzayhUYXNrJiYgdGFzaykKIHsKICAgICBUYXNrKiB0YXNrUHRyID0g c3RkOjptYWtlX3VuaXF1ZTxUYXNrPihzdGQ6Om1vdmUodGFzaykpLnJlbGVhc2UoKTsKICAgICBX ZWFrUHRyPERvY3VtZW50PiBkb2N1bWVudFJlZmVyZW5jZShtX3dlYWtGYWN0b3J5LmNyZWF0ZVdl YWtQdHIoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4IDc4MWI5MzU4NzIzNTkyOWYyM2JlMjk5 MjgwOWQ5MmExYTUzYWRhMmQuLmM3OTU4Yzk2YWI4YThkNTBlNWMzYjNjMDI2YjU1YmJjM2I5NDgx ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC0xMDA4LDcgKzEwMDgsNyBAQCBwdWJsaWM6CiAg ICAgYm9vbCBpc0ROU1ByZWZldGNoRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1faXNETlNQcmVm ZXRjaEVuYWJsZWQ7IH0KICAgICB2b2lkIHBhcnNlRE5TUHJlZmV0Y2hDb250cm9sSGVhZGVyKGNv bnN0IFN0cmluZyYpOwogCi0gICAgdmlydHVhbCB2b2lkIHBvc3RUYXNrKFRhc2spIG92ZXJyaWRl OyAvLyBFeGVjdXRlcyB0aGUgdGFzayBvbiBjb250ZXh0J3MgdGhyZWFkIGFzeW5jaHJvbm91c2x5 LgorICAgIHZpcnR1YWwgdm9pZCBwb3N0VGFzayhUYXNrJiYpIG92ZXJyaWRlOyAvLyBFeGVjdXRl cyB0aGUgdGFzayBvbiBjb250ZXh0J3MgdGhyZWFkIGFzeW5jaHJvbm91c2x5LgogCiAgICAgdm9p ZCBzdXNwZW5kU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyQ2FsbGJhY2tzKCk7CiAgICAgdm9p ZCByZXN1bWVTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXJDYWxsYmFja3MoKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRpb25Db250ZXh0LmggYi9Tb3VyY2Uv V2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oCmluZGV4IGI1ZjE1ODNmYWMzYzY2 N2Q3ZGZlMTNkZTQ1YjFlNjcyOTQyZGI1NGQuLjA0NjUzNzMxYjAwMWE0NmQwOTQ4ZDhiNDQ1NTFj Y2QyYWIwZWRjZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRp b25Db250ZXh0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEV4ZWN1dGlvbkNvbnRl eHQuaApAQCAtMTQ1LDcgKzE0NSw3IEBAIHB1YmxpYzoKICAgICAgICAgYm9vbCBtX2lzQ2xlYW51 cFRhc2s7CiAgICAgfTsKIAotICAgIHZpcnR1YWwgdm9pZCBwb3N0VGFzayhUYXNrKSA9IDA7IC8v IEV4ZWN1dGVzIHRoZSB0YXNrIG9uIGNvbnRleHQncyB0aHJlYWQgYXN5bmNocm9ub3VzbHkuCisg ICAgdmlydHVhbCB2b2lkIHBvc3RUYXNrKFRhc2smJikgPSAwOyAvLyBFeGVjdXRlcyB0aGUgdGFz ayBvbiBjb250ZXh0J3MgdGhyZWFkIGFzeW5jaHJvbm91c2x5LgogCiAgICAgLy8gR2V0cyB0aGUg bmV4dCBpZCBpbiBhIGNpcmN1bGFyIHNlcXVlbmNlIGZyb20gMSB0byAyXjMxLTEuCiAgICAgaW50 IGNpcmN1bGFyU2VxdWVudGlhbElEKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3Jr ZXJzL0RlZmF1bHRTaGFyZWRXb3JrZXJSZXBvc2l0b3J5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dv cmtlcnMvRGVmYXVsdFNoYXJlZFdvcmtlclJlcG9zaXRvcnkuY3BwCmluZGV4IDIxNTFjNzBlMDRl MDcyZTQ3ZTk2MmM5OGQyMjEzZTI5NWM4YzYzNjAuLmY1ODU5YmY0ZmZlODNkNzI1NGY3ZjI1MWJh NThhM2UxOWUxODRhOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvRGVmYXVs dFNoYXJlZFdvcmtlclJlcG9zaXRvcnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv RGVmYXVsdFNoYXJlZFdvcmtlclJlcG9zaXRvcnkuY3BwCkBAIC04MCw4ICs4MCw4IEBAIHB1Ymxp YzoKICAgICBib29sIG1hdGNoZXMoY29uc3QgU3RyaW5nJiBuYW1lLCBQYXNzUmVmUHRyPFNlY3Vy aXR5T3JpZ2luPiBvcmlnaW4sIGNvbnN0IFVSTCYgdXJsVG9NYXRjaCkgY29uc3Q7CiAKICAgICAv LyBXb3JrZXJMb2FkZXJQcm94eQotICAgIHZpcnR1YWwgdm9pZCBwb3N0VGFza1RvTG9hZGVyKFNj cmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2spOwotICAgIHZpcnR1YWwgYm9vbCBwb3N0VGFza0Zv ck1vZGVUb1dvcmtlckdsb2JhbFNjb3BlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2ssIGNv bnN0IFN0cmluZyYpOworICAgIHZpcnR1YWwgdm9pZCBwb3N0VGFza1RvTG9hZGVyKFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQ6OlRhc2smJik7CisgICAgdmlydHVhbCBib29sIHBvc3RUYXNrRm9yTW9k ZVRvV29ya2VyR2xvYmFsU2NvcGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6VGFzayYmLCBjb25z dCBTdHJpbmcmKTsKIAogICAgIC8vIFdvcmtlclJlcG9ydGluZ1Byb3h5CiAgICAgdmlydHVhbCB2 b2lkIHBvc3RFeGNlcHRpb25Ub1dvcmtlck9iamVjdChjb25zdCBTdHJpbmcmIGVycm9yTWVzc2Fn ZSwgaW50IGxpbmVOdW1iZXIsIGludCBjb2x1bW5OdW1iZXIsIGNvbnN0IFN0cmluZyYgc291cmNl VVJMKTsKQEAgLTE0MCw3ICsxNDAsNyBAQCBib29sIFNoYXJlZFdvcmtlclByb3h5OjptYXRjaGVz KGNvbnN0IFN0cmluZyYgbmFtZSwgUGFzc1JlZlB0cjxTZWN1cml0eU9yaWdpbj4gbwogICAgIHJl dHVybiBuYW1lID09IG1fbmFtZTsKIH0KIAotdm9pZCBTaGFyZWRXb3JrZXJQcm94eTo6cG9zdFRh c2tUb0xvYWRlcihTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpUYXNrIHRhc2spCit2b2lkIFNoYXJl ZFdvcmtlclByb3h5Ojpwb3N0VGFza1RvTG9hZGVyKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRh c2smJiB0YXNrKQogewogICAgIE11dGV4TG9ja2VyIGxvY2sobV93b3JrZXJEb2N1bWVudHNMb2Nr KTsKIApAQCAtMTU2LDcgKzE1Niw3IEBAIHZvaWQgU2hhcmVkV29ya2VyUHJveHk6OnBvc3RUYXNr VG9Mb2FkZXIoU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6VGFzayB0YXNrKQogICAgIGRvY3VtZW50 LT5wb3N0VGFzayhzdGQ6Om1vdmUodGFzaykpOwogfQogCi1ib29sIFNoYXJlZFdvcmtlclByb3h5 Ojpwb3N0VGFza0Zvck1vZGVUb1dvcmtlckdsb2JhbFNjb3BlKFNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQ6OlRhc2sgdGFzaywgY29uc3QgU3RyaW5nJiBtb2RlKQorYm9vbCBTaGFyZWRXb3JrZXJQcm94 eTo6cG9zdFRhc2tGb3JNb2RlVG9Xb3JrZXJHbG9iYWxTY29wZShTY3JpcHRFeGVjdXRpb25Db250 ZXh0OjpUYXNrJiYgdGFzaywgY29uc3QgU3RyaW5nJiBtb2RlKQogewogICAgIGlmIChpc0Nsb3Np bmcoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv d29ya2Vycy9Xb3JrZXJHbG9iYWxTY29wZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dv cmtlckdsb2JhbFNjb3BlLmNwcAppbmRleCBhYmJjNTU2ZWM4ZWQzNTEyZDBhN2I2ZGVkYTY2M2Uz NDY3ZmY5MDllLi4zNTgzNWQzYTgyOTU4OWM0MGJkNjQ5YTVlYjhmMWQ4NmE3ZDYyYjZjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckdsb2JhbFNjb3BlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckdsb2JhbFNjb3BlLmNwcApAQCAtMTQ3LDcg KzE0Nyw3IEBAIFdvcmtlck5hdmlnYXRvciogV29ya2VyR2xvYmFsU2NvcGU6Om5hdmlnYXRvcigp IGNvbnN0CiAgICAgcmV0dXJuIG1fbmF2aWdhdG9yLmdldCgpOwogfQogCi12b2lkIFdvcmtlckds b2JhbFNjb3BlOjpwb3N0VGFzayhUYXNrIHRhc2spCit2b2lkIFdvcmtlckdsb2JhbFNjb3BlOjpw b3N0VGFzayhUYXNrJiYgdGFzaykKIHsKICAgICB0aHJlYWQoKS5ydW5Mb29wKCkucG9zdFRhc2so c3RkOjptb3ZlKHRhc2spKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv V29ya2VyR2xvYmFsU2NvcGUuaCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyR2xvYmFs U2NvcGUuaAppbmRleCA5YmQ4OTllM2Y4MjY4MDQ5ODA0MWMxZmY0OTAxOTAxYzE4NzcxMDlmLi4x ZmUwOGU5NTRjZDQ0ZTk1ODBlZThmODNjMjhkOTc5NjNkNjZlMjhlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckdsb2JhbFNjb3BlLmgKKysrIGIvU291cmNlL1dlYkNv cmUvd29ya2Vycy9Xb3JrZXJHbG9iYWxTY29wZS5oCkBAIC03OCw3ICs3OCw3IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAogICAgICAgICB1c2luZyBTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpoYXNQ ZW5kaW5nQWN0aXZpdHk7CiAKLSAgICAgICAgdmlydHVhbCB2b2lkIHBvc3RUYXNrKFRhc2spIG92 ZXJyaWRlOyAvLyBFeGVjdXRlcyB0aGUgdGFzayBvbiBjb250ZXh0J3MgdGhyZWFkIGFzeW5jaHJv bm91c2x5LgorICAgICAgICB2aXJ0dWFsIHZvaWQgcG9zdFRhc2soVGFzayYmKSBvdmVycmlkZTsg Ly8gRXhlY3V0ZXMgdGhlIHRhc2sgb24gY29udGV4dCdzIHRocmVhZCBhc3luY2hyb25vdXNseS4K IAogICAgICAgICAvLyBXb3JrZXJHbG9iYWxTY29wZQogICAgICAgICBXb3JrZXJHbG9iYWxTY29w ZSogc2VsZigpIHsgcmV0dXJuIHRoaXM7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dv cmtlcnMvV29ya2VyTG9hZGVyUHJveHkuaCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2Vy TG9hZGVyUHJveHkuaAppbmRleCA2ZWQzNTg3NmZkNTY5Yzk4YTY2YzhlZTA1MjQzYWFjOTU4MDk2 ODZjLi4zNTM0ZTlmNjQxYTVkMzE4M2Y2ZmZmNzQ1OGZiNDQ3ZjNiOTM3MjA0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckxvYWRlclByb3h5LmgKKysrIGIvU291cmNl L1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJMb2FkZXJQcm94eS5oCkBAIC00NiwxMiArNDYsMTIgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2aXJ0dWFsIH5Xb3JrZXJMb2FkZXJQcm94eSgp IHsgfQogCiAgICAgICAgIC8vIFBvc3RzIGEgdGFzayB0byB0aGUgdGhyZWFkIHdoaWNoIHJ1bnMg dGhlIGxvYWRpbmcgY29kZSAobm9ybWFsbHksIHRoZSBtYWluIHRocmVhZCkuCi0gICAgICAgIHZp cnR1YWwgdm9pZCBwb3N0VGFza1RvTG9hZGVyKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2sp ID0gMDsKKyAgICAgICAgdmlydHVhbCB2b2lkIHBvc3RUYXNrVG9Mb2FkZXIoU2NyaXB0RXhlY3V0 aW9uQ29udGV4dDo6VGFzayYmKSA9IDA7CiAKICAgICAgICAgLy8gUG9zdHMgY2FsbGJhY2tzIGZy b20gbG9hZGluZyBjb2RlIHRvIHRoZSBXb3JrZXJHbG9iYWxTY29wZS4gVGhlICdtb2RlJyBpcyB1 c2VkIHRvIGRpZmZlcmVudGlhdGUKICAgICAgICAgLy8gc3BlY2lmaWMgc3luY2hyb25vdXMgbG9h ZGluZyByZXF1ZXN0cyBzbyB0aGV5IGNhbiBiZSAnbmVzdGVkJywgcGVyIHNwZWMuCiAgICAgICAg IC8vIFJldHVybnMgdHJ1ZSBpZiB0aGUgdGFzayB3YXMgcG9zdGVkIHN1Y2Nlc3NmdWxseS4KLSAg ICAgICAgdmlydHVhbCBib29sIHBvc3RUYXNrRm9yTW9kZVRvV29ya2VyR2xvYmFsU2NvcGUoU2Ny aXB0RXhlY3V0aW9uQ29udGV4dDo6VGFzaywgY29uc3QgU3RyaW5nJiBtb2RlKSA9IDA7CisgICAg ICAgIHZpcnR1YWwgYm9vbCBwb3N0VGFza0Zvck1vZGVUb1dvcmtlckdsb2JhbFNjb3BlKFNjcmlw dEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2smJiwgY29uc3QgU3RyaW5nJiBtb2RlKSA9IDA7CiAgICAg fTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv d29ya2Vycy9Xb3JrZXJNZXNzYWdpbmdQcm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJz L1dvcmtlck1lc3NhZ2luZ1Byb3h5LmNwcAppbmRleCAwNzRmN2MwMjYyMDE4NTA5Y2MxNjA5ZjBi Y2YyMDQ3YWY4MWYwM2NlLi43OGFmYjNmNTE2ZjgyNmNiODcyNDc1MWM1YzFlNzFmYjhmZDY5MDRk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlck1lc3NhZ2luZ1Byb3h5 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlck1lc3NhZ2luZ1Byb3h5LmNw cApAQCAtMTI3LDcgKzEyNywxNCBAQCB2b2lkIFdvcmtlck1lc3NhZ2luZ1Byb3h5Ojpwb3N0TWVz c2FnZVRvV29ya2VyR2xvYmFsU2NvcGUoUGFzc1JlZlB0cjxTZXJpYWxpemVkUwogICAgICAgICBt X3F1ZXVlZEVhcmx5VGFza3MuYXBwZW5kKHN0ZDo6bWFrZV91bmlxdWU8U2NyaXB0RXhlY3V0aW9u Q29udGV4dDo6VGFzaz4oc3RkOjptb3ZlKHRhc2spKSk7CiB9CiAKLWJvb2wgV29ya2VyTWVzc2Fn aW5nUHJveHk6OnBvc3RUYXNrRm9yTW9kZVRvV29ya2VyR2xvYmFsU2NvcGUoU2NyaXB0RXhlY3V0 aW9uQ29udGV4dDo6VGFzayB0YXNrLCBjb25zdCBTdHJpbmcmIG1vZGUpCit2b2lkIFdvcmtlck1l c3NhZ2luZ1Byb3h5Ojpwb3N0VGFza1RvTG9hZGVyKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRh c2smJiB0YXNrKQoreworICAgIC8vIEZJWE1FOiBJbiBjYXNlIG9mIG5lc3RlZCB3b3JrZXJzLCB0 aGlzIHNob3VsZCBnbyBkaXJlY3RseSB0byB0aGUgcm9vdCBEb2N1bWVudCBjb250ZXh0LgorICAg IEFTU0VSVChtX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQtPmlzRG9jdW1lbnQoKSk7CisgICAgbV9z Y3JpcHRFeGVjdXRpb25Db250ZXh0LT5wb3N0VGFzayhzdGQ6Om1vdmUodGFzaykpOworfQorCiti b29sIFdvcmtlck1lc3NhZ2luZ1Byb3h5Ojpwb3N0VGFza0Zvck1vZGVUb1dvcmtlckdsb2JhbFNj b3BlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2smJiB0YXNrLCBjb25zdCBTdHJpbmcmIG1v ZGUpCiB7CiAgICAgaWYgKG1fYXNrZWRUb1Rlcm1pbmF0ZSkKICAgICAgICAgcmV0dXJuIGZhbHNl OwpAQCAtMTM3LDEzICsxNDQsNiBAQCBib29sIFdvcmtlck1lc3NhZ2luZ1Byb3h5Ojpwb3N0VGFz a0Zvck1vZGVUb1dvcmtlckdsb2JhbFNjb3BlKFNjcmlwdEV4ZWN1dGlvbkNvbgogICAgIHJldHVy biB0cnVlOwogfQogCi12b2lkIFdvcmtlck1lc3NhZ2luZ1Byb3h5Ojpwb3N0VGFza1RvTG9hZGVy KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2sgdGFzaykKLXsKLSAgICAvLyBGSVhNRTogSW4g Y2FzZSBvZiBuZXN0ZWQgd29ya2VycywgdGhpcyBzaG91bGQgZ28gZGlyZWN0bHkgdG8gdGhlIHJv b3QgRG9jdW1lbnQgY29udGV4dC4KLSAgICBBU1NFUlQobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0 LT5pc0RvY3VtZW50KCkpOwotICAgIG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+cG9zdFRhc2so c3RkOjptb3ZlKHRhc2spKTsKLX0KLQogdm9pZCBXb3JrZXJNZXNzYWdpbmdQcm94eTo6cG9zdEV4 Y2VwdGlvblRvV29ya2VyT2JqZWN0KGNvbnN0IFN0cmluZyYgZXJyb3JNZXNzYWdlLCBpbnQgbGlu ZU51bWJlciwgaW50IGNvbHVtbk51bWJlciwgY29uc3QgU3RyaW5nJiBzb3VyY2VVUkwpCiB7CiAg ICAgU3RyaW5nIGVycm9yTWVzc2FnZUNvcHkgPSBlcnJvck1lc3NhZ2UuaXNvbGF0ZWRDb3B5KCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlck1lc3NhZ2luZ1Byb3h5 LmggYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlck1lc3NhZ2luZ1Byb3h5LmgKaW5kZXgg MzEyMGQ5YjQ5ZTk0ZTA2OWUzNzI4MjRlN2RmYTFlMDQ5N2EyYjM0Yy4uNDkzMTM0MmNkZDNkYmYw NzFkNzk3ODM2NDU3ZThhYTYxYTc5YzRkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29y a2Vycy9Xb3JrZXJNZXNzYWdpbmdQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv V29ya2VyTWVzc2FnaW5nUHJveHkuaApAQCAtNzksOCArNzksOCBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAgICAgICAgIC8vIEltcGxlbWVudGF0aW9uIG9mIFdvcmtlckxvYWRlclByb3h5LgogICAg ICAgICAvLyBUaGVzZSBtZXRob2RzIGFyZSBjYWxsZWQgb24gZGlmZmVyZW50IHRocmVhZHMgdG8g c2NoZWR1bGUgbG9hZGluZwogICAgICAgICAvLyByZXF1ZXN0cyBhbmQgdG8gc2VuZCBjYWxsYmFj a3MgYmFjayB0byBXb3JrZXJHbG9iYWxTY29wZS4KLSAgICAgICAgdmlydHVhbCB2b2lkIHBvc3RU YXNrVG9Mb2FkZXIoU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6VGFzaykgb3ZlcnJpZGU7Ci0gICAg ICAgIHZpcnR1YWwgYm9vbCBwb3N0VGFza0Zvck1vZGVUb1dvcmtlckdsb2JhbFNjb3BlKFNjcmlw dEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2ssIGNvbnN0IFN0cmluZyYgbW9kZSkgb3ZlcnJpZGU7Cisg ICAgICAgIHZpcnR1YWwgdm9pZCBwb3N0VGFza1RvTG9hZGVyKFNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQ6OlRhc2smJikgb3ZlcnJpZGU7CisgICAgICAgIHZpcnR1YWwgYm9vbCBwb3N0VGFza0Zvck1v ZGVUb1dvcmtlckdsb2JhbFNjb3BlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2smJiwgY29u c3QgU3RyaW5nJiBtb2RlKSBvdmVycmlkZTsKIAogICAgICAgICB2b2lkIHdvcmtlclRocmVhZENy ZWF0ZWQoUGFzc1JlZlB0cjxEZWRpY2F0ZWRXb3JrZXJUaHJlYWQ+KTsKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJSdW5Mb29wLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3dvcmtlcnMvV29ya2VyUnVuTG9vcC5jcHAKaW5kZXggMmE4ODUyZmJlNDAyMjJkMTA4NGQ3OTdi N2U0Yjc2MTBiMDlhMWQ5NS4uZjI5YjAwZWFjNmQ2MWViMzQ5ZGEwMGY4NmU5NzVmYmYxODVmZDk0 YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJSdW5Mb29wLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlclJ1bkxvb3AuY3BwCkBAIC0xOTIsMjIg KzE5MiwyMiBAQCB2b2lkIFdvcmtlclJ1bkxvb3A6OnRlcm1pbmF0ZSgpCiAgICAgbV9tZXNzYWdl UXVldWUua2lsbCgpOwogfQogCi12b2lkIFdvcmtlclJ1bkxvb3A6OnBvc3RUYXNrKFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQ6OlRhc2sgdGFzaykKK3ZvaWQgV29ya2VyUnVuTG9vcDo6cG9zdFRhc2so U2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6VGFzayYmIHRhc2spCiB7CiAgICAgcG9zdFRhc2tGb3JN b2RlKHN0ZDo6bW92ZSh0YXNrKSwgZGVmYXVsdE1vZGUoKSk7CiB9CiAKLXZvaWQgV29ya2VyUnVu TG9vcDo6cG9zdFRhc2tBbmRUZXJtaW5hdGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6VGFzayB0 YXNrKQordm9pZCBXb3JrZXJSdW5Mb29wOjpwb3N0VGFza0FuZFRlcm1pbmF0ZShTY3JpcHRFeGVj dXRpb25Db250ZXh0OjpUYXNrJiYgdGFzaykKIHsKICAgICBtX21lc3NhZ2VRdWV1ZS5hcHBlbmRB bmRLaWxsKFRhc2s6OmNyZWF0ZShzdGQ6Om1vdmUodGFzayksIGRlZmF1bHRNb2RlKCkuaXNvbGF0 ZWRDb3B5KCkpKTsKIH0KIAotdm9pZCBXb3JrZXJSdW5Mb29wOjpwb3N0VGFza0Zvck1vZGUoU2Ny aXB0RXhlY3V0aW9uQ29udGV4dDo6VGFzayB0YXNrLCBjb25zdCBTdHJpbmcmIG1vZGUpCit2b2lk IFdvcmtlclJ1bkxvb3A6OnBvc3RUYXNrRm9yTW9kZShTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpU YXNrJiYgdGFzaywgY29uc3QgU3RyaW5nJiBtb2RlKQogewogICAgIG1fbWVzc2FnZVF1ZXVlLmFw cGVuZChUYXNrOjpjcmVhdGUoc3RkOjptb3ZlKHRhc2spLCBtb2RlLmlzb2xhdGVkQ29weSgpKSk7 CiB9CiAKLXN0ZDo6dW5pcXVlX3B0cjxXb3JrZXJSdW5Mb29wOjpUYXNrPiBXb3JrZXJSdW5Mb29w OjpUYXNrOjpjcmVhdGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6VGFzayB0YXNrLCBjb25zdCBT dHJpbmcmIG1vZGUpCitzdGQ6OnVuaXF1ZV9wdHI8V29ya2VyUnVuTG9vcDo6VGFzaz4gV29ya2Vy UnVuTG9vcDo6VGFzazo6Y3JlYXRlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2smJiB0YXNr LCBjb25zdCBTdHJpbmcmIG1vZGUpCiB7CiAgICAgcmV0dXJuIHN0ZDo6dW5pcXVlX3B0cjxUYXNr PihuZXcgVGFzayhzdGQ6Om1vdmUodGFzayksIG1vZGUpKTsKIH0KQEAgLTIxOCw3ICsyMTgsNyBA QCB2b2lkIFdvcmtlclJ1bkxvb3A6OlRhc2s6OnBlcmZvcm1UYXNrKGNvbnN0IFdvcmtlclJ1bkxv b3AmIHJ1bkxvb3AsIFNjcmlwdEV4ZWN1dAogICAgICAgICBtX3Rhc2sucGVyZm9ybVRhc2soY29u dGV4dCk7CiB9CiAKLVdvcmtlclJ1bkxvb3A6OlRhc2s6OlRhc2soU2NyaXB0RXhlY3V0aW9uQ29u dGV4dDo6VGFzayB0YXNrLCBjb25zdCBTdHJpbmcmIG1vZGUpCitXb3JrZXJSdW5Mb29wOjpUYXNr OjpUYXNrKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2smJiB0YXNrLCBjb25zdCBTdHJpbmcm IG1vZGUpCiAgICAgOiBtX3Rhc2soc3RkOjptb3ZlKHRhc2spKQogICAgICwgbV9tb2RlKG1vZGUu aXNvbGF0ZWRDb3B5KCkpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dv cmtlclJ1bkxvb3AuaCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyUnVuTG9vcC5oCmlu ZGV4IDc2YTQ2ZjIxNDI0NjNiMTdkYTY1YzU4YzFlNmUxOGNiMjQwOTcwOWEuLjliNDczMDJhYzFl ZTkxYTA3YzBkNjYzYTRhYTQwNDEyM2IyZGJkMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3dvcmtlcnMvV29ya2VyUnVuTG9vcC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29y a2VyUnVuTG9vcC5oCkBAIC01Nyw5ICs1Nyw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgdm9pZCB0ZXJtaW5hdGUoKTsKICAgICAgICAgYm9vbCB0ZXJtaW5hdGVkKCkgY29uc3QgeyBy ZXR1cm4gbV9tZXNzYWdlUXVldWUua2lsbGVkKCk7IH0KIAotICAgICAgICB2b2lkIHBvc3RUYXNr KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2spOwotICAgICAgICB2b2lkIHBvc3RUYXNrQW5k VGVybWluYXRlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2spOwotICAgICAgICB2b2lkIHBv c3RUYXNrRm9yTW9kZShTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpUYXNrLCBjb25zdCBTdHJpbmcm IG1vZGUpOworICAgICAgICB2b2lkIHBvc3RUYXNrKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRh c2smJik7CisgICAgICAgIHZvaWQgcG9zdFRhc2tBbmRUZXJtaW5hdGUoU2NyaXB0RXhlY3V0aW9u Q29udGV4dDo6VGFzayYmKTsKKyAgICAgICAgdm9pZCBwb3N0VGFza0Zvck1vZGUoU2NyaXB0RXhl Y3V0aW9uQ29udGV4dDo6VGFzayYmLCBjb25zdCBTdHJpbmcmIG1vZGUpOwogCiAgICAgICAgIHVu c2lnbmVkIGxvbmcgY3JlYXRlVW5pcXVlSWQoKSB7IHJldHVybiArK21fdW5pcXVlSWQ7IH0KIApA QCAtNjgsMTMgKzY4LDEzIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgY2xhc3MgVGFz ayB7CiAgICAgICAgICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShUYXNrKTsgV1RGX01BS0VfRkFT VF9BTExPQ0FURUQ7CiAgICAgICAgIHB1YmxpYzoKLSAgICAgICAgICAgIHN0YXRpYyBzdGQ6OnVu aXF1ZV9wdHI8VGFzaz4gY3JlYXRlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2ssIGNvbnN0 IFN0cmluZyYgbW9kZSk7CisgICAgICAgICAgICBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPFRhc2s+ IGNyZWF0ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpUYXNrJiYsIGNvbnN0IFN0cmluZyYgbW9k ZSk7CiAgICAgICAgICAgICB+VGFzaygpIHsgfQogICAgICAgICAgICAgY29uc3QgU3RyaW5nJiBt b2RlKCkgY29uc3QgeyByZXR1cm4gbV9tb2RlOyB9CiAgICAgICAgICAgICB2b2lkIHBlcmZvcm1U YXNrKGNvbnN0IFdvcmtlclJ1bkxvb3AmLCBTY3JpcHRFeGVjdXRpb25Db250ZXh0Kik7CiAKICAg ICAgICAgcHJpdmF0ZToKLSAgICAgICAgICAgIFRhc2soU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6 VGFzayB0YXNrLCBjb25zdCBTdHJpbmcmIG1vZGUpOworICAgICAgICAgICAgVGFzayhTY3JpcHRF eGVjdXRpb25Db250ZXh0OjpUYXNrJiYsIGNvbnN0IFN0cmluZyYgbW9kZSk7CiAgICAgICAgIAog ICAgICAgICAgICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6VGFzayBtX3Rhc2s7CiAgICAgICAg ICAgICBTdHJpbmcgbV9tb2RlOwo=