133599 2014-06-06 20:28:55 -0700 Document::updateStyleIfNeededForNode can get very expensive 2014-06-09 16:30:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 benjamin benjamin commit-queue esprehn+autocc kangil.han kling koivisto oldest_to_newest 1013916 0 benjamin 2014-06-06 20:28:55 -0700 Document::updateStyleIfNeededForNode can get very expensive 1013917 1 232646 benjamin 2014-06-06 20:38:35 -0700 Created attachment 232646 Patch 1013920 2 benjamin 2014-06-06 20:39:57 -0700 <rdar://problem/17209984> 1014034 3 232687 benjamin 2014-06-08 14:44:50 -0700 Created attachment 232687 Patch 1014272 4 232687 benjamin 2014-06-09 16:30:23 -0700 Comment on attachment 232687 Patch Clearing flags on attachment: 232687 Committed r169729: <http://trac.webkit.org/changeset/169729> 1014273 5 benjamin 2014-06-09 16:30:27 -0700 All reviewed patches have been landed. Closing bug. 232646 2014-06-06 20:38:35 -0700 2014-06-08 14:44:46 -0700 Patch bug-133599-20140606203808.patch text/plain 2672 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNmMGVjOWI4YjhhODE5 NmIzNTRiZWUwNWY0YjczMGY1NWVlMDg0MS4uMWZhYWMxZTZmMzVkNDEyY2RkN2Y4YzlkMDYyNTQy NzA0NDhlZThiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDE0LTA2LTA2ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCisgICAgICAgIERvY3VtZW50Ojp1 cGRhdGVTdHlsZUlmTmVlZGVkRm9yTm9kZSBjYW4gZ2V0IHZlcnkgZXhwZW5zaXZlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM1OTkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHBhZ2VzIGFyZSBx dWVyeWluZyB0aGVpciBzdHlsZSwgd2UgZmlyc3QgcnVuIHRocm91Z2gKKyAgICAgICAgRG9jdW1l bnQ6OnVwZGF0ZVN0eWxlSWZOZWVkZWRGb3JOb2RlKCkgdG8gZmluZCBpZiB0aGF0IHBhcnRpY3Vs YXIgbm9kZSBuZWVkcyBzdHlsZSByZWNhbGMuCisKKyAgICAgICAgVGhlIHByb2JsZW0gd2FzIHRo YXQgdXBkYXRlU3R5bGVJZk5lZWRlZEZvck5vZGUoKSBjb3VsZCBnZXQgcmVhbGx5IGV4cGVuc2l2 ZS4gRm9yIGVhY2ggbm9kZSwKKyAgICAgICAgaXQgbmVlZHMgdG8gY2hlY2sgdGhlIHdob2xlIHBh cmVudCBjaGFpbiB0byBmaW5kIGlmIGFueSBuZWVkcyBzdHlsZSByZWNhbGMuCisgICAgICAgIFdo ZW4gd2ViIHBhZ2VzIGdldCBhIGJ1bmNoIG9mIG5vZGVzIGFuZCBxdWVyeWluZyB0aGVpciBzdHls ZSwgd2UgZW5kZWQgdXAgZ29pbmcgb3ZlciBhIGxvdAorICAgICAgICBvZiBub2RlcyBqdXN0IHRv IGZpbmQgdGhlcmUgaXMgbm90aGluZyB0byBkby4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMg dHdvIHR3ZWFrcyB0byByZWR1Y2UgdGhlIHByb2JsZW06CisgICAgICAgIEZpcnN0LCBiZWZvcmUg cXVlcnlpbmcgbm9kZU9ySXRzQW5jZXN0b3JOZWVkc1N0eWxlUmVjYWxjKCkgd2UgY2hlY2sgaWYg dGhlIERvY3VtZW50IGlzIGRpcnR5IGF0IGFsbC4KKyAgICAgICAgVGhlIG90aGVyIHBhcnQgaXMg bWFraW5nIG5vZGVPckl0c0FuY2VzdG9yTmVlZHNTdHlsZVJlY2FsYygpIGZhc3RlciBieSByZW1v dmluZyB1c2VsZXNzIGVsZW1lbnRzIGNoZWNrLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Om5vZGVPckl0c0FuY2VzdG9yTmVlZHNTdHlsZVJlY2FsYyk6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlU3R5bGVJZk5lZWRlZEZvck5vZGUp OgorCisyMDE0LTA2LTA2ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgor CiAgICAgICAgIEltcHJvdmUgQ1NTUHJpbWl0aXZlVmFsdWU6OmN1c3RvbUNTU1RleHQgZm9yIEFS TXY3CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM1 OTcKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggMDBjOWZiNzBlZDY1ZGU5MThkODFkNmQ1 ZDNhNTA1MGEzODY3NmJiMC4uYjkwYzkyYmUyNTM4Y2Q3ZGNlOTZkNmEwMjM3YjJjZWZlNWZkN2M1 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC02MTExLDcgKzYxMTEsNyBAQCBib29sIERv Y3VtZW50Ojp1bndyYXBDcnlwdG9LZXkoY29uc3QgVmVjdG9yPHVpbnQ4X3Q+JiB3cmFwcGVkS2V5 LCBWZWN0b3I8dWludDhfdAogCiBzdGF0aWMgaW5saW5lIGJvb2wgbm9kZU9ySXRzQW5jZXN0b3JO ZWVkc1N0eWxlUmVjYWxjKGNvbnN0IE5vZGUmIG5vZGUpCiB7Ci0gICAgZm9yIChjb25zdCBOb2Rl KiBuID0gJm5vZGU7IG47IG4gPSBuLT5wYXJlbnRPclNoYWRvd0hvc3RFbGVtZW50KCkpIHsKKyAg ICBmb3IgKGNvbnN0IE5vZGUqIG4gPSAmbm9kZTsgbjsgbiA9IG4tPnBhcmVudE9yU2hhZG93SG9z dE5vZGUoKSkgewogICAgICAgICBpZiAobi0+bmVlZHNTdHlsZVJlY2FsYygpKQogICAgICAgICAg ICAgcmV0dXJuIHRydWU7CiAgICAgfQpAQCAtNjEyMCw3ICs2MTIwLDcgQEAgc3RhdGljIGlubGlu ZSBib29sIG5vZGVPckl0c0FuY2VzdG9yTmVlZHNTdHlsZVJlY2FsYyhjb25zdCBOb2RlJiBub2Rl KQogCiBib29sIERvY3VtZW50Ojp1cGRhdGVTdHlsZUlmTmVlZGVkRm9yTm9kZShjb25zdCBOb2Rl JiBub2RlKQogewotICAgIGlmICghaGFzUGVuZGluZ0ZvcmNlZFN0eWxlUmVjYWxjKCkgJiYgIW5v ZGVPckl0c0FuY2VzdG9yTmVlZHNTdHlsZVJlY2FsYyhub2RlKSkKKyAgICBpZiAoIWhhc1BlbmRp bmdGb3JjZWRTdHlsZVJlY2FsYygpICYmICEoY2hpbGROZWVkc1N0eWxlUmVjYWxjKCkgJiYgbm9k ZU9ySXRzQW5jZXN0b3JOZWVkc1N0eWxlUmVjYWxjKG5vZGUpKQogICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgdXBkYXRlU3R5bGVJZk5lZWRlZCgpOwogICAgIHJldHVybiB0cnVlOwo= 232687 2014-06-08 14:44:50 -0700 2014-06-09 16:30:23 -0700 Patch bug-133599-20140608144426.patch text/plain 2627 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDEzYjczOGY2MTFmNTlk ODdjMTBlMmM0YTI4ODk4YWVkZTU4ZWRkMS4uNjRjNzVjNjE5MjU0MTM1M2E2NDQxYzM2YTFlZDBk ZjU4MDRmMzdjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA2LTA4ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIERvY3VtZW50Ojp1 cGRhdGVTdHlsZUlmTmVlZGVkRm9yTm9kZSBjYW4gZ2V0IHZlcnkgZXhwZW5zaXZlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM1OTkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHBhZ2VzIGFyZSBx dWVyeWluZyB0aGVpciBzdHlsZSwgd2UgZmlyc3QgcnVuIHRocm91Z2gKKyAgICAgICAgRG9jdW1l bnQ6OnVwZGF0ZVN0eWxlSWZOZWVkZWRGb3JOb2RlKCkgdG8gZmluZCBpZiB0aGF0IHBhcnRpY3Vs YXIgbm9kZSBuZWVkcyBzdHlsZSByZWNhbGMuCisKKyAgICAgICAgVGhlIHByb2JsZW0gd2FzIHRo YXQgdXBkYXRlU3R5bGVJZk5lZWRlZEZvck5vZGUoKSBjb3VsZCBnZXQgcmVhbGx5IGV4cGVuc2l2 ZS4gRm9yIGVhY2ggbm9kZSwKKyAgICAgICAgaXQgbmVlZHMgdG8gY2hlY2sgdGhlIHdob2xlIHBh cmVudCBjaGFpbiB0byBmaW5kIGlmIGFueSBuZWVkcyBzdHlsZSByZWNhbGMuCisgICAgICAgIFdo ZW4gd2ViIHBhZ2VzIGdldCBhIGJ1bmNoIG9mIG5vZGVzIGFuZCBxdWVyeWluZyB0aGVpciBzdHls ZSwgd2UgZW5kZWQgdXAgZ29pbmcgb3ZlciBhIGxvdAorICAgICAgICBvZiBub2RlcyBqdXN0IHRv IGZpbmQgdGhlcmUgaXMgbm90aGluZyB0byBkby4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMg dHdvIHR3ZWFrcyB0byByZWR1Y2UgdGhlIHByb2JsZW06CisgICAgICAgIEZpcnN0LCBiZWZvcmUg cXVlcnlpbmcgbm9kZU9ySXRzQW5jZXN0b3JOZWVkc1N0eWxlUmVjYWxjKCkgd2UgY2hlY2sgaWYg dGhlIERvY3VtZW50IGlzIGRpcnR5IGF0IGFsbC4KKyAgICAgICAgVGhlIG90aGVyIHBhcnQgaXMg bWFraW5nIG5vZGVPckl0c0FuY2VzdG9yTmVlZHNTdHlsZVJlY2FsYygpIGZhc3RlciBieSByZW1v dmluZyB1c2VsZXNzIGVsZW1lbnRzIGNoZWNrLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Om5vZGVPckl0c0FuY2VzdG9yTmVlZHNTdHlsZVJlY2FsYyk6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlU3R5bGVJZk5lZWRlZEZvck5vZGUp OgorCiAyMDE0LTA2LTA4ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4K IAogICAgICAgICBSZWR1Y2UgdGhlIG92ZXJoZWFkIG9mIHVwZGF0aW5nIHRoZSBhbmltYXRhYmxl IHN0eWxlIG9uIEFSTXY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCAwMGM5ZmI3MGVkNjVk ZTkxOGQ4MWQ2ZDVkM2E1MDUwYTM4Njc2YmIwLi41ZmY4NDFiZTJkZDU2MTE3MTQzNTAzZDFiMmRj MjczNjM4YjNhYTEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTYxMTEsNyArNjExMSw3 IEBAIGJvb2wgRG9jdW1lbnQ6OnVud3JhcENyeXB0b0tleShjb25zdCBWZWN0b3I8dWludDhfdD4m IHdyYXBwZWRLZXksIFZlY3Rvcjx1aW50OF90CiAKIHN0YXRpYyBpbmxpbmUgYm9vbCBub2RlT3JJ dHNBbmNlc3Rvck5lZWRzU3R5bGVSZWNhbGMoY29uc3QgTm9kZSYgbm9kZSkKIHsKLSAgICBmb3Ig KGNvbnN0IE5vZGUqIG4gPSAmbm9kZTsgbjsgbiA9IG4tPnBhcmVudE9yU2hhZG93SG9zdEVsZW1l bnQoKSkgeworICAgIGZvciAoY29uc3QgTm9kZSogbiA9ICZub2RlOyBuOyBuID0gbi0+cGFyZW50 T3JTaGFkb3dIb3N0Tm9kZSgpKSB7CiAgICAgICAgIGlmIChuLT5uZWVkc1N0eWxlUmVjYWxjKCkp CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CkBAIC02MTIwLDcgKzYxMjAsNyBAQCBz dGF0aWMgaW5saW5lIGJvb2wgbm9kZU9ySXRzQW5jZXN0b3JOZWVkc1N0eWxlUmVjYWxjKGNvbnN0 IE5vZGUmIG5vZGUpCiAKIGJvb2wgRG9jdW1lbnQ6OnVwZGF0ZVN0eWxlSWZOZWVkZWRGb3JOb2Rl KGNvbnN0IE5vZGUmIG5vZGUpCiB7Ci0gICAgaWYgKCFoYXNQZW5kaW5nRm9yY2VkU3R5bGVSZWNh bGMoKSAmJiAhbm9kZU9ySXRzQW5jZXN0b3JOZWVkc1N0eWxlUmVjYWxjKG5vZGUpKQorICAgIGlm ICghaGFzUGVuZGluZ0ZvcmNlZFN0eWxlUmVjYWxjKCkgJiYgIShjaGlsZE5lZWRzU3R5bGVSZWNh bGMoKSAmJiBub2RlT3JJdHNBbmNlc3Rvck5lZWRzU3R5bGVSZWNhbGMobm9kZSkpKQogICAgICAg ICByZXR1cm4gZmFsc2U7CiAgICAgdXBkYXRlU3R5bGVJZk5lZWRlZCgpOwogICAgIHJldHVybiB0 cnVlOwo=