133591 2014-06-06 16:57:36 -0700 advanceByCombiningCharacterSequence() can be simplified 2014-06-25 19:34:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield commit-queue webkit-bug-importer oldest_to_newest 1013886 0 mmaxfield 2014-06-06 16:57:36 -0700 It can use U16_NEXT() instead. 1017824 1 233673 mmaxfield 2014-06-23 20:15:49 -0700 Created attachment 233673 Patch 1017825 2 webkit-bug-importer 2014-06-23 20:19:32 -0700 <rdar://problem/17430091> 1018167 3 233673 commit-queue 2014-06-24 16:32:56 -0700 Comment on attachment 233673 Patch Clearing flags on attachment: 233673 Committed r170402: <http://trac.webkit.org/changeset/170402> 1018168 4 commit-queue 2014-06-24 16:32:59 -0700 All reviewed patches have been landed. Closing bug. 1018491 5 233673 darin 2014-06-25 19:34:08 -0700 Comment on attachment 233673 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233673&action=review > Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:275 > + if (U16_IS_SURROGATE(baseCharacter)) Technically this is incorrect. Since the argument is a UChar32, it should just be U_IS_SURROGATE. But in practice this will work since U16_IS_SURROGATE just calls U_IS_SURROGATE. 233673 2014-06-23 20:15:49 -0700 2014-06-25 19:34:08 -0700 Patch bug-133591-20140623201528.patch text/plain 1986 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmU1NzY5OWMzZGQxODQz YjZhYWM3YTc2ZDA0ZTRkYzZiMjIwMjVmZi4uYzI4YzA3NTgyMDc1NzBkYzQxYzAyOWJhZmZhOWJk YzZiYjBlNmVjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA2LTIzICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgYWR2YW5jZUJ5 Q29tYmluaW5nQ2hhcmFjdGVyU2VxdWVuY2UoKSBjYW4gYmUgc2ltcGxpZmllZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzNTkxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIFUxNl9ORVhUKCkgYmVj YXVzZSBpdCBhbHJlYWR5IGRvZXMgd2hhdCB3ZSdyZSB0cnlpbmcgdG8gZG8uCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjphZHZhbmNlQnlDb21iaW5pbmdDaGFyYWN0ZXJTZXF1ZW5jZSk6CisK IDIwMTQtMDYtMjMgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CiAKICAg ICAgICAgW0FUS10gUmVtb3ZlIHNvbWUgdW5uZWNlc3NhcnkgY29kZSBmcm9tIFdlYktpdEFjY2Vz c2libGVXcmFwcGVyQXRrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9tYWMvQ29tcGxleFRleHRDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRyb2xsZXIuY3BwCmluZGV4IDQyYTk3MWM2 NDUyYjViNjU5NzAzYTdmOGVlOTY4YWZmNDgyZjgxYjMuLjNjYzQ0YzIwMWVjZDE2NDllMmM5YmMy ZGM3ZDk2YzMzZjJkODRkYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRyb2xsZXIuY3BwCkBAIC0yNjgs MTggKzI2OCwxMiBAQCBzdGF0aWMgYm9vbCBhZHZhbmNlQnlDb21iaW5pbmdDaGFyYWN0ZXJTZXF1 ZW5jZShjb25zdCBVQ2hhciomIGl0ZXJhdG9yLCBjb25zdCBVQwogCiAgICAgbWFya0NvdW50ID0g MDsKIAotICAgIGJhc2VDaGFyYWN0ZXIgPSAqaXRlcmF0b3IrKzsKLQotICAgIGlmIChVMTZfSVNf U1VSUk9HQVRFKGJhc2VDaGFyYWN0ZXIpKSB7Ci0gICAgICAgIGlmICghVTE2X0lTX0xFQUQoYmFz ZUNoYXJhY3RlcikpCi0gICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgIGlmIChpdGVy YXRvciA9PSBlbmQpCi0gICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgIFVDaGFyIHRy YWlsID0gKml0ZXJhdG9yKys7Ci0gICAgICAgIGlmICghVTE2X0lTX1RSQUlMKHRyYWlsKSkKLSAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgYmFzZUNoYXJhY3RlciA9IFUxNl9HRVRf U1VQUExFTUVOVEFSWShiYXNlQ2hhcmFjdGVyLCB0cmFpbCk7Ci0gICAgfQorICAgIHVuc2lnbmVk IGkgPSAwOworICAgIFUxNl9ORVhUKGl0ZXJhdG9yLCBpLCBlbmQgLSBpdGVyYXRvciwgYmFzZUNo YXJhY3Rlcik7CisgICAgaXRlcmF0b3IgPSBpdGVyYXRvciArIGk7CisKKyAgICBpZiAoVTE2X0lT X1NVUlJPR0FURShiYXNlQ2hhcmFjdGVyKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAg Ly8gQ29uc3VtZSBtYXJrcy4KICAgICB3aGlsZSAoaXRlcmF0b3IgPCBlbmQpIHsK