133583 2014-06-06 14:27:02 -0700 Should boost ChildProcesses on iOS 2014-06-10 09:16:25 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 barraclough barraclough oldest_to_newest 1013851 0 barraclough 2014-06-06 14:27:02 -0700 . 1013852 1 232628 barraclough 2014-06-06 14:28:38 -0700 Created attachment 232628 Fix 1013853 2 barraclough 2014-06-06 14:28:55 -0700 rdar 17199785 1013855 3 232628 andersca 2014-06-06 14:38:48 -0700 Comment on attachment 232628 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=232628&action=review > Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:191 > +#if PLATFORM(IOS) > + // On iOS, leak a boost onto all child processes > + bool leakBoost = true; > +#elif ENABLE(NETWORK_PROCESS) > + // On Mac, leak a boost onto the NetworkProcess. > + bool leakBoost = launchOptions.processType == ProcessLauncher::NetworkProcess; > +#else > + bool leakBoost = false; > +#endif Please move this to a separate function, something like static bool shouldLeakBoost(const LaunchOptions&); 1013856 4 barraclough 2014-06-06 14:44:42 -0700 Transmitting file data .. Committed revision 169663. 1013858 5 barraclough 2014-06-06 14:49:31 -0700 Transmitting file data .. Committed revision 169663. 1014405 6 ddkilzer 2014-06-10 09:15:24 -0700 <rdar://problem/17199785> 1014406 7 ddkilzer 2014-06-10 09:16:25 -0700 <http://trac.webkit.org/changeset/169663> 232628 2014-06-06 14:28:38 -0700 2014-06-06 14:38:48 -0700 Fix 133583.1.patch text/plain 2187 barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTY2MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA2LTA2ICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIFNob3VsZCBib29z dCBDaGlsZFByb2Nlc3NlcyBvbiBpT1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMzU4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJN YWMubW06CisgICAgICAgIChXZWJLaXQ6OmNvbm5lY3RUb1NlcnZpY2UpOgorICAgICAgICAgICAg LSBib29zdCBhbGwgY2hpbGQgcHJvY2Vzc2VzIG9uIGlPUy4KKwogMjAxNC0wNi0wNiAgQWxleGV5 IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXggYWZ0ZXIg PGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE2OTY1NT4uCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NMYXVuY2hlck1hYy5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NM YXVuY2hlck1hYy5tbQkocmV2aXNpb24gMTY5NTc2KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW0JKHdvcmtpbmcgY29weSkKQEAg LTE3OSwxNiArMTc5LDIyIEBAIHN0YXRpYyB2b2lkIGNvbm5lY3RUb1NlcnZpY2UoY29uc3QgUHJv Y2UKICAgICAvLyBYUEMgcmVxdWlyZXMgaGF2aW5nIGFuIGV2ZW50IGhhbmRsZXIsIGV2ZW4gaWYg aXQgaXMgbm90IHVzZWQuCiAgICAgeHBjX2Nvbm5lY3Rpb25fc2V0X2V2ZW50X2hhbmRsZXIoY29u bmVjdGlvbi5nZXQoKSwgXih4cGNfb2JqZWN0X3QgZXZlbnQpIHsgfSk7CiAgICAgeHBjX2Nvbm5l Y3Rpb25fcmVzdW1lKGNvbm5lY3Rpb24uZ2V0KCkpOwotCi0jaWYgRU5BQkxFKE5FVFdPUktfUFJP Q0VTUykgJiYgIVBMQVRGT1JNKElPUykKLSAgICAvLyBMZWFrIGEgYm9vc3Qgb250byB0aGUgTmV0 d29ya1Byb2Nlc3MuCi0gICAgaWYgKGxhdW5jaE9wdGlvbnMucHJvY2Vzc1R5cGUgPT0gUHJvY2Vz c0xhdW5jaGVyOjpOZXR3b3JrUHJvY2VzcykgeworICAgIAorI2lmIFBMQVRGT1JNKElPUykKKyAg ICAvLyBPbiBpT1MsIGxlYWsgYSBib29zdCBvbnRvIGFsbCBjaGlsZCBwcm9jZXNzZXMKKyAgICBi b29sIGxlYWtCb29zdCA9IHRydWU7CisjZWxpZiBFTkFCTEUoTkVUV09SS19QUk9DRVNTKQorICAg IC8vIE9uIE1hYywgbGVhayBhIGJvb3N0IG9udG8gdGhlIE5ldHdvcmtQcm9jZXNzLgorICAgIGJv b2wgbGVha0Jvb3N0ID0gbGF1bmNoT3B0aW9ucy5wcm9jZXNzVHlwZSA9PSBQcm9jZXNzTGF1bmNo ZXI6Ok5ldHdvcmtQcm9jZXNzOworI2Vsc2UKKyAgICBib29sIGxlYWtCb29zdCA9IGZhbHNlOwor I2VuZGlmCisgICAgaWYgKGxlYWtCb29zdCkgewogICAgICAgICBhdXRvIHByZUJvb3RzdHJhcE1l c3NhZ2UgPSBJUEM6OmFkb3B0WFBDKHhwY19kaWN0aW9uYXJ5X2NyZWF0ZShudWxscHRyLCBudWxs cHRyLCAwKSk7CiAgICAgICAgIHhwY19kaWN0aW9uYXJ5X3NldF9zdHJpbmcocHJlQm9vdHN0cmFw TWVzc2FnZS5nZXQoKSwgIm1lc3NhZ2UtbmFtZSIsICJwcmUtYm9vdHN0cmFwIik7CiAgICAgICAg IHhwY19jb25uZWN0aW9uX3NlbmRfbWVzc2FnZShjb25uZWN0aW9uLmdldCgpLCBwcmVCb290c3Ry YXBNZXNzYWdlLmdldCgpKTsKICAgICB9Ci0jZW5kaWYKLQorICAgIAogICAgIC8vIENyZWF0ZSB0 aGUgbGlzdGVuaW5nIHBvcnQuCiAgICAgbWFjaF9wb3J0X3QgbGlzdGVuaW5nUG9ydDsKICAgICBt YWNoX3BvcnRfYWxsb2NhdGUobWFjaF90YXNrX3NlbGYoKSwgTUFDSF9QT1JUX1JJR0hUX1JFQ0VJ VkUsICZsaXN0ZW5pbmdQb3J0KTsK