133577 2014-06-06 09:59:19 -0700 In a certain app state, Array.prototype.filter() returns incorrect results 2014-06-10 11:00:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.9 RESOLVED FIXED http://jsbin.com/potewaye/13/edit?js,console InRadar P2 Normal --- 1 ryan msaboff benjamin mathias msaboff oliver oldest_to_newest 1013808 0 232618 ryan 2014-06-06 09:59:19 -0700 Created attachment 232618 Array.prototype.filter() bug test case The Router component in the YUI JS library somehow induces a certain state that temporarily causes Array.prototype.filter() to return incorrect results (an empty array instead of a correctly filtered array). I've been unable to track down the precise cause of this state, but it's at least consistently reproducible using the attached test case, which is also visible at http://jsbin.com/potewaye/13/edit?js,console The test succeeds in all browsers except Safari 8 on OS X Yosemite and recent WebKit nightlies (I tested 9537.76.4, r169635). I don't think the problem lies with YUI, since YUI's router has been in wide production use for several years and this problem only surfaced in these brand new WebKit builds. http://www.smugmug.com/ is one production website affected by this bug, but there are many others using the YUI Router, including various Yahoo sites. Steps to Reproduce: 1. Run the attached test case. Expected Results: Three separate arrays should be logged to the console demonstrating that Array.prototype.filter() is working properly: ["started"], ["finished"], and ["foo"]. Actual Results: In Safari 8 and WebKit 9537.76.4, r169635, the logged arrays are ["started"], ["finished"], and [], and you'll see the error message "Array.prototype.filter() failed!" indicating that Array.prototype.filter() returned incorrect results when run inside a YUI router callback. I also filed this as rdar://17186034 1013857 1 benjamin 2014-06-06 14:45:44 -0700 <rdar://problem/17186034> 1014132 2 msaboff 2014-06-09 10:31:59 -0700 Original radar - <rdar://problem/17019752> 1014305 3 232757 msaboff 2014-06-09 18:51:20 -0700 Created attachment 232757 Patch 1014333 4 232757 oliver 2014-06-09 21:17:13 -0700 Comment on attachment 232757 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232757&action=review > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1714 > + bieq ArrayStorage::m_vector + TagOffset[t0, t3, 8], EmptyValueTag, .opPutByValArrayStorageEmpty Could you add a test to make sure that we don't call setters or anything when doing a put by val direct on a hole? 1014437 5 232796 msaboff 2014-06-10 10:53:29 -0700 Created attachment 232796 Patch with updated test from comment 1014439 6 msaboff 2014-06-10 10:58:37 -0700 Committed r169751: <http://trac.webkit.org/changeset/169751> 1014440 7 232796 ggaren 2014-06-10 11:00:16 -0700 Comment on attachment 232796 Patch with updated test from comment r=me 232618 2014-06-06 09:59:19 -0700 2014-06-06 09:59:19 -0700 Array.prototype.filter() bug test case array-filter-bug.html text/html 1250 ryan PCFkb2N0eXBlIGh0bWw+CjxodG1sPgo8Ym9keT4KCjxwPgpQbGVhc2Ugb3BlbiB5b3VyIGJyb3dz ZXIgY29uc29sZSB0byB2aWV3IHRoaXMgdGVzdCdzIG91dHB1dC4KPC9wPgoKPHNjcmlwdCBzcmM9 Imh0dHA6Ly95dWkueWFob29hcGlzLmNvbS8zLjE3LjIvYnVpbGQveXVpL3l1aS1taW4uanMiPjwv c2NyaXB0PgoKPHNjcmlwdD4KLy8gVGhpcyBjb2RlIGRlbW9uc3RyYXRlcyBhIHN0cmFuZ2UgY2Fz ZSBpbiB3aGljaCBBcnJheS5wcm90b3R5cGUuZmlsdGVyKCkKLy8gcmV0dXJucyBpbmNvcnJlY3Qg cmVzdWx0cyBpbiBTYWZhcmkgOCBvbiBPUyBYIDEwLjEwIFlvc2VtaXRlLiBJdCB3b3JrcyBpbiBh bGwKLy8gb3RoZXIgYnJvd3NlcnMuCi8vCi8vIEkgd2lzaCBJIGNvdWxkIGJvaWwgdGhpcyBkb3du IHRvIGEgbW9yZSByZWR1Y2VkIHRlc3QgY2FzZSwgYnV0IHRoaXMgaXMgb25lCi8vIGNyYXp5IGhl aXNlbmJ1Zy4gVGhpcyBhbG1vc3QgY2VydGFpbmx5IGlzIG5vdCBhIFlVSSBidWcgdGhvdWdoLCBz aW5jZSB0aGlzCi8vIGNvZGUgd29ya3MgZmluZSBpbiBhbGwgb3RoZXIgYnJvd3NlcnMgYW5kIFlV SSdzIHJvdXRlciBoYXMgYmVlbiBpbiB3aWRlCi8vIHByb2R1Y3Rpb24gdXNlIGZvciB5ZWFycy4K Ly8KLy8gLSBSeWFuIEdyb3ZlIChAeWF5cGllLCByeWFuQHdvbmtvLmNvbSkKCllVSSgpLnVzZSgn cm91dGVyJywgZnVuY3Rpb24gKFkpIHsKICB2YXIgb3JpZ2luYWxVcmwgPSBsb2NhdGlvbi5ocmVm LAogICAgICByb3V0ZXIgICAgICA9IG5ldyBZLlJvdXRlcigpOwoKICByb3V0ZXIucm91dGUoJy9m b28nLCBmdW5jdGlvbiAoKSB7CiAgICB2YXIgcmVzdWx0ID0gWydmb28nXS5maWx0ZXIoZnVuY3Rp b24gKCkgeyByZXR1cm4gdHJ1ZTsgfSk7CgogICAgY29uc29sZS5sb2cocmVzdWx0KTsKCiAgICBp ZiAocmVzdWx0Lmxlbmd0aCAhPT0gMSkgewogICAgICBjb25zb2xlLmVycm9yKCdBcnJheS5wcm90 b3R5cGUuZmlsdGVyKCkgZmFpbGVkIScpOwogICAgfQogIH0pOwoKICBjb25zb2xlLmxvZyhbJ3N0 YXJ0ZWQnXS5maWx0ZXIoZnVuY3Rpb24gKCkgeyByZXR1cm4gdHJ1ZTsgfSkpOwogIHJvdXRlci5z YXZlKCcvZm9vJyk7CiAgY29uc29sZS5sb2coWydmaW5pc2hlZCddLmZpbHRlcihmdW5jdGlvbiAo KSB7IHJldHVybiB0cnVlOyB9KSk7CiAgcm91dGVyLnNhdmUob3JpZ2luYWxVcmwpOyAvLyB0byBh dm9pZCBicmVha2luZyByZWZyZXNoCn0pOwo8L3NjcmlwdD4KCjwvYm9keT4KPC9odG1sPgo= 232757 2014-06-09 18:51:20 -0700 2014-06-10 10:53:29 -0700 Patch 133577.patch text/plain 6513 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY5NzM4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTA2LTA5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEluIGEgY2VydGFpbiBhcHAgc3RhdGUsIEFycmF5LnByb3RvdHlwZS5maWx0ZXIoKSByZXR1 cm5zIGluY29ycmVjdCByZXN1bHRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzM1NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXhlZCB0aGUgTExJbnQgcHJvY2Vzc2luZyBvZiBvcF9wdXRfYnlfdmFs X2RpcmVjdCB0byBoYXZlIHRoZSBzYW1lIGhvbGUgY2hlY2sgYXMgb3BfcHV0X2J5X3ZhbC4KKwor ICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc206CisgICAgICAgICog bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbToKKwogMjAxNC0wNi0wOSAgTWFyayBIYWhu ZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCBhZnRl ciByMTY5NzAzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRl cnByZXRlcjMyXzY0LmFzbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxp bnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQkocmV2aXNpb24gMTY5NzM4KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20JKHdv cmtpbmcgY29weSkKQEAgLTE2NjAsNyArMTY2MCw3IEBAIG1hY3JvIGNvbnRpZ3VvdXNQdXRCeVZh bChzdG9yZUNhbGxiYWNrKQogICAgIGptcCAuc3RvcmVSZXN1bHQKIGVuZAogCi1tYWNybyBwdXRC eVZhbChob2xlQ2hlY2ssIHNsb3dQYXRoKQorbWFjcm8gcHV0QnlWYWwoc2xvd1BhdGgpCiAgICAg dHJhY2VFeGVjdXRpb24oKQogICAgIHdyaXRlQmFycmllck9uT3BlcmFuZHMoMSwgMykKICAgICBs b2FkaSA0W1BDXSwgdDAKQEAgLTE3MTEsNyArMTcxMSw3IEBAIG1hY3JvIHB1dEJ5VmFsKGhvbGVD aGVjaywgc2xvd1BhdGgpCiAub3BQdXRCeVZhbE5vdENvbnRpZ3VvdXM6CiAgICAgYmluZXEgdDIs IEFycmF5U3RvcmFnZVNoYXBlLCAub3BQdXRCeVZhbFNsb3cKICAgICBiaWFlcSB0MywgLXNpemVv ZiBJbmRleGluZ0hlYWRlciArIEluZGV4aW5nSGVhZGVyOjp1Lmxlbmd0aHMudmVjdG9yTGVuZ3Ro W3QwXSwgLm9wUHV0QnlWYWxPdXRPZkJvdW5kcwotICAgIGhvbGVDaGVjayhBcnJheVN0b3JhZ2U6 Om1fdmVjdG9yICsgVGFnT2Zmc2V0W3QwLCB0MywgOF0sIC5vcFB1dEJ5VmFsQXJyYXlTdG9yYWdl RW1wdHkpCisgICAgYmllcSBBcnJheVN0b3JhZ2U6Om1fdmVjdG9yICsgVGFnT2Zmc2V0W3QwLCB0 MywgOF0sIEVtcHR5VmFsdWVUYWcsIC5vcFB1dEJ5VmFsQXJyYXlTdG9yYWdlRW1wdHkKIC5vcFB1 dEJ5VmFsQXJyYXlTdG9yYWdlU3RvcmVSZXN1bHQ6CiAgICAgbG9hZGkgMTJbUENdLCB0MgogICAg IGxvYWRDb25zdGFudE9yVmFyaWFibGUyUmVnKHQyLCB0MSwgdDIpCkBAIC0xNzM3LDEzICsxNzM3 LDEwIEBAIG1hY3JvIHB1dEJ5VmFsKGhvbGVDaGVjaywgc2xvd1BhdGgpCiBlbmQKIAogX2xsaW50 X29wX3B1dF9ieV92YWw6Ci0gICAgcHV0QnlWYWwobWFjcm8oYWRkciwgc2xvd1BhdGgpCi0gICAg ICAgIGJpZXEgYWRkciwgRW1wdHlWYWx1ZVRhZywgc2xvd1BhdGgKLSAgICBlbmQsIF9sbGludF9z bG93X3BhdGhfcHV0X2J5X3ZhbCkKKyAgICBwdXRCeVZhbChfbGxpbnRfc2xvd19wYXRoX3B1dF9i eV92YWwpCiAKIF9sbGludF9vcF9wdXRfYnlfdmFsX2RpcmVjdDoKLSAgICBwdXRCeVZhbChtYWNy byhhZGRyLCBzbG93UGF0aCkKLSAgICBlbmQsIF9sbGludF9zbG93X3BhdGhfcHV0X2J5X3ZhbF9k aXJlY3QpCisgICAgcHV0QnlWYWwoX2xsaW50X3Nsb3dfcGF0aF9wdXRfYnlfdmFsX2RpcmVjdCkK IAogX2xsaW50X29wX2ptcDoKICAgICB0cmFjZUV4ZWN1dGlvbigpCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQko cmV2aXNpb24gMTY5NzM4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVs SW50ZXJwcmV0ZXI2NC5hc20JKHdvcmtpbmcgY29weSkKQEAgLTE0OTUsNyArMTQ5NSw3IEBAIG1h Y3JvIGNvbnRpZ3VvdXNQdXRCeVZhbChzdG9yZUNhbGxiYWNrKQogICAgIGptcCAuc3RvcmVSZXN1 bHQKIGVuZAogCi1tYWNybyBwdXRCeVZhbChob2xlQ2hlY2ssIHNsb3dQYXRoKQorbWFjcm8gcHV0 QnlWYWwoc2xvd1BhdGgpCiAgICAgdHJhY2VFeGVjdXRpb24oKQogICAgIHdyaXRlQmFycmllck9u T3BlcmFuZHMoMSwgMykKICAgICBsb2FkaXNGcm9tSW5zdHJ1Y3Rpb24oMSwgdDApCkBAIC0xNTQz LDcgKzE1NDMsNyBAQCBtYWNybyBwdXRCeVZhbChob2xlQ2hlY2ssIHNsb3dQYXRoKQogLm9wUHV0 QnlWYWxOb3RDb250aWd1b3VzOgogICAgIGJpbmVxIHQyLCBBcnJheVN0b3JhZ2VTaGFwZSwgLm9w UHV0QnlWYWxTbG93CiAgICAgYmlhZXEgdDMsIC1zaXplb2YgSW5kZXhpbmdIZWFkZXIgKyBJbmRl eGluZ0hlYWRlcjo6dS5sZW5ndGhzLnZlY3Rvckxlbmd0aFt0MF0sIC5vcFB1dEJ5VmFsT3V0T2ZC b3VuZHMKLSAgICBob2xlQ2hlY2soQXJyYXlTdG9yYWdlOjptX3ZlY3Rvclt0MCwgdDMsIDhdLCAu b3BQdXRCeVZhbEFycmF5U3RvcmFnZUVtcHR5KQorICAgIGJ0cXogQXJyYXlTdG9yYWdlOjptX3Zl Y3Rvclt0MCwgdDMsIDhdLCAub3BQdXRCeVZhbEFycmF5U3RvcmFnZUVtcHR5CiAub3BQdXRCeVZh bEFycmF5U3RvcmFnZVN0b3JlUmVzdWx0OgogICAgIGxvYWRpc0Zyb21JbnN0cnVjdGlvbigzLCB0 MikKICAgICBsb2FkQ29uc3RhbnRPclZhcmlhYmxlKHQyLCB0MSkKQEAgLTE1NjgsMTMgKzE1Njgs MTAgQEAgbWFjcm8gcHV0QnlWYWwoaG9sZUNoZWNrLCBzbG93UGF0aCkKIGVuZAogCiBfbGxpbnRf b3BfcHV0X2J5X3ZhbDoKLSAgICBwdXRCeVZhbChtYWNybyhzbG90LCBzbG93UGF0aCkKLSAgICAg ICAgYnRxeiBzbG90LCBzbG93UGF0aAotICAgIGVuZCwgX2xsaW50X3Nsb3dfcGF0aF9wdXRfYnlf dmFsKQorICAgIHB1dEJ5VmFsKF9sbGludF9zbG93X3BhdGhfcHV0X2J5X3ZhbCkKIAogX2xsaW50 X29wX3B1dF9ieV92YWxfZGlyZWN0OgotICAgIHB1dEJ5VmFsKG1hY3JvKHNsb3QsIHNsb3dQYXRo KQotICAgIGVuZCwgX2xsaW50X3Nsb3dfcGF0aF9wdXRfYnlfdmFsX2RpcmVjdCkKKyAgICBwdXRC eVZhbChfbGxpbnRfc2xvd19wYXRoX3B1dF9ieV92YWxfZGlyZWN0KQogCiAKIF9sbGludF9vcF9q bXA6CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjk3MzgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxNC0wNi0wOSAgTWljaGFlbCBTYWJv ZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KKworICAgICAgICBJbiBhIGNlcnRhaW4gYXBwIHN0YXRl LCBBcnJheS5wcm90b3R5cGUuZmlsdGVyKCkgcmV0dXJucyBpbmNvcnJlY3QgcmVzdWx0cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzNTc3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmV3IHRlc3QgdG8g Y2hlY2sgdGhhdCB0aGUgbGxpbnQgaGFuZGxlcyB3cml0aW5nIHRvIGFuIGFycmF5IGhvbGUgZnJv bSBhIGJ1aWx0LWluCisgICAgICAgIGZ1bmN0aW9uLgorCisgICAgICAgICoganMvcmVncmVzcy9w dXQtYnktdmFsLWRpcmVjdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGpzL3JlZ3Jl c3MvcHV0LWJ5LXZhbC1kaXJlY3QuaHRtbDogQWRkZWQuCisgICAgICAgICoganMvcmVncmVzcy9z Y3JpcHQtdGVzdHMvcHV0LWJ5LXZhbC1kaXJlY3QuanM6IEFkZGVkLgorICAgICAgICAodGVzdCk6 CisKIDIwMTQtMDYtMDkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgV29yayB0b3dhcmRzIGhhdmluZyBmcmFtZXMgaW4gdGhlIHNjcm9sbGluZyB0cmVl CkluZGV4OiBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3B1dC1ieS12YWwtZGlyZWN0LWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3B1dC1ieS12YWwtZGly ZWN0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2pzL3JlZ3Jlc3Mv cHV0LWJ5LXZhbC1kaXJlY3QtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs MTAgQEAKK0pTUmVncmVzcy9wdXQtYnktdmFsLWRpcmVjdAorCitPbiBzdWNjZXNzLCB5b3Ugd2ls bCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01Q TEVURSIuCisKKworUEFTUyBubyBleGNlcHRpb24gdGhyb3duCitQQVNTIHN1Y2Nlc3NmdWxseVBh cnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvanMvcmVn cmVzcy9wdXQtYnktdmFsLWRpcmVjdC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2pz L3JlZ3Jlc3MvcHV0LWJ5LXZhbC1kaXJlY3QuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2pzL3JlZ3Jlc3MvcHV0LWJ5LXZhbC1kaXJlY3QuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MCwwICsxLDEyIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9F TiI+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIuLi8uLi9y ZXNvdXJjZXMvcmVncmVzcy1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InNjcmlwdC10 ZXN0cy9wdXQtYnlfdmFsLWRpcmVjdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4v cmVzb3VyY2VzL3JlZ3Jlc3MtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4v cmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cklu ZGV4OiBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3NjcmlwdC10ZXN0cy9wdXQtYnktdmFsLWRpcmVj dC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3NjcmlwdC10ZXN0cy9w dXQtYnktdmFsLWRpcmVjdC5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2pzL3JlZ3Jl c3Mvc2NyaXB0LXRlc3RzL3B1dC1ieS12YWwtZGlyZWN0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsMTkgQEAKK2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgdmFyIHZhbHVlcyA9IFsiZm9vIiwg ImJhciIsICJiYXoiXTsKKworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMjsgaSsrKSB7CisgICAg ICAgIHZhciByZXN1bHQgPSB2YWx1ZXMuZmlsdGVyKGZ1bmN0aW9uKGN1cnJlbnQpIHsKKyAgICAg ICAgICAgIGlmIChjdXJyZW50ID09ICJmb28iKQorICAgICAgICAgICAgICAgIHJldHVybiB0cnVl CisgICAgICAgICAgICByZXR1cm4gZmFsc2UKKyAgICAgICAgfSkKKworICAgICAgICBpZiAocmVz dWx0Lmxlbmd0aCAhPT0gMSkKKyAgICAgICAgICAgICB0aHJvdyAiZmlsdGVyIHJlc3VsdCBsZW5n dGggd3JvbmcsIHNob3VsZCBiZSAxLCBidXQgd2FzICIgKyByZXN1bHQubGVuZ3RoCisKKyAgICAg ICAgaWYgKGkgPT0gMCkgLy8gQ2hhbmdlIHJlc3VsdCB0byB1cGRhdGUgaXRzIGFycmF5IHByb2Zp bGUgdG8gQXJyYXlTdG9yYWdlU2hhcGUKKyAgICAgICAgICAgIHJlc3VsdC5zaGlmdCgpCisgICAg fQorfQorCit0ZXN0KCkK 232796 2014-06-10 10:53:29 -0700 2014-06-10 11:00:16 -0700 Patch with updated test from comment 133577-2.patch text/plain 6599 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY5NzM4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTA2LTA5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEluIGEgY2VydGFpbiBhcHAgc3RhdGUsIEFycmF5LnByb3RvdHlwZS5maWx0ZXIoKSByZXR1 cm5zIGluY29ycmVjdCByZXN1bHRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzM1NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXhlZCB0aGUgTExJbnQgcHJvY2Vzc2luZyBvZiBvcF9wdXRfYnlfdmFs X2RpcmVjdCB0byBoYXZlIHRoZSBzYW1lIGhvbGUgY2hlY2sgYXMgb3BfcHV0X2J5X3ZhbC4KKwor ICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc206CisgICAgICAgICog bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbToKKwogMjAxNC0wNi0wOSAgTWFyayBIYWhu ZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCBhZnRl ciByMTY5NzAzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRl cnByZXRlcjMyXzY0LmFzbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxp bnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQkocmV2aXNpb24gMTY5NzM4KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20JKHdv cmtpbmcgY29weSkKQEAgLTE2NjAsNyArMTY2MCw3IEBAIG1hY3JvIGNvbnRpZ3VvdXNQdXRCeVZh bChzdG9yZUNhbGxiYWNrKQogICAgIGptcCAuc3RvcmVSZXN1bHQKIGVuZAogCi1tYWNybyBwdXRC eVZhbChob2xlQ2hlY2ssIHNsb3dQYXRoKQorbWFjcm8gcHV0QnlWYWwoc2xvd1BhdGgpCiAgICAg dHJhY2VFeGVjdXRpb24oKQogICAgIHdyaXRlQmFycmllck9uT3BlcmFuZHMoMSwgMykKICAgICBs b2FkaSA0W1BDXSwgdDAKQEAgLTE3MTEsNyArMTcxMSw3IEBAIG1hY3JvIHB1dEJ5VmFsKGhvbGVD aGVjaywgc2xvd1BhdGgpCiAub3BQdXRCeVZhbE5vdENvbnRpZ3VvdXM6CiAgICAgYmluZXEgdDIs IEFycmF5U3RvcmFnZVNoYXBlLCAub3BQdXRCeVZhbFNsb3cKICAgICBiaWFlcSB0MywgLXNpemVv ZiBJbmRleGluZ0hlYWRlciArIEluZGV4aW5nSGVhZGVyOjp1Lmxlbmd0aHMudmVjdG9yTGVuZ3Ro W3QwXSwgLm9wUHV0QnlWYWxPdXRPZkJvdW5kcwotICAgIGhvbGVDaGVjayhBcnJheVN0b3JhZ2U6 Om1fdmVjdG9yICsgVGFnT2Zmc2V0W3QwLCB0MywgOF0sIC5vcFB1dEJ5VmFsQXJyYXlTdG9yYWdl RW1wdHkpCisgICAgYmllcSBBcnJheVN0b3JhZ2U6Om1fdmVjdG9yICsgVGFnT2Zmc2V0W3QwLCB0 MywgOF0sIEVtcHR5VmFsdWVUYWcsIC5vcFB1dEJ5VmFsQXJyYXlTdG9yYWdlRW1wdHkKIC5vcFB1 dEJ5VmFsQXJyYXlTdG9yYWdlU3RvcmVSZXN1bHQ6CiAgICAgbG9hZGkgMTJbUENdLCB0MgogICAg IGxvYWRDb25zdGFudE9yVmFyaWFibGUyUmVnKHQyLCB0MSwgdDIpCkBAIC0xNzM3LDEzICsxNzM3 LDEwIEBAIG1hY3JvIHB1dEJ5VmFsKGhvbGVDaGVjaywgc2xvd1BhdGgpCiBlbmQKIAogX2xsaW50 X29wX3B1dF9ieV92YWw6Ci0gICAgcHV0QnlWYWwobWFjcm8oYWRkciwgc2xvd1BhdGgpCi0gICAg ICAgIGJpZXEgYWRkciwgRW1wdHlWYWx1ZVRhZywgc2xvd1BhdGgKLSAgICBlbmQsIF9sbGludF9z bG93X3BhdGhfcHV0X2J5X3ZhbCkKKyAgICBwdXRCeVZhbChfbGxpbnRfc2xvd19wYXRoX3B1dF9i eV92YWwpCiAKIF9sbGludF9vcF9wdXRfYnlfdmFsX2RpcmVjdDoKLSAgICBwdXRCeVZhbChtYWNy byhhZGRyLCBzbG93UGF0aCkKLSAgICBlbmQsIF9sbGludF9zbG93X3BhdGhfcHV0X2J5X3ZhbF9k aXJlY3QpCisgICAgcHV0QnlWYWwoX2xsaW50X3Nsb3dfcGF0aF9wdXRfYnlfdmFsX2RpcmVjdCkK IAogX2xsaW50X29wX2ptcDoKICAgICB0cmFjZUV4ZWN1dGlvbigpCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQko cmV2aXNpb24gMTY5NzM4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVs SW50ZXJwcmV0ZXI2NC5hc20JKHdvcmtpbmcgY29weSkKQEAgLTE0OTUsNyArMTQ5NSw3IEBAIG1h Y3JvIGNvbnRpZ3VvdXNQdXRCeVZhbChzdG9yZUNhbGxiYWNrKQogICAgIGptcCAuc3RvcmVSZXN1 bHQKIGVuZAogCi1tYWNybyBwdXRCeVZhbChob2xlQ2hlY2ssIHNsb3dQYXRoKQorbWFjcm8gcHV0 QnlWYWwoc2xvd1BhdGgpCiAgICAgdHJhY2VFeGVjdXRpb24oKQogICAgIHdyaXRlQmFycmllck9u T3BlcmFuZHMoMSwgMykKICAgICBsb2FkaXNGcm9tSW5zdHJ1Y3Rpb24oMSwgdDApCkBAIC0xNTQz LDcgKzE1NDMsNyBAQCBtYWNybyBwdXRCeVZhbChob2xlQ2hlY2ssIHNsb3dQYXRoKQogLm9wUHV0 QnlWYWxOb3RDb250aWd1b3VzOgogICAgIGJpbmVxIHQyLCBBcnJheVN0b3JhZ2VTaGFwZSwgLm9w UHV0QnlWYWxTbG93CiAgICAgYmlhZXEgdDMsIC1zaXplb2YgSW5kZXhpbmdIZWFkZXIgKyBJbmRl eGluZ0hlYWRlcjo6dS5sZW5ndGhzLnZlY3Rvckxlbmd0aFt0MF0sIC5vcFB1dEJ5VmFsT3V0T2ZC b3VuZHMKLSAgICBob2xlQ2hlY2soQXJyYXlTdG9yYWdlOjptX3ZlY3Rvclt0MCwgdDMsIDhdLCAu b3BQdXRCeVZhbEFycmF5U3RvcmFnZUVtcHR5KQorICAgIGJ0cXogQXJyYXlTdG9yYWdlOjptX3Zl Y3Rvclt0MCwgdDMsIDhdLCAub3BQdXRCeVZhbEFycmF5U3RvcmFnZUVtcHR5CiAub3BQdXRCeVZh bEFycmF5U3RvcmFnZVN0b3JlUmVzdWx0OgogICAgIGxvYWRpc0Zyb21JbnN0cnVjdGlvbigzLCB0 MikKICAgICBsb2FkQ29uc3RhbnRPclZhcmlhYmxlKHQyLCB0MSkKQEAgLTE1NjgsMTMgKzE1Njgs MTAgQEAgbWFjcm8gcHV0QnlWYWwoaG9sZUNoZWNrLCBzbG93UGF0aCkKIGVuZAogCiBfbGxpbnRf b3BfcHV0X2J5X3ZhbDoKLSAgICBwdXRCeVZhbChtYWNybyhzbG90LCBzbG93UGF0aCkKLSAgICAg ICAgYnRxeiBzbG90LCBzbG93UGF0aAotICAgIGVuZCwgX2xsaW50X3Nsb3dfcGF0aF9wdXRfYnlf dmFsKQorICAgIHB1dEJ5VmFsKF9sbGludF9zbG93X3BhdGhfcHV0X2J5X3ZhbCkKIAogX2xsaW50 X29wX3B1dF9ieV92YWxfZGlyZWN0OgotICAgIHB1dEJ5VmFsKG1hY3JvKHNsb3QsIHNsb3dQYXRo KQotICAgIGVuZCwgX2xsaW50X3Nsb3dfcGF0aF9wdXRfYnlfdmFsX2RpcmVjdCkKKyAgICBwdXRC eVZhbChfbGxpbnRfc2xvd19wYXRoX3B1dF9ieV92YWxfZGlyZWN0KQogCiAKIF9sbGludF9vcF9q bXA6CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjk3MzgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxNC0wNi0wOSAgTWljaGFlbCBTYWJv ZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KKworICAgICAgICBJbiBhIGNlcnRhaW4gYXBwIHN0YXRl LCBBcnJheS5wcm90b3R5cGUuZmlsdGVyKCkgcmV0dXJucyBpbmNvcnJlY3QgcmVzdWx0cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzNTc3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmV3IHRlc3QgdG8g Y2hlY2sgdGhhdCB0aGUgbGxpbnQgaGFuZGxlcyB3cml0aW5nIHRvIGFuIGFycmF5IGhvbGUgZnJv bSBhIGJ1aWx0LWluCisgICAgICAgIGZ1bmN0aW9uLgorCisgICAgICAgICoganMvcmVncmVzcy9w dXQtYnktdmFsLWRpcmVjdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGpzL3JlZ3Jl c3MvcHV0LWJ5LXZhbC1kaXJlY3QuaHRtbDogQWRkZWQuCisgICAgICAgICoganMvcmVncmVzcy9z Y3JpcHQtdGVzdHMvcHV0LWJ5LXZhbC1kaXJlY3QuanM6IEFkZGVkLgorICAgICAgICAodGVzdCk6 CisKIDIwMTQtMDYtMDkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgV29yayB0b3dhcmRzIGhhdmluZyBmcmFtZXMgaW4gdGhlIHNjcm9sbGluZyB0cmVl CkluZGV4OiBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3B1dC1ieS12YWwtZGlyZWN0LWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3B1dC1ieS12YWwtZGly ZWN0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2pzL3JlZ3Jlc3Mv cHV0LWJ5LXZhbC1kaXJlY3QtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs MTAgQEAKK0pTUmVncmVzcy9wdXQtYnktdmFsLWRpcmVjdAorCitPbiBzdWNjZXNzLCB5b3Ugd2ls bCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01Q TEVURSIuCisKKworUEFTUyBubyBleGNlcHRpb24gdGhyb3duCitQQVNTIHN1Y2Nlc3NmdWxseVBh cnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvanMvcmVn cmVzcy9wdXQtYnktdmFsLWRpcmVjdC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2pz L3JlZ3Jlc3MvcHV0LWJ5LXZhbC1kaXJlY3QuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2pzL3JlZ3Jlc3MvcHV0LWJ5LXZhbC1kaXJlY3QuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MCwwICsxLDEyIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9F TiI+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIuLi8uLi9y ZXNvdXJjZXMvcmVncmVzcy1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InNjcmlwdC10 ZXN0cy9wdXQtYnlfdmFsLWRpcmVjdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4v cmVzb3VyY2VzL3JlZ3Jlc3MtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4v cmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cklu ZGV4OiBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3NjcmlwdC10ZXN0cy9wdXQtYnktdmFsLWRpcmVj dC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3NjcmlwdC10ZXN0cy9w dXQtYnktdmFsLWRpcmVjdC5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2pzL3JlZ3Jl c3Mvc2NyaXB0LXRlc3RzL3B1dC1ieS12YWwtZGlyZWN0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsMjEgQEAKK2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgdmFyIHZhbHVlcyA9IFsiZm9vIiwg ImJhciIsICJiYXoiXTsKKworICAgIEFycmF5LnByb3RvdHlwZS5fX2RlZmluZVNldHRlcl9fKCIw IiwgZnVuY3Rpb24oKSB7IHRocm93ICJJbiBjdXN0b20gc2V0dGVyIiB9KQorCisgICAgZm9yICh2 YXIgaSA9IDA7IGkgPCAyOyBpKyspIHsKKyAgICAgICAgdmFyIHJlc3VsdCA9IHZhbHVlcy5maWx0 ZXIoZnVuY3Rpb24oY3VycmVudCkgeworICAgICAgICAgICAgaWYgKGN1cnJlbnQgPT0gImZvbyIp CisgICAgICAgICAgICAgICAgcmV0dXJuIHRydWUKKyAgICAgICAgICAgIHJldHVybiBmYWxzZQor ICAgICAgICB9KQorCisgICAgICAgIGlmIChyZXN1bHQubGVuZ3RoICE9PSAxKQorICAgICAgICAg ICAgIHRocm93ICJmaWx0ZXIgcmVzdWx0IGxlbmd0aCB3cm9uZywgc2hvdWxkIGJlIDEsIGJ1dCB3 YXMgIiArIHJlc3VsdC5sZW5ndGgKKworICAgICAgICBpZiAoaSA9PSAwKSAvLyBDaGFuZ2UgcmVz dWx0IHRvIHVwZGF0ZSBpdHMgYXJyYXkgcHJvZmlsZSB0byBBcnJheVN0b3JhZ2VTaGFwZQorICAg ICAgICAgICAgcmVzdWx0LnNoaWZ0KCkKKyAgICB9Cit9CisKK3Rlc3QoKQo=