133528 2014-06-04 18:30:57 -0700 SVGGlyphToPathTranslator ASSERTs when encountering a missing glyph in an SVG font 2014-06-11 19:25:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield commit-queue dino d-r esprehn+autocc fmalita glenn gyuyoung.kim jonlee kondapallykalyan pdr schenney sergio simon.fraser thorton webkit-bug-importer oldest_to_newest 1013431 0 mmaxfield 2014-06-04 18:30:57 -0700 Currently an assert fires if you style text (possibly underlined, regarding text-decoration-skip: ink, and possibly not regarding simply drawing the text) and you supply a letter that is not contained within the SVG font. 1013439 1 mmaxfield 2014-06-04 18:45:03 -0700 <rdar://problem/17166642> 1014992 2 232923 mmaxfield 2014-06-11 17:32:40 -0700 Created attachment 232923 Patch 1015002 3 232923 simon.fraser 2014-06-11 17:59:16 -0700 Comment on attachment 232923 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232923&action=review > Source/WebCore/platform/graphics/mac/FontMac.mm:548 > + // The advances will get all messed up if we do anything other than bail here. > + result.clear(); // Better to be consistent rather than half-correct Maybe make the comments a bit less hilarious. 1015008 4 mmaxfield 2014-06-11 19:25:32 -0700 http://trac.webkit.org/changeset/169872 232923 2014-06-11 17:32:40 -0700 2014-06-11 17:59:15 -0700 Patch bug-133528-20140611173215.patch text/plain 6960 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ0Y2VkM2RlMDYzMzBm NWMxYTdjNWFiNGUwNTNmZGMxNTIyNzQ4Ni4uZmI4YjhkM2Q0Y2JhNjAxMjE2MmEwMWMyYTM1ZjVj OGVjYmVjZjE5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA2LTExICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgU1ZHR2x5cGhU b1BhdGhUcmFuc2xhdG9yIEFTU0VSVHMgd2hlbiBlbmNvdW50ZXJpbmcgYSBtaXNzaW5nIGdseXBo IGluIGFuIFNWRyBmb250CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzM1MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUdXJucyBvdXQgdGhpcyBhc3NlcnRpb24gaXMgYmVuaWduLiBXZSBjYW4gdGFrZSBh biBlYXJseSBvdXQgb2YgYWR2YW5jZSgpICh3aGljaAorICAgICAgICBpcyB0aGVuIGhhbmRsZWQg cHJvcGVybHkgYnkgRm9udDo6ZGFzaGVzRm9ySW50ZXJzZWN0aW9uc1dpdGhSZWN0KCkKKworICAg ICAgICBUZXN0OiBzdmcvY3VzdG9tL3NraXAtdW5kZXJsaW5lLW1pc3NpbmctZ2x5cGguaHRtbAor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0ZvbnRNYWMubW06CisgICAgICAgIChX ZWJDb3JlOjpGb250OjpkYXNoZXNGb3JJbnRlcnNlY3Rpb25zV2l0aFJlY3QpOiBSYXRoZXIgdGhh biBza2lwIHBhcnRpYWwgcmVzdWx0cywKKyAgICAgICAgZG9uJ3Qgc2tpcCBhbnl0aGluZyBhdCBh bGwgdG8gYmUgY29uc2lzdGVudC4KKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1NWR1RleHRSdW5S ZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR0dseXBoVG9QYXRoVHJh bnNsYXRvcjo6YWR2YW5jZSk6IFRha2UgYW4gZWFybHkgb3V0IHRvIGF2b2lkIGFuIEFTU0VSVC4K KwogMjAxNC0wNi0xMCAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgog CiAgICAgICAgIEphcGFuZXNlIHRleHQgaW4gR29vZ2xlIHNlYXJjaCBpcyByZW5kZXJlZCB0b28g bG93IGFuZCBjbGlwcGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9tYWMvRm9udE1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21h Yy9Gb250TWFjLm1tCmluZGV4IDU5NTc1MDg0ODE4OGUzYjM1OTI5Y2FlZTRjMDk5MmE4MDVkMDc0 OTEuLmRkZjE1NDdiOTk3OTBiMDBlMTkwNzY2YzU4ZmE1NzZlZmJiYmQxZWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250TWFjLm1tCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250TWFjLm1tCkBAIC01MjgsNyAr NTI4LDcgQEAgRGFzaEFycmF5IEZvbnQ6OmRhc2hlc0ZvckludGVyc2VjdGlvbnNXaXRoUmVjdChj b25zdCBUZXh0UnVuJiBydW4sIGNvbnN0IEZsb2F0UG8KICAgICBpZiAoIWdseXBoQnVmZmVyLnNp emUoKSkKICAgICAgICAgcmV0dXJuIERhc2hBcnJheSgpOwogICAgIAotICAgIC8vIEZJWE1FOiBI YW5kbGUgU1ZHICsgbm9uLVNWRyBpbnRlcmxlYXZlZCBydW5zCisgICAgLy8gRklYTUU6IEhhbmRs ZSBTVkcgKyBub24tU1ZHIGludGVybGVhdmVkIHJ1bnMuIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzM3NzgKICAgICBjb25zdCBTaW1wbGVGb250RGF0YSogZm9udERh dGEgPSBnbHlwaEJ1ZmZlci5mb250RGF0YUF0KDApOwogICAgIHN0ZDo6dW5pcXVlX3B0cjxHbHlw aFRvUGF0aFRyYW5zbGF0b3I+IHRyYW5zbGF0b3I7CiAgICAgYm9vbCBpc1NWRyA9IGZhbHNlOwpA QCAtNTQzLDggKzU0MywxMSBAQCBEYXNoQXJyYXkgRm9udDo6ZGFzaGVzRm9ySW50ZXJzZWN0aW9u c1dpdGhSZWN0KGNvbnN0IFRleHRSdW4mIHJ1biwgY29uc3QgRmxvYXRQbwogICAgIGZvciAoaW50 IGluZGV4ID0gMDsgdHJhbnNsYXRvci0+Y29udGFpbnNNb3JlUGF0aHMoKTsgKytpbmRleCwgdHJh bnNsYXRvci0+YWR2YW5jZSgpKSB7CiAgICAgICAgIEdseXBoSXRlcmF0aW9uU3RhdGUgaW5mbyA9 IEdseXBoSXRlcmF0aW9uU3RhdGUoQ0dQb2ludE1ha2UoMCwgMCksIENHUG9pbnRNYWtlKDAsIDAp LCBsaW5lRXh0ZW50cy55KCksIGxpbmVFeHRlbnRzLnkoKSArIGxpbmVFeHRlbnRzLmhlaWdodCgp LCBsaW5lRXh0ZW50cy54KCkgKyBsaW5lRXh0ZW50cy53aWR0aCgpLCBsaW5lRXh0ZW50cy54KCkp OwogICAgICAgICBjb25zdCBTaW1wbGVGb250RGF0YSogbG9jYWxGb250RGF0YSA9IGdseXBoQnVm ZmVyLmZvbnREYXRhQXQoaW5kZXgpOwotICAgICAgICBpZiAoIWxvY2FsRm9udERhdGEgfHwgKCFp c1NWRyAmJiBsb2NhbEZvbnREYXRhLT5pc1NWR0ZvbnQoKSkgfHwgKGlzU1ZHICYmIGxvY2FsRm9u dERhdGEgIT0gZm9udERhdGEpKQotICAgICAgICAgICAgYnJlYWs7IC8vIFRoZSBhZHZhbmNlcyB3 aWxsIGdldCBhbGwgbWVzc2VkIHVwIGlmIHdlIGRvIGFueXRoaW5nIG90aGVyIHRoYW4gYmFpbCBo ZXJlLgorICAgICAgICBpZiAoIWxvY2FsRm9udERhdGEgfHwgKCFpc1NWRyAmJiBsb2NhbEZvbnRE YXRhLT5pc1NWR0ZvbnQoKSkgfHwgKGlzU1ZHICYmIGxvY2FsRm9udERhdGEgIT0gZm9udERhdGEp KSB7CisgICAgICAgICAgICAvLyBUaGUgYWR2YW5jZXMgd2lsbCBnZXQgYWxsIG1lc3NlZCB1cCBp ZiB3ZSBkbyBhbnl0aGluZyBvdGhlciB0aGFuIGJhaWwgaGVyZS4KKyAgICAgICAgICAgIHJlc3Vs dC5jbGVhcigpOyAvLyBCZXR0ZXIgdG8gYmUgY29uc2lzdGVudCByYXRoZXIgdGhhbiBoYWxmLWNv cnJlY3QKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CiAgICAgICAgIHN3aXRjaCAodHJh bnNsYXRvci0+dW5kZXJsaW5lVHlwZSgpKSB7CiAgICAgICAgIGNhc2UgR2x5cGhUb1BhdGhUcmFu c2xhdG9yOjpHbHlwaFVuZGVybGluZVR5cGU6OlNraXBEZXNjZW5kZXJzOiB7CiAgICAgICAgICAg ICBQYXRoIHBhdGggPSB0cmFuc2xhdG9yLT5wYXRoKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3ZnL1NWR1RleHRSdW5SZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHVGV4dFJ1blJlbmRlcmluZ0NvbnRleHQuY3BwCmlu ZGV4IDYxYjAyMTcxMWFhMjQ1OTc1YTk0MzE4YTM2NjM3N2Y2OTk0MTE4MmMuLjYxNzczODYzYzdj ZjQzMzJlMmQ0MzljMTFkZmE5ZTc3ZmRiN2Q4NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9zdmcvU1ZHVGV4dFJ1blJlbmRlcmluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHVGV4dFJ1blJlbmRlcmluZ0NvbnRleHQuY3BwCkBA IC0yMDIsNyArMjAyLDcgQEAgdm9pZCBTVkdHbHlwaFRvUGF0aFRyYW5zbGF0b3I6OmFkdmFuY2Uo KQogICAgICAgICB9CiAKICAgICAgICAgKyttX2luZGV4OwotICAgICAgICBpZiAobV9pbmRleCA+ PSBtX3N0b3BwaW5nUG9pbnQpCisgICAgICAgIGlmIChtX2luZGV4ID49IG1fc3RvcHBpbmdQb2lu dCB8fCAhbV9nbHlwaEJ1ZmZlci5mb250RGF0YUF0KG1faW5kZXgpLT5pc1NWR0ZvbnQoKSkKICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICBtX2dseXBoID0gbV9nbHlwaEJ1ZmZlci5nbHlwaEF0 KG1faW5kZXgpOwogICAgICAgICBpZiAoIW1fZ2x5cGgpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2YyM2UzMDUwMWJmNGMx OGEzNzhkMjdlNTI1YTliMzc1OTJlNDlhYi4uZDM3ZDk2ODRkYjRlNGZlY2EyMGUzZTZkOWMxZDY3 MzdmMWZkOGEzNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA2LTExICBNeWxlcyBDLiBN YXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgU1ZHR2x5cGhUb1BhdGhU cmFuc2xhdG9yIEFTU0VSVHMgd2hlbiBlbmNvdW50ZXJpbmcgYSBtaXNzaW5nIGdseXBoIGluIGFu IFNWRyBmb250CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzM1MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBNYWtlIHN1cmUgdGhhdCBubyBBU1NFUlQgb2NjdXJzIGluIHRoaXMgc2l0dWF0aW9uLiBJbiBh ZGRpdGlvbiwgbWFrZSBzdXJlIHRoYXQgdGhlCisgICAgICAgIHdob2xlIGVsZW1lbnQgZG9lc24n dCBnZXQgc2tpcDppbmsgZ2Fwcy4gVGhpcyB3aWxsIG5lZWQgdG8gYmUgdXBkYXRlZCB3aGVuIHdl CisgICAgICAgIHN1cHBvcnQgU1ZHICsgbm9uLVNWRyBtaXhlZCBydW5zLgorCisgICAgICAgICog c3ZnL2N1c3RvbS9za2lwLXVuZGVybGluZS1taXNzaW5nLWdseXBoLWV4cGVjdGVkLmh0bWw6IEFk ZGVkCisgICAgICAgICogc3ZnL2N1c3RvbS9za2lwLXVuZGVybGluZS1taXNzaW5nLWdseXBoLmh0 bWw6IEFkZGVkCisKIDIwMTQtMDYtMTAgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFw cGxlLmNvbT4KIAogICAgICAgICBKYXBhbmVzZSB0ZXh0IGluIEdvb2dsZSBzZWFyY2ggaXMgcmVu ZGVyZWQgdG9vIGxvdyBhbmQgY2xpcHBlZApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2N1 c3RvbS9za2lwLXVuZGVybGluZS1taXNzaW5nLWdseXBoLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRU ZXN0cy9zdmcvY3VzdG9tL3NraXAtdW5kZXJsaW5lLW1pc3NpbmctZ2x5cGgtZXhwZWN0ZWQuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi42NDI1Y2Y5MjJmNzM1MzA1ZTZkMjcwMjI3NmYwYjg4YzI2YjU3NzM0Ci0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9za2lwLXVuZGVybGluZS1t aXNzaW5nLWdseXBoLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwyMiBAQAorPCFET0NUWVBFIGh0 bWw+Cis8aHRtbD4KKzxoZWFkPgorPG1ldGEgY2hhcnNldD0idXRmLTgiPgorPHN0eWxlPgorQGZv bnQtZmFjZSB7CisgICAgZm9udC1mYW1pbHk6IGZyZWVzYW5zOworICAgIHNyYzogdXJsKC4uLy4u L3N2Zy9jdXN0b20vcmVzb3VyY2VzL1NWR0ZyZWVTYW5zLnN2ZykgZm9ybWF0KCJzdmciKTsKK30K Kzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KK1RoaXMgdGVzdCBtYWtlcyBzdXJlIHRoYXQgdGhl cmUgaXMgbm8gQVNTRVJUIGhpdCB3aGVuIHdlIGFyZSBhdHRlbXB0aW5nIHRvIGRyYXcKK2Egc2tp cDppbmsgdGV4dCBkZWNvcmF0aW9uIG9uIFNWRyB0ZXh0IHdoZXJlIHRoZSBTVkcgZm9udCBkb2Vz IG5vdCBoYXZlIGFsbCB0aGUKK2dseXBocyB0aGF0IHdlIG5lZWQuCisKK1RoaXMgdGVzdCBhbHNv IHRlc3RzIHRoYXQsIGluIHRoaXMgc2l0dWF0aW9uLCBubyBnYXBzIGFyZSBkcmF3biBhdCBhbGwu IFRoaXMKK3Rlc3Qgd2lsbCBuZWVkIHRvIGJlIGFsdGVyZWQgd2hlbiB3ZSBmaW5hbGx5IHN1cHBv cnQgbWl4ZWQgU1ZHIGFuZCBub24tU1ZHCitmb250cyBhbG9uZyB3aXRoIHNraXA6aW5rIGRlY29y YXRpb25zLgorPGRpdiBzdHlsZT0idGV4dC1kZWNvcmF0aW9uOiB1bmRlcmxpbmU7IC13ZWJraXQt dGV4dC1kZWNvcmF0aW9uLXNraXA6IG5vbmU7IGZvbnQ6IDQ4cHggZnJlZXNhbnM7Ij5hYnlj44Go ZWZ5Z2g8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2 Zy9jdXN0b20vc2tpcC11bmRlcmxpbmUtbWlzc2luZy1nbHlwaC5odG1sIGIvTGF5b3V0VGVzdHMv c3ZnL2N1c3RvbS9za2lwLXVuZGVybGluZS1taXNzaW5nLWdseXBoLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u MjM1OWEyNWZmMmYzMWM1MmJiYWYxMzNiZWNhMDJiNTJlZGRmZDRjOQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vc2tpcC11bmRlcmxpbmUtbWlzc2luZy1nbHlwaC5o dG1sCkBAIC0wLDAgKzEsMjIgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxt ZXRhIGNoYXJzZXQ9InV0Zi04Ij4KKzxzdHlsZT4KK0Bmb250LWZhY2UgeworICAgIGZvbnQtZmFt aWx5OiBmcmVlc2FuczsKKyAgICBzcmM6IHVybCguLi8uLi9zdmcvY3VzdG9tL3Jlc291cmNlcy9T VkdGcmVlU2Fucy5zdmcpIGZvcm1hdCgic3ZnIik7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJv ZHk+CitUaGlzIHRlc3QgbWFrZXMgc3VyZSB0aGF0IHRoZXJlIGlzIG5vIEFTU0VSVCBoaXQgd2hl biB3ZSBhcmUgYXR0ZW1wdGluZyB0byBkcmF3CithIHNraXA6aW5rIHRleHQgZGVjb3JhdGlvbiBv biBTVkcgdGV4dCB3aGVyZSB0aGUgU1ZHIGZvbnQgZG9lcyBub3QgaGF2ZSBhbGwgdGhlCitnbHlw aHMgdGhhdCB3ZSBuZWVkLgorCitUaGlzIHRlc3QgYWxzbyB0ZXN0cyB0aGF0LCBpbiB0aGlzIHNp dHVhdGlvbiwgbm8gZ2FwcyBhcmUgZHJhd24gYXQgYWxsLiBUaGlzCit0ZXN0IHdpbGwgbmVlZCB0 byBiZSBhbHRlcmVkIHdoZW4gd2UgZmluYWxseSBzdXBwb3J0IG1peGVkIFNWRyBhbmQgbm9uLVNW RworZm9udHMgYWxvbmcgd2l0aCBza2lwOmluayBkZWNvcmF0aW9ucy4KKzxkaXYgc3R5bGU9InRl eHQtZGVjb3JhdGlvbjogdW5kZXJsaW5lOyAtd2Via2l0LXRleHQtZGVjb3JhdGlvbi1za2lwOiBp bms7IGZvbnQ6IDQ4cHggZnJlZXNhbnM7Ij5hYnlj44GoZWZ5Z2g8L2Rpdj4KKzwvYm9keT4KKzwv aHRtbD4K