133526 2014-06-04 14:40:57 -0700 REGRESSION (iOS WebKit2): Selection rect disappears on touch up on google result 2014-06-04 15:45:04 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified CLOSED WONTFIX InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 1013380 0 enrica 2014-06-04 14:40:57 -0700 Tap and hold on an address after searching for a place in google. Lifting the finger makes the selection disappear. <rdar://problem/16863448> 1013386 1 232503 enrica 2014-06-04 14:53:37 -0700 Created attachment 232503 Patch 1013399 2 232503 benjamin 2014-06-04 15:33:16 -0700 Comment on attachment 232503 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232503&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:755 > +- (void)cancelHighlight > +{ > + [_highlightLongPressGestureRecognizer cancel]; > +} You can just expose _cancelLongPressGestureRecognizer. Or if you really need a separate call, use [self _cancelLongPressGestureRecognizer]. 1013401 3 enrica 2014-06-04 15:40:28 -0700 (In reply to comment #2) > (From update of attachment 232503 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232503&action=review > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:755 > > +- (void)cancelHighlight > > +{ > > + [_highlightLongPressGestureRecognizer cancel]; > > +} > > You can just expose _cancelLongPressGestureRecognizer. Or if you really need a separate call, use [self _cancelLongPressGestureRecognizer]. I did not see that. I'll use that one directly. No need for this patch then. Thanks! 232503 2014-06-04 14:53:37 -0700 2014-06-04 15:33:16 -0700 Patch cancelhighlight.txt text/plain 1598 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTU5NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA2LTA0ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAoaU9TIFdl YktpdDIpOiBTZWxlY3Rpb24gcmVjdCBkaXNhcHBlYXJzIG9uIHRvdWNoIHVwIG9uIGdvb2dsZSBy ZXN1bHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzM1MjYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2ODYzNDQ4PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHRoZXJlIGFyZSBubyBndWFy YW50ZWVzIGFib3V0IHRoZSBvcmRlciBpbiB3aGljaCBtdWx0aXBsZSBnZXN0dXJlIHJlY29nbml6 ZXJzCisgICAgICAgIGZvciB0aGUgc2FtZSBnZXN0dXJlIGFyZSBjYWxsZWQgd2hlbiB0aGUgZ2Vz dHVyZSBlbmRzLCB3ZSBuZWVkIHRvIHByb3ZpZGUgVUlLaXQKKyAgICAgICAgYSB3YXkgdG8gY2Fu Y2VsIHRoZSBoaWdobGlnaHQgbG9uZyBwcmVzcyBnZXN0dXJlIHdoZW4gdGhlIHNlbGVjdGlvbiBn ZXN0dXJlIHN0YXJ0cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGNhbmNlbEhpZ2hsaWdodF0p OgorCiAyMDE0LTA2LTAzICBUaW1vdGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWJLaXQyIFZpZXcgR2VzdHVyZXMgKFpvb20pOiBDYW4gc2hvdyB1bnBh aW50ZWQgcmVnaW9ucyB3aGVuIHpvb20tcGluY2hpbmctb3V0CkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQkocmV2aXNpb24gMTY5NTg5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0Nv bnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHdvcmtpbmcgY29weSkKQEAgLTc0OSw2ICs3NDksMTEg QEAgLSAodm9pZClfaGlnaGxpZ2h0TG9uZ1ByZXNzUmVjb2duaXplZDooVQogICAgIH0KIH0KIAor LSAodm9pZCljYW5jZWxIaWdobGlnaHQKK3sKKyAgICBbX2hpZ2hsaWdodExvbmdQcmVzc0dlc3R1 cmVSZWNvZ25pemVyIGNhbmNlbF07Cit9CisKIC0gKHZvaWQpX2xvbmdQcmVzc1JlY29nbml6ZWQ6 KFVJTG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIgKilnZXN0dXJlUmVjb2duaXplcgogewogICAg IEFTU0VSVChnZXN0dXJlUmVjb2duaXplciA9PSBfbG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIp Owo=