133510 2014-06-04 06:01:49 -0700 [MediaStream] MediaStream.addTrack should not check for tracks ended state. 2014-06-09 02:46:13 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kiran.guduru webkit-unassigned commit-queue eric.carlson glenn hta jer.noble lucas.de.marchi philipj sergio tommyw oldest_to_newest 1013303 0 kiran.guduru 2014-06-04 06:01:49 -0700 As per the updated spec, MediaStream.addTrack() should not check for tracks ended state. https://www.w3.org/Bugs/Public/show_bug.cgi?id=25250 1013304 1 232475 kiran.guduru 2014-06-04 06:11:01 -0700 Created attachment 232475 MediaStream.addTrack should not check for tracks ended state. MediaStream.addTrack should not check for tracks ended state. 1013307 2 232476 kiran.guduru 2014-06-04 07:06:24 -0700 Created attachment 232476 MediaStream.addTrack should not check for tracks ended state. Added test files. 1013327 3 232476 eric.carlson 2014-06-04 09:19:04 -0700 Comment on attachment 232476 MediaStream.addTrack should not check for tracks ended state. View in context: https://bugs.webkit.org/attachment.cgi?id=232476&action=review If you address the comments, fill in the "Reviewed by" in each ChangeLog, and upload the new patch WITHOUT orphaning the old version, you don't need another review and any reviewer will mark it cq+. > Source/WebCore/ChangeLog:14 > + (WebCore::MediaStreamPrivate::addTrack): Nit: I think it is helpful to have a comment about what changed. > LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:1 > +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> Nit: you should use an HTML5 doctype here: "<!DOCTYPE html>" > LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:7 > + > + Nit: you have an extra blank line. > LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:10 > + Ditto. > LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:41 > + Ditto. > LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:50 > + Ditto. 1013451 4 232519 kiran.guduru 2014-06-04 20:38:03 -0700 Created attachment 232519 MediaStream.addTrack should not check for tracks ended state. Added comment line and removed blank spaces as per the review comments. 1013497 5 232519 commit-queue 2014-06-05 02:43:15 -0700 Comment on attachment 232519 MediaStream.addTrack should not check for tracks ended state. Clearing flags on attachment: 232519 Committed r169611: <http://trac.webkit.org/changeset/169611> 1014086 6 kiran.guduru 2014-06-09 02:45:38 -0700 Patches landed, so closing the bug. 232475 2014-06-04 06:11:01 -0700 2014-06-04 07:06:24 -0700 MediaStream.addTrack should not check for tracks ended state. patch.txt text/plain 1581 kiran.guduru SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTU4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA2LTA0ICBLaXJhbiAg PGtpcmFuLmd1ZHVydUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbTWVkaWFTdHJlYW1dIE1lZGlh U3RyZWFtLmFkZFRyYWNrIHNob3VsZCBub3QgY2hlY2sgZm9yIHRyYWNrcyBlbmRlZCBzdGF0ZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzUxMC4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMsIHNpbmNlIHRoaXMgcGF0Y2ggZG9zZW50IHJhaXNlcyBhbnkgZXhjZXB0aW9uIG9uIGFk ZGluZyBlbmVkIHRyYWNrcy4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlh U3RyZWFtUHJpdmF0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVN0cmVhbVByaXZhdGU6 OmFkZFRyYWNrKToKKwogMjAxNC0wNi0wNCAgUmFkdSBTdGF2aWxhICA8c3RhdmlsYUBhZG9iZS5j b20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogW0NTUyBSZWdpb25zXSBSZWdpb25zIHdpdGggb3Zl cmZsb3c6YXV0byBnZW5lcmF0ZSBzY3JvbGxiYXJzIGV2ZW4gaWYgdGhlIGNvbnRlbnQgZmxvd3Mg aW50byB0aGUgZm9sbG93aW5nIHJlZ2lvbnMgYW5kIGFzIHN1Y2gsIHNob3VsZCBub3QgYmUgc2Ny b2xsZWQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3Ry ZWFtUHJpdmF0ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVk aWFzdHJlYW0vTWVkaWFTdHJlYW1Qcml2YXRlLmNwcAkocmV2aXNpb24gMTY5NTg1KQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1Qcml2YXRlLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTc3LDkgKzE3Nyw2IEBAIHZvaWQgTWVkaWFTdHJlYW1Qcml2YXRl OjpzZXRBY3RpdmUoYm9vbAogdm9pZCBNZWRpYVN0cmVhbVByaXZhdGU6OmFkZFRyYWNrKFBhc3NS ZWZQdHI8TWVkaWFTdHJlYW1UcmFja1ByaXZhdGU+IHBycFRyYWNrKQogewogICAgIFJlZlB0cjxN ZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZT4gdHJhY2sgPSBwcnBUcmFjazsKLSAgICBpZiAodHJhY2st PmVuZGVkKCkpCi0gICAgICAgIHJldHVybjsKLQogICAgIFZlY3RvcjxSZWZQdHI8TWVkaWFTdHJl YW1UcmFja1ByaXZhdGU+PiYgdHJhY2tzID0gdHJhY2stPnR5cGUoKSA9PSBNZWRpYVN0cmVhbVNv dXJjZTo6QXVkaW8gPyBtX2F1ZGlvUHJpdmF0ZVRyYWNrcyA6IG1fdmlkZW9Qcml2YXRlVHJhY2tz OwogCiAgICAgc2l6ZV90IHBvcyA9IHRyYWNrcy5maW5kKHRyYWNrKTsK 232476 2014-06-04 07:06:24 -0700 2014-06-04 09:19:04 -0700 MediaStream.addTrack should not check for tracks ended state. patch.txt text/plain 5905 kiran.guduru SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTU4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA2LTA0ICBLaXJhbiAg PGtpcmFuLmd1ZHVydUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbTWVkaWFTdHJlYW1dIE1lZGlh U3RyZWFtLmFkZFRyYWNrIHNob3VsZCBub3QgY2hlY2sgZm9yIHRyYWNrcyBlbmRlZCBzdGF0ZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzUxMAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGluZyBh bmQgcmVtb3Zpbmcgb2YgdHJhY2tzIHRvIGEgTWVkaWFTdHJlYW0gc2hvdWxkIG5vdCBoYXZlIGRl cGVuZGVuY3kKKyAgICAgICAgb24gdHJhY2tzIHN0YXRlLgorCisgICAgICAgIFRlc3Q6IGZhc3Qv bWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0tYWRkLWVuZGVkLXRyYWNrcy5odG1sCisKKyAgICAgICAg KiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVByaXZhdGUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFTdHJlYW1Qcml2YXRlOjphZGRUcmFjayk6CisKIDIwMTQtMDYtMDQgIFJh ZHUgU3RhdmlsYSAgPHN0YXZpbGFAYWRvYmUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046IFtD U1MgUmVnaW9uc10gUmVnaW9ucyB3aXRoIG92ZXJmbG93OmF1dG8gZ2VuZXJhdGUgc2Nyb2xsYmFy cyBldmVuIGlmIHRoZSBjb250ZW50IGZsb3dzIGludG8gdGhlIGZvbGxvd2luZyByZWdpb25zIGFu ZCBhcyBzdWNoLCBzaG91bGQgbm90IGJlIHNjcm9sbGVkCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVByaXZhdGUuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtUHJpdmF0ZS5j cHAJKHJldmlzaW9uIDE2OTU4NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL01lZGlhU3RyZWFtUHJpdmF0ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3Nyw5ICsxNzcs NiBAQCB2b2lkIE1lZGlhU3RyZWFtUHJpdmF0ZTo6c2V0QWN0aXZlKGJvb2wKIHZvaWQgTWVkaWFT dHJlYW1Qcml2YXRlOjphZGRUcmFjayhQYXNzUmVmUHRyPE1lZGlhU3RyZWFtVHJhY2tQcml2YXRl PiBwcnBUcmFjaykKIHsKICAgICBSZWZQdHI8TWVkaWFTdHJlYW1UcmFja1ByaXZhdGU+IHRyYWNr ID0gcHJwVHJhY2s7Ci0gICAgaWYgKHRyYWNrLT5lbmRlZCgpKQotICAgICAgICByZXR1cm47Ci0K ICAgICBWZWN0b3I8UmVmUHRyPE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlPj4mIHRyYWNrcyA9IHRy YWNrLT50eXBlKCkgPT0gTWVkaWFTdHJlYW1Tb3VyY2U6OkF1ZGlvID8gbV9hdWRpb1ByaXZhdGVU cmFja3MgOiBtX3ZpZGVvUHJpdmF0ZVRyYWNrczsKIAogICAgIHNpemVfdCBwb3MgPSB0cmFja3Mu ZmluZCh0cmFjayk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjk1ODYpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0wNi0wNCAgS2ly YW4gIDxraXJhbi5ndWR1cnVAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW01lZGlhU3RyZWFtXSBN ZWRpYVN0cmVhbS5hZGRUcmFjayBzaG91bGQgbm90IGNoZWNrIGZvciB0cmFja3MgZW5kZWQgc3Rh dGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM1 MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZh c3QvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0tYWRkLWVuZGVkLXRyYWNrcy1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0tYWRkLWVuZGVk LXRyYWNrcy5odG1sOiBBZGRlZC4KKwogMjAxNC0wNi0wNCAgUmFkdSBTdGF2aWxhICA8c3Rhdmls YUBhZG9iZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogW0NTUyBSZWdpb25zXSBSZWdpb25z IHdpdGggb3ZlcmZsb3c6YXV0byBnZW5lcmF0ZSBzY3JvbGxiYXJzIGV2ZW4gaWYgdGhlIGNvbnRl bnQgZmxvd3MgaW50byB0aGUgZm9sbG93aW5nIHJlZ2lvbnMgYW5kIGFzIHN1Y2gsIHNob3VsZCBu b3QgYmUgc2Nyb2xsZWQKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vTWVkaWFT dHJlYW0tYWRkLWVuZGVkLXRyYWNrcy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS1hZGQtZW5kZWQtdHJhY2tzLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vTWVk aWFTdHJlYW0tYWRkLWVuZGVkLXRyYWNrcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMTMgQEAKK1Rlc3QgYWRkaW5nIHRyYWNrcyB0byBpbmFjdGl2ZSBNZWRpYVN0cmVhbS4K KworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywg Zm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1Mgc3RyZWFtMS5nZXRBdWRpb1Ry YWNrcygpLmxlbmd0aCBpcyAxCitQQVNTIHN0cmVhbTIuZ2V0QXVkaW9UcmFja3MoKS5sZW5ndGgg aXMgMQorUEFTUyBhdWRpb1RyYWNrLnJlYWR5U3RhdGUgaXMgImVuZGVkIgorUEFTUyBzdHJlYW0y LmdldEF1ZGlvVHJhY2tzKCkubGVuZ3RoIGlzIDIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlz IHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L21lZGlhc3Ry ZWFtL01lZGlhU3RyZWFtLWFkZC1lbmRlZC10cmFja3MuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLWFkZC1lbmRlZC10cmFja3MuaHRt bAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vTWVkaWFTdHJl YW0tYWRkLWVuZGVkLXRyYWNrcy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDgwIEBACis8 IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKyAg ICA8aGVhZD4KKyAgICAgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBy ZS5qcyI+PC9zY3JpcHQ+CisgICAgICAgIDxzY3JpcHQ+CisKKworICAgICAgICAgICAgdmFyIHN0 cmVhbTE7CisgICAgICAgICAgICB2YXIgc3RyZWFtMjsKKworICAgICAgICAgICAgdmFyIGF1ZGlv VHJhY2s7CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIGVycm9yKCkKKyAgICAgICAgICAgIHsKKyAg ICAgICAgICAgICAgICB0ZXN0RmFpbGVkKCdTdHJlYW0gZ2VuZXJhdGlvbiBmYWlsZWQuJyk7Cisg ICAgICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgICAgICAgICB9CisKKyAgICAgICAg ICAgIGZ1bmN0aW9uIGdldFVzZXJNZWRpYShkaWN0aW9uYXJ5LCBjYWxsYmFjaykKKyAgICAgICAg ICAgIHsKKyAgICAgICAgICAgICAgICB0cnkgeworICAgICAgICAgICAgICAgICAgICBuYXZpZ2F0 b3Iud2Via2l0R2V0VXNlck1lZGlhKGRpY3Rpb25hcnksIGNhbGxiYWNrLCBlcnJvcik7CisgICAg ICAgICAgICAgICAgfSBjYXRjaCAoZSkgeworICAgICAgICAgICAgICAgICAgICB0ZXN0RmFpbGVk KCd3ZWJraXRHZXRVc2VyTWVkaWEgdGhyZXcgZXhjZXB0aW9uIDonICsgZSk7CisgICAgICAgICAg ICAgICAgICAgIGZpbmlzaEpTVGVzdCgpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAg IH0KKworICAgICAgICAgICAgZnVuY3Rpb24gdHJ5QWRkVHJhY2soc3RyZWFtLCB0cmFjaykKKyAg ICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICB0cnkgeworICAgICAgICAgICAgICAgICAgICBz dHJlYW0uYWRkVHJhY2sodHJhY2spOworICAgICAgICAgICAgICAgIH0gY2F0Y2ggKGV4Y2VwdGlv bikgeworICAgICAgICAgICAgICAgICAgICB0ZXN0RmFpbGVkKCJhZGRUcmFjayB0aHJldyBhbiBl eGNlcHRpb24uIik7CisgICAgICAgICAgICAgICAgICAgIGZpbmlzaEpTVGVzdCgpOworICAgICAg ICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gY3JlYXRl U3RyZWFtQW5kQWRkVHJhY2tzKCkKKyAgICAgICAgICAgIHsKKworICAgICAgICAgICAgICAgIHNo b3VsZEJlKCdzdHJlYW0yLmdldEF1ZGlvVHJhY2tzKCkubGVuZ3RoJywgJzEnKTsKKyAgICAgICAg ICAgICAgICBhdWRpb1RyYWNrID0gc3RyZWFtMS5nZXRBdWRpb1RyYWNrcygpWzBdOworICAgICAg ICAgICAgICAgIGF1ZGlvVHJhY2suc3RvcCgpOworICAgICAgICAgICAgICAgIHNob3VsZEJlRXF1 YWxUb1N0cmluZygnYXVkaW9UcmFjay5yZWFkeVN0YXRlJywgJ2VuZGVkJyk7CisgICAgICAgICAg ICAgICAgdHJ5QWRkVHJhY2soc3RyZWFtMiwgYXVkaW9UcmFjayk7CisgICAgICAgICAgICAgICAg c2hvdWxkQmUoJ3N0cmVhbTIuZ2V0QXVkaW9UcmFja3MoKS5sZW5ndGgnLCAnMicpOworCisgICAg ICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7CisKKyAgICAgICAgICAgIH0KKworICAgICAgICAg ICAgZnVuY3Rpb24gZ290U3RyZWFtMihzKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAg IHN0cmVhbTIgPSBzOworICAgICAgICAgICAgICAgIGNyZWF0ZVN0cmVhbUFuZEFkZFRyYWNrcygp OworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBnb3RTdHJlYW0xKHMpCisg ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgc3RyZWFtMSA9IHM7CisgICAgICAgICAgICAg ICAgc2hvdWxkQmUoJ3N0cmVhbTEuZ2V0QXVkaW9UcmFja3MoKS5sZW5ndGgnLCAnMScpOworICAg ICAgICAgICAgICAgIGdldFVzZXJNZWRpYSh7YXVkaW86dHJ1ZSwgdmlkZW86dHJ1ZX0sIGdvdFN0 cmVhbTIpOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBzdGFydE1lZGlh KCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBkZXNjcmlwdGlvbigiVGVzdCBhZGRp bmcgdHJhY2tzIHRvIGluYWN0aXZlIE1lZGlhU3RyZWFtLiIpOworICAgICAgICAgICAgICAgIGdl dFVzZXJNZWRpYSh7YXVkaW86dHJ1ZSwgdmlkZW86dHJ1ZX0sIGdvdFN0cmVhbTEpOyAKKyAgICAg ICAgICAgIH0KKyAgICAgICAgICAgIHdpbmRvdy5qc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKyAgICAg ICAgICAgIHdpbmRvdy5zdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworICAgICAgICA8L3Njcmlw dD4KKyAgICAgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMi Pjwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keSBvbmxvYWQ9InN0YXJ0TWVkaWEoKSI+ CisgICAgICAgIDxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorICAgICAgICA8ZGl2IGlkPSJjb25z b2xlIj48L2Rpdj4KKyAgICA8L2JvZHk+Cis8L2h0bWw+Cg== 232519 2014-06-04 20:38:03 -0700 2014-06-05 02:43:15 -0700 MediaStream.addTrack should not check for tracks ended state. patch_for_landing.txt text/plain 5984 kiran.guduru SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTU4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA2LTA0ICBLaXJhbiAg PGtpcmFuLmd1ZHVydUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbTWVkaWFTdHJlYW1dIE1lZGlh U3RyZWFtLmFkZFRyYWNrIHNob3VsZCBub3QgY2hlY2sgZm9yIHRyYWNrcyBlbmRlZCBzdGF0ZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzUxMAor CisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KKworICAgICAgICBBZGRpbmcgYW5k IHJlbW92aW5nIG9mIHRyYWNrcyB0byBhIE1lZGlhU3RyZWFtIHNob3VsZCBub3QgaGF2ZSBkZXBl bmRlbmN5CisgICAgICAgIG9uIHRyYWNrcyBzdGF0ZS4gU28gdGhlIGNoZWNrIGZvciBNZWRpYVN0 cmVhbVRyYWNrJ3MgZW5kZWQgc3RhdGUgaGFzIGJlZW4KKyAgICAgICAgcmVtb3ZlZCB3aGlsZSBh ZGRpbmcgYSB0cmFjayBpbiBNZWRpYVN0cmVhbVByaXZhdGUuY3BwLgorCisgICAgICAgIFRlc3Q6 IGZhc3QvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0tYWRkLWVuZGVkLXRyYWNrcy5odG1sCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVByaXZhdGUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6TWVkaWFTdHJlYW1Qcml2YXRlOjphZGRUcmFjayk6CisKIDIwMTQtMDYt MDQgIFJhZHUgU3RhdmlsYSAgPHN0YXZpbGFAYWRvYmUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJ T046IFtDU1MgUmVnaW9uc10gUmVnaW9ucyB3aXRoIG92ZXJmbG93OmF1dG8gZ2VuZXJhdGUgc2Ny b2xsYmFycyBldmVuIGlmIHRoZSBjb250ZW50IGZsb3dzIGludG8gdGhlIGZvbGxvd2luZyByZWdp b25zIGFuZCBhcyBzdWNoLCBzaG91bGQgbm90IGJlIHNjcm9sbGVkCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVByaXZhdGUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtUHJp dmF0ZS5jcHAJKHJldmlzaW9uIDE2OTU4NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21l ZGlhc3RyZWFtL01lZGlhU3RyZWFtUHJpdmF0ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3Nyw5 ICsxNzcsNiBAQCB2b2lkIE1lZGlhU3RyZWFtUHJpdmF0ZTo6c2V0QWN0aXZlKGJvb2wKIHZvaWQg TWVkaWFTdHJlYW1Qcml2YXRlOjphZGRUcmFjayhQYXNzUmVmUHRyPE1lZGlhU3RyZWFtVHJhY2tQ cml2YXRlPiBwcnBUcmFjaykKIHsKICAgICBSZWZQdHI8TWVkaWFTdHJlYW1UcmFja1ByaXZhdGU+ IHRyYWNrID0gcHJwVHJhY2s7Ci0gICAgaWYgKHRyYWNrLT5lbmRlZCgpKQotICAgICAgICByZXR1 cm47Ci0KICAgICBWZWN0b3I8UmVmUHRyPE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlPj4mIHRyYWNr cyA9IHRyYWNrLT50eXBlKCkgPT0gTWVkaWFTdHJlYW1Tb3VyY2U6OkF1ZGlvID8gbV9hdWRpb1By aXZhdGVUcmFja3MgOiBtX3ZpZGVvUHJpdmF0ZVRyYWNrczsKIAogICAgIHNpemVfdCBwb3MgPSB0 cmFja3MuZmluZCh0cmFjayk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjk1ODYpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0wNi0w NCAgS2lyYW4gIDxraXJhbi5ndWR1cnVAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW01lZGlhU3Ry ZWFtXSBNZWRpYVN0cmVhbS5hZGRUcmFjayBzaG91bGQgbm90IGNoZWNrIGZvciB0cmFja3MgZW5k ZWQgc3RhdGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzM1MTAKKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAg KiBmYXN0L21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLWFkZC1lbmRlZC10cmFja3MtZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLWFkZC1l bmRlZC10cmFja3MuaHRtbDogQWRkZWQuCisKIDIwMTQtMDYtMDQgIFJhZHUgU3RhdmlsYSAgPHN0 YXZpbGFAYWRvYmUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046IFtDU1MgUmVnaW9uc10gUmVn aW9ucyB3aXRoIG92ZXJmbG93OmF1dG8gZ2VuZXJhdGUgc2Nyb2xsYmFycyBldmVuIGlmIHRoZSBj b250ZW50IGZsb3dzIGludG8gdGhlIGZvbGxvd2luZyByZWdpb25zIGFuZCBhcyBzdWNoLCBzaG91 bGQgbm90IGJlIHNjcm9sbGVkCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL01l ZGlhU3RyZWFtLWFkZC1lbmRlZC10cmFja3MtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0tYWRkLWVuZGVkLXRyYWNrcy1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFt L01lZGlhU3RyZWFtLWFkZC1lbmRlZC10cmFja3MtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDEzIEBACitUZXN0IGFkZGluZyB0cmFja3MgdG8gaW5hY3RpdmUgTWVkaWFTdHJl YW0uCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2Fn ZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHN0cmVhbTEuZ2V0QXVk aW9UcmFja3MoKS5sZW5ndGggaXMgMQorUEFTUyBzdHJlYW0yLmdldEF1ZGlvVHJhY2tzKCkubGVu Z3RoIGlzIDEKK1BBU1MgYXVkaW9UcmFjay5yZWFkeVN0YXRlIGlzICJlbmRlZCIKK1BBU1Mgc3Ry ZWFtMi5nZXRBdWRpb1RyYWNrcygpLmxlbmd0aCBpcyAyCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9tZWRp YXN0cmVhbS9NZWRpYVN0cmVhbS1hZGQtZW5kZWQtdHJhY2tzLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS1hZGQtZW5kZWQtdHJhY2tz Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL01lZGlh U3RyZWFtLWFkZC1lbmRlZC10cmFja3MuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw3NiBA QAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHNjcmlwdCBz cmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CisgICAgICAgIDxz Y3JpcHQ+CisKKyAgICAgICAgICAgIHZhciBzdHJlYW0xOworICAgICAgICAgICAgdmFyIHN0cmVh bTI7CisgICAgICAgICAgICB2YXIgYXVkaW9UcmFjazsKKworICAgICAgICAgICAgZnVuY3Rpb24g ZXJyb3IoKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHRlc3RGYWlsZWQoJ1N0cmVh bSBnZW5lcmF0aW9uIGZhaWxlZC4nKTsKKyAgICAgICAgICAgICAgICBmaW5pc2hKU1Rlc3QoKTsK KyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gZ2V0VXNlck1lZGlhKGRpY3Rp b25hcnksIGNhbGxiYWNrKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHRyeSB7Cisg ICAgICAgICAgICAgICAgICAgIG5hdmlnYXRvci53ZWJraXRHZXRVc2VyTWVkaWEoZGljdGlvbmFy eSwgY2FsbGJhY2ssIGVycm9yKTsKKyAgICAgICAgICAgICAgICB9IGNhdGNoIChlKSB7CisgICAg ICAgICAgICAgICAgICAgIHRlc3RGYWlsZWQoJ3dlYmtpdEdldFVzZXJNZWRpYSB0aHJldyBleGNl cHRpb24gOicgKyBlKTsKKyAgICAgICAgICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAg ICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiB0cnlB ZGRUcmFjayhzdHJlYW0sIHRyYWNrKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHRy eSB7CisgICAgICAgICAgICAgICAgICAgIHN0cmVhbS5hZGRUcmFjayh0cmFjayk7CisgICAgICAg ICAgICAgICAgfSBjYXRjaCAoZXhjZXB0aW9uKSB7CisgICAgICAgICAgICAgICAgICAgIHRlc3RG YWlsZWQoImFkZFRyYWNrIHRocmV3IGFuIGV4Y2VwdGlvbi4iKTsKKyAgICAgICAgICAgICAgICAg ICAgZmluaXNoSlNUZXN0KCk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorCisg ICAgICAgICAgICBmdW5jdGlvbiBjcmVhdGVTdHJlYW1BbmRBZGRUcmFja3MoKQorICAgICAgICAg ICAgeworICAgICAgICAgICAgICAgIHNob3VsZEJlKCdzdHJlYW0yLmdldEF1ZGlvVHJhY2tzKCku bGVuZ3RoJywgJzEnKTsKKyAgICAgICAgICAgICAgICBhdWRpb1RyYWNrID0gc3RyZWFtMS5nZXRB dWRpb1RyYWNrcygpWzBdOworICAgICAgICAgICAgICAgIGF1ZGlvVHJhY2suc3RvcCgpOworICAg ICAgICAgICAgICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygnYXVkaW9UcmFjay5yZWFkeVN0YXRl JywgJ2VuZGVkJyk7CisgICAgICAgICAgICAgICAgdHJ5QWRkVHJhY2soc3RyZWFtMiwgYXVkaW9U cmFjayk7CisgICAgICAgICAgICAgICAgc2hvdWxkQmUoJ3N0cmVhbTIuZ2V0QXVkaW9UcmFja3Mo KS5sZW5ndGgnLCAnMicpOworCisgICAgICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAg ICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIGdvdFN0cmVhbTIocykKKyAgICAgICAg ICAgIHsKKyAgICAgICAgICAgICAgICBzdHJlYW0yID0gczsKKyAgICAgICAgICAgICAgICBjcmVh dGVTdHJlYW1BbmRBZGRUcmFja3MoKTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVu Y3Rpb24gZ290U3RyZWFtMShzKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHN0cmVh bTEgPSBzOworICAgICAgICAgICAgICAgIHNob3VsZEJlKCdzdHJlYW0xLmdldEF1ZGlvVHJhY2tz KCkubGVuZ3RoJywgJzEnKTsKKyAgICAgICAgICAgICAgICBnZXRVc2VyTWVkaWEoe2F1ZGlvOnRy dWUsIHZpZGVvOnRydWV9LCBnb3RTdHJlYW0yKTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAg ICAgZnVuY3Rpb24gc3RhcnRNZWRpYSgpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAg ZGVzY3JpcHRpb24oIlRlc3QgYWRkaW5nIHRyYWNrcyB0byBpbmFjdGl2ZSBNZWRpYVN0cmVhbS4i KTsKKyAgICAgICAgICAgICAgICBnZXRVc2VyTWVkaWEoe2F1ZGlvOnRydWUsIHZpZGVvOnRydWV9 LCBnb3RTdHJlYW0xKTsgCisgICAgICAgICAgICB9CisgICAgICAgICAgICB3aW5kb3cuanNUZXN0 SXNBc3luYyA9IHRydWU7CisgICAgICAgICAgICB3aW5kb3cuc3VjY2Vzc2Z1bGx5UGFyc2VkID0g dHJ1ZTsKKyAgICAgICAgPC9zY3JpcHQ+CisgICAgICAgIDxzY3JpcHQgc3JjPSIuLi8uLi9yZXNv dXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKyAgICA8L2hlYWQ+CisgICAgPGJvZHkg b25sb2FkPSJzdGFydE1lZGlhKCkiPgorICAgICAgICA8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4K KyAgICAgICAgPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisgICAgPC9ib2R5PgorPC9odG1sPgo=