133499 2014-06-03 20:49:50 -0700 [CSS Shapes] Fix off by one in creating a RasterShape 2014-06-04 21:07:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bjonesbe bjonesbe commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1013213 0 bjonesbe 2014-06-03 20:49:50 -0700 Fix off by one in creating a RasterShape 1013215 1 bjonesbe 2014-06-03 20:54:56 -0700 Note that crash is not a security issue because it is caught by a release assert in WTF::Vector. 1013217 2 232463 bjonesbe 2014-06-03 20:57:49 -0700 Created attachment 232463 Patch 1013419 3 232463 darin 2014-06-04 17:16:42 -0700 Comment on attachment 232463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232463&action=review > LayoutTests/ChangeLog:9 > + * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash-expected.txt: Added. > + * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash.html: Added. Would be nicer to do some kind of reference test instead, but maybe that's impractical. 1013427 4 232463 commit-queue 2014-06-04 17:46:09 -0700 Comment on attachment 232463 Patch Clearing flags on attachment: 232463 Committed r169604: <http://trac.webkit.org/changeset/169604> 1013428 5 commit-queue 2014-06-04 17:46:12 -0700 All reviewed patches have been landed. Closing bug. 1013453 6 bjonesbe 2014-06-04 21:07:46 -0700 (In reply to comment #3) > (From update of attachment 232463 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232463&action=review > > > LayoutTests/ChangeLog:9 > > + * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash-expected.txt: Added. > > + * fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash.html: Added. > > Would be nicer to do some kind of reference test instead, but maybe that's impractical. Ref tests for image shapes with different combinations of margin, borders, padding and shape margin are forthcoming. I just wanted to get this one fixed ASAP since it's a crasher. Thanks for the review. 232463 2014-06-03 20:57:49 -0700 2014-06-04 17:46:09 -0700 Patch bug-133499-20140603205724.patch text/plain 4464 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWM3MTEyMzJjOTA3YWQ5 M2Y5MWNiYzc4MDQzZmE2OWE3NWUxZWI3Ny4uODAyM2VjNDU2M2JhNjA4YmYxMDFmNWU4OTI4MTUy MzE0M2IyMmEwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA2LTAzICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgU2hhcGVzXSBG aXggb2ZmIGJ5IG9uZSBpbiBjcmVhdGluZyBhIFJhc3RlclNoYXBlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM0OTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L3NoYXBlcy9zaGFwZS1v dXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1zaGFwZS1tYXJnaW4tY3Jhc2guaHRt bAorCisgICAgICAgICogcmVuZGVyaW5nL3NoYXBlcy9SYXN0ZXJTaGFwZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSYXN0ZXJTaGFwZUludGVydmFsczo6Y29tcHV0ZVNoYXBlTWFyZ2luSW50ZXJ2 YWxzKToKKyAgICAgICAgICAgIG1hcmdpblkxIGlzIHN1cHBvc2VkIHRvIGJlIGFuIGluY2x1c2l2 ZSBlbmRwb2ludCwgaG93ZXZlciwgbWF4WSgpCisgICAgICAgICAgICBpcyBhbiBleGNsdXNpdmUg ZW5kcG9pbnQuIFRoaXMgc2ltcGx5IGNoYW5nZXMgbWFyZ2luWTEgaW50byBhbgorICAgICAgICAg ICAgZXhjbHVzaXZlIGVuZHBvaW50LgorCiAyMDE0LTA2LTAyICBac29sdCBCb3JiZWx5ICA8enNi b3JiZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CiAKICAgICAgICAgV2ViQ29yZSBi dWlsZCBmaXggZm9yIHdlYnJlcGxheQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3NoYXBlcy9SYXN0ZXJTaGFwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hh cGVzL1Jhc3RlclNoYXBlLmNwcAppbmRleCBhZDdkYmNiMTA4MDZmNzE4Mjc3MmU4OTZkZDZhNTM1 MzkyMGFkMTljLi4zNGYyYTc3Y2VhNjUwZjU0YjMyNzgxOTlkNTU2ZTI3N2ZiM2UzNDBmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hhcGVzL1Jhc3RlclNoYXBlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hhcGVzL1Jhc3RlclNoYXBlLmNwcApAQCAt ODYsNyArODYsNyBAQCBzdGQ6OnVuaXF1ZV9wdHI8UmFzdGVyU2hhcGVJbnRlcnZhbHM+IFJhc3Rl clNoYXBlSW50ZXJ2YWxzOjpjb21wdXRlU2hhcGVNYXJnaW5JbgogCiAgICAgICAgIG1hcmdpbklu dGVydmFsR2VuZXJhdG9yLnNldCh5LCBpbnRlcnZhbEF0WSk7CiAgICAgICAgIGludCBtYXJnaW5Z MCA9IHN0ZDo6bWF4KG1pblkoKSwgeSAtIHNoYXBlTWFyZ2luKTsKLSAgICAgICAgaW50IG1hcmdp blkxID0gc3RkOjptaW4obWF4WSgpLCB5ICsgc2hhcGVNYXJnaW4pOworICAgICAgICBpbnQgbWFy Z2luWTEgPSBzdGQ6Om1pbihtYXhZKCksIHkgKyBzaGFwZU1hcmdpbiArIDEpOwogCiAgICAgICAg IGZvciAoaW50IG1hcmdpblkgPSB5IC0gMTsgbWFyZ2luWSA+PSBtYXJnaW5ZMDsgLS1tYXJnaW5Z KSB7CiAgICAgICAgICAgICBpZiAobWFyZ2luWSA+IGJvdW5kcygpLnkoKSAmJiBpbnRlcnZhbEF0 KG1hcmdpblkpLmNvbnRhaW5zKGludGVydmFsQXRZKSkKQEAgLTk2LDcgKzk2LDcgQEAgc3RkOjp1 bmlxdWVfcHRyPFJhc3RlclNoYXBlSW50ZXJ2YWxzPiBSYXN0ZXJTaGFwZUludGVydmFsczo6Y29t cHV0ZVNoYXBlTWFyZ2luSW4KIAogICAgICAgICByZXN1bHQtPmludGVydmFsQXQoeSkudW5pdGUo bWFyZ2luSW50ZXJ2YWxHZW5lcmF0b3IuaW50ZXJ2YWxBdCh5KSk7CiAKLSAgICAgICAgZm9yIChp bnQgbWFyZ2luWSA9IHkgKyAxOyBtYXJnaW5ZIDw9IG1hcmdpblkxOyArK21hcmdpblkpIHsKKyAg ICAgICAgZm9yIChpbnQgbWFyZ2luWSA9IHkgKyAxOyBtYXJnaW5ZIDwgbWFyZ2luWTE7ICsrbWFy Z2luWSkgewogICAgICAgICAgICAgaWYgKG1hcmdpblkgPCBib3VuZHMoKS5tYXhZKCkgJiYgaW50 ZXJ2YWxBdChtYXJnaW5ZKS5jb250YWlucyhpbnRlcnZhbEF0WSkpCiAgICAgICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgICAgICByZXN1bHQtPmludGVydmFsQXQobWFyZ2luWSkudW5pdGUobWFy Z2luSW50ZXJ2YWxHZW5lcmF0b3IuaW50ZXJ2YWxBdChtYXJnaW5ZKSk7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjAzMWQ1 OTYxNGM0YWRlZWI1NTAzM2UyZmQ1ZTM4YmIwMjhkNzdmYi4uYjI1Mzk0YTRlZWI3ODc3NWYzMGUw MTg4N2VkNTZmNmUwMDcwYmRhNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA2LTAzICBC ZW0gSm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgU2hhcGVz XSBGaXggb2ZmIGJ5IG9uZSBpbiBjcmVhdGluZyBhIFJhc3RlclNoYXBlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM0OTkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3Qvc2hhcGVzL3NoYXBlLW91 dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxvYXRzLXNoYXBlLW1hcmdpbi1jcmFzaC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxv YXRzL3NoYXBlLW91dHNpZGUtZmxvYXRzLXNoYXBlLW1hcmdpbi1jcmFzaC5odG1sOiBBZGRlZC4K KwogMjAxNC0wNi0wMiAgTWFydGluIEhvY2sgIDxtaG9ja0BhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCBUZXN0RXhwZWN0YXRpb25zIGdhcmRlbmluZyBhZnRlciByMTY5NTMyLgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hh cGUtb3V0c2lkZS1mbG9hdHMtc2hhcGUtbWFyZ2luLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxv YXRzLXNoYXBlLW1hcmdpbi1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZmMwNjYwY2Y3 YTE5OWJkYzg4NTY5OTNkZDU3NzZjMmRlZGExMzU2ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxv YXRzLXNoYXBlLW1hcmdpbi1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorVGhpcyB0 ZXN0IHNob3VsZCBub3QgY3Jhc2guCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3NoYXBl cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1zaGFwZS1tYXJnaW4t Y3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRz L3NoYXBlLW91dHNpZGUtZmxvYXRzLXNoYXBlLW1hcmdpbi1jcmFzaC5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjlhYmIzMTI4MWZlNzQwNDhkZjljMTJmNjU4ZmJmYmJjZmFiOGM2NmEKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1v dXRzaWRlLWZsb2F0cy1zaGFwZS1tYXJnaW4tY3Jhc2guaHRtbApAQCAtMCwwICsxLDE5IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxzdHlsZT4KK2RpdiB7CisgICAgd2lkdGg6IDVweDsKKyAgICBoZWln aHQ6IDVweDsKKyAgICBtYXJnaW4tdG9wOiAycHg7CisgICAgLXdlYmtpdC1zaGFwZS1tYXJnaW46 IDJweDsKKyAgICAtd2Via2l0LXNoYXBlLW91dHNpZGU6IHVybCgiZGF0YTppbWFnZS9zdmcreG1s O3V0ZjgsPHN2ZyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcnIHdpZHRoPSc1JyBo ZWlnaHQ9JzUnPjxyZWN0IHg9JzAnIHk9JzAnIHdpZHRoPScxMDAlJyBoZWlnaHQ9JzEwMCUnLz48 L3N2Zz4iKTsKKyAgICBmbG9hdDpsZWZ0OworfQorPC9zdHlsZT4KKzxzY3JpcHQ+CisgICAgaWYg KHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKzwv c2NyaXB0PgorPGJvZHk+CisgICAgPGRpdj48L2Rpdj4KKyAgICBUaGlzIHRlc3Qgc2hvdWxkIG5v dCBjcmFzaC4KKzwvYm9keT4K