133495 2014-06-03 17:53:59 -0700 Pasting multiple photos on iOS only pastes one photo 2014-06-06 14:57:41 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jhoneycutt jhoneycutt ap benjamin enrica rniwa oldest_to_newest 1013188 0 jhoneycutt 2014-06-03 17:53:59 -0700 Pasting multiple photos in Mail's compose mail sheet only pastes one photo. <rdar://problem/16138616> 1013192 1 232455 jhoneycutt 2014-06-03 18:10:33 -0700 Created attachment 232455 Patch 1013370 2 jhoneycutt 2014-06-04 13:47:16 -0700 Committed r169594: <http://trac.webkit.org/changeset/169594> 1013686 3 ap 2014-06-05 16:40:42 -0700 I happened to look into the same code today, and now I don't understand something. Pasteboard::read() already iterates over all items, and adds fragments for them. So we do we even need documentFragmentFromDelegate() before calling webContentFromPasteboard(), which calls Pasteboard::read()? 1013859 4 jhoneycutt 2014-06-06 14:57:41 -0700 (In reply to comment #3) > I happened to look into the same code today, and now I don't understand something. > > Pasteboard::read() already iterates over all items, and adds fragments for them. So we do we even need documentFragmentFromDelegate() before calling webContentFromPasteboard(), which calls Pasteboard::read()? Mail uses this delegate call to (at least) resize the images that are pasted. I'm not sure if it does anything else. 232455 2014-06-03 18:10:33 -0700 2014-06-04 13:19:27 -0700 Patch bug-133495-20140603181008.patch text/plain 3103 jhoneycutt U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGY0MzBjOWYyOWI4OWVm YTVkODBiN2RhOTNhZjUyNjM2YjdhMDQ2MC4uYzA1ZTAzMTFkYTgyYTk4MDBlMTFkMjkzMDhhNGE5 NDI5MmQyM2UzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA2LTAzICBKb24g SG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+CisKKyAgICAgICAgUGFzdGluZyBtdWx0 aXBsZSBwaG90b3Mgb24gaU9TIG9ubHkgcGFzdGVzIG9uZSBwaG90bworCisgICAgICAgIDxodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzNDk1PgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMTYxMzg2MTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBlZGl0aW5nL2lvcy9FZGl0b3JJT1MubW06CisgICAgICAgIChXZWJD b3JlOjpFZGl0b3I6OnBhc3RlV2l0aFBhc3RlYm9hcmQpOgorICAgICAgICBDcmVhdGUgYSBXZWJD b250ZW50UmVhZGVyLiBGb3IgZWFjaCBwYXN0ZWJvYXJkIGl0ZW0sIGdldCB0aGUgZG9jdW1lbnQK KyAgICAgICAgZnJhZ21lbnQgZm9yIHRoYXQgaXRlbSwgYW5kIGFkZCBpdCB0byB0aGUgcmVhZGVy LiBJZiB3ZSBmYWlsIHRvIGdldAorICAgICAgICB0aGUgZnJhZ21lbnQgZnJvbSB0aGUgZGVsZWdh dGUsIGZhbGwgYmFjayB0byB1c2luZworICAgICAgICB3ZWJDb250ZW50RnJvbVBhc3RlYm9hcmQo KSBhcyBiZWZvcmUuCisKIDIwMTQtMDUtMjggIEpvbiBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFw cGxlLmNvbT4KIAogICAgICAgICBSb2xsIHIxNjg2NjggYmFjayBpbi4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvaW9zL0VkaXRvcklPUy5tbSBiL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvaW9zL0VkaXRvcklPUy5tbQppbmRleCBkOWM3MGZjNzgwNzYwZWJlZTAzZTljMDY1MDY0 MWEyZmI2ZGRiNjk3Li4zNTI3MGMwNmJiZGIxNjYzYjcwODVjYTM2M2EwZmVhYTBmMTYxZjE5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2lvcy9FZGl0b3JJT1MubW0KKysrIGIv U291cmNlL1dlYkNvcmUvZWRpdGluZy9pb3MvRWRpdG9ySU9TLm1tCkBAIC0zOTksNiArMzk5LDgg QEAgcHVibGljOgogICAgIHsKICAgICB9CiAKKyAgICB2b2lkIGFkZEZyYWdtZW50KFBhc3NSZWZQ dHI8RG9jdW1lbnRGcmFnbWVudD4pOworCiAgICAgRnJhbWUmIGZyYW1lOwogICAgIFJhbmdlJiBj b250ZXh0OwogICAgIGNvbnN0IGJvb2wgYWxsb3dQbGFpblRleHQ7CkBAIC00MTUsNyArNDE3LDYg QEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgcmVhZEltYWdlKFBhc3NSZWZQdHI8U2hhcmVk QnVmZmVyPiwgY29uc3QgU3RyaW5nJiB0eXBlKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIGJvb2wg cmVhZFVSTChjb25zdCBVUkwmLCBjb25zdCBTdHJpbmcmIHRpdGxlKSBvdmVycmlkZTsKICAgICB2 aXJ0dWFsIGJvb2wgcmVhZFBsYWluVGV4dChjb25zdCBTdHJpbmcmKSBvdmVycmlkZTsKLSAgICB2 b2lkIGFkZEZyYWdtZW50KFBhc3NSZWZQdHI8RG9jdW1lbnRGcmFnbWVudD4pOwogfTsKIAogdm9p ZCBFZGl0b3I6OldlYkNvbnRlbnRSZWFkZXI6OmFkZEZyYWdtZW50KFBhc3NSZWZQdHI8RG9jdW1l bnRGcmFnbWVudD4gbmV3RnJhZ21lbnQpCkBAIC01NTQsMTEgKzU1NSwyMSBAQCBQYXNzUmVmUHRy PERvY3VtZW50RnJhZ21lbnQ+IEVkaXRvcjo6d2ViQ29udGVudEZyb21QYXN0ZWJvYXJkKFBhc3Rl Ym9hcmQmIHBhc3RlYgogdm9pZCBFZGl0b3I6OnBhc3RlV2l0aFBhc3RlYm9hcmQoUGFzdGVib2Fy ZCogcGFzdGVib2FyZCwgYm9vbCBhbGxvd1BsYWluVGV4dCwgTWFpbEJsb2NrcXVvdGVIYW5kbGlu ZyBtYWlsQmxvY2txdW90ZUhhbmRsaW5nKQogewogICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UgPSBz ZWxlY3RlZFJhbmdlKCk7CisgICAgV2ViQ29udGVudFJlYWRlciByZWFkZXIobV9mcmFtZSwgKnJh bmdlLCBhbGxvd1BsYWluVGV4dCk7CisgICAgaW50IG51bWJlck9mUGFzdGVib2FyZEl0ZW1zID0g Y2xpZW50KCktPmdldFBhc3RlYm9hcmRJdGVtc0NvdW50KCk7CisgICAgZm9yIChpbnQgaSA9IDA7 IGkgPCBudW1iZXJPZlBhc3RlYm9hcmRJdGVtczsgKytpKSB7CisgICAgICAgIFJlZlB0cjxEb2N1 bWVudEZyYWdtZW50PiBmcmFnbWVudCA9IGNsaWVudCgpLT5kb2N1bWVudEZyYWdtZW50RnJvbURl bGVnYXRlKGkpOworICAgICAgICBpZiAoIWZyYWdtZW50KQorICAgICAgICAgICAgY29udGludWU7 CiAKLSAgICBib29sIGNob3NlUGxhaW5UZXh0OwotICAgIFJlZlB0cjxEb2N1bWVudEZyYWdtZW50 PiBmcmFnbWVudCA9IGNsaWVudCgpLT5kb2N1bWVudEZyYWdtZW50RnJvbURlbGVnYXRlKDApOwot ICAgIGlmICghZnJhZ21lbnQpCi0gICAgICAgIGZyYWdtZW50ID0gd2ViQ29udGVudEZyb21QYXN0 ZWJvYXJkKCpwYXN0ZWJvYXJkLCAqcmFuZ2UsIGFsbG93UGxhaW5UZXh0LCBjaG9zZVBsYWluVGV4 dCk7CisgICAgICAgIHJlYWRlci5hZGRGcmFnbWVudChmcmFnbWVudCk7CisgICAgfQorCisgICAg UmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IGZyYWdtZW50ID0gcmVhZGVyLmZyYWdtZW50OworICAg IGlmICghZnJhZ21lbnQpIHsKKyAgICAgICAgYm9vbCBjaG9zZVBsYWluVGV4dElnbm9yZWQ7Cisg ICAgICAgIGZyYWdtZW50ID0gd2ViQ29udGVudEZyb21QYXN0ZWJvYXJkKCpwYXN0ZWJvYXJkLCAq cmFuZ2UsIGFsbG93UGxhaW5UZXh0LCBjaG9zZVBsYWluVGV4dElnbm9yZWQpOworICAgIH0KIAog ICAgIGlmIChmcmFnbWVudCAmJiBzaG91bGRJbnNlcnRGcmFnbWVudChmcmFnbWVudCwgcmFuZ2Us IEVkaXRvckluc2VydEFjdGlvblBhc3RlZCkpCiAgICAgICAgIHBhc3RlQXNGcmFnbWVudChmcmFn bWVudCwgY2FuU21hcnRSZXBsYWNlV2l0aFBhc3RlYm9hcmQoKnBhc3RlYm9hcmQpLCBmYWxzZSwg bWFpbEJsb2NrcXVvdGVIYW5kbGluZyk7Cg==