133494 2014-06-03 17:22:50 -0700 ArrayIterator should not be exposed in Safari 8 2014-06-04 14:55:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified OS X 10.9 RESOLVED FIXED P1 Normal --- 1 ljharb oliver mathias oliver webkit-bug-importer oldest_to_newest 1013182 0 ljharb 2014-06-03 17:22:50 -0700 In Safari 8: - Object.prototype.toString.call(ArrayIterator) === '[object Function'] - typeof ArrayIterator !== 'function' - ArrayIterator() // throws However, none of this is relevant, because the ES6 spec requires that ArrayIterator not be exposed. Per https://twitter.com/ohunt/status/473981524983812096 and https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array-iterator-objects This breaks the es6-shim, and potentially any code that doesn't expect the ArrayIterator global to be defined - or attempts to use it like a standard JS object. 1013358 1 232494 oliver 2014-06-04 13:15:33 -0700 Created attachment 232494 Patch 1013362 2 232494 msaboff 2014-06-04 13:21:17 -0700 Comment on attachment 232494 Patch r=me 1013387 3 oliver 2014-06-04 14:55:18 -0700 Committed r169598: <http://trac.webkit.org/changeset/169598> 232494 2014-06-04 13:15:33 -0700 2014-06-04 13:21:16 -0700 Patch bug-133494-20140604131508.patch text/plain 4923 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NTM5MTllODVjODJlNGZjMTMwMGY3MGFiODk2ZjBkYmNhZTc2ZTAzLi5jMDkzYTU4ZWEzMjExYzcy OThmNDEyZDgzMTdkOTljYmEzZDViNGJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNC0wNi0wNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIEFycmF5SXRlcmF0b3Igc2hvdWxkIG5vdCBiZSBleHBvc2VkIGluIFNhZmFyaSA4 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM0OTQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXBhcmF0 ZSBvdXQgdHlwZXMgdGhhdCByZXF1aXJlIGNvbnN0cnVjdG9yIG9iamVjdHMsIGFuZCBkb24ndAor ICAgICAgICBpbmNsdWRlIHRoZSBpdGVyYXRvciB0eXBlcyBpbiB0aGF0IGxpc3QuCisKKyAgICAg ICAgKiBydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxP YmplY3Q6OnJlc2V0KToKKyAgICAgICAgKiBydW50aW1lL0pTR2xvYmFsT2JqZWN0Lmg6CisKIDIw MTQtMDYtMDMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBMTFZN IHNvZnQtbGlua2luZyBzaG91bGQgYmUgdHJ1bHkgZmFpbC1zaWxlbnQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcAppbmRleCAzZmY2NWYyYzQ4 MjJhNDdkNGVhYjVmNzIxNTg1YjVkYjc4MGQ0NGE1Li45MTQ3MWFhMTU0MjQ1ZmFkYzRkZTM5MWEy MWNiODFkN2Y5MzBlOTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0dsb2JhbE9iamVjdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNHbG9iYWxPYmplY3QuY3BwCkBAIC00MjEsNyArNDIxLDcgQEAgdm9pZCBKU0dsb2JhbE9iamVj dDo6cmVzZXQoSlNWYWx1ZSBwcm90b3R5cGUpCiAjZGVmaW5lIFBVVF9DT05TVFJVQ1RPUl9GT1Jf U0lNUExFX1RZUEUoY2FwaXRhbE5hbWUsIGxvd2VyTmFtZSwgcHJvcGVyTmFtZSwgaW5zdGFuY2VU eXBlLCBqc05hbWUpIFwKICAgICBwdXREaXJlY3RXaXRob3V0VHJhbnNpdGlvbih2bSwgdm0ucHJv cGVydHlOYW1lcy0+IGpzTmFtZSwgbG93ZXJOYW1lICMjIENvbnN0cnVjdG9yLCBEb250RW51bSk7 IFwKIAotICAgIEZPUl9FQUNIX1NJTVBMRV9CVUlMVElOX1RZUEUoUFVUX0NPTlNUUlVDVE9SX0ZP Ul9TSU1QTEVfVFlQRSkKKyAgICBGT1JfRUFDSF9TSU1QTEVfQlVJTFRJTl9UWVBFX1dJVEhfQ09O U1RSVUNUT1IoUFVUX0NPTlNUUlVDVE9SX0ZPUl9TSU1QTEVfVFlQRSkKIAogI3VuZGVmIFBVVF9D T05TVFJVQ1RPUl9GT1JfU0lNUExFX1RZUEUKICAgICBQcm90b3R5cGVNYXAmIHByb3RvdHlwZU1h cCA9IHZtLnByb3RvdHlwZU1hcDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTR2xvYmFsT2JqZWN0LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0dsb2JhbE9iamVjdC5oCmluZGV4IGRiYjFkOTFhMTBhMzBmM2VkNzBiM2JkOTY0MGRhNWFkNDU0 ZjczOTIuLjA5NGZhZDAwODg5ZmUzZWQ4MWJjM2VjNDM4NTZjOWE5NmU1ZmUyZmMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuaApAQCAtODUsNyAr ODUsNyBAQCBzdHJ1Y3QgSGFzaFRhYmxlOwogCiAjZGVmaW5lIERFRklORV9TVEFOREFSRF9CVUlM VElOKG1hY3JvLCB1cHBlck5hbWUsIGxvd2VyTmFtZSkgbWFjcm8odXBwZXJOYW1lLCBsb3dlck5h bWUsIGxvd2VyTmFtZSwgSlMgIyMgdXBwZXJOYW1lLCB1cHBlck5hbWUpCiAgICAgCi0jZGVmaW5l IEZPUl9FQUNIX1NJTVBMRV9CVUlMVElOX1RZUEUobWFjcm8pIFwKKyNkZWZpbmUgRk9SX0VBQ0hf U0lNUExFX0JVSUxUSU5fVFlQRV9XSVRIX0NPTlNUUlVDVE9SKG1hY3JvKSBcCiAgICAgbWFjcm8o U2V0LCBzZXQsIHNldCwgSlNTZXQsIFNldCkgXAogICAgIG1hY3JvKE1hcCwgbWFwLCBtYXAsIEpT TWFwLCBNYXApIFwKICAgICBtYWNybyhEYXRlLCBkYXRlLCBkYXRlLCBEYXRlSW5zdGFuY2UsIERh dGUpIFwKQEAgLTk1LDYgKzk1LDkgQEAgc3RydWN0IEhhc2hUYWJsZTsKICAgICBtYWNybyhFcnJv ciwgZXJyb3IsIGVycm9yLCBFcnJvckluc3RhbmNlLCBFcnJvcikgXAogICAgIG1hY3JvKEpTQXJy YXlCdWZmZXIsIGFycmF5QnVmZmVyLCBhcnJheUJ1ZmZlciwgSlNBcnJheUJ1ZmZlciwgQXJyYXlC dWZmZXIpIFwKICAgICBERUZJTkVfU1RBTkRBUkRfQlVJTFRJTihtYWNybywgV2Vha01hcCwgd2Vh a01hcCkgXAorCisjZGVmaW5lIEZPUl9FQUNIX1NJTVBMRV9CVUlMVElOX1RZUEUobWFjcm8pIFwK KyAgICBGT1JfRUFDSF9TSU1QTEVfQlVJTFRJTl9UWVBFX1dJVEhfQ09OU1RSVUNUT1IobWFjcm8p IFwKICAgICBERUZJTkVfU1RBTkRBUkRfQlVJTFRJTihtYWNybywgQXJyYXlJdGVyYXRvciwgYXJy YXlJdGVyYXRvcikgXAogICAgIERFRklORV9TVEFOREFSRF9CVUlMVElOKG1hY3JvLCBBcmd1bWVu dHNJdGVyYXRvciwgYXJndW1lbnRzSXRlcmF0b3IpIFwKICAgICBERUZJTkVfU1RBTkRBUkRfQlVJ TFRJTihtYWNybywgTWFwSXRlcmF0b3IsIG1hcEl0ZXJhdG9yKSBcCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTEzYmRiMGQ0 Mjk1ZWVmMTZiOTM0YjUzMTc0YWYyYTg0NDFhZjYwZi4uNTkwZDFmNzVmYzEwMGJjMGJiY2ZjOTUw OTJiOWUxNDM4NjNhOWQ5NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA2LTA0ICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKKyAgICAgICAgQXJyYXlJdGVyYXRvciBzaG91 bGQgbm90IGJlIGV4cG9zZWQgaW4gU2FmYXJpIDgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzQ5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0ZXN0cy4KKworICAgICAgICAqIGpzL25vLWl0ZXJh dG9yLWNvbnN0cnVjdG9ycy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBqcy9zY3JpcHQtdGVzdHMv bm8taXRlcmF0b3ItY29uc3RydWN0b3JzLmpzOiBBZGRlZC4KKwogMjAxNC0wNi0wNCAgUmFkdSBT dGF2aWxhICA8c3RhdmlsYUBhZG9iZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogW0NTUyBS ZWdpb25zXSBSZWdpb25zIHdpdGggb3ZlcmZsb3c6YXV0byBnZW5lcmF0ZSBzY3JvbGxiYXJzIGV2 ZW4gaWYgdGhlIGNvbnRlbnQgZmxvd3MgaW50byB0aGUgZm9sbG93aW5nIHJlZ2lvbnMgYW5kIGFz IHN1Y2gsIHNob3VsZCBub3QgYmUgc2Nyb2xsZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pz L25vLWl0ZXJhdG9yLWNvbnN0cnVjdG9ycy5odG1sIGIvTGF5b3V0VGVzdHMvanMvbm8taXRlcmF0 b3ItY29uc3RydWN0b3JzLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTY2YzdiNWZiZmNhOGNmMWViMDJiYWQy NDFhZTc2YjM3NWE0Mzk2MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2pzL25vLWl0 ZXJhdG9yLWNvbnN0cnVjdG9ycy5odG1sCkBAIC0wLDAgKzEsMTAgQEAKKzwhRE9DVFlQRSBIVE1M IFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0 IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxi b2R5PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9uby1pdGVyYXRvci1jb25zdHJ1Y3RvcnMu anMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMi Pjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMv c2NyaXB0LXRlc3RzL25vLWl0ZXJhdG9yLWNvbnN0cnVjdG9ycy5qcyBiL0xheW91dFRlc3RzL2pz L3NjcmlwdC10ZXN0cy9uby1pdGVyYXRvci1jb25zdHJ1Y3RvcnMuanMKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTg2 NWE2ZTIzNWRkNTA4YmU1Y2ZmYmIxMGU0YTdjZmY2MWExZjQ4NwotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9uby1pdGVyYXRvci1jb25zdHJ1Y3RvcnMuanMK QEAgLTAsMCArMSw3IEBACitkZXNjcmlwdGlvbigiVGhpcyB0ZXN0IG1ha2VzIHN1cmUgd2UgYXJl bid0IHB1dHRpbmcgdGhlIGl0ZXJhdG9yIGNvbnN0cnVjdG9ycyBvbiB0aGUgZ2xvYmFsIG9iamVj dC4iKTsKKwordmFyIGdsb2JhbCA9IHRoaXM7CitzaG91bGRCZUZhbHNlKCJBcnJheUl0ZXJhdG9y IGluIHRoaXMiKTsKK3Nob3VsZEJlRmFsc2UoIkFyZ3VtZW50c0l0ZXJhdG9yIGluIHRoaXMiKTsK K3Nob3VsZEJlRmFsc2UoIk1hcEl0ZXJhdG9yIGluIHRoaXMiKTsKK3Nob3VsZEJlRmFsc2UoIlNl dEl0ZXJhdG9yIGluIHRoaXMiKTsK