133470 2014-06-03 01:07:45 -0700 TileGrid::prepopulateRect populates the wrong tiles if scale != 1 2014-06-03 11:14:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton simon.fraser oldest_to_newest 1013065 0 thorton 2014-06-03 01:07:45 -0700 prepopulateRect does the wrong math for non-unit-scale tile caches. 1013068 1 232418 thorton 2014-06-03 02:23:39 -0700 Created attachment 232418 patch 1013118 2 thorton 2014-06-03 11:14:12 -0700 http://trac.webkit.org/changeset/169564 232418 2014-06-03 02:23:39 -0700 2014-06-03 09:05:28 -0700 patch prepopulate.diff text/plain 3536 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NzRlNzY0Li5kNjZjMDk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDYtMDMgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgorCisgICAgICAgIFRpbGVHcmlkOjpwcmVwb3B1bGF0ZVJlY3QgcG9wdWxhdGVzIHRoZSB3cm9u ZyB0aWxlcyBpZiBzY2FsZSAhPSAxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzM0NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZy YW1lVmlldzo6cmVxdWVzdFNjcm9sbFBvc2l0aW9uVXBkYXRlKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jYS9tYWMvVGlsZUdyaWQubW06CisgICAgICAgIChXZWJDb3JlOjpUaWxlR3Jp ZDo6cHJlcG9wdWxhdGVSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVHcmlkOjpyZXZhbGlk YXRlVGlsZXMpOgorICAgICAgICBwcmVwb3B1bGF0ZVJlY3QgdGFrZXMgcmVjdHMgaW4gImNvbnRl bnQiIGNvb3JkaW5hdGVzLCBidXQgd2hlbiBsYXRlciBwYXNzZWQgdG8KKyAgICAgICAgZW5zdXJl VGlsZXNGb3JSZWN0LCB0aGV5J3JlIGV4cGVjdGVkIHRvIGJlIGluIHRoZSBzYW1lIGNvb3JkaW5h dGUgc3BhY2UgYXMgdGhlIGxheWVyJ3MKKyAgICAgICAgdmlzaWJsZSByZWN0LCBhbmQgYXJlIHNj YWxlZCB1cC4gU28sIGFwcGx5IHRoZSBpbnZlcnNlIHNjYWxlIHRvIGNvdW50ZXIgdGhhdC4KKwog MjAxNC0wNi0wMiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBb TVNFXVtNYWNdIE1lZGlhIGRvZXMgbm90IGdlbmVyYXRlICdlbmRlZCcgZXZlbnQgd2hlbiBwbGF5 aW5nIHRvIGR1cmF0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZp ZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDU5NzA3YWEu Ljc2YjBmNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTIxMjksMTEgKzIxMjks OCBAQCBib29sIEZyYW1lVmlldzo6aXNSdWJiZXJCYW5kSW5Qcm9ncmVzcygpIGNvbnN0CiBib29s IEZyYW1lVmlldzo6cmVxdWVzdFNjcm9sbFBvc2l0aW9uVXBkYXRlKGNvbnN0IEludFBvaW50JiBw b3NpdGlvbikKIHsKICNpZiBFTkFCTEUoQVNZTkNfU0NST0xMSU5HKQotICAgIGlmIChUaWxlZEJh Y2tpbmcqIHRpbGVkQmFja2luZyA9IHRoaXMtPnRpbGVkQmFja2luZygpKSB7Ci0gICAgICAgIElu dFJlY3QgdmlzaWJsZVJlY3QgPSB2aXNpYmxlQ29udGVudFJlY3QoKTsKLSAgICAgICAgdmlzaWJs ZVJlY3Quc2V0TG9jYXRpb24ocG9zaXRpb24pOwotICAgICAgICB0aWxlZEJhY2tpbmctPnByZXBv cHVsYXRlUmVjdCh2aXNpYmxlUmVjdCk7Ci0gICAgfQorICAgIGlmIChUaWxlZEJhY2tpbmcqIHRp bGVkQmFja2luZyA9IHRoaXMtPnRpbGVkQmFja2luZygpKQorICAgICAgICB0aWxlZEJhY2tpbmct PnByZXBvcHVsYXRlUmVjdChGbG9hdFJlY3QocG9zaXRpb24sIHZpc2libGVDb250ZW50UmVjdCgp LnNpemUoKSkpOwogCiAgICAgaWYgKFBhZ2UqIHBhZ2UgPSBmcmFtZSgpLnBhZ2UoKSkgewogICAg ICAgICBpZiAoU2Nyb2xsaW5nQ29vcmRpbmF0b3IqIHNjcm9sbGluZ0Nvb3JkaW5hdG9yID0gcGFn ZS0+c2Nyb2xsaW5nQ29vcmRpbmF0b3IoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhL21hYy9UaWxlR3JpZC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhL21hYy9UaWxlR3JpZC5tbQppbmRleCA0YTQxM2FmLi4wNjNiN2ZkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUdy aWQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVH cmlkLm1tCkBAIC0yMDIsMTQgKzIwMiwxMSBAQCBib29sIFRpbGVHcmlkOjp0aWxlc1dvdWxkQ2hh bmdlRm9yVmlzaWJsZVJlY3QoY29uc3QgRmxvYXRSZWN0JiBuZXdWaXNpYmxlUmVjdCwgYwogCiBi b29sIFRpbGVHcmlkOjpwcmVwb3B1bGF0ZVJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KQogewot ICAgIEZsb2F0UmVjdCBzY2FsZWRSZWN0KHJlY3QpOwotICAgIHNjYWxlZFJlY3Quc2NhbGUobV9z Y2FsZSk7Ci0gICAgSW50UmVjdCByZWN0SW5UaWxlQ29vcmRzKGVuY2xvc2luZ0ludFJlY3Qoc2Nh bGVkUmVjdCkpOwotCi0gICAgaWYgKG1fcHJpbWFyeVRpbGVDb3ZlcmFnZVJlY3QuY29udGFpbnMo cmVjdEluVGlsZUNvb3JkcykpCisgICAgSW50UmVjdCBlbmNsb3NpbmdDb3ZlcmFnZVJlY3QgPSBl bmNsb3NpbmdJbnRSZWN0KHJlY3QpOworICAgIGlmIChtX3ByaW1hcnlUaWxlQ292ZXJhZ2VSZWN0 LmNvbnRhaW5zKGVuY2xvc2luZ0NvdmVyYWdlUmVjdCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK LSAgICAKLSAgICBtX3NlY29uZGFyeVRpbGVDb3ZlcmFnZVJlY3RzLmFwcGVuZChyZWN0KTsKKwor ICAgIG1fc2Vjb25kYXJ5VGlsZUNvdmVyYWdlUmVjdHMuYXBwZW5kKGVuY2xvc2luZ0NvdmVyYWdl UmVjdCk7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKQEAgLTM2MCw4ICszNTcsMTEgQEAgdm9pZCBU aWxlR3JpZDo6cmV2YWxpZGF0ZVRpbGVzKHVuc2lnbmVkIHZhbGlkYXRpb25Qb2xpY3kpCiAgICAg ICAgIHJlbW92ZUFsbFNlY29uZGFyeVRpbGVzKCk7CiAgICAgICAgIG1fY29ob3J0TGlzdC5jbGVh cigpOwogICAgIH0gZWxzZSB7Ci0gICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbV9zZWNv bmRhcnlUaWxlQ292ZXJhZ2VSZWN0cy5zaXplKCk7ICsraSkKLSAgICAgICAgICAgIGVuc3VyZVRp bGVzRm9yUmVjdChtX3NlY29uZGFyeVRpbGVDb3ZlcmFnZVJlY3RzW2ldLCBDb3ZlcmFnZVR5cGU6 OlNlY29uZGFyeVRpbGVzKTsKKyAgICAgICAgZm9yIChhdXRvJiBzZWNvbmRhcnlDb3ZlcmFnZVJl Y3QgOiBtX3NlY29uZGFyeVRpbGVDb3ZlcmFnZVJlY3RzKSB7CisgICAgICAgICAgICBGbG9hdFJl Y3Qgc2Vjb25kYXJ5UmVjdEluTGF5ZXJDb29yZGluYXRlcyhzZWNvbmRhcnlDb3ZlcmFnZVJlY3Qp OworICAgICAgICAgICAgc2Vjb25kYXJ5UmVjdEluTGF5ZXJDb29yZGluYXRlcy5zY2FsZSgxIC8g bV9zY2FsZSk7CisgICAgICAgICAgICBlbnN1cmVUaWxlc0ZvclJlY3Qoc2Vjb25kYXJ5UmVjdElu TGF5ZXJDb29yZGluYXRlcywgQ292ZXJhZ2VUeXBlOjpTZWNvbmRhcnlUaWxlcyk7CisgICAgICAg IH0KICAgICAgICAgbV9zZWNvbmRhcnlUaWxlQ292ZXJhZ2VSZWN0cy5jbGVhcigpOwogICAgIH0K IAo=