133467 2014-06-02 23:24:10 -0700 [EFL]Build error in WebKit2/Shared/Downloads/soup/DownloadSoup.cpp 2014-06-05 04:30:47 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tanay.c webkit-unassigned cgarcia commit-queue ossy tanay.c oldest_to_newest 1013054 0 tanay.c 2014-06-02 23:24:10 -0700 /home/tanay.c/Webkit_svn_checkout/WebKit/Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp: In member function ‘void WebKit::DownloadClient::handleResponseLater(const WebCore::ResourceResponse&)’: /home/tanay.c/Webkit_svn_checkout/WebKit/Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:190:128: error: call of overloaded ‘schedule(const char [37], std::_Bind_helper<false, void (WebKit::DownloadClient::*)(), WebKit::DownloadClient* const>::type)’ is ambiguous /home/tanay.c/Webkit_svn_checkout/WebKit/Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:190:128: note: candidates are: In file included from /home/tanay.c/Webkit_svn_checkout/WebKit/Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:35:0: /home/tanay.c/Webkit_svn_checkout/WebKit/Source/WTF/wtf/gobject/GMainLoopSource.h:53:29: note: void WTF::GMainLoopSource::schedule(const char*, std::function<void()>, int, std::function<void()>, GMainContext*) In file included from /home/tanay.c/Webkit_svn_checkout/WebKit/Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:35:0: /home/tanay.c/Webkit_svn_checkout/WebKit/Source/WTF/wtf/gobject/GMainLoopSource.h:54:29: note: void WTF::GMainLoopSource::schedule(const char*, std::function<bool()>, int, std::function<void()>, GMainContext*) 1013077 1 cgarcia 2014-06-03 03:49:49 -0700 gcc 4.7 I guess, we need a explicit cast (or constructor) to workaround it 1013079 2 ossy 2014-06-03 04:15:15 -0700 (In reply to comment #1) > gcc 4.7 I guess, we need a explicit cast (or constructor) to workaround it Do we still support GCC 4.7 ? 1013283 3 232470 tanay.c 2014-06-04 03:21:04 -0700 Created attachment 232470 Patch 1013284 4 tanay.c 2014-06-04 03:23:39 -0700 The EFL build bots are using 4.8.1 version. However, I notice this error when compiling with GCC 4.7.3. 1013288 5 232470 cgarcia 2014-06-04 03:26:25 -0700 Comment on attachment 232470 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232470&action=review > Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:190 > - m_handleResponseLater.schedule("[WebKit] DownloadHandleResponseLater", std::bind(&DownloadClient::handleResponse, this)); > + m_handleResponseLater.schedule("[WebKit] DownloadHandleResponseLater", static_cast<std::function<void()>>(std::bind(&DownloadClient::handleResponse, this))); I think you can use the function constructor instead of a static cast, something like std::function<void()>(std::bind(&DownloadClient::handleResponse, this)). I think it's cleaner. 1013294 6 tanay.c 2014-06-04 03:37:21 -0700 (In reply to comment #5) > (From update of attachment 232470 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232470&action=review > > > Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:190 > > - m_handleResponseLater.schedule("[WebKit] DownloadHandleResponseLater", std::bind(&DownloadClient::handleResponse, this)); > > + m_handleResponseLater.schedule("[WebKit] DownloadHandleResponseLater", static_cast<std::function<void()>>(std::bind(&DownloadClient::handleResponse, this))); > > I think you can use the function constructor instead of a static cast, something like std::function<void()>(std::bind(&DownloadClient::handleResponse, this)). I think it's cleaner. Sure, uploading another patch. 1013295 7 232471 tanay.c 2014-06-04 03:38:50 -0700 Created attachment 232471 Patch 1013296 8 232471 cgarcia 2014-06-04 04:08:11 -0700 Comment on attachment 232471 Patch Thanks 1013508 9 232471 commit-queue 2014-06-05 04:30:44 -0700 Comment on attachment 232471 Patch Clearing flags on attachment: 232471 Committed r169612: <http://trac.webkit.org/changeset/169612> 1013509 10 commit-queue 2014-06-05 04:30:47 -0700 All reviewed patches have been landed. Closing bug. 232470 2014-06-04 03:21:04 -0700 2014-06-04 03:38:36 -0700 Patch bug-133467-20140604155135.patch text/plain 1531 tanay.c SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTU4NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA2LTA0ICBUYW5heSBD ICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXNvbHZlIGNvbXBpbGVyIGVycm9y IChjYWxsIG9mIG92ZXJsb2FkZWQg4oCYc2NoZWR1bGUnIGZ1bmN0aW9uIGlzIGFtYmlndW91cykg CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM0NjcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJl ZC9Eb3dubG9hZHMvc291cC9Eb3dubG9hZFNvdXAuY3BwOgorICAgICAgICAoV2ViS2l0OjpEb3du bG9hZENsaWVudDo6aGFuZGxlUmVzcG9uc2VMYXRlcik6IEV4cGxpY2l0bHkgY2FzdGluZyBzZWNv bmQgcGFyYW1ldGVyIHRvIHN0ZDo6ZnVuY3Rpb248dm9pZCgpPgorCiAyMDE0LTA2LTAzICBUaW1v dGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJLaXQy IFZpZXcgR2VzdHVyZXMgKFpvb20pOiBDYW4gc2hvdyB1bnBhaW50ZWQgcmVnaW9ucyB3aGVuIHpv b20tcGluY2hpbmctb3V0CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRG93bmxvYWRzL3Nv dXAvRG93bmxvYWRTb3VwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQv RG93bmxvYWRzL3NvdXAvRG93bmxvYWRTb3VwLmNwcAkocmV2aXNpb24gMTY5NTI3KQorKysgU291 cmNlL1dlYktpdDIvU2hhcmVkL0Rvd25sb2Fkcy9zb3VwL0Rvd25sb2FkU291cC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE4Nyw3ICsxODcsNyBAQCBwdWJsaWM6CiAKICAgICAgICAgLy8gQ2FsbCBk aWRSZWNlaXZlUmVzcG9uc2UgaW4gYW4gaWRsZSB0byBtYWtlIHN1cmUgdGhlIGRvd25sb2FkIGlz IGFkZGVkCiAgICAgICAgIC8vIHRvIHRoZSBEb3dubG9hZE1hbmFnZXIgZG93bmxvYWRzIG1hcC4K LSAgICAgICAgbV9oYW5kbGVSZXNwb25zZUxhdGVyLnNjaGVkdWxlKCJbV2ViS2l0XSBEb3dubG9h ZEhhbmRsZVJlc3BvbnNlTGF0ZXIiLCBzdGQ6OmJpbmQoJkRvd25sb2FkQ2xpZW50OjpoYW5kbGVS ZXNwb25zZSwgdGhpcykpOworICAgICAgICBtX2hhbmRsZVJlc3BvbnNlTGF0ZXIuc2NoZWR1bGUo IltXZWJLaXRdIERvd25sb2FkSGFuZGxlUmVzcG9uc2VMYXRlciIsIHN0YXRpY19jYXN0PHN0ZDo6 ZnVuY3Rpb248dm9pZCgpPj4oc3RkOjpiaW5kKCZEb3dubG9hZENsaWVudDo6aGFuZGxlUmVzcG9u c2UsIHRoaXMpKSk7CiAgICAgfQogCiAgICAgRG93bmxvYWQqIG1fZG93bmxvYWQ7Cg== 232471 2014-06-04 03:38:50 -0700 2014-06-05 04:30:44 -0700 Patch bug-133467-20140604160920.patch text/plain 1516 tanay.c SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTU4NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA2LTA0ICBUYW5heSBD ICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXNvbHZlIGNvbXBpbGVyIGVycm9y IChjYWxsIG9mIG92ZXJsb2FkZWQgJ3NjaGVkdWxlJyBmdW5jdGlvbiBpcyBhbWJpZ3VvdXMpIAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzNDY3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQv RG93bmxvYWRzL3NvdXAvRG93bmxvYWRTb3VwLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RG93bmxv YWRDbGllbnQ6OmhhbmRsZVJlc3BvbnNlTGF0ZXIpOiBFeHBsaWNpdGx5IGNhc3Rpbmcgc2Vjb25k IHBhcmFtZXRlciB0byBzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4KKwogMjAxNC0wNi0wMyAgVGltb3Ro eSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0MiBW aWV3IEdlc3R1cmVzIChab29tKTogQ2FuIHNob3cgdW5wYWludGVkIHJlZ2lvbnMgd2hlbiB6b29t LXBpbmNoaW5nLW91dApJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL0Rvd25sb2Fkcy9zb3Vw L0Rvd25sb2FkU291cC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL0Rv d25sb2Fkcy9zb3VwL0Rvd25sb2FkU291cC5jcHAJKHJldmlzaW9uIDE2OTUyNykKKysrIFNvdXJj ZS9XZWJLaXQyL1NoYXJlZC9Eb3dubG9hZHMvc291cC9Eb3dubG9hZFNvdXAuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xODcsNyArMTg3LDcgQEAgcHVibGljOgogCiAgICAgICAgIC8vIENhbGwgZGlk UmVjZWl2ZVJlc3BvbnNlIGluIGFuIGlkbGUgdG8gbWFrZSBzdXJlIHRoZSBkb3dubG9hZCBpcyBh ZGRlZAogICAgICAgICAvLyB0byB0aGUgRG93bmxvYWRNYW5hZ2VyIGRvd25sb2FkcyBtYXAuCi0g ICAgICAgIG1faGFuZGxlUmVzcG9uc2VMYXRlci5zY2hlZHVsZSgiW1dlYktpdF0gRG93bmxvYWRI YW5kbGVSZXNwb25zZUxhdGVyIiwgc3RkOjpiaW5kKCZEb3dubG9hZENsaWVudDo6aGFuZGxlUmVz cG9uc2UsIHRoaXMpKTsKKyAgICAgICAgbV9oYW5kbGVSZXNwb25zZUxhdGVyLnNjaGVkdWxlKCJb V2ViS2l0XSBEb3dubG9hZEhhbmRsZVJlc3BvbnNlTGF0ZXIiLCBzdGQ6OmZ1bmN0aW9uPHZvaWQo KT4oc3RkOjpiaW5kKCZEb3dubG9hZENsaWVudDo6aGFuZGxlUmVzcG9uc2UsIHRoaXMpKSk7CiAg ICAgfQogCiAgICAgRG93bmxvYWQqIG1fZG93bmxvYWQ7Cg==