133464 2014-06-02 17:28:14 -0700 [iOS][WK2] Align the highlight rects with device pixels 2014-06-03 13:59:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 benjamin benjamin oldest_to_newest 1013037 0 benjamin 2014-06-02 17:28:14 -0700 [iOS][WK2] Align the highlight rects with device pixels 1013038 1 232410 benjamin 2014-06-02 17:30:41 -0700 Created attachment 232410 Patch 1013039 2 benjamin 2014-06-02 17:32:27 -0700 <rdar://problem/16708861> 1013044 3 232410 enrica 2014-06-02 18:15:30 -0700 Comment on attachment 232410 Patch Looks good to me. 1013136 4 232410 benjamin 2014-06-03 13:59:29 -0700 Comment on attachment 232410 Patch Clearing flags on attachment: 232410 Committed r169567: <http://trac.webkit.org/changeset/169567> 1013137 5 benjamin 2014-06-03 13:59:32 -0700 All reviewed patches have been landed. Closing bug. 232410 2014-06-02 17:30:41 -0700 2014-06-03 13:59:29 -0700 Patch bug-133464-20140602172942.patch text/plain 7074 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDE4MjlhOTVjZmY4Y2Ex NzFmMzczMGQyNDhkOWNhYmFhZWU2Y2FkYy4uOGFiM2NkODI3NjJkNDhiNTI5NGJmNDY5NDc1MmRk ZThmODhhZDdkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA2LTAyICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW1dLMl0g QWxpZ24gdGhlIGhpZ2hsaWdodCByZWN0cyB3aXRoIGRldmljZSBwaXhlbHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzQ2NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB1dGlsaXR5IGZ1bmN0aW9u cyB0byBwaXhlbCBhbGlnbiBwb2ludHMgYW5kIHJlY3RzLgorCisgICAgICAgICogV2ViQ29yZS5l eHAuaW46CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQb2ludC5oOgorICAgICAg ICAoV2ViQ29yZTo6Zmxvb3JlZFRvRGV2aWNlUGl4ZWxzKToKKyAgICAgICAgKFdlYkNvcmU6OmNl aWxlZFRvRGV2aWNlUGl4ZWxzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFJl Y3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZW5jbG9zaW5nUmVjdEV4dGVuZGVkVG9EZXZpY2VQ aXhlbHMpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UmVjdC5oOgorCiAyMDE0 LTA2LTAyICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAg ICBNYWtlIHBzZXVkbyBlbGVtZW50IG1hdGNoaW5nIGZvciBzdHlsZSByZXNvbHV0aW9uIG1vcmUg SklUIGZyaWVuZGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzFiNmM2YjY5YTkxYWQyMDhjMTQxZTllYjRjYTcw ZTdjMzk5OTU0Yy4uYjA1N2VmMjQ1YzMzZTYzNDg3MDUwOWRiZDNlMGE5NDQyNzBhN2Y0ZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE0LTA2LTAyICBCZW5qYW1pbiBQb3VsYWluICA8 YnBvdWxhaW5AYXBwbGUuY29tPgogCisgICAgICAgIFtpT1NdW1dLMl0gQWxpZ24gdGhlIGhpZ2hs aWdodCByZWN0cyB3aXRoIGRldmljZSBwaXhlbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzQ2NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTY3 MDg4NjE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1b V0tDb250ZW50VmlldyBfc2hvd1RhcEhpZ2hsaWdodFdpdGhDb2xvcjpXZWJDb3JlOjpxdWFkczpX ZWJDb3JlOjp0b3BMZWZ0UmFkaXVzOldlYkNvcmU6OnRvcFJpZ2h0UmFkaXVzOldlYkNvcmU6OmJv dHRvbUxlZnRSYWRpdXM6V2ViQ29yZTo6Ym90dG9tUmlnaHRSYWRpdXM6V2ViQ29yZTo6XSk6CisK KzIwMTQtMDYtMDIgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CisKICAg ICAgICAgW2lPU11bV0syXSBSb3VuZCB0aGUgVUlTY3JvbGxWaWV3IGNvbnRlbnQgc2l6ZSB0byBk ZXZpY2UgcGl4ZWwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMzQxNwogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTU5MjI0NDA+CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbiBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUu ZXhwLmluCmluZGV4IDIzZjAxMzgzMmZlZjk3ZTM3Zjg3ODY3NTBlNzI5ZGU2ZDQzYmYyNjYuLjc2 YmVlZTE4NjYxMDE4NzhjYzg5N2UwNjliMGUyNjMyMTM3NjhiNGYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhw LmluCkBAIC0yNjM4LDYgKzI2MzgsNyBAQCBfX1pON1dlYkNvcmUzMWFwcGxpY2F0aW9uSXNEYWlq aXNlbkRpY3Rpb25hcnlFdgogX19aTjdXZWJDb3JlMzFhcHBsaWNhdGlvbklzTWljcm9zb2Z0TWVz c2VuZ2VyRXYKIF9fWk43V2ViQ29yZTMxZW5hYmxlVVJMU2NoZW1lQ2Fub25pY2FsaXphdGlvbkVi CiBfX1pON1dlYkNvcmUzM2FwcGxpY2F0aW9uSXNUaGVFY29ub21pc3RPbklQaG9uZUV2CitfX1pO N1dlYkNvcmUzNWVuY2xvc2luZ1JlY3RFeHRlbmRlZFRvRGV2aWNlUGl4ZWxzRVJLTlNfOUZsb2F0 UmVjdEVmCiBfX1pON1dlYkNvcmUzNXBvc2l0aW9uT2ZOZXh0Qm91bmRhcnlPZkdyYW51bGFyaXR5 RVJLTlNfMTVWaXNpYmxlUG9zaXRpb25FTlNfMTVUZXh0R3JhbnVsYXJpdHlFTlNfMThTZWxlY3Rp b25EaXJlY3Rpb25FCiBfX1pON1dlYkNvcmU0MWluaXRpYWxpemVIVFRQQ29ubmVjdGlvblNldHRp bmdzT25TdGFydHVwRXYKIF9fWk43V2ViQ29yZTRGb250QzFFUktOU18xNkZvbnRQbGF0Zm9ybURh dGFFTjNXVEYxMFBhc3NSZWZQdHJJTlNfMTJGb250U2VsZWN0b3JFRUUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuaAppbmRleCA1MDVjNWEyZGQ2Yjg2YWIy ZmNiMjVjNjg3OWQ5ZWQ2ZjcxOGRmNDg0Li41N2UzYWM1OWYxZTIxMGIyYjY5ZDZmMDFiNTkyMzE3 NGZhY2VmNjRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9G bG9hdFBvaW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQ b2ludC5oCkBAIC0yMjAsMTEgKzIyMCwyMSBAQCBpbmxpbmUgSW50UG9pbnQgZmxvb3JlZEludFBv aW50KGNvbnN0IEZsb2F0UG9pbnQmIHApCiAgICAgcmV0dXJuIEludFBvaW50KGNsYW1wVG9JbnRl Z2VyKGZsb29yZihwLngoKSkpLCBjbGFtcFRvSW50ZWdlcihmbG9vcmYocC55KCkpKSk7CiB9CiAK K2lubGluZSBGbG9hdFBvaW50IGZsb29yZWRUb0RldmljZVBpeGVscyhjb25zdCBGbG9hdFBvaW50 JiBwLCBmbG9hdCBkZXZpY2VTY2FsZUZhY3RvcikKK3sKKyAgICByZXR1cm4gRmxvYXRQb2ludChm bG9vcmYocC54KCkgKiBkZXZpY2VTY2FsZUZhY3RvcikgIC8gZGV2aWNlU2NhbGVGYWN0b3IsIGZs b29yZihwLnkoKSAqIGRldmljZVNjYWxlRmFjdG9yKSAgLyBkZXZpY2VTY2FsZUZhY3Rvcik7Cit9 CisKIGlubGluZSBJbnRQb2ludCBjZWlsZWRJbnRQb2ludChjb25zdCBGbG9hdFBvaW50JiBwKQog ewogICAgIHJldHVybiBJbnRQb2ludChjbGFtcFRvSW50ZWdlcihjZWlsZihwLngoKSkpLCBjbGFt cFRvSW50ZWdlcihjZWlsZihwLnkoKSkpKTsKIH0KIAoraW5saW5lIEZsb2F0UG9pbnQgY2VpbGVk VG9EZXZpY2VQaXhlbHMoY29uc3QgRmxvYXRQb2ludCYgcCwgZmxvYXQgZGV2aWNlU2NhbGVGYWN0 b3IpCit7CisgICAgcmV0dXJuIEZsb2F0UG9pbnQoY2VpbGYocC54KCkgKiBkZXZpY2VTY2FsZUZh Y3RvcikgIC8gZGV2aWNlU2NhbGVGYWN0b3IsIGNlaWxmKHAueSgpICogZGV2aWNlU2NhbGVGYWN0 b3IpICAvIGRldmljZVNjYWxlRmFjdG9yKTsKK30KKwogaW5saW5lIEludFNpemUgZmxvb3JlZElu dFNpemUoY29uc3QgRmxvYXRQb2ludCYgcCkKIHsKICAgICByZXR1cm4gSW50U2l6ZShjbGFtcFRv SW50ZWdlcihmbG9vcmYocC54KCkpKSwgY2xhbXBUb0ludGVnZXIoZmxvb3JmKHAueSgpKSkpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRSZWN0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UmVjdC5jcHAKaW5kZXgg YTdjMDhlNjc3MTJlYmI4OGMyNTRjYmNmZjZkOGQxNzg4NGExN2YyNy4uM2EwYzNlNzcwYmNmNjVh Mjk3ZjI5YWExOTcyYmZjYWM1ZGYxYzM2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvRmxvYXRSZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9GbG9hdFJlY3QuY3BwCkBAIC0yMDYsNiArMjA2LDEzIEBAIHZvaWQgRmxvYXRS ZWN0OjpmaXRUb1BvaW50cyhjb25zdCBGbG9hdFBvaW50JiBwMCwgY29uc3QgRmxvYXRQb2ludCYg cDEsIGNvbnN0IEZsCiAgICAgc2V0TG9jYXRpb25BbmRTaXplRnJvbUVkZ2VzKGxlZnQsIHRvcCwg cmlnaHQsIGJvdHRvbSk7CiB9CiAKK0Zsb2F0UmVjdCBlbmNsb3NpbmdSZWN0RXh0ZW5kZWRUb0Rl dmljZVBpeGVscyhjb25zdCBGbG9hdFJlY3QmIHJlY3QsIGZsb2F0IGRldmljZVNjYWxlRmFjdG9y KQoreworICAgIEZsb2F0UG9pbnQgbG9jYXRpb24gPSBmbG9vcmVkVG9EZXZpY2VQaXhlbHMocmVj dC5taW5YTWluWUNvcm5lcigpLCBkZXZpY2VTY2FsZUZhY3Rvcik7CisgICAgRmxvYXRQb2ludCBt YXhQb2ludCA9IGNlaWxlZFRvRGV2aWNlUGl4ZWxzKHJlY3QubWF4WE1heFlDb3JuZXIoKSwgZGV2 aWNlU2NhbGVGYWN0b3IpOworICAgIHJldHVybiBGbG9hdFJlY3QobG9jYXRpb24sIG1heFBvaW50 IC0gbG9jYXRpb24pOworfQorCiBJbnRSZWN0IGVuY2xvc2luZ0ludFJlY3QoY29uc3QgRmxvYXRS ZWN0JiByZWN0KQogewogICAgIEludFBvaW50IGxvY2F0aW9uID0gZmxvb3JlZEludFBvaW50KHJl Y3QubWluWE1pbllDb3JuZXIoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9GbG9hdFJlY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0Zsb2F0UmVjdC5oCmluZGV4IGFkZjg5YzBhYWY5MzhhMWRmYTU0OTZmOTE2NWY2NTI1ZmIxYWQ3 NTIuLjRmMzE3OTQzNWIwM2NlMjYyNmEzNDI4MmNkZmE5ZTk1ZDQ2OThlODIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UmVjdC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UmVjdC5oCkBAIC0yNDYsNiArMjQ2LDcg QEAgaW5saW5lIGJvb2wgRmxvYXRSZWN0Ojppc0luZmluaXRlKCkgY29uc3QKICAgICByZXR1cm4g KnRoaXMgPT0gaW5maW5pdGVSZWN0KCk7CiB9CiAKK0Zsb2F0UmVjdCBlbmNsb3NpbmdSZWN0RXh0 ZW5kZWRUb0RldmljZVBpeGVscyhjb25zdCBGbG9hdFJlY3QmLCBmbG9hdCBkZXZpY2VTY2FsZUZh Y3Rvcik7CiBJbnRSZWN0IGVuY2xvc2luZ0ludFJlY3QoY29uc3QgRmxvYXRSZWN0Jik7CiAKIC8v IFJldHVybnMgYSB2YWxpZCBJbnRSZWN0IGNvbnRhaW5lZCB3aXRoaW4gdGhlIGdpdmVuIEZsb2F0 UmVjdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggYjA5ODFmYTM4YWRkMzc1Y2U3MWM0OTBlOWMyZmI3 OGZlM2U0NGIzYS4uMmI5NTQ5YmVjOWI2NWM4MzA2ODQyYTgwY2RmNDNjYmIyOTUxZjEzNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KQEAgLTQwMSw2ICs0MDEsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaGln aGxpZ2h0ZWRRdWFkc0FyZVNtYWxsZXJUaGFuUmVjdChjb25zdCBWZWN0b3I8RmxvYXRRdWFkPiYg cQogICAgIH0KIAogICAgIGJvb2wgYWxsSGlnaGxpZ2h0UmVjdHNBcmVSZWN0aWxpbmVhciA9IHRy dWU7CisgICAgZmxvYXQgZGV2aWNlU2NhbGVGYWN0b3IgPSBfcGFnZS0+ZGV2aWNlU2NhbGVGYWN0 b3IoKTsKICAgICBjb25zdCBzaXplX3QgcXVhZENvdW50ID0gaGlnaGxpZ2h0ZWRRdWFkcy5zaXpl KCk7CiAgICAgUmV0YWluUHRyPE5TTXV0YWJsZUFycmF5PiByZWN0cyA9IGFkb3B0TlMoW1tOU011 dGFibGVBcnJheSBhbGxvY10gaW5pdFdpdGhDYXBhY2l0eTpzdGF0aWNfY2FzdDxjb25zdCBOU1VJ bnRlZ2VyPihxdWFkQ291bnQpXSk7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBxdWFkQ291 bnQ7ICsraSkgewpAQCAtNDA4LDggKzQwOSw5IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBoaWdobGln aHRlZFF1YWRzQXJlU21hbGxlclRoYW5SZWN0KGNvbnN0IFZlY3RvcjxGbG9hdFF1YWQ+JiBxCiAg ICAgICAgIGlmIChxdWFkLmlzUmVjdGlsaW5lYXIoKSkgewogICAgICAgICAgICAgRmxvYXRSZWN0 IGJvdW5kaW5nQm94ID0gcXVhZC5ib3VuZGluZ0JveCgpOwogICAgICAgICAgICAgYm91bmRpbmdC b3guc2NhbGUoc2VsZlNjYWxlKTsKLSAgICAgICAgICAgIENHUmVjdCByZWN0ID0gQ0dSZWN0SW5z ZXQoYm91bmRpbmdCb3gsIC1VSVdlYlZpZXdNaW5pbXVtSGlnaGxpZ2h0UmFkaXVzLCAtVUlXZWJW aWV3TWluaW11bUhpZ2hsaWdodFJhZGl1cyk7Ci0gICAgICAgICAgICBbcmVjdHMgYWRkT2JqZWN0 OltOU1ZhbHVlIHZhbHVlV2l0aENHUmVjdDpyZWN0XV07CisgICAgICAgICAgICBib3VuZGluZ0Jv eC5pbmZsYXRlKFVJV2ViVmlld01pbmltdW1IaWdobGlnaHRSYWRpdXMpOworICAgICAgICAgICAg Q0dSZWN0IHBpeGVsQWxpZ25lZFJlY3QgPSBzdGF0aWNfY2FzdDxDR1JlY3Q+KGVuY2xvc2luZ1Jl Y3RFeHRlbmRlZFRvRGV2aWNlUGl4ZWxzKGJvdW5kaW5nQm94LCBkZXZpY2VTY2FsZUZhY3Rvcikp OworICAgICAgICAgICAgW3JlY3RzIGFkZE9iamVjdDpbTlNWYWx1ZSB2YWx1ZVdpdGhDR1JlY3Q6 cGl4ZWxBbGlnbmVkUmVjdF1dOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgYWxsSGln aGxpZ2h0UmVjdHNBcmVSZWN0aWxpbmVhciA9IGZhbHNlOwogICAgICAgICAgICAgcmVjdHMuY2xl YXIoKTsK