133450 2014-06-02 09:31:04 -0700 ASSERT(!m_inRemovedLastRefFunction) in Element::addShadowRoot while destroying a document 2014-06-09 13:10:56 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap jer.noble calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble koivisto philipj rniwa sergio oldest_to_newest 1012957 0 ap 2014-06-02 09:31:04 -0700 Seen this on bots. Doesn't seem to happen frequently, and probably not reproducible locally, but perhaps fixable based on stack trace? This sequence of calls seems crazy. http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r169530%20(5705)/media/video-fullscreeen-only-controls-crash-log.txt 0 com.apple.JavaScriptCore 0x000000010b2b723a WTFCrash + 42 (Assertions.cpp:333) 1 com.apple.WebCore 0x000000010e6cc232 WebCore::TreeShared<WebCore::Node>::ref() + 178 (TreeShared.h:64) 2 com.apple.WebCore 0x000000010e6d6c3d WTF::Ref<WebCore::Document>::Ref(WebCore::Document&) + 45 (Ref.h:38) 3 com.apple.WebCore 0x000000010e6b7e6d WTF::Ref<WebCore::Document>::Ref(WebCore::Document&) + 29 (Ref.h:38) 4 com.apple.WebCore 0x000000010e91f18d WebCore::ChildNodeInsertionNotifier::notify(WebCore::Node&) + 125 (ContainerNodeAlgorithms.h:224) 5 com.apple.WebCore 0x000000010ed89677 WebCore::Element::addShadowRoot(WTF::PassRefPtr<WebCore::ShadowRoot>) + 247 (Element.cpp:1468) 6 com.apple.WebCore 0x000000010ed89775 WebCore::Element::ensureUserAgentShadowRoot() + 85 (Element.cpp:1519) --> why are we doing this while destructing everything?! 7 com.apple.WebCore 0x000000010f0e3bbb WebCore::HTMLMediaElement::configureMediaControls() + 75 (HTMLMediaElement.cpp:5145) 8 com.apple.WebCore 0x000000010f0e467b WebCore::HTMLMediaElement::removedFrom(WebCore::ContainerNode&) + 107 (HTMLMediaElement.cpp:712) 9 com.apple.WebCore 0x000000010e926b7b WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument(WebCore::Node&) + 107 (ContainerNodeAlgorithms.h:242) 10 com.apple.WebCore 0x000000010e91f4ab WebCore::ChildNodeRemovalNotifier::notify(WebCore::Node&) + 59 (ContainerNodeAlgorithms.h:259) 11 com.apple.WebCore 0x000000010e923dd4 WebCore::Private::NodeRemovalDispatcher<WebCore::Node, WebCore::ContainerNode, true>::dispatch(WebCore::Node&, WebCore::ContainerNode&) + 116 (ContainerNodeAlgorithms.h:146) 1014128 1 jer.noble 2014-06-09 10:23:20 -0700 *** Bug 133644 has been marked as a duplicate of this bug. *** 1014130 2 232711 jer.noble 2014-06-09 10:25:42 -0700 Created attachment 232711 Patch 1014196 3 232711 commit-queue 2014-06-09 13:10:49 -0700 Comment on attachment 232711 Patch Clearing flags on attachment: 232711 Committed r169708: <http://trac.webkit.org/changeset/169708> 1014197 4 commit-queue 2014-06-09 13:10:56 -0700 All reviewed patches have been landed. Closing bug. 232711 2014-06-09 10:25:42 -0700 2014-06-09 13:10:49 -0700 Patch bug-133450-20140609102518.patch text/plain 1758 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5Njg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmE3ZGVkNGY5NWY5MTA4 NDU1NWU4NzY4MDU0MjFmYjYzYTZlY2IxOC4uMTY2NmFjN2UxZjBlY2ZiNzE2ZDA4NzEyZjBjYzA3 NjZmYzE5ZjFiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA2LTA5ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEFTU0VSVCghbV9pblJlbW92 ZWRMYXN0UmVmRnVuY3Rpb24pIGluIEVsZW1lbnQ6OmFkZFNoYWRvd1Jvb3Qgd2hpbGUgZGVzdHJv eWluZyBhIGRvY3VtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzM0NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBlbnN1cmVVc2VyQWdlbnRTaGFkb3dSb290KCkgaXMgYmVpbmcgY2FsbGVkIHdoZW4g YSBtZWRpYSBlbGVtZW50IGlzIHJlbW92ZWQgZnJvbSBpdHMgZG9jdW1lbnQKKyAgICAgICAgaW4g SFRNTE1lZGlhRWxlbWVudDo6cmVtb3ZlZEZyb20oKSBiZWNhdXNlIE5vZGU6OnJlbW92ZWRGcm9t KCkgaGFzIG5vdCB5ZXQgcnVuIGFuZCByZW1vdmVkIHRoZQorICAgICAgICBJbkRvY3VtZW50IGZs YWcgZnJvbSB0aGUgbm9kZS4gIFJhdGhlciB0aGFuIGNhbGxpbmcgY29uZmlndXJlTWVkaWFDb250 cm9scygpIGF0IHRoaXMgcG9pbnQKKyAgICAgICAganVzdCBleHBpbGljdGx5IHJlbW92ZSB0aGUg bWVkaWEgY29udHJvbHMgaWYgcHJlc2VudC4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpwYXJzZUF0dHJp YnV0ZSk6CisKIDIwMTQtMDYtMDYgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAK ICAgICAgICAgUmVmYWN0b3Jpbmc6IG1ha2UgTWVkaWFUaW1lIHRoZSBwcmltYXJ5IHRpbWUgdHlw ZSBmb3IgYXVkaW92aXN1YWwgdGltZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcAppbmRleCBkZjU5ZDhlNzgwOTgyMjBjYjdhOTU5OTYxOGI1ZDc2OTQ1OGVmODZmLi42 YjAyNzM0Y2UxZWNmMWRiNTFhMjFkNzkwZDcxZWY2MjA1ZTZiOTMyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTcwNCw3ICs3MDQsOCBAQCB2b2lkIEhUTUxN ZWRpYUVsZW1lbnQ6OnJlbW92ZWRGcm9tKENvbnRhaW5lck5vZGUmIGluc2VydGlvblBvaW50KQog CiAgICAgbV9pbkFjdGl2ZURvY3VtZW50ID0gZmFsc2U7CiAgICAgaWYgKGluc2VydGlvblBvaW50 LmluRG9jdW1lbnQoKSkgewotICAgICAgICBjb25maWd1cmVNZWRpYUNvbnRyb2xzKCk7CisgICAg ICAgIGlmIChoYXNNZWRpYUNvbnRyb2xzKCkpCisgICAgICAgICAgICBtZWRpYUNvbnRyb2xzKCkt PmhpZGUoKTsKICAgICAgICAgaWYgKG1fbmV0d29ya1N0YXRlID4gTkVUV09SS19FTVBUWSkKICAg ICAgICAgICAgIHBhdXNlKCk7CiAgICAgICAgIGlmIChtX2lzRnVsbHNjcmVlbikK