133436 2014-06-01 12:43:34 -0700 Don't scroll to non-integral scroll offsets 2014-06-01 16:07:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser andersca bdakin cmarcelo commit-queue jamesr luiz simon.fraser thorton tonikitoo oldest_to_newest 1012843 0 simon.fraser 2014-06-01 12:43:34 -0700 Don't scroll to non-integral scroll offsets 1012844 1 232351 simon.fraser 2014-06-01 12:45:53 -0700 Created attachment 232351 Patch 1012845 2 simon.fraser 2014-06-01 12:46:17 -0700 <rdar://problem/17088336> 1012851 3 232351 zalan 2014-06-01 13:24:59 -0700 Comment on attachment 232351 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232351&action=review > Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:324 > + // FIXME: when we support half-pixel scroll positions on Retina displays, this will need to round to half pixels. half-pixel -> device pixel > Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:325 > + FloatPoint roundedPosition(roundf(scrollPosition.x()), roundf(scrollPosition.y())); I am wondering whether the input devices that send integral values do integer truncation or rounding. (and whether we should mimic that behavior) 1012864 4 232351 darin 2014-06-01 14:49:04 -0700 Comment on attachment 232351 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232351&action=review >> Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:325 >> + FloatPoint roundedPosition(roundf(scrollPosition.x()), roundf(scrollPosition.y())); > > I am wondering whether the input devices that send integral values do integer truncation or rounding. (and whether we should mimic that behavior) Is this the single correct bottleneck for the rounding? What about the setScrollPositionWithoutContentEdgeConstraints and setScrollLayerPosition functions? 1012867 5 simon.fraser 2014-06-01 15:34:47 -0700 (In reply to comment #4) > (From update of attachment 232351 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232351&action=review > > >> Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:325 > >> + FloatPoint roundedPosition(roundf(scrollPosition.x()), roundf(scrollPosition.y())); > > > > I am wondering whether the input devices that send integral values do integer truncation or rounding. (and whether we should mimic that behavior) > > Is this the single correct bottleneck for the rounding? What about the setScrollPositionWithoutContentEdgeConstraints and setScrollLayerPosition functions? This is the bottleneck, yes. 1012872 6 232351 commit-queue 2014-06-01 16:07:51 -0700 Comment on attachment 232351 Patch Clearing flags on attachment: 232351 Committed r169519: <http://trac.webkit.org/changeset/169519> 1012873 7 commit-queue 2014-06-01 16:07:55 -0700 All reviewed patches have been landed. Closing bug. 232351 2014-06-01 12:45:53 -0700 2014-06-01 16:07:51 -0700 Patch bug-133436-20140601124528.patch text/plain 2449 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDMxNzEyOTVlYjAwZDE2 OGFmMDdiMWQyZmY4Mzc2NWQwOWQ0MmM5OS4uZmViOGViNTQ1NDQ5NjRkNWZhZjUyNmE3NDYwYmIx ODI3ZDVmM2UzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA2LTAxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IHNjcm9s bCB0byBub24taW50ZWdyYWwgc2Nyb2xsIG9mZnNldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzQzNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTcwODgzMzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2l0aCB0aGUgZ3JhZHVhbCBtaWdyYXRpb24gb2Ygc2Nyb2xsIG9mZnNldHMgdG8gZmxvYXRp bmcgcG9pbnQsIHdlIGVuZGVkCisgICAgICAgIHVwIHdpdGggYSBmdWxseSBmbG9hdGluZyBwb2lu dCBjb2RlIHBhdGggYmVlbiBldmVudCBzY3JvbGwgZGVsdGFzIGFuZAorICAgICAgICBzZXR0aW5n IHNjcm9sbCBwb3NpdGlvbnMgaW4gdGhlIHNjcm9sbGluZyB0cmVlLgorICAgICAgICAKKyAgICAg ICAgV2l0aCBzb21lIGlucHV0IGRldmljZXMgKGUuZy4gTG9naXRlY2ggc2Nyb2xsd2hlZWwgbWlj ZSksIHRoZSBzY3JvbGwgZGVsdGFzCisgICAgICAgIGNvbWUgaW4gd2l0aCBub24taW50ZWdyYWwg dmFsdWVzLCBhbmQgdGhhdCBjYXVzZWQgdGhlIHNjcm9sbCBvZmZzZXQgdG8gYmUgbm9uLWludGVn cmFsLAorICAgICAgICByZXN1bHRpbmcgaW4gZnV6enkgbGF5ZXIgY29udGVudHMuIFNvIHJvdW5k IHRoZSBzY3JvbGwgcG9zaXRpb24uCisKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9tYWMvU2Ny b2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlNj cm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05vZGVNYWM6OnNldFNjcm9sbFBvc2l0aW9uKToKKwog MjAxNC0wNS0zMSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgQ1NTIEpJVCBjbGVhbnVwOiBtb3ZlIHR3byB1dGlsaXR5IGZ1bmN0aW9ucyBvdXQgb2Yg dGhlIHByb3BlcnRpZXMtbWF0Y2hlciBzZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZU1hYy5t bSBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdUcmVlRnJhbWVT Y3JvbGxpbmdOb2RlTWFjLm1tCmluZGV4IDZmMThjMjBiOGNhZDhlYzFlZDE1ZmQ5NTMyZmI0Yzg4 ZjAyODE2MzkuLmUzYzE4ZjUyZTEzMjNjOWRkNDAzZTI2NWNhNGE1M2IyNDA3YTkxNTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdUcmVlRnJh bWVTY3JvbGxpbmdOb2RlTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5n L21hYy9TY3JvbGxpbmdUcmVlRnJhbWVTY3JvbGxpbmdOb2RlTWFjLm1tCkBAIC0zMjAsNyArMzIw LDExIEBAIEZsb2F0UG9pbnQgU2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZU1hYzo6c2Ny b2xsUG9zaXRpb24oKSBjb25zdAogCiB2b2lkIFNjcm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05v ZGVNYWM6OnNldFNjcm9sbFBvc2l0aW9uKGNvbnN0IEZsb2F0UG9pbnQmIHNjcm9sbFBvc2l0aW9u KQogewotICAgIFNjcm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05vZGU6OnNldFNjcm9sbFBvc2l0 aW9uKHNjcm9sbFBvc2l0aW9uKTsKKyAgICAvLyBTY3JvbGwgZGVsdGFzIGNhbiBiZSBub24taW50 ZWdyYWwgd2l0aCBzb21lIGlucHV0IGRldmljZXMsIHNvIHNjcm9sbFBvc2l0aW9uIG1heSBub3Qg YmUgaW50ZWdyYWwuCisgICAgLy8gRklYTUU6IHdoZW4gd2Ugc3VwcG9ydCBoYWxmLXBpeGVsIHNj cm9sbCBwb3NpdGlvbnMgb24gUmV0aW5hIGRpc3BsYXlzLCB0aGlzIHdpbGwgbmVlZCB0byByb3Vu ZCB0byBoYWxmIHBpeGVscy4KKyAgICBGbG9hdFBvaW50IHJvdW5kZWRQb3NpdGlvbihyb3VuZGYo c2Nyb2xsUG9zaXRpb24ueCgpKSwgcm91bmRmKHNjcm9sbFBvc2l0aW9uLnkoKSkpOworCisgICAg U2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZTo6c2V0U2Nyb2xsUG9zaXRpb24ocm91bmRl ZFBvc2l0aW9uKTsKIAogICAgIGlmIChzY3JvbGxpbmdUcmVlKCkuc2Nyb2xsaW5nUGVyZm9ybWFu Y2VMb2dnaW5nRW5hYmxlZCgpKQogICAgICAgICBsb2dFeHBvc2VkVW5maWxsZWRBcmVhKCk7Cg==