133419 2014-05-31 01:22:51 -0700 View snapshots are sometimes taken at the wrong scale 2014-05-31 23:26:09 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca mitz sam webkit-bug-importer oldest_to_newest 1012736 0 thorton 2014-05-31 01:22:51 -0700 Sometimes (if a window created on a 2x display tries to take a snapshot after being moved to a 1x display), the snapshot comes back at the wrong size (scaled up and blurry). To work around this for now, we can re-request the snapshot with a slightly different set of options which work in this case (but won't be correct if the bug isn't happening). 1012737 1 webkit-bug-importer 2014-05-31 01:23:22 -0700 <rdar://problem/17087497> 1012738 2 thorton 2014-05-31 01:23:38 -0700 <rdar://problem/17084993> tracks the underlying bug. 1012739 3 232316 thorton 2014-05-31 01:29:04 -0700 Created attachment 232316 patch 1012805 4 thorton 2014-05-31 23:26:09 -0700 http://trac.webkit.org/changeset/169510 232316 2014-05-31 01:29:04 -0700 2014-05-31 07:12:22 -0700 patch snapshot.diff text/plain 3054 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2YWE1ZTRlLi40NTJjMGU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDUtMzEgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgorCisgICAgICAgIFZpZXcgc25hcHNob3RzIGFyZSBzb21ldGltZXMgdGFrZW4gYXQgdGhlIHdy b25nIHNjYWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzM0MTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3MDg3NDk3PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMv V0tWaWV3Lm1tOgorICAgICAgICAoLVtXS1ZpZXcgX3Rha2VWaWV3U25hcHNob3RdKToKKyAgICAg ICAgV29yayBhcm91bmQgPHJkYXI6Ly9wcm9ibGVtLzE3MDg0OTkzPiBieSByZS1yZXF1ZXN0aW5n IHRoZSBzbmFwc2hvdCBhdAorICAgICAgICBrQ0dXaW5kb3dJbWFnZU5vbWluYWxSZXNvbHV0aW9u IGlmIGl0IHdhcyBjYXB0dXJlZCBhdCB0aGUgd3Jvbmcgc2NhbGUuCisKIDIwMTQtMDUtMjkgIERh biBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIENhbuKAmXQg cmVjb3ZlciBmcm9tIHN1YmZyYW1lIGxvYWQgZXJyb3JzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL21hYy9XS1ZpZXcubW0KaW5kZXggZjg4YzJjNi4uMDNiZGNlNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQpAQCAtMTI2LDcgKzEyNiw2IEBACiAK ICNpZiBkZWZpbmVkKF9faGFzX2luY2x1ZGUpICYmIF9faGFzX2luY2x1ZGUoPENvcmVHcmFwaGlj cy9Db3JlR3JhcGhpY3NQcml2YXRlLmg+KQogI2ltcG9ydCA8Q29yZUdyYXBoaWNzL0NvcmVHcmFw aGljc1ByaXZhdGUuaD4KLSNpbXBvcnQgPENvcmVHcmFwaGljcy9DR1NDYXB0dXJlLmg+CiAjZW5k aWYKIAogZXh0ZXJuICJDIiB7CkBAIC0xMzQsNyArMTMzLDYgQEAgdHlwZWRlZiB1aW50MzJfdCBD R1NDb25uZWN0aW9uSUQ7CiB0eXBlZGVmIHVpbnQzMl90IENHU1dpbmRvd0lEOwogQ0dTQ29ubmVj dGlvbklEIENHU01haW5Db25uZWN0aW9uSUQodm9pZCk7CiBDR0Vycm9yIENHU0dldFNjcmVlblJl Y3RGb3JXaW5kb3coQ0dTQ29ubmVjdGlvbklEIGNpZCwgQ0dTV2luZG93SUQgd2lkLCBDR1JlY3Qg KnJlY3QpOwotQ0dFcnJvciBDR1NDYXB0dXJlV2luZG93c0NvbnRlbnRzVG9SZWN0KENHU0Nvbm5l Y3Rpb25JRCBjaWQsIGNvbnN0IENHU1dpbmRvd0lEIHdpbmRvd3NbXSwgdWludDMyX3Qgd2luZG93 Q291bnQsIENHUmVjdCByZWN0LCBDR0ltYWdlUmVmICpvdXRJbWFnZSk7CiB9OwogCiB1c2luZyBu YW1lc3BhY2UgV2ViS2l0OwpAQCAtMzA0NywxNCArMzA0NSwxNiBAQCBzdGF0aWMgdm9pZCBjcmVh dGVTYW5kYm94RXh0ZW5zaW9uc0ZvckZpbGVVcGxvYWQoTlNQYXN0ZWJvYXJkICpwYXN0ZWJvYXJk LCBTYW5kYgogCiAgICAgVmlld1NuYXBzaG90IHNuYXBzaG90OwogCi0gICAgaWYgKCFbd2luZG93 IHdpbmRvd051bWJlcl0pCisgICAgQ0dTV2luZG93SUQgd2luZG93SUQgPSAoQ0dTV2luZG93SUQp W3dpbmRvdyB3aW5kb3dOdW1iZXJdOworICAgIGlmICghd2luZG93SUQpCiAgICAgICAgIHJldHVy biBzbmFwc2hvdDsKIAotICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCB1c2UgQ0dXaW5kb3dMaXN0 Q3JlYXRlSW1hZ2Ugb25jZSA8cmRhcjovL3Byb2JsZW0vMTU3MDk2NDY+IGlzIHJlc29sdmVkLgot ICAgIENHU1dpbmRvd0lEIHdpbmRvd0lEID0gW3dpbmRvdyB3aW5kb3dOdW1iZXJdOwotICAgIENH SW1hZ2VSZWYgY2dXaW5kb3dJbWFnZSA9IG51bGxwdHI7Ci0gICAgQ0dTQ2FwdHVyZVdpbmRvd3ND b250ZW50c1RvUmVjdChDR1NNYWluQ29ubmVjdGlvbklEKCksICZ3aW5kb3dJRCwgMSwgQ0dSZWN0 TnVsbCwgJmNnV2luZG93SW1hZ2UpOwotICAgIFJldGFpblB0cjxDR0ltYWdlUmVmPiB3aW5kb3dT bmFwc2hvdEltYWdlID0gYWRvcHRDRihjZ1dpbmRvd0ltYWdlKTsKKyAgICBSZXRhaW5QdHI8Q0dJ bWFnZVJlZj4gd2luZG93U25hcHNob3RJbWFnZSA9IGFkb3B0Q0YoQ0dXaW5kb3dMaXN0Q3JlYXRl SW1hZ2UoQ0dSZWN0TnVsbCwga0NHV2luZG93TGlzdE9wdGlvbkluY2x1ZGluZ1dpbmRvdywgd2lu ZG93SUQsIGtDR1dpbmRvd0ltYWdlQm91bmRzSWdub3JlRnJhbWluZyB8IGtDR1dpbmRvd0ltYWdl U2hvdWxkQmVPcGFxdWUpKTsKKworICAgIC8vIFdvcmsgYXJvdW5kIDxyZGFyOi8vcHJvYmxlbS8x NzA4NDk5Mz47IHJlLXJlcXVlc3QgdGhlIHNuYXBzaG90IGF0IGtDR1dpbmRvd0ltYWdlTm9taW5h bFJlc29sdXRpb24gaWYgaXQgd2FzIGNhcHR1cmVkIGF0IHRoZSB3cm9uZyBzY2FsZS4KKyAgICBD R0Zsb2F0IGRlc2lyZWRTbmFwc2hvdFdpZHRoID0gd2luZG93LmZyYW1lLnNpemUud2lkdGggKiB3 aW5kb3cuc2NyZWVuLmJhY2tpbmdTY2FsZUZhY3RvcjsKKyAgICBpZiAoQ0dJbWFnZUdldFdpZHRo KHdpbmRvd1NuYXBzaG90SW1hZ2UuZ2V0KCkpICE9IGRlc2lyZWRTbmFwc2hvdFdpZHRoKQorICAg ICAgICB3aW5kb3dTbmFwc2hvdEltYWdlID0gYWRvcHRDRihDR1dpbmRvd0xpc3RDcmVhdGVJbWFn ZShDR1JlY3ROdWxsLCBrQ0dXaW5kb3dMaXN0T3B0aW9uSW5jbHVkaW5nV2luZG93LCB3aW5kb3dJ RCwga0NHV2luZG93SW1hZ2VCb3VuZHNJZ25vcmVGcmFtaW5nIHwga0NHV2luZG93SW1hZ2VTaG91 bGRCZU9wYXF1ZSB8IGtDR1dpbmRvd0ltYWdlTm9taW5hbFJlc29sdXRpb24pKTsKIAogICAgIFtz ZWxmIF9lbnN1cmVHZXN0dXJlQ29udHJvbGxlcl07CiAK