133418 2014-05-30 23:45:41 -0700 REGRESSION (r169412): Garbage pixels when vertical rubber-banding on http://yvoschaap.com/pmarca/ 2014-05-31 23:27:45 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue simon.fraser zalan oldest_to_newest 1012731 0 thorton 2014-05-30 23:45:41 -0700 <rdar://problem/17065494> 1012733 1 232315 thorton 2014-05-31 00:26:44 -0700 Created attachment 232315 patch 1012734 2 commit-queue 2014-05-31 00:27:42 -0700 Attachment 232315 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:3: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1012742 3 232315 sam 2014-05-31 07:13:49 -0700 Comment on attachment 232315 patch View in context: https://bugs.webkit.org/attachment.cgi?id=232315&action=review > Source/WebCore/ChangeLog:3 > + REGRESSION (r169412): Garbage pixels when vertical rubber-banding on http://yvoschaap.com/pmarca/ Tab? 1012806 4 thorton 2014-05-31 23:27:45 -0700 http://trac.webkit.org/changeset/169512 232315 2014-05-31 00:26:44 -0700 2014-05-31 07:13:48 -0700 patch grad.diff text/plain 6987 thorton ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiMDc1YTdlLi4yN2M5N2RkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTQtMDUt MzEgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIxNjk0MTIpOiBHYXJiYWdlIHBpeGVscyB3aGVuIHZlcnRpY2FsIHJ1YmJl ci1iYW5kaW5nIG9uIGh0dHA6Ly95dm9zY2hhYXAuY29tL3BtYXJjYS8KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzQxOAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTcwNjU0OTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBmYXN0L2Nzcy9yZXBlYXRpbmctZ3JhZGllbnQtcGF0dGVybi1wYWludHMt ZW50aXJlLWFyZWEtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MvcmVw ZWF0aW5nLWdyYWRpZW50LXBhdHRlcm4tcGFpbnRzLWVudGlyZS1hcmVhLmh0bWw6IEFkZGVkLgor ICAgICAgICBBZGQgYSBsYXlvdXQgdGVzdCB3aGljaCBlbnN1cmVzIHRoYXQgb3V0LW9mLXBoYXNl IHJlcGVhdGluZyBpbWFnZXMKKyAgICAgICAgKGEgZ2VuZXJhdGVkIGdyYWRpZW50IGltYWdlIGlu IHRoaXMgY2FzZSkgZmlsbCB0aGUgZmlyc3Qgcm93L2NvbHVtbgorICAgICAgICBvZiB0aWxlcyBj b3JyZWN0bHkgKGFuZCB3aXRoIHRoZSBjb3JyZWN0IGVuZCBvZiB0aGUgcmVwZWF0ZWQgaW1hZ2Up LgorICAgICAgICBBZGRpdGlvbmFsbHksIHRoZSByZXF1ZXN0ZWQgZ3JhZGllbnQgc2l6ZSBpcyB2 ZXJ5IGxhcmdlLCB0byBlbnN1cmUKKyAgICAgICAgdGhhdCB3ZSB1c2UgdGhlIG1hbnVhbCB0aWxp bmcgZmFsbGJhY2sgY29kZSAodGhpcyB0ZXN0IHdvdWxkCisgICAgICAgIGhhdmUgc3B1biBhbmQg cnVuIG91dCBvZiBtZW1vcnkgYmVmb3JlIHIxNjk0MTIpLgorCiAyMDE0LTA1LTI5ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBHYXJkZW5pbmc6IG1hcmtpbmcganMv cHJpbWl0aXZlLXByb3BlcnR5LWFjY2Vzcy1lZGdlLWNhc2VzLmh0bWwgYXMgY3Jhc2h5LgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvcmVwZWF0aW5nLWdyYWRpZW50LXBhdHRlcm4t cGFpbnRzLWVudGlyZS1hcmVhLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9y ZXBlYXRpbmctZ3JhZGllbnQtcGF0dGVybi1wYWludHMtZW50aXJlLWFyZWEtZXhwZWN0ZWQuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5lZjNhZjc0Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvcmVwZWF0aW5nLWdyYWRpZW50LXBhdHRlcm4t cGFpbnRzLWVudGlyZS1hcmVhLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwxNSBAQAorPGh0bWw+ Cis8aGVhZD4KKzxzdHlsZT4KK2RpdiB7CisgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CisK KyAgICB3aWR0aDogMTAwcHg7CisgICAgaGVpZ2h0OiAxMDBweDsKK30KKzwvc3R5bGU+Cis8L2hl YWQ+Cis8Ym9keT4KKzxkaXY+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2Nzcy9yZXBlYXRpbmctZ3JhZGllbnQtcGF0dGVybi1wYWludHMtZW50 aXJlLWFyZWEuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3JlcGVhdGluZy1ncmFkaWVudC1w YXR0ZXJuLXBhaW50cy1lbnRpcmUtYXJlYS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLjAyOWJiNWYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nz cy9yZXBlYXRpbmctZ3JhZGllbnQtcGF0dGVybi1wYWludHMtZW50aXJlLWFyZWEuaHRtbApAQCAt MCwwICsxLDI3IEBACis8aHRtbD4KKzxoZWFkPgorPHN0eWxlPgorI2JnIHsKKyAgICBiYWNrZ3Jv dW5kLWNvbG9yOiByZWQ7CisKKyAgICB3aWR0aDogMTAwcHg7CisgICAgaGVpZ2h0OiAxMDBweDsK KyAgICBwb3NpdGlvbjogYWJzb2x1dGU7Cit9CisjZ3JhZCB7CisgICAgYmFja2dyb3VuZC1pbWFn ZTogbGluZWFyLWdyYWRpZW50KHRyYW5zcGFyZW50IDUwJSwgZ3JlZW4gNTAlKTsKKyAgICBiYWNr Z3JvdW5kLXNpemU6IDEwMDAwMHB4IDEwMDAwMHB4OworICAgIGJhY2tncm91bmQtcG9zaXRpb246 IDUwcHggMTAwcHg7CisgICAgYmFja2dyb3VuZC1yZXBlYXQ6IHJlcGVhdDsKKworICAgIHdpZHRo OiAxMDBweDsKKyAgICBoZWlnaHQ6IDIwMHB4OworICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKK30K Kzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYgaWQ9ImJnIj48L2Rpdj4KKzxkaXYgaWQ9 ImdyYWQiPjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDBhZTZkYTUuLjJh MTllZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxNC0wNS0zMCAgVGltb3RoeSBI b3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKwkJUkVHUkVTU0lPTiAocjE2OTQx Mik6IEdhcmJhZ2UgcGl4ZWxzIHdoZW4gdmVydGljYWwgcnViYmVyLWJhbmRpbmcgb24gaHR0cDov L3l2b3NjaGFhcC5jb20vcG1hcmNhLworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTMzNDE4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzA2NTQ5ND4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNv cmUuZXhwLmluOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuaDoKKyAg ICAgICAgKFdlYkNvcmU6OnRvRmxvYXRQb2ludCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2U6OmRyYXdUaWxlZCk6CisgICAg ICAgIFRoZSBtYW51YWwgdGlsaW5nIGNvZGUgcHJldmlvdXNseSBhZGp1c3RlZCB0aGUgaW5pdGlh bAorICAgICAgICB0aWxpbmcgc291cmNlIHJlY3Qgc28gdGhhdCBpZiB0aGUgcGF0dGVybiB3YXMg b3V0IG9mIHBoYXNlLAorICAgICAgICB0aGUgZmlyc3Qgcm93IGFuZCBjb2x1bW4gd291bGQgcGFp bnQgb25seSB0aGUgbmVjZXNzYXJ5IHBhcnQKKyAgICAgICAgb2YgdGhlIHRpbGUuIEhvd2V2ZXIs IGl0IGRpZCBub3QgYWxzbyBhZGp1c3QgdGhlIGRlc3RpbmF0aW9uIHJlY3QsCisgICAgICAgIHNv IHRoZSB0aWxlIHdhcyBwYWludGVkIGluIGVudGlyZWx5IHRoZSB3cm9uZyBwbGFjZS4KKyAgICAg ICAgQWRkaXRpb25hbCB0ZXN0aW5nIChieSBlbmFibGluZyBtYW51YWwgdGlsaW5nIG1vZGUgZm9y IGFsbCBwYXR0ZXJuZWQKKyAgICAgICAgaW1hZ2VzIGFuZCBydW5uaW5nIGFsbCBvZiB0aGUgbGF5 b3V0IHRlc3RzKSBleHBvc2VkIGFub3RoZXIgYnVnCisgICAgICAgIHdoZXJlIHRoZSBsYXN0IHJv dyBhbmQgY29sdW1uIHdvdWxkIHBhaW50IHRvbyBtdWNoLCB3aGljaAorICAgICAgICB3YXMgcmVz b2x2ZWQgYnkgY2xpcHBpbmcgdG8gdGhlIG91dGVyIGltYWdlJ3MgZGVzdGluYXRpb24gcmVjdC4K KwogMjAxNC0wNS0yOSAgSmVyZW15IEpvbmVzICA8amVyZW15akBhcHBsZS5jb20+CiAKICAgICAg ICAgUGVyc2VydmUgY2FwdGlvbiBzZWxlY3Rpb24gaW4gZnVsbHNjcmVlbi4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuaAppbmRleCA1Mzk4YzBjLi41MDVj NWEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFBv aW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQb2ludC5o CkBAIC0yMzUsNiArMjM1LDExIEBAIGlubGluZSBGbG9hdFNpemUgdG9GbG9hdFNpemUoY29uc3Qg RmxvYXRQb2ludCYgYSkKICAgICByZXR1cm4gRmxvYXRTaXplKGEueCgpLCBhLnkoKSk7CiB9CiAK K2lubGluZSBGbG9hdFBvaW50IHRvRmxvYXRQb2ludChjb25zdCBGbG9hdFNpemUmIGEpCit7Cisg ICAgcmV0dXJuIEZsb2F0UG9pbnQoYS53aWR0aCgpLCBhLmhlaWdodCgpKTsKK30KKwogfQogCiAj ZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmNwcAppbmRleCBm MTg0YjhlLi5hZjUzNzhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9JbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1h Z2UuY3BwCkBAIC0xNTMsNyArMTUzLDYgQEAgdm9pZCBJbWFnZTo6ZHJhd1RpbGVkKEdyYXBoaWNz Q29udGV4dCogY3R4dCwgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCwgY29uc3QgRmwKICAgICB9 CiAjZW5kaWYKIAotCiAgICAgLy8gUGF0dGVybmVkIGltYWdlcyBhbmQgZ3JhZGllbnRzIGNhbiB1 c2UgbG90cyBvZiBtZW1vcnkgZm9yIGNhY2hpbmcgd2hlbiB0aGUKICAgICAvLyB0aWxlIHNpemUg aXMgbGFyZ2UgKDxyZGFyOi8vcHJvYmxlbS80NjkxODU5PiwgPHJkYXI6Ly9wcm9ibGVtLzYyMzk1 MDU+KS4KICAgICAvLyBNZW1vcnkgY29uc3VtcHRpb24gZGVwZW5kcyBvbiB0aGUgdHJhbnNmb3Jt ZWQgdGlsZSBzaXplIHdoaWNoIGNhbiBnZXQKQEAgLTE2NSwyMSArMTY0LDI3IEBAIHZvaWQgSW1h Z2U6OmRyYXdUaWxlZChHcmFwaGljc0NvbnRleHQqIGN0eHQsIGNvbnN0IEZsb2F0UmVjdCYgZGVz dFJlY3QsIGNvbnN0IEZsCiAjZW5kaWYKICAgICBGbG9hdFJlY3QgdHJhbnNmb3JtZWRUaWxlU2l6 ZSA9IGN0eHQtPmdldENUTSgpLm1hcFJlY3QoRmxvYXRSZWN0KEZsb2F0UG9pbnQoKSwgc2NhbGVk VGlsZVNpemUpKTsKICAgICBmbG9hdCB0cmFuc2Zvcm1lZFRpbGVTaXplUGl4ZWxzID0gdHJhbnNm b3JtZWRUaWxlU2l6ZS53aWR0aCgpICogdHJhbnNmb3JtZWRUaWxlU2l6ZS5oZWlnaHQoKTsKKyAg ICBGbG9hdFJlY3QgY3VycmVudFRpbGVSZWN0ID0gb25lVGlsZVJlY3Q7CiAgICAgaWYgKHRyYW5z Zm9ybWVkVGlsZVNpemVQaXhlbHMgPiBtYXhQYXR0ZXJuVGlsZVBpeGVscykgewotICAgICAgICBm bG9hdCBmcm9tWSA9IChkZXN0UmVjdC55KCkgLSBvbmVUaWxlUmVjdC55KCkpIC8gc2NhbGUuaGVp Z2h0KCk7Ci0gICAgICAgIGZsb2F0IHRvWSA9IG9uZVRpbGVSZWN0LnkoKTsKKyAgICAgICAgR3Jh cGhpY3NDb250ZXh0U3RhdGVTYXZlciBzdGF0ZVNhdmVyKCpjdHh0KTsKKyAgICAgICAgY3R4dC0+ Y2xpcChkZXN0UmVjdCk7CisKKyAgICAgICAgY3VycmVudFRpbGVSZWN0LnNoaWZ0WUVkZ2VUbyhk ZXN0UmVjdC55KCkpOworICAgICAgICBmbG9hdCB0b1kgPSBjdXJyZW50VGlsZVJlY3QueSgpOwog ICAgICAgICB3aGlsZSAodG9ZIDwgZGVzdFJlY3QubWF4WSgpKSB7Ci0gICAgICAgICAgICBmbG9h dCBmcm9tWCA9IChkZXN0UmVjdC54KCkgLSBvbmVUaWxlUmVjdC54KCkpIC8gc2NhbGUud2lkdGgo KTsKLSAgICAgICAgICAgIGZsb2F0IHRvWCA9IG9uZVRpbGVSZWN0LngoKTsKKyAgICAgICAgICAg IGN1cnJlbnRUaWxlUmVjdC5zaGlmdFhFZGdlVG8oZGVzdFJlY3QueCgpKTsKKyAgICAgICAgICAg IGZsb2F0IHRvWCA9IGN1cnJlbnRUaWxlUmVjdC54KCk7CiAgICAgICAgICAgICB3aGlsZSAodG9Y IDwgZGVzdFJlY3QubWF4WCgpKSB7Ci0gICAgICAgICAgICAgICAgRmxvYXRSZWN0IHRvUmVjdCh0 b1gsIHRvWSwgb25lVGlsZVJlY3Qud2lkdGgoKSwgb25lVGlsZVJlY3QuaGVpZ2h0KCkpOwotICAg ICAgICAgICAgICAgIEZsb2F0UmVjdCBmcm9tUmVjdChmcm9tWCwgZnJvbVksIG9uZVRpbGVSZWN0 LndpZHRoKCkgLyBzY2FsZS53aWR0aCgpLCBvbmVUaWxlUmVjdC5oZWlnaHQoKSAvIHNjYWxlLmhl aWdodCgpKTsKKyAgICAgICAgICAgICAgICBGbG9hdFJlY3QgdG9SZWN0KHRvWCwgdG9ZLCBjdXJy ZW50VGlsZVJlY3Qud2lkdGgoKSwgY3VycmVudFRpbGVSZWN0LmhlaWdodCgpKTsKKyAgICAgICAg ICAgICAgICBGbG9hdFJlY3QgZnJvbVJlY3QodG9GbG9hdFBvaW50KGN1cnJlbnRUaWxlUmVjdC5s b2NhdGlvbigpIC0gb25lVGlsZVJlY3QubG9jYXRpb24oKSksIGN1cnJlbnRUaWxlUmVjdC5zaXpl KCkpOworICAgICAgICAgICAgICAgIGZyb21SZWN0LnNjYWxlKDEgLyBzY2FsZS53aWR0aCgpLCAx IC8gc2NhbGUuaGVpZ2h0KCkpOworCiAgICAgICAgICAgICAgICAgZHJhdyhjdHh0LCB0b1JlY3Qs IGZyb21SZWN0LCBzdHlsZUNvbG9yU3BhY2UsIG9wLCBCbGVuZE1vZGVOb3JtYWwsIEltYWdlT3Jp ZW50YXRpb25EZXNjcmlwdGlvbigpKTsKLSAgICAgICAgICAgICAgICB0b1ggKz0gb25lVGlsZVJl Y3Qud2lkdGgoKTsKLSAgICAgICAgICAgICAgICBmcm9tWCA9IDA7CisgICAgICAgICAgICAgICAg dG9YICs9IGN1cnJlbnRUaWxlUmVjdC53aWR0aCgpOworICAgICAgICAgICAgICAgIGN1cnJlbnRU aWxlUmVjdC5zaGlmdFhFZGdlVG8ob25lVGlsZVJlY3QueCgpKTsKICAgICAgICAgICAgIH0KLSAg ICAgICAgICAgIHRvWSArPSBvbmVUaWxlUmVjdC5oZWlnaHQoKTsKLSAgICAgICAgICAgIGZyb21Z ID0gMDsKKyAgICAgICAgICAgIHRvWSArPSBjdXJyZW50VGlsZVJlY3QuaGVpZ2h0KCk7CisgICAg ICAgICAgICBjdXJyZW50VGlsZVJlY3Quc2hpZnRZRWRnZVRvKG9uZVRpbGVSZWN0LnkoKSk7CiAg ICAgICAgIH0KICAgICAgICAgcmV0dXJuOwogICAgIH0K