133410 2014-05-30 12:23:37 -0700 Address some review comments on bug 133408 2014-06-02 13:22:51 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren andersca bdakin darin mitz sam webkit-bug-importer oldest_to_newest 1012653 0 ggaren 2014-05-30 12:23:37 -0700 Comment #5 From Darin Adler 2014-05-30 11:54:49 PST (-) [reply] (From update of attachment 232297 [details]) View in context: https://bugs.webkit.org/attachment.cgi?id=232297&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListItem.h:32 > -/*! A @link WKBackForwardListItem @/link represents a visited webpage in a WKWebView's back-forward list. > +/*! A WKBackForwardListItem object represents a previously visited webpage in the back-forward list of a web view. Not sure this is perfectly accurate. Is the page you are currently on a previously visited webpage? > Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.h:41 > +/*! @abstract A Boolean value indicating whether the frame is the main frame > + or a subframe. Are we capitalizing the word “boolean” here because of its origin as a person’s name? I suggest “boolean” with a lowercase b. > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:76 > + @discussion Clients should visually indicate that this panel comes from > + JavaScript initiated by the specified frame. I think this is confusing wording. The point here is that for good security it's important to indicate that the panel comes from JavaScript and which website controls the content of the panel. But “initiated by the specified frame” is an oblique way to say this. 1012655 1 webkit-bug-importer 2014-05-30 12:24:15 -0700 <rdar://problem/17081195> 1012658 2 ggaren 2014-05-30 12:34:33 -0700 > > Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListItem.h:32 > > -/*! A @link WKBackForwardListItem @/link represents a visited webpage in a WKWebView's back-forward list. > > +/*! A WKBackForwardListItem object represents a previously visited webpage in the back-forward list of a web view. > > Not sure this is perfectly accurate. Is the page you are currently on a previously visited webpage? Not necessarily. Also, I suppose the details of why something ended up in the list involve subtleties of loading, redirection, and DOM APIs. So, I think it's best not to comment on how something got in the list. I removed "previously visited" and just left it at "webpage". > > Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.h:41 > > +/*! @abstract A Boolean value indicating whether the frame is the main frame > > + or a subframe. > > Are we capitalizing the word “boolean” here because of its origin as a person’s name? I suggest “boolean” with a lowercase b. I wondered the same thing. It seems to a de facto standard in Apple headerdoc, so I think we should just click agree: <https://developer.apple.com/library/ios/documentation/uikit/reference/uiview_class/uiview/uiview.html> <https://developer.apple.com/library/ios/documentation/uikit/reference/UIWebView_Class/Reference/Reference.html> > > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:76 > > + @discussion Clients should visually indicate that this panel comes from > > + JavaScript initiated by the specified frame. > > I think this is confusing wording. The point here is that for good security it's important to indicate that the panel comes from JavaScript and which website controls the content of the panel. But “initiated by the specified frame” is an oblique way to say this. How about: @discussion For user security, your app should visually indicate that a specific websites controls the content in this panel. 1012659 3 webkit-bug-importer 2014-05-30 12:34:47 -0700 <rdar://problem/17081315> 1012661 4 232300 ggaren 2014-05-30 12:35:39 -0700 Created attachment 232300 Patch 1012662 5 ggaren 2014-05-30 12:36:27 -0700 s/websites/website/ 1012663 6 mitz 2014-05-30 12:41:55 -0700 (In reply to comment #2) > How about: > > @discussion For user security, your app should visually indicate that > a specific websites controls the content in this panel. Can you drop “visually”? The app should indicate this in a way that works for visually-impaired users as well. 1012670 7 232300 darin 2014-05-30 13:37:22 -0700 Comment on attachment 232300 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232300&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:76 > + @discussion For user security, your app should visually indicate that > + a specific website controls the content in this panel. Besides Dan’s suggestion of omitting the word “visually” it also might be useful to point at the simple recipe for figuring out which specific website to indicate. I presume that it’s one of the properties of WKFrameInfo, maybe something that returns a URL that the client should extract a hostname from using an NSURL method. Of course, they would also want to have use a “user visible host name” with IDN decoded, but I’m not sure the API makes a helper method that can decode IDN public. 1012685 8 232306 ggaren 2014-05-30 14:47:44 -0700 Created attachment 232306 Patch 1012686 9 ggaren 2014-05-30 14:48:25 -0700 Changed "visually indicate" to "call attention to". Added the example of "[[[frame request] URL] host]". 1012690 10 232306 andersca 2014-05-30 15:32:35 -0700 Comment on attachment 232306 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232306&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:64 > + for identifying the controlling website is [[[frame request] URL] host]. Please use property syntax, i.e. frame.request.URL.host. > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:78 > + for identifying the controlling website is [[[frame request] URL] host]. Please use property syntax, i.e. frame.request.URL.host. > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:93 > + for identifying the controlling website is [[[frame request] URL] host]. Please use property syntax, i.e. frame.request.URL.host. 1012994 11 ggaren 2014-06-02 13:22:51 -0700 Committed r169542: <http://trac.webkit.org/changeset/169542> 232300 2014-05-30 12:35:39 -0700 2014-05-30 14:47:42 -0700 Patch bug-133410-20140530123459.patch text/plain 3374 ggaren SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTQ5MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA1LTMwICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkcmVzcyBzb21lIHJldmll dyBjb21tZW50cyBvbiBidWcgMTMzNDA4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzM0MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tCYWNrRm9yd2FyZExpc3RJ dGVtLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVsZWdhdGUuaDoKKwog MjAxNC0wNS0zMCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAg IFNvbWUgbW9yZSBjb3B5LWVkaXRpbmcgb2YgdGhlIE1vZGVybiBXZWJLaXQgaGVhZGVyZG9jCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLQmFja0ZvcndhcmRMaXN0 SXRlbS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tCYWNrRm9yd2FyZExpc3RJdGVtLmgJKHJldmlzaW9uIDE2OTQ5MCkKKysrIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tCYWNrRm9yd2FyZExpc3RJdGVtLmgJKHdvcmtpbmcg Y29weSkKQEAgLTI5LDcgKzI5LDcgQEAKIAogI2ltcG9ydCA8Rm91bmRhdGlvbi9Gb3VuZGF0aW9u Lmg+CiAKLS8qISBBIFdLQmFja0ZvcndhcmRMaXN0SXRlbSBvYmplY3QgcmVwcmVzZW50cyBhIHBy ZXZpb3VzbHkgdmlzaXRlZCB3ZWJwYWdlIGluIHRoZSBiYWNrLWZvcndhcmQgbGlzdCBvZiBhIHdl YiB2aWV3LgorLyohIEEgV0tCYWNrRm9yd2FyZExpc3RJdGVtIG9iamVjdCByZXByZXNlbnRzIGEg d2VicGFnZSBpbiB0aGUgYmFjay1mb3J3YXJkIGxpc3Qgb2YgYSB3ZWIgdmlldy4KICAqLwogV0tf Q0xBU1NfQVZBSUxBQkxFKDEwXzEwLCA4XzApCiBAaW50ZXJmYWNlIFdLQmFja0ZvcndhcmRMaXN0 SXRlbSA6IE5TT2JqZWN0CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L1dLVUlEZWxlZ2F0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvQ29jb2EvV0tVSURlbGVnYXRlLmgJKHJldmlzaW9uIDE2OTQ5MCkKKysrIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlLmgJKHdvcmtpbmcgY29weSkKQEAg LTU5LDggKzU5LDggQEAKICBjYWxsLgogIEBwYXJhbSBjb21wbGV0aW9uSGFuZGxlciBUaGUgY29t cGxldGlvbiBoYW5kbGVyIHRvIGNhbGwgYWZ0ZXIgdGhlIGFsZXJ0CiAgcGFuZWwgaGFzIGJlZW4g ZGlzbWlzc2VkLgotIEBkaXNjdXNzaW9uIENsaWVudHMgc2hvdWxkIHZpc3VhbGx5IGluZGljYXRl IHRoYXQgdGhpcyBwYW5lbCBjb21lcyBmcm9tCi0gSmF2YVNjcmlwdCBpbml0aWF0ZWQgYnkgdGhl IHNwZWNpZmllZCBmcmFtZS4KKyBAZGlzY3Vzc2lvbiBGb3IgdXNlciBzZWN1cml0eSwgeW91ciBh cHAgc2hvdWxkIHZpc3VhbGx5IGluZGljYXRlIHRoYXQKKyBhIHNwZWNpZmljIHdlYnNpdGUgY29u dHJvbHMgdGhlIGNvbnRlbnQgaW4gdGhpcyBwYW5lbC4KICBUaGUgcGFuZWwgc2hvdWxkIGhhdmUg YSBzaW5nbGUgT0sgYnV0dG9uLgogICovCiAtICh2b2lkKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdl YlZpZXcgcnVuSmF2YVNjcmlwdEFsZXJ0UGFuZWxXaXRoTWVzc2FnZTooTlNTdHJpbmcgKiltZXNz YWdlIGluaXRpYXRlZEJ5RnJhbWU6KFdLRnJhbWVJbmZvICopZnJhbWUgY29tcGxldGlvbkhhbmRs ZXI6KHZvaWQgKF4pKCkpY29tcGxldGlvbkhhbmRsZXI7CkBAIC03Miw4ICs3Miw4IEBACiAgQHBh cmFtIGNvbXBsZXRpb25IYW5kbGVyIFRoZSBjb21wbGV0aW9uIGhhbmRsZXIgdG8gY2FsbCBhZnRl ciB0aGUgY29uZmlybQogIHBhbmVsIGhhcyBiZWVuIGRpc21pc3NlZC4gUGFzcyBZRVMgaWYgdGhl IHVzZXIgY2hvc2UgT0ssIE5PIGlmIHRoZSB1c2VyCiAgY2hvc2UgQ2FuY2VsLgotIEBkaXNjdXNz aW9uIENsaWVudHMgc2hvdWxkIHZpc3VhbGx5IGluZGljYXRlIHRoYXQgdGhpcyBwYW5lbCBjb21l cyBmcm9tCi0gSmF2YVNjcmlwdCBpbml0aWF0ZWQgYnkgdGhlIHNwZWNpZmllZCBmcmFtZS4KKyBA ZGlzY3Vzc2lvbiBGb3IgdXNlciBzZWN1cml0eSwgeW91ciBhcHAgc2hvdWxkIHZpc3VhbGx5IGlu ZGljYXRlIHRoYXQKKyBhIHNwZWNpZmljIHdlYnNpdGUgY29udHJvbHMgdGhlIGNvbnRlbnQgaW4g dGhpcyBwYW5lbC4KICBUaGUgcGFuZWwgc2hvdWxkIGhhdmUgdHdvIGJ1dHRvbnMsIHN1Y2ggYXMg T0sgYW5kIENhbmNlbC4KICAqLwogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3 IHJ1bkphdmFTY3JpcHRDb25maXJtUGFuZWxXaXRoTWVzc2FnZTooTlNTdHJpbmcgKiltZXNzYWdl IGluaXRpYXRlZEJ5RnJhbWU6KFdLRnJhbWVJbmZvICopZnJhbWUgY29tcGxldGlvbkhhbmRsZXI6 KHZvaWQgKF4pKEJPT0wgcmVzdWx0KSljb21wbGV0aW9uSGFuZGxlcjsKQEAgLTg2LDggKzg2LDgg QEAKICBAcGFyYW0gY29tcGxldGlvbkhhbmRsZXIgVGhlIGNvbXBsZXRpb24gaGFuZGxlciB0byBj YWxsIGFmdGVyIHRoZSB0ZXh0CiAgaW5wdXQgcGFuZWwgaGFzIGJlZW4gZGlzbWlzc2VkLiBQYXNz IHRoZSBlbnRlcmVkIHRleHQgaWYgdGhlIHVzZXIgY2hvc2UKICBPSywgb3RoZXJ3aXNlIG5pbC4K LSBAZGlzY3Vzc2lvbiBDbGllbnRzIHNob3VsZCB2aXN1YWxseSBpbmRpY2F0ZSB0aGF0IHRoaXMg cGFuZWwgY29tZXMgZnJvbQotIEphdmFTY3JpcHQgaW5pdGlhdGVkIGJ5IHRoZSBzcGVjaWZpZWQg ZnJhbWUuCisgQGRpc2N1c3Npb24gRm9yIHVzZXIgc2VjdXJpdHksIHlvdXIgYXBwIHNob3VsZCB2 aXN1YWxseSBpbmRpY2F0ZSB0aGF0CisgYSBzcGVjaWZpYyB3ZWJzaXRlIGNvbnRyb2xzIHRoZSBj b250ZW50IGluIHRoaXMgcGFuZWwuCiAgVGhlIHBhbmVsIHNob3VsZCBoYXZlIHR3byBidXR0b25z LCBzdWNoIGFzIE9LIGFuZCBDYW5jZWwsIGFuZCBhIGZpZWxkIGluCiAgd2hpY2ggdG8gZW50ZXIg dGV4dC4KICAqLwo= 232306 2014-05-30 14:47:44 -0700 2014-05-30 15:32:35 -0700 Patch bug-133410-20140530144705.patch text/plain 3655 ggaren SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTQ5NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA1LTMwICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkcmVzcyBzb21lIHJldmll dyBjb21tZW50cyBvbiBidWcgMTMzNDA4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzM0MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tCYWNrRm9yd2FyZExpc3RJ dGVtLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVsZWdhdGUuaDoKKwog MjAxNC0wNS0zMCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgaW4gcjE2OTQ5MC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tCYWNrRm9yd2FyZExpc3RJdGVtLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0JhY2tGb3J3YXJkTGlzdEl0ZW0u aAkocmV2aXNpb24gMTY5NDk1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS0JhY2tGb3J3YXJkTGlzdEl0ZW0uaAkod29ya2luZyBjb3B5KQpAQCAtMjksNyArMjksNyBA QAogCiAjaW1wb3J0IDxGb3VuZGF0aW9uL0ZvdW5kYXRpb24uaD4KIAotLyohIEEgV0tCYWNrRm9y d2FyZExpc3RJdGVtIG9iamVjdCByZXByZXNlbnRzIGEgcHJldmlvdXNseSB2aXNpdGVkIHdlYnBh Z2UgaW4gdGhlIGJhY2stZm9yd2FyZCBsaXN0IG9mIGEgd2ViIHZpZXcuCisvKiEgQSBXS0JhY2tG b3J3YXJkTGlzdEl0ZW0gb2JqZWN0IHJlcHJlc2VudHMgYSB3ZWJwYWdlIGluIHRoZSBiYWNrLWZv cndhcmQgbGlzdCBvZiBhIHdlYiB2aWV3LgogICovCiBXS19DTEFTU19BVkFJTEFCTEUoMTBfMTAs IDhfMCkKIEBpbnRlcmZhY2UgV0tCYWNrRm9yd2FyZExpc3RJdGVtIDogTlNPYmplY3QKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVsZWdhdGUu aAkocmV2aXNpb24gMTY5NDk1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1VJRGVsZWdhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtNTksOCArNTksOSBAQAogIGNhbGwu CiAgQHBhcmFtIGNvbXBsZXRpb25IYW5kbGVyIFRoZSBjb21wbGV0aW9uIGhhbmRsZXIgdG8gY2Fs bCBhZnRlciB0aGUgYWxlcnQKICBwYW5lbCBoYXMgYmVlbiBkaXNtaXNzZWQuCi0gQGRpc2N1c3Np b24gQ2xpZW50cyBzaG91bGQgdmlzdWFsbHkgaW5kaWNhdGUgdGhhdCB0aGlzIHBhbmVsIGNvbWVz IGZyb20KLSBKYXZhU2NyaXB0IGluaXRpYXRlZCBieSB0aGUgc3BlY2lmaWVkIGZyYW1lLgorIEBk aXNjdXNzaW9uIEZvciB1c2VyIHNlY3VyaXR5LCB5b3VyIGFwcCBzaG91bGQgY2FsbCBhdHRlbnRp b24gdG8gdGhlIGZhY3QKKyB0aGF0IGEgc3BlY2lmaWMgd2Vic2l0ZSBjb250cm9scyB0aGUgY29u dGVudCBpbiB0aGlzIHBhbmVsLiBBIHNpbXBsZSBmb3J1bWxhCisgZm9yIGlkZW50aWZ5aW5nIHRo ZSBjb250cm9sbGluZyB3ZWJzaXRlIGlzIFtbW2ZyYW1lIHJlcXVlc3RdIFVSTF0gaG9zdF0uCiAg VGhlIHBhbmVsIHNob3VsZCBoYXZlIGEgc2luZ2xlIE9LIGJ1dHRvbi4KICAqLwogLSAodm9pZCl3 ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IHJ1bkphdmFTY3JpcHRBbGVydFBhbmVsV2l0aE1l c3NhZ2U6KE5TU3RyaW5nICopbWVzc2FnZSBpbml0aWF0ZWRCeUZyYW1lOihXS0ZyYW1lSW5mbyAq KWZyYW1lIGNvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKSgpKWNvbXBsZXRpb25IYW5kbGVyOwpA QCAtNzIsOCArNzMsOSBAQAogIEBwYXJhbSBjb21wbGV0aW9uSGFuZGxlciBUaGUgY29tcGxldGlv biBoYW5kbGVyIHRvIGNhbGwgYWZ0ZXIgdGhlIGNvbmZpcm0KICBwYW5lbCBoYXMgYmVlbiBkaXNt aXNzZWQuIFBhc3MgWUVTIGlmIHRoZSB1c2VyIGNob3NlIE9LLCBOTyBpZiB0aGUgdXNlcgogIGNo b3NlIENhbmNlbC4KLSBAZGlzY3Vzc2lvbiBDbGllbnRzIHNob3VsZCB2aXN1YWxseSBpbmRpY2F0 ZSB0aGF0IHRoaXMgcGFuZWwgY29tZXMgZnJvbQotIEphdmFTY3JpcHQgaW5pdGlhdGVkIGJ5IHRo ZSBzcGVjaWZpZWQgZnJhbWUuCisgQGRpc2N1c3Npb24gRm9yIHVzZXIgc2VjdXJpdHksIHlvdXIg YXBwIHNob3VsZCBjYWxsIGF0dGVudGlvbiB0byB0aGUgZmFjdAorIHRoYXQgYSBzcGVjaWZpYyB3 ZWJzaXRlIGNvbnRyb2xzIHRoZSBjb250ZW50IGluIHRoaXMgcGFuZWwuIEEgc2ltcGxlIGZvcnVt bGEKKyBmb3IgaWRlbnRpZnlpbmcgdGhlIGNvbnRyb2xsaW5nIHdlYnNpdGUgaXMgW1tbZnJhbWUg cmVxdWVzdF0gVVJMXSBob3N0XS4KICBUaGUgcGFuZWwgc2hvdWxkIGhhdmUgdHdvIGJ1dHRvbnMs IHN1Y2ggYXMgT0sgYW5kIENhbmNlbC4KICAqLwogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcg Kil3ZWJWaWV3IHJ1bkphdmFTY3JpcHRDb25maXJtUGFuZWxXaXRoTWVzc2FnZTooTlNTdHJpbmcg KiltZXNzYWdlIGluaXRpYXRlZEJ5RnJhbWU6KFdLRnJhbWVJbmZvICopZnJhbWUgY29tcGxldGlv bkhhbmRsZXI6KHZvaWQgKF4pKEJPT0wgcmVzdWx0KSljb21wbGV0aW9uSGFuZGxlcjsKQEAgLTg2 LDggKzg4LDkgQEAKICBAcGFyYW0gY29tcGxldGlvbkhhbmRsZXIgVGhlIGNvbXBsZXRpb24gaGFu ZGxlciB0byBjYWxsIGFmdGVyIHRoZSB0ZXh0CiAgaW5wdXQgcGFuZWwgaGFzIGJlZW4gZGlzbWlz c2VkLiBQYXNzIHRoZSBlbnRlcmVkIHRleHQgaWYgdGhlIHVzZXIgY2hvc2UKICBPSywgb3RoZXJ3 aXNlIG5pbC4KLSBAZGlzY3Vzc2lvbiBDbGllbnRzIHNob3VsZCB2aXN1YWxseSBpbmRpY2F0ZSB0 aGF0IHRoaXMgcGFuZWwgY29tZXMgZnJvbQotIEphdmFTY3JpcHQgaW5pdGlhdGVkIGJ5IHRoZSBz cGVjaWZpZWQgZnJhbWUuCisgQGRpc2N1c3Npb24gRm9yIHVzZXIgc2VjdXJpdHksIHlvdXIgYXBw IHNob3VsZCBjYWxsIGF0dGVudGlvbiB0byB0aGUgZmFjdAorIHRoYXQgYSBzcGVjaWZpYyB3ZWJz aXRlIGNvbnRyb2xzIHRoZSBjb250ZW50IGluIHRoaXMgcGFuZWwuIEEgc2ltcGxlIGZvcnVtbGEK KyBmb3IgaWRlbnRpZnlpbmcgdGhlIGNvbnRyb2xsaW5nIHdlYnNpdGUgaXMgW1tbZnJhbWUgcmVx dWVzdF0gVVJMXSBob3N0XS4KICBUaGUgcGFuZWwgc2hvdWxkIGhhdmUgdHdvIGJ1dHRvbnMsIHN1 Y2ggYXMgT0sgYW5kIENhbmNlbCwgYW5kIGEgZmllbGQgaW4KICB3aGljaCB0byBlbnRlciB0ZXh0 LgogICovCg==