133402 2014-05-30 02:23:18 -0700 [GTK] media controls should prevent 'click' events from reaching the page 2014-06-02 01:32:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 133268 1 calvaris calvaris calvaris commit-queue eric.carlson glenn jer.noble mrobinson philipj sergio webkit-bug-importer oldest_to_newest 1012583 0 calvaris 2014-05-30 02:23:18 -0700 +++ This bug was initially created as a clone of Bug #133268 +++ The C++ based media control elements stopped 'click' event propagation, the JS based controls should too. 1012588 1 232288 calvaris 2014-05-30 03:14:52 -0700 Created attachment 232288 Patch 1012590 2 232289 calvaris 2014-05-30 03:32:22 -0700 Created attachment 232289 Patch Removed returning true for handlePlay and handleTimeUpdate which are not input but video events. 1012831 3 calvaris 2014-06-01 09:31:59 -0700 If any reviewer had a minute for this quick review I would be deeply grateful :D 1012916 4 232289 commit-queue 2014-06-02 01:31:57 -0700 Comment on attachment 232289 Patch Clearing flags on attachment: 232289 Committed r169527: <http://trac.webkit.org/changeset/169527> 1012917 5 commit-queue 2014-06-02 01:32:00 -0700 All reviewed patches have been landed. Closing bug. 232288 2014-05-30 03:14:52 -0700 2014-05-30 03:32:15 -0700 Patch bug-133402-20140530121427.patch text/plain 3921 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Y5ZDc4YmYzOTVjMzIz NTYwNjRiMWJiODQ4M2Y0ZjM0MjE5M2ZjNy4uMWM4ZmY4YzIxNDE5NjE1ZmRjMzhmNmQyZjIxYTQ1 ZjUxYzBkYTQ0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE0LTA1LTMwICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dU S10gbWVkaWEgY29udHJvbHMgc2hvdWxkIHByZXZlbnQgJ2NsaWNrJyBldmVudHMgZnJvbSByZWFj aGluZyB0aGUgcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTMzNDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2hlbiBoYW5kbGluZyBldmVudHMsIHdlIGV2ZW50cyB3ZSBuZWVkIHRvIHJldHVybiB0 cnVlIGluIG9yZGVyCisgICAgICAgIHRoYXQgdGhlIHN1cGVyY2xhc3MgZ2V0cyB0aGUgdmFsdWUg YW5kIHByZXZlbnRzIHRoZSBleGVjdXRpb24gb2YKKyAgICAgICAgdGhlIGRlZmF1bHQgZXZlbnQg aGFuZGxlciBpbiB0aGUgcGFnZS4KKworICAgICAgICBUZXN0OiBtZWRpYS9tZWRpYS1jb250cm9s cy1jYW5jZWwtZXZlbnRzLmh0bWwKKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9t ZWRpYUNvbnRyb2xzR3RrLmpzOgorICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUuaGFu ZGxlUGxheSk6CisgICAgICAgIChDb250cm9sbGVyR3RrLnByb3RvdHlwZS5oYW5kbGVUaW1lVXBk YXRlKToKKyAgICAgICAgKENvbnRyb2xsZXJHdGsucHJvdG90eXBlLmhhbmRsZU11dGVCdXR0b25N b3VzZU92ZXIpOgorICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUuaGFuZGxlVm9sdW1l Qm94TW91c2VPdXQpOgorICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUuaGFuZGxlQ2Fw dGlvbkJ1dHRvbkNsaWNrZWQpOgorICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUuaGFu ZGxlQ2FwdGlvbkJ1dHRvbk1vdXNlT3Zlcik6CisgICAgICAgIChDb250cm9sbGVyR3RrLnByb3Rv dHlwZS5oYW5kbGVDYXB0aW9uQnV0dG9uU2hvd01lbnUpOgorICAgICAgICAoQ29udHJvbGxlckd0 ay5wcm90b3R5cGUuaGFuZGxlQ2FwdGlvbkJ1dHRvbk1vdXNlT3V0KToKKyAgICAgICAgKENvbnRy b2xsZXJHdGsucHJvdG90eXBlLmhhbmRsZUNhcHRpb25Nb3VzZU91dCk6IFJldHVybiB0cnVlIHRv CisgICAgICAgIHByZXZlbnQgZm9yd2FyZGluZyB0aGUgZXZlbnQgZXhlY3V0aW9uLgorCiAyMDE0 LTA1LTI3ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAg IFtNYWNdIG1lZGlhIGNvbnRyb2xzIHNob3VsZCBwcmV2ZW50ICdjbGljaycgZXZlbnRzIGZyb20g cmVhY2hpbmcgdGhlIHBhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNHdGsuanMKaW5kZXggYTlmZjAwODY3ZTkyYWE5MTE4 YTY4OGFmOGQ2ZTViZGNmZjBlYWQ1OC4uODdhNTBmMzhhZDE5YWU3MTM5MjQwNGMxMzM4MGM4Njcw MTgwZjU4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xz L21lZGlhQ29udHJvbHNHdGsuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNv bnRyb2xzL21lZGlhQ29udHJvbHNHdGsuanMKQEAgLTEwNCwxMSArMTA0LDEzIEBAIENvbnRyb2xs ZXJHdGsucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLnNob3dDdXJyZW50VGltZSgpOwogICAg ICAgICBpZiAoIXRoaXMuaXNMaXZlKQogICAgICAgICAgICAgdGhpcy5zaG93Q3VycmVudFRpbWUo KTsKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIAogICAgIGhhbmRsZVRpbWVVcGRhdGU6 IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKICAgICAgICAgdGhpcy51cGRhdGVUaW1lKCk7CisgICAg ICAgIHJldHVybiB0cnVlOwogICAgIH0sCiAKICAgICBoYW5kbGVNdXRlQnV0dG9uTW91c2VPdmVy OiBmdW5jdGlvbihldmVudCkKQEAgLTEyMSwxMSArMTIzLDEzIEBAIENvbnRyb2xsZXJHdGsucHJv dG90eXBlID0gewogICAgICAgICAgICAgdGhpcy5jb250cm9scy5wYW5lbC5jbGFzc0xpc3QucmVt b3ZlKHRoaXMuQ2xhc3NOYW1lcy5kb3duKTsKICAgICAgICAgfQogICAgICAgICB0aGlzLmNvbnRy b2xzLnZvbHVtZUJveC5jbGFzc0xpc3QucmVtb3ZlKHRoaXMuQ2xhc3NOYW1lcy5oaWRpbmcpOwor ICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LAogCiAgICAgaGFuZGxlVm9sdW1lQm94TW91c2VP dXQ6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKICAgICAgICAgdGhpcy5jb250cm9scy52b2x1bWVC b3guY2xhc3NMaXN0LmFkZCh0aGlzLkNsYXNzTmFtZXMuaGlkaW5nKTsKKyAgICAgICAgcmV0dXJu IHRydWU7CiAgICAgfSwKIAogICAgIGFkZENvbnRyb2xzOiBmdW5jdGlvbigpCkBAIC0xNjUsNiAr MTY5LDcgQEAgQ29udHJvbGxlckd0ay5wcm90b3R5cGUgPSB7CiAgICAgaGFuZGxlQ2FwdGlvbkJ1 dHRvbkNsaWNrZWQ6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKICAgICAgICAgdGhpcy5oYW5kbGVD YXB0aW9uQnV0dG9uU2hvd01lbnUoZXZlbnQpCisgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0s CiAKICAgICBidWlsZENhcHRpb25NZW51OiBmdW5jdGlvbigpCkBAIC0yMTIsNiArMjE3LDcgQEAg Q29udHJvbGxlckd0ay5wcm90b3R5cGUgPSB7CiAgICAgaGFuZGxlQ2FwdGlvbkJ1dHRvbk1vdXNl T3ZlcjogZnVuY3Rpb24oZXZlbnQpCiAgICAgewogICAgICAgICB0aGlzLmhhbmRsZUNhcHRpb25C dXR0b25TaG93TWVudShldmVudCk7CisgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0sCiAKICAg ICBoYW5kbGVDYXB0aW9uQnV0dG9uU2hvd01lbnU6IGZ1bmN0aW9uKGV2ZW50KQpAQCAtMjIwLDEy ICsyMjYsMTQgQEAgQ29udHJvbGxlckd0ay5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB0aGlz LmJ1aWxkQ2FwdGlvbk1lbnUoKTsKICAgICAgICAgaWYgKCFjb250YWlucyh0aGlzLmNhcHRpb25N ZW51LmNhcHRpb25NZW51VHJlZUVsZW1lbnRzLCBldmVudC5yZWxhdGVkVGFyZ2V0KSkKICAgICAg ICAgICAgIHRoaXMuc2hvd0NhcHRpb25NZW51KCk7CisgICAgICAgIHJldHVybiB0cnVlOwogICAg IH0sCiAKICAgICBoYW5kbGVDYXB0aW9uQnV0dG9uTW91c2VPdXQ6IGZ1bmN0aW9uKGV2ZW50KQog ICAgIHsKICAgICAgICAgaWYgKHRoaXMuY2FwdGlvbk1lbnUgJiYgIWNvbnRhaW5zKHRoaXMuY2Fw dGlvbk1lbnUuY2FwdGlvbk1lbnVUcmVlRWxlbWVudHMsIGV2ZW50LnJlbGF0ZWRUYXJnZXQpKQog ICAgICAgICAgICAgdGhpcy5oaWRlQ2FwdGlvbk1lbnUoKTsKKyAgICAgICAgcmV0dXJuIHRydWU7 CiAgICAgfSwKIAogICAgIGhhbmRsZUNhcHRpb25Nb3VzZU91dDogZnVuY3Rpb24oZXZlbnQpCkBA IC0yMzMsNiArMjQxLDcgQEAgQ29udHJvbGxlckd0ay5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlm IChldmVudC5yZWxhdGVkVGFyZ2V0ICE9IHRoaXMuY29udHJvbHMuY2FwdGlvbkJ1dHRvbiAmJgog ICAgICAgICAgICAgIWNvbnRhaW5zKHRoaXMuY2FwdGlvbk1lbnUuY2FwdGlvbk1lbnVUcmVlRWxl bWVudHMsIGV2ZW50LnJlbGF0ZWRUYXJnZXQpKQogICAgICAgICAgICAgdGhpcy5oaWRlQ2FwdGlv bk1lbnUoKTsKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIH07CiAK 232289 2014-05-30 03:32:22 -0700 2014-06-02 01:31:56 -0700 Patch bug-133402-20140530123157.patch text/plain 3488 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Y5ZDc4YmYzOTVjMzIz NTYwNjRiMWJiODQ4M2Y0ZjM0MjE5M2ZjNy4uYTUzODExMjVkZjdkZTAwMjdiMGMxZDYwZDE5MDBm ZTZhZjU3YWIyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA1LTMwICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dU S10gbWVkaWEgY29udHJvbHMgc2hvdWxkIHByZXZlbnQgJ2NsaWNrJyBldmVudHMgZnJvbSByZWFj aGluZyB0aGUgcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTMzNDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2hlbiBoYW5kbGluZyBldmVudHMsIHdlIGV2ZW50cyB3ZSBuZWVkIHRvIHJldHVybiB0 cnVlIGluIG9yZGVyCisgICAgICAgIHRoYXQgdGhlIHN1cGVyY2xhc3MgZ2V0cyB0aGUgdmFsdWUg YW5kIHByZXZlbnRzIHRoZSBleGVjdXRpb24gb2YKKyAgICAgICAgdGhlIGRlZmF1bHQgZXZlbnQg aGFuZGxlciBpbiB0aGUgcGFnZS4KKworICAgICAgICBUZXN0OiBtZWRpYS9tZWRpYS1jb250cm9s cy1jYW5jZWwtZXZlbnRzLmh0bWwKKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9t ZWRpYUNvbnRyb2xzR3RrLmpzOgorICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUuaGFu ZGxlTXV0ZUJ1dHRvbk1vdXNlT3Zlcik6CisgICAgICAgIChDb250cm9sbGVyR3RrLnByb3RvdHlw ZS5oYW5kbGVWb2x1bWVCb3hNb3VzZU91dCk6CisgICAgICAgIChDb250cm9sbGVyR3RrLnByb3Rv dHlwZS5oYW5kbGVDYXB0aW9uQnV0dG9uQ2xpY2tlZCk6CisgICAgICAgIChDb250cm9sbGVyR3Rr LnByb3RvdHlwZS5oYW5kbGVDYXB0aW9uQnV0dG9uTW91c2VPdmVyKToKKyAgICAgICAgKENvbnRy b2xsZXJHdGsucHJvdG90eXBlLmhhbmRsZUNhcHRpb25CdXR0b25TaG93TWVudSk6CisgICAgICAg IChDb250cm9sbGVyR3RrLnByb3RvdHlwZS5oYW5kbGVDYXB0aW9uQnV0dG9uTW91c2VPdXQpOgor ICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUuaGFuZGxlQ2FwdGlvbk1vdXNlT3V0KTog UmV0dXJuIHRydWUgdG8KKyAgICAgICAgcHJldmVudCBmb3J3YXJkaW5nIHRoZSBldmVudCBleGVj dXRpb24uCisKIDIwMTQtMDUtMjcgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5j b20+CiAKICAgICAgICAgW01hY10gbWVkaWEgY29udHJvbHMgc2hvdWxkIHByZXZlbnQgJ2NsaWNr JyBldmVudHMgZnJvbSByZWFjaGluZyB0aGUgcGFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNHdGsuanMgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0d0ay5qcwppbmRleCBhOWZm MDA4NjdlOTJhYTkxMThhNjg4YWY4ZDZlNWJkY2ZmMGVhZDU4Li41YWI1YWMyYWNjZTU5NjA0Mzky YzRiYmE2MWEzZGQwNWQxOWE2YTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0d0ay5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0d0ay5qcwpAQCAtMTIxLDExICsxMjEs MTMgQEAgQ29udHJvbGxlckd0ay5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB0aGlzLmNvbnRy b2xzLnBhbmVsLmNsYXNzTGlzdC5yZW1vdmUodGhpcy5DbGFzc05hbWVzLmRvd24pOwogICAgICAg ICB9CiAgICAgICAgIHRoaXMuY29udHJvbHMudm9sdW1lQm94LmNsYXNzTGlzdC5yZW1vdmUodGhp cy5DbGFzc05hbWVzLmhpZGluZyk7CisgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0sCiAKICAg ICBoYW5kbGVWb2x1bWVCb3hNb3VzZU91dDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewogICAgICAg ICB0aGlzLmNvbnRyb2xzLnZvbHVtZUJveC5jbGFzc0xpc3QuYWRkKHRoaXMuQ2xhc3NOYW1lcy5o aWRpbmcpOworICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LAogCiAgICAgYWRkQ29udHJvbHM6 IGZ1bmN0aW9uKCkKQEAgLTE2NSw2ICsxNjcsNyBAQCBDb250cm9sbGVyR3RrLnByb3RvdHlwZSA9 IHsKICAgICBoYW5kbGVDYXB0aW9uQnV0dG9uQ2xpY2tlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAg ewogICAgICAgICB0aGlzLmhhbmRsZUNhcHRpb25CdXR0b25TaG93TWVudShldmVudCkKKyAgICAg ICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIAogICAgIGJ1aWxkQ2FwdGlvbk1lbnU6IGZ1bmN0aW9u KCkKQEAgLTIxMiw2ICsyMTUsNyBAQCBDb250cm9sbGVyR3RrLnByb3RvdHlwZSA9IHsKICAgICBo YW5kbGVDYXB0aW9uQnV0dG9uTW91c2VPdmVyOiBmdW5jdGlvbihldmVudCkKICAgICB7CiAgICAg ICAgIHRoaXMuaGFuZGxlQ2FwdGlvbkJ1dHRvblNob3dNZW51KGV2ZW50KTsKKyAgICAgICAgcmV0 dXJuIHRydWU7CiAgICAgfSwKIAogICAgIGhhbmRsZUNhcHRpb25CdXR0b25TaG93TWVudTogZnVu Y3Rpb24oZXZlbnQpCkBAIC0yMjAsMTIgKzIyNCwxNCBAQCBDb250cm9sbGVyR3RrLnByb3RvdHlw ZSA9IHsKICAgICAgICAgICAgIHRoaXMuYnVpbGRDYXB0aW9uTWVudSgpOwogICAgICAgICBpZiAo IWNvbnRhaW5zKHRoaXMuY2FwdGlvbk1lbnUuY2FwdGlvbk1lbnVUcmVlRWxlbWVudHMsIGV2ZW50 LnJlbGF0ZWRUYXJnZXQpKQogICAgICAgICAgICAgdGhpcy5zaG93Q2FwdGlvbk1lbnUoKTsKKyAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIAogICAgIGhhbmRsZUNhcHRpb25CdXR0b25Nb3Vz ZU91dDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewogICAgICAgICBpZiAodGhpcy5jYXB0aW9uTWVu dSAmJiAhY29udGFpbnModGhpcy5jYXB0aW9uTWVudS5jYXB0aW9uTWVudVRyZWVFbGVtZW50cywg ZXZlbnQucmVsYXRlZFRhcmdldCkpCiAgICAgICAgICAgICB0aGlzLmhpZGVDYXB0aW9uTWVudSgp OworICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LAogCiAgICAgaGFuZGxlQ2FwdGlvbk1vdXNl T3V0OiBmdW5jdGlvbihldmVudCkKQEAgLTIzMyw2ICsyMzksNyBAQCBDb250cm9sbGVyR3RrLnBy b3RvdHlwZSA9IHsKICAgICAgICAgaWYgKGV2ZW50LnJlbGF0ZWRUYXJnZXQgIT0gdGhpcy5jb250 cm9scy5jYXB0aW9uQnV0dG9uICYmCiAgICAgICAgICAgICAhY29udGFpbnModGhpcy5jYXB0aW9u TWVudS5jYXB0aW9uTWVudVRyZWVFbGVtZW50cywgZXZlbnQucmVsYXRlZFRhcmdldCkpCiAgICAg ICAgICAgICB0aGlzLmhpZGVDYXB0aW9uTWVudSgpOworICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICB9LAogfTsKIAo=