133388 2014-05-29 14:24:43 -0700 Fix iOS depth buffer clearing issue. 2014-05-29 15:10:53 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen webkit-unassigned commit-queue dino kondapallykalyan noam roger_fong oldest_to_newest 1012496 0 achristensen 2014-05-29 14:24:43 -0700 On iOS, the depth buffer is not being cleared correctly in WebGLRenderingContext::clearIfComposited because it is always returning after the check for !m_context->layerComposited(). This moves where the layer is being marked as composited from the mac-specific GraphicsContext3D::prepareTexture to the mac and iOS specific display function, which calls drawInCGLContext through its [super display] call. 1012497 1 232263 achristensen 2014-05-29 14:27:24 -0700 Created attachment 232263 Patch 1012504 2 232263 commit-queue 2014-05-29 15:10:48 -0700 Comment on attachment 232263 Patch Clearing flags on attachment: 232263 Committed r169467: <http://trac.webkit.org/changeset/169467> 1012505 3 commit-queue 2014-05-29 15:10:53 -0700 All reviewed patches have been landed. Closing bug. 232263 2014-05-29 14:27:24 -0700 2014-05-29 15:10:47 -0700 Patch bug-133388-20140529142700.patch text/plain 2032 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTQ2MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA1LTI5ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2lPUyBXZWJH TF0gRml4IGRlcHRoIGJ1ZmZlciBjbGVhcmluZyBpc3N1ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzM4OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYnV0IHRoaXMgZml4ZXMg d2ViZ2wvMS4wLjEvY29uZm9ybWFuY2UvY2FudmFzL2J1ZmZlci1wcmVzZXJ2ZS10ZXN0Lmh0bWwu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvV2ViR0xMYXllci5tbToKKyAgICAg ICAgKC1bV2ViR0xMYXllciBkaXNwbGF5XSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv b3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkdyYXBoaWNzQ29udGV4dDNEOjpwcmVwYXJlVGV4dHVyZSk6CisgICAgICAgIE1vdmVkIG1h cmtpbmcgdGhlIGxheWVyIGFzIGNvbXBvc2l0ZWQgZnJvbSB0aGUgbWFjLW9ubHkgcHJlcGFyZVRl eHR1cmUgdG8KKyAgICAgICAgdGhlIGVuZCBvZiBbV2ViR0xMYXllciBkaXNwbGF5XSB3aGljaCBp cyBjYWxsZWQgYnkgbWFjIGFuZCBpT1MuCisKIDIwMTQtMDUtMjkgIEplcmVteSBKb25lcyAgPGpl cmVteWpAYXBwbGUuY29tPgogCiAgICAgICAgIFBlcnNlcnZlIGNhcHRpb24gc2VsZWN0aW9uIGlu IGZ1bGxzY3JlZW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMv V2ViR0xMYXllci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9tYWMvV2ViR0xMYXllci5tbQkocmV2aXNpb24gMTY5MTIxKQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1dlYkdMTGF5ZXIubW0JKHdvcmtpbmcgY29weSkKQEAg LTE1NSw2ICsxNTUsNyBAQCAtICh2b2lkKWRpc3BsYXkKICNlbHNlCiAgICAgW3N1cGVyIGRpc3Bs YXldOwogI2VuZGlmCisgICAgbV9jb250ZXh0LT5tYXJrTGF5ZXJDb21wb3NpdGVkKCk7CiB9CiAK IEBlbmQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFw aGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9u LmNwcAkocmV2aXNpb24gMTY5MTIxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjIzLDcgKzIyMyw2IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnByZXBhcmVUZXh0 dXJlKCkKICAgICBpZiAobV9zdGF0ZS5ib3VuZEZCTyAhPSBtX2ZibykKICAgICAgICAgOjpnbEJp bmRGcmFtZWJ1ZmZlckVYVChHcmFwaGljc0NvbnRleHQzRDo6RlJBTUVCVUZGRVIsIG1fc3RhdGUu Ym91bmRGQk8pOwogICAgIDo6Z2xGaW5pc2goKTsKLSAgICBtX2xheWVyQ29tcG9zaXRlZCA9IHRy dWU7CiB9CiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnJlYWRSZW5kZXJpbmdSZXN1bHRzKHVu c2lnbmVkIGNoYXIgKnBpeGVscywgaW50IHBpeGVsc1NpemUpCg==