133387 2014-05-29 14:19:25 -0700 Compatibility hack to make GitX less crashy 2014-05-29 15:33:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 mark.lam mark.lam dev+webkit ggaren webkit-bug-importer oldest_to_newest 1012493 0 mark.lam 2014-05-29 14:19:25 -0700 The GitX app is using WebCore on a different thread than the main thread. This results in crashes because WebKit is a main-thread only API. This patch implements a MAC only hack to make GitX less crashy by forcing the use of the JSLock when entering the JSC VM if the app bundle is GitX. 1012494 1 mark.lam 2014-05-29 14:19:57 -0700 <rdar://problem/17008429> 1012502 2 ggaren 2014-05-29 15:09:04 -0700 GitX bug: <http://gitx.lighthouseapp.com/projects/17830-gitx/tickets/321-gitx-sometimes-crashes-beneath-pbwebhistorycontroller-preferenceschanged-on-a-secondary-thread>. 1012507 3 232266 mark.lam 2014-05-29 15:17:28 -0700 Created attachment 232266 the patch. 1012511 4 232266 ggaren 2014-05-29 15:33:19 -0700 Comment on attachment 232266 the patch. Alexey and MarkR discovered that this was a temporary regression caused by a notification firing on a secondary thread. We don't need this workaround. We need the notification to fire on the main thread instead. 232266 2014-05-29 15:17:28 -0700 2014-05-29 15:33:19 -0700 the patch. bug-133387.patch text/plain 2510 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTQ2MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA1LTI5ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBDb21wYXRpYmlsaXR5IGhhY2sgdG8g bWFrZSBHaXRYIGxlc3MgY3Jhc2h5LgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTMz Mzg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBHaXRYIGFwcCBpcyB1c2luZyBXZWJDb3JlIG9uIGEgZGlmZmVyZW50IHRocmVhZCB0aGFuIHRo ZSBtYWluIHRocmVhZC4KKyAgICAgICAgVGhpcyByZXN1bHRzIGluIGNyYXNoZXMgYmVjYXVzZSBX ZWJLaXQgaXMgYSBtYWluLXRocmVhZCBvbmx5IEFQSS4gIFRoaXMKKyAgICAgICAgcGF0Y2ggaW1w bGVtZW50cyBhIE1BQyBvbmx5IGhhY2sgdG8gbWFrZSBHaXRYIGxlc3MgY3Jhc2h5IGJ5IGZvcmNp bmcgdGhlCisgICAgICAgIHVzZSBvZiB0aGUgSlNMb2NrIHdoZW4gZW50ZXJpbmcgdGhlIEpTQyBW TSBpZiB0aGUgYXBwIGJ1bmRsZSBpcyBHaXRYLgorCisgICAgICAgIEdpdFggYnVnOiA8aHR0cDov L2dpdHgubGlnaHRob3VzZWFwcC5jb20vcHJvamVjdHMvMTc4MzAtZ2l0eC90aWNrZXRzLzMyMS1n aXR4LXNvbWV0aW1lcy1jcmFzaGVzLWJlbmVhdGgtcGJ3ZWJoaXN0b3J5Y29udHJvbGxlci1wcmVm ZXJlbmNlc2NoYW5nZWQtb24tYS1zZWNvbmRhcnktdGhyZWFkPi4KKworICAgICAgICBObyBuZXcg dGVzdHMuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6b2tUb0J5cGFzc0pTTG9jayk6CisgICAgICAgIChXZWJDb3JlOjpKU0RP TVdpbmRvd0Jhc2U6OmNvbW1vblZNKToKKwogMjAxNC0wNS0yOSAgSmVyZW15IEpvbmVzICA8amVy ZW15akBhcHBsZS5jb20+CiAKICAgICAgICAgUGVyc2VydmUgY2FwdGlvbiBzZWxlY3Rpb24gaW4g ZnVsbHNjcmVlbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93 QmFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01X aW5kb3dCYXNlLmNwcAkocmV2aXNpb24gMTY5NDYwKQorKysgU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNET01XaW5kb3dCYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjEzLDYgKzIxMywy MSBAQCBKU0RPTVdpbmRvd1NoZWxsKiBKU0RPTVdpbmRvd0Jhc2U6OnNoZWxsCiAgICAgcmV0dXJu IG1fc2hlbGw7CiB9CiAKKyNpZiBQTEFURk9STShNQUMpCitzdGF0aWMgYm9vbCBva1RvQnlwYXNz SlNMb2NrKCkKK3sKKyAgICAvLyBUaGlzIGlzIGEgaGFjayB0byBoZWxwIEdpdFggYmUgbGVzcyBj cmFzaHkuCisgICAgLy8gR2l0WCBidWc6IDxodHRwOi8vZ2l0eC5saWdodGhvdXNlYXBwLmNvbS9w cm9qZWN0cy8xNzgzMC1naXR4L3RpY2tldHMvMzIxLWdpdHgtc29tZXRpbWVzLWNyYXNoZXMtYmVu ZWF0aC1wYndlYmhpc3Rvcnljb250cm9sbGVyLXByZWZlcmVuY2VzY2hhbmdlZC1vbi1hLXNlY29u ZGFyeS10aHJlYWQ+LgorICAgIHN0YXRpYyBib29sIGhhY2tOZWVkZWQgPSBDRkVxdWFsKENGQnVu ZGxlR2V0SWRlbnRpZmllcihDRkJ1bmRsZUdldE1haW5CdW5kbGUoKSksIENGU1RSKCJuZXQucGhl cmUuR2l0WCIpKTsKKyAgICByZXR1cm4gIWhhY2tOZWVkZWQ7Cit9CisjZWxzZQorc3RhdGljIGJv b2wgb2tUb0J5cGFzc0pTTG9jaygpCit7CisgICAgcmV0dXJuIHRydWU7Cit9CisjZW5kaWYKKwog Vk0mIEpTRE9NV2luZG93QmFzZTo6Y29tbW9uVk0oKQogewogICAgIEFTU0VSVChpc01haW5UaHJl YWQoKSk7CkBAIC0yMjIsNyArMjM3LDggQEAgVk0mIEpTRE9NV2luZG93QmFzZTo6Y29tbW9uVk0o KQogICAgICAgICBTY3JpcHRDb250cm9sbGVyOjppbml0aWFsaXplVGhyZWFkaW5nKCk7CiAgICAg ICAgIHZtID0gVk06OmNyZWF0ZUxlYWtlZChMYXJnZUhlYXApLmxlYWtSZWYoKTsKICNpZiAhUExB VEZPUk0oSU9TKQotICAgICAgICB2bS0+c2V0RXhjbHVzaXZlVGhyZWFkKHN0ZDo6dGhpc190aHJl YWQ6OmdldF9pZCgpKTsKKyAgICAgICAgaWYgKG9rVG9CeXBhc3NKU0xvY2soKSkKKyAgICAgICAg ICAgIHZtLT5zZXRFeGNsdXNpdmVUaHJlYWQoc3RkOjp0aGlzX3RocmVhZDo6Z2V0X2lkKCkpOwog I2Vsc2UKICAgICAgICAgdm0tPmhlYXAuc2V0RnVsbEFjdGl2aXR5Q2FsbGJhY2soV2ViU2FmZUZ1 bGxHQ0FjdGl2aXR5Q2FsbGJhY2s6OmNyZWF0ZSgmdm0tPmhlYXApKTsKICNpZiBFTkFCTEUoR0dD KQo=