133382 2014-05-29 11:52:19 -0700 Support -apple-system-font on OS X 2014-05-30 14:01:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield jonlee mitz webkit-bug-importer oldest_to_newest 1012469 0 mmaxfield 2014-05-29 11:52:19 -0700 Support -apple-system-font on OS X 1012470 1 232257 mmaxfield 2014-05-29 11:56:40 -0700 Created attachment 232257 Patch 1012471 2 232257 simon.fraser 2014-05-29 12:00:41 -0700 Comment on attachment 232257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232257&action=review > LayoutTests/ChangeLog:11 > + * platform/mac/fast/text/apple-system-font-expected.html: Added. > + * platform/mac/fast/text/apple-system-font.html: Added. I think this ref test is bogus. You should extend the existing -webkit-system-font test. 1012527 3 232257 mitz 2014-05-29 16:54:12 -0700 Comment on attachment 232257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232257&action=review > Source/WebCore/platform/mac/WebFontCache.mm:164 > - if ([desiredFamily compare:@"-webkit-system-font" options:NSCaseInsensitiveSearch] == NSOrderedSame) { > + if ([desiredFamily compare:@"-webkit-system-font" options:NSCaseInsensitiveSearch] == NSOrderedSame > + || [desiredFamily compare:@"-apple-system-font" options:NSCaseInsensitiveSearch] == NSOrderedSame) { Can we use stringIsCaseInsensitiveEqualToString() here instead? 1012532 4 mmaxfield 2014-05-29 17:06:14 -0700 http://trac.webkit.org/changeset/169474 Will use stringIsCaseInsensitiveEqualToString in a follow-up patch 1012639 5 webkit-bug-importer 2014-05-30 11:29:15 -0700 <rdar://problem/17080463> 1012673 6 mmaxfield 2014-05-30 14:01:25 -0700 Addressed Mitz' comments in http://trac.webkit.org/changeset/169492 232257 2014-05-29 11:56:40 -0700 2014-05-29 16:54:12 -0700 Patch bug-133382-20140529115616.patch text/plain 3647 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2JjOTliMzNhZDQwMzkx NzQ2MGIwYmU3NjA5MThhNDYwOGVmYzg0Ni4uMzE1ZjZmYmYyM2NkODFlYzRkZWNkOWY5MTJiMzdh Mjc0M2I4M2ZkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA1LTI5ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcG9ydCAt YXBwbGUtc3lzdGVtLWZvbnQgb24gT1MgWAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMzgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgR3VhcmQgb24gYm90aCBmYW1pbHkgbmFtZXM6ICItYXBwbGUtc3lz dGVtLWZvbnQiIGFuZCAiLXdlYmtpdC1zeXN0ZW0tZm9udCIKKworICAgICAgICBUZXN0OiBwbGF0 Zm9ybS9tYWMvZmFzdC90ZXh0L2FwcGxlLXN5c3RlbS1mb250Lmh0bWwKKworICAgICAgICAqIHBs YXRmb3JtL21hYy9XZWJGb250Q2FjaGUubW06CisgICAgICAgICgrW1dlYkZvbnRDYWNoZSBpbnRl cm5hbEZvbnRXaXRoRmFtaWx5OnRyYWl0czp3ZWlnaHQ6c2l6ZTpdKToKKwogMjAxNC0wNS0yOCAg T2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdob29wcywgdXBkYXRl IGJpbmRpbmdzIHRlc3RzIHJlc3VsdHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvV2ViRm9udENhY2hlLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dl YkZvbnRDYWNoZS5tbQppbmRleCBkNmRjYWQ4NGZiYzA1NGE4MzVmM2IyYTRhZjE3MTVmMGFkMzMw N2I1Li5iZTllMWQ5YThjYzIxYWFjODA0NDBmNjBmYmFkMTY3ZjIzYzk0NDNlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViRm9udENhY2hlLm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJGb250Q2FjaGUubW0KQEAgLTE2MCw3ICsxNjAsOCBA QCArICh2b2lkKWdldFRyYWl0czooVmVjdG9yPHVuc2lnbmVkPiYpdHJhaXRzTWFza3MgaW5GYW1p bHk6KE5TU3RyaW5nICopZGVzaXJlZEZhbQogKyAoTlNGb250ICopaW50ZXJuYWxGb250V2l0aEZh bWlseTooTlNTdHJpbmcgKilkZXNpcmVkRmFtaWx5IHRyYWl0czooTlNGb250VHJhaXRNYXNrKWRl c2lyZWRUcmFpdHMgd2VpZ2h0OihpbnQpZGVzaXJlZFdlaWdodCBzaXplOihmbG9hdClzaXplCiB7 CiAKLSAgICBpZiAoW2Rlc2lyZWRGYW1pbHkgY29tcGFyZTpAIi13ZWJraXQtc3lzdGVtLWZvbnQi IG9wdGlvbnM6TlNDYXNlSW5zZW5zaXRpdmVTZWFyY2hdID09IE5TT3JkZXJlZFNhbWUpIHsKKyAg ICBpZiAoW2Rlc2lyZWRGYW1pbHkgY29tcGFyZTpAIi13ZWJraXQtc3lzdGVtLWZvbnQiIG9wdGlv bnM6TlNDYXNlSW5zZW5zaXRpdmVTZWFyY2hdID09IE5TT3JkZXJlZFNhbWUKKyAgICAgICAgfHwg W2Rlc2lyZWRGYW1pbHkgY29tcGFyZTpAIi1hcHBsZS1zeXN0ZW0tZm9udCIgb3B0aW9uczpOU0Nh c2VJbnNlbnNpdGl2ZVNlYXJjaF0gPT0gTlNPcmRlcmVkU2FtZSkgewogICAgICAgICAvLyBXZSBp Z25vcmUgaXRhbGljIGZvciBzeXN0ZW0gZm9udC4KICAgICAgICAgcmV0dXJuIChkZXNpcmVkV2Vp Z2h0ID49IDcpID8gW05TRm9udCBib2xkU3lzdGVtRm9udE9mU2l6ZTpzaXplXSA6IFtOU0ZvbnQg c3lzdGVtRm9udE9mU2l6ZTpzaXplXTsKICAgICB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWE4MDVlMmExZWIwNWMyMzE0 MDMzZTE3ZjAwMzE3ODM2NWVkZTZiZi4uZGY2ZDBjZTEyYmNlZDBiM2JjNTQ5ZmRmYjVkOGVkNThl YmU2NGI3YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA1LTI5ICBNeWxlcyBDLiBNYXhm aWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcG9ydCAtYXBwbGUtc3lz dGVtLWZvbnQgb24gT1MgWAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTMzMzgyCisKKyAgICAgICAgVGhpcyB0ZXN0IG1ha2VzIHN1cmUgdGhhdCAtYXBw bGUtc3lzdGVtLWZvbnQgaXMgcmVuZGVyZWQgdGhlIHNhbWUgd2F5IGFzIC13ZWJraXQtc3lzdGVt LWZvbnQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9tYWMvZmFzdC90ZXh0L2FwcGxlLXN5c3RlbS1mb250LWV4cGVjdGVkLmh0bWw6 IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L3RleHQvYXBwbGUtc3lzdGVtLWZv bnQuaHRtbDogQWRkZWQuCisKIDIwMTQtMDUtMjggIE1hcnRpbiBIb2NrICA8bWhvY2tAYXBwbGUu Y29tPgogCiAgICAgICAgIE1hcmtpbmcgdGVzdCBhcyBmbGFreSBwZW5kaW5nIGZ1cnRoZXIgcmV2 aWV3LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvdGV4dC9hcHBs ZS1zeXN0ZW0tZm9udC1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zh c3QvdGV4dC9hcHBsZS1zeXN0ZW0tZm9udC1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjVkNDJk MzBjNmY4MTM1ZmNmOWI2YzQ1ZDVhM2M5MzgxNDlkNDI4NTQKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC90ZXh0L2FwcGxlLXN5c3RlbS1mb250LWV4cGVj dGVkLmh0bWwKQEAgLTAsMCArMSwyIEBACitUaGlzIHRlc3QgbWFrZXMgc3VyZSB0aGF0IC1hcHBs ZS1zeXN0ZW0tZm9udCBpcyByZW5kZXJlZCB0aGUgc2FtZSBhcyAtd2Via2l0LXN5c3RlbS1mb250 LgorPGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IC13ZWJraXQtc3lzdGVtLWZvbnQiPlRoaXMgaXMg c29tZSB0ZXh0PC9kaXY+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFz dC90ZXh0L2FwcGxlLXN5c3RlbS1mb250Lmh0bWwgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv ZmFzdC90ZXh0L2FwcGxlLXN5c3RlbS1mb250Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2YyZjIzZTk0NzAw MWEyZjVlNGJkYTU4Mzg4NmY4YjJmMDk5YTc2NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy9mYXN0L3RleHQvYXBwbGUtc3lzdGVtLWZvbnQuaHRtbApAQCAtMCww ICsxLDIgQEAKK1RoaXMgdGVzdCBtYWtlcyBzdXJlIHRoYXQgLWFwcGxlLXN5c3RlbS1mb250IGlz IHJlbmRlcmVkIHRoZSBzYW1lIGFzIC13ZWJraXQtc3lzdGVtLWZvbnQuCis8ZGl2IHN0eWxlPSJm b250LWZhbWlseTogLWFwcGxlLXN5c3RlbS1mb250Ij5UaGlzIGlzIHNvbWUgdGV4dDwvZGl2Pgo=