133376 2014-05-29 05:28:13 -0700 Remove repetitive header in HTMLInputElement.cpp 2014-05-30 12:27:28 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 hiremathprashants webkit-unassigned commit-queue stavila oldest_to_newest 1012403 0 hiremathprashants 2014-05-29 05:28:13 -0700 RuntimeEnabledFeatures.h header file is added twice in file, So removing it. Also fixing webkit-style fix in file. 1012404 1 232242 hiremathprashants 2014-05-29 05:30:58 -0700 Created attachment 232242 Patch proposed patch 1012405 2 commit-queue 2014-05-29 05:32:07 -0700 Attachment 232242 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1012406 3 232243 hiremathprashants 2014-05-29 05:39:26 -0700 Created attachment 232243 Patch Fixed ChangeLog Error 1012409 4 232243 stavila 2014-05-29 06:06:09 -0700 Comment on attachment 232243 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232243&action=review > Source/WebCore/html/HTMLInputElement.cpp:856 > if (renderer() && renderer()->style().hasAppearance()) Altough this is a correct style fix, I think you should stick to changes relevant to this particular issue (e.g. just the header inclusion removal) 1012561 5 232279 hiremathprashants 2014-05-29 19:37:43 -0700 Created attachment 232279 Patch Removed Repeative headers only 1012656 6 232279 commit-queue 2014-05-30 12:27:25 -0700 Comment on attachment 232279 Patch Clearing flags on attachment: 232279 Committed r169491: <http://trac.webkit.org/changeset/169491> 1012657 7 commit-queue 2014-05-30 12:27:28 -0700 All reviewed patches have been landed. Closing bug. 232242 2014-05-29 05:30:58 -0700 2014-05-29 05:39:17 -0700 Patch bug-133376-20140529180010.patch text/plain 1520 hiremathprashants SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTQ0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA1LTI5ICBQcmFzaGFu dCBIaXJlbWF0aCAgPGhpcmVtYXRocHJhc2hhbnRzQGdtYWlsLmNvbT4KKworICAgICAgICBSZW1v dmUgcmVwZXRpdGl2ZSBoZWFkZXIgaW4gSFRNTElucHV0RWxlbWVudC5jcHAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzM3NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoT09QUyEp LgorCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnNldENoZWNrZWQpOgorCiAyMDE0LTA1LTI4ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENhcHRpb25zIGR1cmluZyBI TFMgcGxheWJhY2sgZmxhc2gvYXJlIGRpZmZpY3VsdCB0byByZWFkaWx5CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAJKHJldmlzaW9uIDE2OTQ0NCkKKysrIFNv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTY5LDEwICs2OSw2IEBACiAjaW5jbHVkZSAiQ29sb3JJbnB1dFR5cGUuaCIKICNlbmRpZgogCi0j aWYgRU5BQkxFKElOUFVUX1NQRUVDSCkKLSNpbmNsdWRlICJSdW50aW1lRW5hYmxlZEZlYXR1cmVz LmgiCi0jZW5kaWYKLQogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiAjaW5jbHVkZSAiVG91Y2hF dmVudC5oIgogI2VuZGlmCkBAIC04NTYsNyArODUyLDcgQEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50 OjpzZXRDaGVja2VkKGJvb2wgbgogICAgIHNldE5lZWRzU3R5bGVSZWNhbGMoKTsKIAogICAgIGlm IChDaGVja2VkUmFkaW9CdXR0b25zKiBidXR0b25zID0gY2hlY2tlZFJhZGlvQnV0dG9ucygpKQot ICAgICAgICAgICAgYnV0dG9ucy0+dXBkYXRlQ2hlY2tlZFN0YXRlKHRoaXMpOworICAgICAgICBi dXR0b25zLT51cGRhdGVDaGVja2VkU3RhdGUodGhpcyk7CiAgICAgaWYgKHJlbmRlcmVyKCkgJiYg cmVuZGVyZXIoKS0+c3R5bGUoKS5oYXNBcHBlYXJhbmNlKCkpCiAgICAgICAgIHJlbmRlcmVyKCkt PnRoZW1lKCkuc3RhdGVDaGFuZ2VkKCpyZW5kZXJlcigpLCBDb250cm9sU3RhdGVzOjpDaGVja2Vk U3RhdGUpOwogICAgIHNldE5lZWRzVmFsaWRpdHlDaGVjaygpOwo= 232243 2014-05-29 05:39:26 -0700 2014-05-29 19:37:33 -0700 Patch bug-133376-20140529180839.patch text/plain 1550 hiremathprashants SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTQ0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA1LTI5ICBQcmFzaGFu dCBIaXJlbWF0aCAgPGhpcmVtYXRocHJhc2hhbnRzQGdtYWlsLmNvbT4KKworICAgICAgICBSZW1v dmUgcmVwZXRpdGl2ZSBoZWFkZXIgaW4gSFRNTElucHV0RWxlbWVudC5jcHAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzM3NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIGl0IGlzIGp1c3Qgd2Vi a2l0LXN0eWxlIGZpeCwgVGVzdCBub3QgbmVlZGVkLgorCisgICAgICAgICogaHRtbC9IVE1MSW5w dXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnNldENo ZWNrZWQpOgorCiAyMDE0LTA1LTI4ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgogCiAgICAgICAgIENhcHRpb25zIGR1cmluZyBITFMgcGxheWJhY2sgZmxhc2gvYXJlIGRpZmZp Y3VsdCB0byByZWFkaWx5CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1l bnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVu dC5jcHAJKHJldmlzaW9uIDE2OTQ0NCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0 RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY5LDEwICs2OSw2IEBACiAjaW5jbHVkZSAi Q29sb3JJbnB1dFR5cGUuaCIKICNlbmRpZgogCi0jaWYgRU5BQkxFKElOUFVUX1NQRUVDSCkKLSNp bmNsdWRlICJSdW50aW1lRW5hYmxlZEZlYXR1cmVzLmgiCi0jZW5kaWYKLQogI2lmIEVOQUJMRShU T1VDSF9FVkVOVFMpCiAjaW5jbHVkZSAiVG91Y2hFdmVudC5oIgogI2VuZGlmCkBAIC04NTYsNyAr ODUyLDcgQEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50OjpzZXRDaGVja2VkKGJvb2wgbgogICAgIHNl dE5lZWRzU3R5bGVSZWNhbGMoKTsKIAogICAgIGlmIChDaGVja2VkUmFkaW9CdXR0b25zKiBidXR0 b25zID0gY2hlY2tlZFJhZGlvQnV0dG9ucygpKQotICAgICAgICAgICAgYnV0dG9ucy0+dXBkYXRl Q2hlY2tlZFN0YXRlKHRoaXMpOworICAgICAgICBidXR0b25zLT51cGRhdGVDaGVja2VkU3RhdGUo dGhpcyk7CiAgICAgaWYgKHJlbmRlcmVyKCkgJiYgcmVuZGVyZXIoKS0+c3R5bGUoKS5oYXNBcHBl YXJhbmNlKCkpCiAgICAgICAgIHJlbmRlcmVyKCktPnRoZW1lKCkuc3RhdGVDaGFuZ2VkKCpyZW5k ZXJlcigpLCBDb250cm9sU3RhdGVzOjpDaGVja2VkU3RhdGUpOwogICAgIHNldE5lZWRzVmFsaWRp dHlDaGVjaygpOwo= 232279 2014-05-29 19:37:43 -0700 2014-05-30 12:27:25 -0700 Patch bug-133376-20140530080652.patch text/plain 1085 hiremathprashants SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTQ4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA1LTI5ICBQcmFzaGFu dCBIaXJlbWF0aCAgPGhpcmVtYXRocHJhc2hhbnRzQGdtYWlsLmNvbT4KKworICAgICAgICBSZW1v dmUgcmVwZXRpdGl2ZSBoZWFkZXIgaW4gSFRNTElucHV0RWxlbWVudC5jcHAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzM3NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGlzIGp1c3QgcmVtb3ZhbCBy ZXBlYXRpdmUgaGVhZGVycyBoZW5jZSBubyB0ZXN0IG5lZWRlZC4KKworICAgICAgICAqIGh0bWwv SFRNTElucHV0RWxlbWVudC5jcHA6CisKIDIwMTQtMDUtMjkgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBQcmVwYXJlIGNzcyBqaXQgZm9yIGFy bTY0IGFuZCBvdGhlciBhcmNoaXRlY3R1cmVzLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MSW5wdXRFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxJbnB1dEVsZW1lbnQuY3BwCShyZXZpc2lvbiAxNjk0NDQpCisrKyBTb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OSwxMCArNjksNiBA QAogI2luY2x1ZGUgIkNvbG9ySW5wdXRUeXBlLmgiCiAjZW5kaWYKIAotI2lmIEVOQUJMRShJTlBV VF9TUEVFQ0gpCi0jaW5jbHVkZSAiUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oIgotI2VuZGlmCi0K ICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQogI2luY2x1ZGUgIlRvdWNoRXZlbnQuaCIKICNlbmRp Zgo=