133370 2014-05-29 00:12:41 -0700 Crash loading skydrive.com (assertion under RemoteLayerTreeDisplayRefreshMonitor) 2014-05-30 08:44:50 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton darin simon.fraser oldest_to_newest 1012364 0 thorton 2014-05-29 00:12:41 -0700 The set of monitors is being mutated while iterating the set of monitors... <rdar://problem/17061361> 1012365 1 232236 thorton 2014-05-29 00:15:08 -0700 Created attachment 232236 patch 1012412 2 232236 andersca 2014-05-29 06:44:59 -0700 Comment on attachment 232236 patch View in context: https://bugs.webkit.org/attachment.cgi?id=232236&action=review > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:333 > + HashSet<RemoteLayerTreeDisplayRefreshMonitor*> monitors = m_displayRefreshMonitors; I think you should use a Vector and copy the hash set to it instead, that might be faster! 1012461 3 thorton 2014-05-29 11:20:05 -0700 http://trac.webkit.org/changeset/169456 1012524 4 thorton 2014-05-29 16:38:47 -0700 Reopening to address post-landing review comments. 1012531 5 232272 thorton 2014-05-29 17:03:55 -0700 Created attachment 232272 patch 1012560 6 232272 ggaren 2014-05-29 19:30:30 -0700 Comment on attachment 232272 patch View in context: https://bugs.webkit.org/attachment.cgi?id=232272&action=review > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:343 > + HashSet<RemoteLayerTreeDisplayRefreshMonitor*> monitorsToNotify = m_displayRefreshMonitors; > + m_displayRefreshMonitorsToNotify = &monitorsToNotify; > + while (!monitorsToNotify.isEmpty()) > + monitorsToNotify.takeAny()->didUpdateLayers(); > + m_displayRefreshMonitorsToNotify = nullptr; > } Because takeAny() uses the begin() iterator, it has to iterate a chunk of the hash table each time to find the first non-null bucket. So, switching to takeAny() may not be a performance improvement. 1012562 7 232272 darin 2014-05-29 19:59:17 -0700 Comment on attachment 232272 patch View in context: https://bugs.webkit.org/attachment.cgi?id=232272&action=review >> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:343 >> } > > Because takeAny() uses the begin() iterator, it has to iterate a chunk of the hash table each time to find the first non-null bucket. So, switching to takeAny() may not be a performance improvement. The change is for correctness, not performance improvement. 1012563 8 232272 darin 2014-05-29 20:00:54 -0700 Comment on attachment 232272 patch View in context: https://bugs.webkit.org/attachment.cgi?id=232272&action=review > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:339 > + m_displayRefreshMonitorsToNotify = &monitorsToNotify; If would be good to ASSERT(!m_displayRefreshMonitorsToNotify) here. 1012623 9 thorton 2014-05-30 08:44:50 -0700 http://trac.webkit.org/changeset/169486 232236 2014-05-29 00:15:08 -0700 2014-05-29 17:03:55 -0700 patch displayrefresh.diff text/plain 1848 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmNjJlYjdhLi5jZTU4MTg5ZWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTYgQEAKKzIwMTQtMDUtMjkgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUu Y29tPgorCisgICAgICAgIENyYXNoIGxvYWRpbmcgc2t5ZHJpdmUuY29tIChhc3NlcnRpb24gdW5k ZXIgUmVtb3RlTGF5ZXJUcmVlRGlzcGxheVJlZnJlc2hNb25pdG9yKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMzcwCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8xNzA2MTM2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2lu Z0FyZWEubW06CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhOjpk aWRVcGRhdGUpOgorICAgICAgICBDb3B5IHRoZSBzZXQgb2YgcmVmcmVzaCBtb25pdG9ycyBzbyB0 aGF0IHdlIGRvbid0IHRyeSB0byBtdXRhdGUgdGhlIGxpc3Qgd2UncmUgaXRlcmF0aW5nLAorICAg ICAgICBhbmQgZG9uJ3QgdHJ5IHRvIGZpcmUgcmVmcmVzaCBtb25pdG9ycyB0aGF0IHdlcmUgcmVt b3ZlZCBpbiBhIHByZXZpb3VzIGl0ZXJhdGlvbiBvZiB0aGUgbG9vcC4KKwogMjAxNC0wNS0yOCAg SmVmZnJleSBQZmF1ICA8anBmYXVAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBPYmotQyBBUEkg Zm9yIGNhY2hlIHBhcnRpdGlvbmVkIFVSTCBzY2hlbWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhLm1t IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVE cmF3aW5nQXJlYS5tbQppbmRleCBmNWRmODhlLi44YTc5MjQyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVh Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5 ZXJUcmVlRHJhd2luZ0FyZWEubW0KQEAgLTMzMCw4ICszMzAsMTIgQEAgdm9pZCBSZW1vdGVMYXll clRyZWVEcmF3aW5nQXJlYTo6ZGlkVXBkYXRlKCkKICAgICBbQ0FUcmFuc2FjdGlvbiBiZWdpbl07 CiAgICAgW0NBVHJhbnNhY3Rpb24gY29tbWl0XTsKIAotICAgIGZvciAoYXV0byYgbW9uaXRvciA6 IG1fZGlzcGxheVJlZnJlc2hNb25pdG9ycykKLSAgICAgICAgbW9uaXRvci0+ZGlkVXBkYXRlTGF5 ZXJzKCk7CisgICAgSGFzaFNldDxSZW1vdGVMYXllclRyZWVEaXNwbGF5UmVmcmVzaE1vbml0b3Iq PiBtb25pdG9ycyA9IG1fZGlzcGxheVJlZnJlc2hNb25pdG9yczsKKyAgICBmb3IgKGF1dG8mIG1v bml0b3IgOiBtb25pdG9ycykgeworICAgICAgICAvLyBUaGUgbW9uaXRvciBtaWdodCBoYXZlIGJl ZW4gcmVtb3ZlZCBieSBhbiBlYXJsaWVyIGRpZFVwZGF0ZUxheWVycyBjYWxsYmFjay4KKyAgICAg ICAgaWYgKG1fZGlzcGxheVJlZnJlc2hNb25pdG9ycy5jb250YWlucyhtb25pdG9yKSkKKyAgICAg ICAgICAgIG1vbml0b3ItPmRpZFVwZGF0ZUxheWVycygpOworICAgIH0KIH0KIAogdm9pZCBSZW1v dGVMYXllclRyZWVEcmF3aW5nQXJlYTo6bWFpbkZyYW1lQ29udGVudFNpemVDaGFuZ2VkKGNvbnN0 IEludFNpemUmIGNvbnRlbnRzU2l6ZSkK 232272 2014-05-29 17:03:55 -0700 2014-05-29 20:00:49 -0700 patch displayrefresh2.diff text/plain 4567 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2YWE1ZTRlLi5jODA4ZmUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTQtMDUtMjkgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgorCisgICAgICAgIENyYXNoIGxvYWRpbmcgc2t5ZHJpdmUuY29tIChhc3NlcnRpb24gdW5kZXIg UmVtb3RlTGF5ZXJUcmVlRGlzcGxheVJlZnJlc2hNb25pdG9yKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMzcwCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8xNzA2MTM2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0Fy ZWEuaDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURy YXdpbmdBcmVhLm1tOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJl YTo6UmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEpOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVM YXllclRyZWVEcmF3aW5nQXJlYTo6d2lsbERlc3Ryb3lEaXNwbGF5UmVmcmVzaE1vbml0b3IpOgor ICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYTo6ZGlkVXBkYXRlKToK KyAgICAgICAgUG9zdC1sYW5kaW5nIHJldmlldyBjb21tZW50cyBmcm9tIERhcmluIG5vdGVkIHRo YXQgY2hlY2tpbmcgaWYgdGhlCisgICAgICAgIERyYXdpbmdBcmVhJ3MgbV9kaXNwbGF5UmVmcmVz aE1vbml0b3JzIGNvbnRhaW5zIHRoZSBtb25pdG9yIGluIHRoZQorICAgICAgICBsaXN0IHRvIG5v dGlmeSBpcyBpbnN1ZmZpY2llbnQsIGJlY2F1c2UgYSBuZXcgb25lIGNvdWxkIGhhdmUgYmVlbgor ICAgICAgICBhZGRlZCB3aXRoIHRoZSBzYW1lIGFkZHJlc3MuIEluc3RlYWQsIGNvcHkgdGhlIEhh c2hTZXQsIHJlbW92aW5nCisgICAgICAgIGF0IHJhbmRvbSBmcm9tIGl0IGFuZCBmaXJpbmcgZGlk VXBkYXRlTGF5ZXJzLCBidXQgKmFsc28qIHJlbW92aW5nCisgICAgICAgIGZyb20gaXQgaW4gdGhl IHdpbGxEZXN0cm95RGlzcGxheVJlZnJlc2hNb25pdG9yIGNhbGxiYWNrLgorICAgICAgICBUaGlz IGlzIHZlcnkgc2ltaWxhciB0byB3aGF0IERpc3BsYXlSZWZyZXNoTW9uaXRvciBpdHNlbGYgZG9l cyBpbnRlcm5hbGx5CisgICAgICAgICh3ZSBkb24ndCBoYXZlIHRvIGR1cGxpY2F0ZSBpdHMgY29k ZSB0byBhdm9pZCByZS1lbnRyeSBiZWNhdXNlIGl0IGlzCisgICAgICAgIGFscmVhZHkgaW1wb3Nz aWJsZSB0byByZS1lbnRlciBkaWRVcGRhdGUpLgorCiAyMDE0LTA1LTI5ICBEYW4gQmVybnN0ZWlu ICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBDYW7igJl0IHJlY292ZXIgZnJv bSBzdWJmcmFtZSBsb2FkIGVycm9ycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5oIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5o CmluZGV4IDcxMmIyN2UuLjFmNjg3MTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdB cmVhLmgKQEAgLTE0Myw2ICsxNDMsNyBAQCBwcml2YXRlOgogICAgIFJlZlB0cjxCYWNraW5nU3Rv cmVGbHVzaGVyPiBtX3BlbmRpbmdCYWNraW5nU3RvcmVGbHVzaGVyOwogCiAgICAgSGFzaFNldDxS ZW1vdGVMYXllclRyZWVEaXNwbGF5UmVmcmVzaE1vbml0b3IqPiBtX2Rpc3BsYXlSZWZyZXNoTW9u aXRvcnM7CisgICAgSGFzaFNldDxSZW1vdGVMYXllclRyZWVEaXNwbGF5UmVmcmVzaE1vbml0b3Iq PiogbV9kaXNwbGF5UmVmcmVzaE1vbml0b3JzVG9Ob3RpZnk7CiB9OwogCiBEUkFXSU5HX0FSRUFf VFlQRV9DQVNUUyhSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYSwgdHlwZSgpID09IERyYXdpbmdB cmVhVHlwZVJlbW90ZUxheWVyVHJlZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhLm1tIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJl YS5tbQppbmRleCBiYmYyMjM1Li44ODY0MmI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJh d2luZ0FyZWEubW0KQEAgLTYxLDYgKzYxLDcgQEAgUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWE6 OlJlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhKFdlYlBhZ2UqIHdlYlBhZ2UsIGNvbnN0IFcKICAg ICAsIG1faGFzRGVmZXJyZWRGbHVzaChmYWxzZSkKICAgICAsIG1fd2FpdGluZ0ZvckJhY2tpbmdT dG9yZVN3YXAoZmFsc2UpCiAgICAgLCBtX2hhZEZsdXNoRGVmZXJyZWRXaGlsZVdhaXRpbmdGb3JC YWNraW5nU3RvcmVTd2FwKGZhbHNlKQorICAgICwgbV9kaXNwbGF5UmVmcmVzaE1vbml0b3JzVG9O b3RpZnkobnVsbHB0cikKIHsKICAgICB3ZWJQYWdlLT5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLnNl dEZvcmNlQ29tcG9zaXRpbmdNb2RlKHRydWUpOwogI2lmIFBMQVRGT1JNKElPUykKQEAgLTEwMSw3 ICsxMDIsMTEgQEAgUGFzc1JlZlB0cjxEaXNwbGF5UmVmcmVzaE1vbml0b3I+IFJlbW90ZUxheWVy VHJlZURyYXdpbmdBcmVhOjpjcmVhdGVEaXNwbGF5UmVmcmUKIAogdm9pZCBSZW1vdGVMYXllclRy ZWVEcmF3aW5nQXJlYTo6d2lsbERlc3Ryb3lEaXNwbGF5UmVmcmVzaE1vbml0b3IoRGlzcGxheVJl ZnJlc2hNb25pdG9yKiBtb25pdG9yKQogewotICAgIG1fZGlzcGxheVJlZnJlc2hNb25pdG9ycy5y ZW1vdmUoc3RhdGljX2Nhc3Q8UmVtb3RlTGF5ZXJUcmVlRGlzcGxheVJlZnJlc2hNb25pdG9yKj4o bW9uaXRvcikpOworICAgIGF1dG8gcmVtb3RlTW9uaXRvciA9IHN0YXRpY19jYXN0PFJlbW90ZUxh eWVyVHJlZURpc3BsYXlSZWZyZXNoTW9uaXRvcio+KG1vbml0b3IpOworICAgIG1fZGlzcGxheVJl ZnJlc2hNb25pdG9ycy5yZW1vdmUocmVtb3RlTW9uaXRvcik7CisKKyAgICBpZiAobV9kaXNwbGF5 UmVmcmVzaE1vbml0b3JzVG9Ob3RpZnkpCisgICAgICAgIG1fZGlzcGxheVJlZnJlc2hNb25pdG9y c1RvTm90aWZ5LT5yZW1vdmUocmVtb3RlTW9uaXRvcik7CiB9CiAKIHZvaWQgUmVtb3RlTGF5ZXJU cmVlRHJhd2luZ0FyZWE6OnNldFJvb3RDb21wb3NpdGluZ0xheWVyKEdyYXBoaWNzTGF5ZXIqIHJv b3RMYXllcikKQEAgLTMzMCwxNSArMzM1LDExIEBAIHZvaWQgUmVtb3RlTGF5ZXJUcmVlRHJhd2lu Z0FyZWE6OmRpZFVwZGF0ZSgpCiAgICAgW0NBVHJhbnNhY3Rpb24gYmVnaW5dOwogICAgIFtDQVRy YW5zYWN0aW9uIGNvbW1pdF07CiAKLSAgICBWZWN0b3I8UmVtb3RlTGF5ZXJUcmVlRGlzcGxheVJl ZnJlc2hNb25pdG9yKj4gbW9uaXRvcnM7Ci0gICAgbW9uaXRvcnMucmVzZXJ2ZUNhcGFjaXR5KG1f ZGlzcGxheVJlZnJlc2hNb25pdG9ycy5zaXplKCkpOwotICAgIGZvciAoYXV0byYgbW9uaXRvciA6 IG1fZGlzcGxheVJlZnJlc2hNb25pdG9ycykKLSAgICAgICAgbW9uaXRvcnMuYXBwZW5kKG1vbml0 b3IpOwotICAgIGZvciAoYXV0byYgbW9uaXRvciA6IG1vbml0b3JzKSB7Ci0gICAgICAgIC8vIFRo ZSBtb25pdG9yIG1pZ2h0IGhhdmUgYmVlbiByZW1vdmVkIGJ5IGFuIGVhcmxpZXIgZGlkVXBkYXRl TGF5ZXJzIGNhbGxiYWNrLgotICAgICAgICBpZiAobV9kaXNwbGF5UmVmcmVzaE1vbml0b3JzLmNv bnRhaW5zKG1vbml0b3IpKQotICAgICAgICAgICAgbW9uaXRvci0+ZGlkVXBkYXRlTGF5ZXJzKCk7 Ci0gICAgfQorICAgIEhhc2hTZXQ8UmVtb3RlTGF5ZXJUcmVlRGlzcGxheVJlZnJlc2hNb25pdG9y Kj4gbW9uaXRvcnNUb05vdGlmeSA9IG1fZGlzcGxheVJlZnJlc2hNb25pdG9yczsKKyAgICBtX2Rp c3BsYXlSZWZyZXNoTW9uaXRvcnNUb05vdGlmeSA9ICZtb25pdG9yc1RvTm90aWZ5OworICAgIHdo aWxlICghbW9uaXRvcnNUb05vdGlmeS5pc0VtcHR5KCkpCisgICAgICAgIG1vbml0b3JzVG9Ob3Rp ZnkudGFrZUFueSgpLT5kaWRVcGRhdGVMYXllcnMoKTsKKyAgICBtX2Rpc3BsYXlSZWZyZXNoTW9u aXRvcnNUb05vdGlmeSA9IG51bGxwdHI7CiB9CiAKIHZvaWQgUmVtb3RlTGF5ZXJUcmVlRHJhd2lu Z0FyZWE6Om1haW5GcmFtZUNvbnRlbnRTaXplQ2hhbmdlZChjb25zdCBJbnRTaXplJiBjb250ZW50 c1NpemUpCg==