133352 2014-05-28 11:58:46 -0700 [iOS WK2] Improve behavior of position:fixed inside accelerated overflow-scroll 2014-05-28 12:35:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser andersca bdakin cmarcelo commit-queue jamesr luiz simon.fraser thorton tonikitoo oldest_to_newest 1012260 0 simon.fraser 2014-05-28 11:58:46 -0700 [iOS WK2] Improve behavior of position:fixed inside accelerated overflow-scroll 1012264 1 232208 simon.fraser 2014-05-28 12:30:59 -0700 Created attachment 232208 Patch 1012265 2 232208 thorton 2014-05-28 12:32:39 -0700 Comment on attachment 232208 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232208&action=review > Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:191 > for (size_t i = 0; i < size; ++i) newloop 1012267 3 simon.fraser 2014-05-28 12:35:35 -0700 https://trac.webkit.org/r169430 232208 2014-05-28 12:30:59 -0700 2014-05-28 12:32:39 -0700 Patch bug-133352-20140528123035.patch text/plain 7246 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGUxNDU5MTVkOGQ2MTVk NjA2MGY3YWU4MDg5MzA0N2EzNjYwN2FiMS4uODU2M2E5ZWMzZmUyNjc4N2U1YTNlY2MyNDQwM2I0 YTVhODNkNGU5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA1LTI4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBJ bXByb3ZlIGJlaGF2aW9yIG9mIHBvc2l0aW9uOmZpeGVkIGluc2lkZSBhY2NlbGVyYXRlZCBvdmVy Zmxvdy1zY3JvbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMzM1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdoZW4gYWRqdXN0aW5nIGxheWVycyBpbnNpZGUgYWNjZWxlcmF0ZWQgb3ZlcmZsb3ctc2Ny b2xsLCBwYXNzIGEgZGVsdGEKKyAgICAgICAgZG93biB0byBkZXNjZW5kYW50IG5vZGVzLiBGaXgg YmVoYXZpb3Igb2Ygc3RpY2t5IG5vZGVzIGluc2lkZSBmaXhlZCBub2RlcworICAgICAgICBpbnNp ZGUgb3ZlcmZsb3cgc2Nyb2xsIChzdGlja3kgc2hvdWxkIG9ubHkgYmUgYWZmZWN0ZWQgaWYgdGhl IHBhcmVudCBub2RlCisgICAgICAgIGlzIGEgc2Nyb2xsaW5nIG5vZGUpLgorCisgICAgICAgICog cGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ1RyZWVGaXhlZE5vZGUubW06CisgICAgICAgIChX ZWJDb3JlOjpTY3JvbGxpbmdUcmVlRml4ZWROb2RlOjp1cGRhdGVMYXllcnNBZnRlckFuY2VzdG9y Q2hhbmdlKTogSnVzdCByZW1vdmUKKyAgICAgICAgc29tZSAuZ2V0KCkKKyAgICAgICAgKiBwYWdl L3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nVHJlZVN0aWNreU5vZGUubW06CisgICAgICAgIChXZWJD b3JlOjpTY3JvbGxpbmdUcmVlU3RpY2t5Tm9kZTo6dXBkYXRlTGF5ZXJzQWZ0ZXJBbmNlc3RvckNo YW5nZSk6IFJlbW92ZSAuZ2V0KClzLgorICAgICAgICBXZSBuZXZlciBjYXJlIGFib3V0IHRoZSBj dW11bGF0aXZlIGRlbHRhIGhlcmUsIGJlY2F1c2Ugc3RpY2t5IG5vZGVzIG9ubHkgcmVzcG9uZCB0 bworICAgICAgICBjaGFuZ2VzIGluIHRoZWlyIGRpcmVjdCBzY3JvbGxpbmcgYW5jZXN0b3JzLiBP bmx5IGFkanVzdCB0aGUgbGF5ZXIgaWYgdGhlIHBhcmVudAorICAgICAgICBpcyBhIHNjcm9sbGlu ZyBub2RlLgorCiAyMDE0LTA1LTI3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTY5NDAwLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CmluZGV4IDg3ZjI4ZDViNTRjNGMyMGQ5NDg3NDJmMTc4ZTUyOTljNzNhYmJiYzguLjAwZGE3Nzdi NTgyY2YxODM5MDRjMmZiM2U1N2U3NzVlMmNkYWE2YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAxNC0wNS0yOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4K KworICAgICAgICBbaU9TIFdLMl0gSW1wcm92ZSBiZWhhdmlvciBvZiBwb3NpdGlvbjpmaXhlZCBp bnNpZGUgYWNjZWxlcmF0ZWQgb3ZlcmZsb3ctc2Nyb2xsCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMzNTIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFBhc3MgdGhlIGNvcnJlY3QgZGVsdGEg ZG93biB0byBkZXNjZW5kYW50IG5vZGVzLgorCisgICAgICAgICogVUlQcm9jZXNzL1Njcm9sbGlu Zy9pb3MvU2Nyb2xsaW5nVHJlZU92ZXJmbG93U2Nyb2xsaW5nTm9kZUlPUy5tbToKKyAgICAgICAg KFdlYktpdDo6U2Nyb2xsaW5nVHJlZU92ZXJmbG93U2Nyb2xsaW5nTm9kZUlPUzo6dXBkYXRlQ2hp bGROb2Rlc0FmdGVyU2Nyb2xsKToKKwogMjAxNC0wNS0yNyAgU2ltb24gRnJhc2VyICA8c2ltb24u ZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TIFdLMl0gRml4IGJlaGF2aW9yIG9mIHBv c2l0aW9uOnN0aWNreSBpbnNpZGUgYWNjZWxlcmF0ZWQgb3ZlcmZsb3ctc2Nyb2xsCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nVHJlZUZpeGVk Tm9kZS5tbSBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdUcmVl Rml4ZWROb2RlLm1tCmluZGV4IGIwNTEzZjE1NTNmOWQ3NGYzZmJlYWUzODdkYzM0MDJmYzU2YTMx ZTQuLjBkM2FjNDJkNGIwNjUzY2JmODZiZDJiZGNlZWE3NmUzN2I2MWQ4MTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdUcmVlRml4ZWROb2Rl Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdUcmVl Rml4ZWROb2RlLm1tCkBAIC02OSwxMCArNjksMTEgQEAgdm9pZCBTY3JvbGxpbmdUcmVlRml4ZWRO b2RlOjp1cGRhdGVMYXllcnNBZnRlckFuY2VzdG9yQ2hhbmdlKGNvbnN0IFNjcm9sbGluZ1RyZWUK ICAgICBGbG9hdFBvaW50IGxheWVyUG9zaXRpb24gPSBtX2NvbnN0cmFpbnRzLmxheWVyUG9zaXRp b25Gb3JWaWV3cG9ydFJlY3QoZml4ZWRQb3NpdGlvblJlY3QpOwogICAgIGxheWVyUG9zaXRpb24g LT0gY3VtdWxhdGl2ZURlbHRhOwogCi0gICAgQ0dSZWN0IGxheWVyQm91bmRzID0gW21fbGF5ZXIu Z2V0KCkgYm91bmRzXTsKLSAgICBDR1BvaW50IGFuY2hvclBvaW50ID0gW21fbGF5ZXIuZ2V0KCkg YW5jaG9yUG9pbnRdOworICAgIENHUmVjdCBsYXllckJvdW5kcyA9IFttX2xheWVyIGJvdW5kc107 CisgICAgQ0dQb2ludCBhbmNob3JQb2ludCA9IFttX2xheWVyIGFuY2hvclBvaW50XTsKICAgICBD R1BvaW50IG5ld1Bvc2l0aW9uID0gbGF5ZXJQb3NpdGlvbiAtIG1fY29uc3RyYWludHMuYWxpZ25t ZW50T2Zmc2V0KCkgKyBhbmNob3JQb2ludCAqIGxheWVyQm91bmRzLnNpemU7Ci0gICAgW21fbGF5 ZXIuZ2V0KCkgc2V0UG9zaXRpb246bmV3UG9zaXRpb25dOworICAgIAorICAgIFttX2xheWVyIHNl dFBvc2l0aW9uOm5ld1Bvc2l0aW9uXTsKIAogICAgIGlmICghbV9jaGlsZHJlbikKICAgICAgICAg cmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbWFjL1Nj cm9sbGluZ1RyZWVTdGlja3lOb2RlLm1tIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcv bWFjL1Njcm9sbGluZ1RyZWVTdGlja3lOb2RlLm1tCmluZGV4IDFhYWNmZDQ1OTlmMDQzMjE5MWVh NGNmZjBjYzQwZmFlZDhmZDZjOTIuLjFkOWFjZGM3ODRjMmE0MjRjNzU5MDhlZWY1MGU2NGQyNDQx ZmMyNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3Jv bGxpbmdUcmVlU3RpY2t5Tm9kZS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9tYWMvU2Nyb2xsaW5nVHJlZVN0aWNreU5vZGUubW0KQEAgLTY3LDI5ICs2NywzNSBAQCBzdGF0 aWMgaW5saW5lIENHUG9pbnQgb3BlcmF0b3IqKENHUG9pbnQmIGEsIGNvbnN0IENHU2l6ZSYgYikK IAogdm9pZCBTY3JvbGxpbmdUcmVlU3RpY2t5Tm9kZTo6dXBkYXRlTGF5ZXJzQWZ0ZXJBbmNlc3Rv ckNoYW5nZShjb25zdCBTY3JvbGxpbmdUcmVlTm9kZSYgY2hhbmdlZE5vZGUsIGNvbnN0IEZsb2F0 UmVjdCYgZml4ZWRQb3NpdGlvblJlY3QsIGNvbnN0IEZsb2F0U2l6ZSYgY3VtdWxhdGl2ZURlbHRh KQogewotICAgIEZsb2F0UmVjdCBjb25zdHJhaW5pbmdSZWN0ID0gZml4ZWRQb3NpdGlvblJlY3Q7 Ci0gICAgaWYgKHBhcmVudCgpLT5pc092ZXJmbG93U2Nyb2xsaW5nTm9kZSgpKQorICAgIGJvb2wg YWRqdXN0U3RpY2t5TGF5ZXIgPSBmYWxzZTsKKyAgICBGbG9hdFJlY3QgY29uc3RyYWluaW5nUmVj dDsKKworICAgIGlmIChwYXJlbnQoKS0+aXNPdmVyZmxvd1Njcm9sbGluZ05vZGUoKSkgewogICAg ICAgICBjb25zdHJhaW5pbmdSZWN0ID0gRmxvYXRSZWN0KHRvU2Nyb2xsaW5nVHJlZU92ZXJmbG93 U2Nyb2xsaW5nTm9kZShwYXJlbnQoKSktPnNjcm9sbFBvc2l0aW9uKCksIG1fY29uc3RyYWludHMu Y29uc3RyYWluaW5nUmVjdEF0TGFzdExheW91dCgpLnNpemUoKSk7CisgICAgICAgIGFkanVzdFN0 aWNreUxheWVyID0gdHJ1ZTsKKyAgICB9IGVsc2UgaWYgKHBhcmVudCgpLT5pc0ZyYW1lU2Nyb2xs aW5nTm9kZSgpKSB7CisgICAgICAgIGNvbnN0cmFpbmluZ1JlY3QgPSBmaXhlZFBvc2l0aW9uUmVj dDsKKyAgICAgICAgYWRqdXN0U3RpY2t5TGF5ZXIgPSB0cnVlOworICAgIH0KKworICAgIEZsb2F0 U2l6ZSBkZWx0YUZvckRlc2NlbmRhbnRzID0gY3VtdWxhdGl2ZURlbHRhOwogCi0gICAgRmxvYXRQ b2ludCBsYXllclBvc2l0aW9uID0gbV9jb25zdHJhaW50cy5sYXllclBvc2l0aW9uRm9yQ29uc3Ry YWluaW5nUmVjdChjb25zdHJhaW5pbmdSZWN0KTsKKyAgICBpZiAoYWRqdXN0U3RpY2t5TGF5ZXIp IHsKKyAgICAgICAgRmxvYXRQb2ludCBsYXllclBvc2l0aW9uID0gbV9jb25zdHJhaW50cy5sYXll clBvc2l0aW9uRm9yQ29uc3RyYWluaW5nUmVjdChjb25zdHJhaW5pbmdSZWN0KTsKIAotICAgIC8v IEZJWE1FOiBTdWJ0cmFjdGluZyB0aGUgY3VtdWxhdGl2ZURlbHRhIGlzIG5vdCB0b3RhbGx5IHN1 ZmZpY2llbnQgdG8gZ2V0IHRoZSBuZXcgcG9zaXRpb24gcmlnaHQgZm9yIG5lc3RlZAotICAgIC8v IHN0aWNreSBvYmplY3RzLiBXZSBwcm9iYWJseSBuZWVkIGEgd2F5IHRvIG1vZGlmeSB0aGUgY29u dGFpbmluZ0Jsb2NrUmVjdCBpbiB0aGUgVmlld3BvcnRDb250cmFpbnRzCi0gICAgLy8gdG8gZ2V0 IHRoaXMgcmlnaHQgaW4gYWxsIGNhc2VzLgotICAgIGxheWVyUG9zaXRpb24gLT0gY3VtdWxhdGl2 ZURlbHRhOworICAgICAgICBDR1JlY3QgbGF5ZXJCb3VuZHMgPSBbbV9sYXllciBib3VuZHNdOwor ICAgICAgICBDR1BvaW50IGFuY2hvclBvaW50ID0gW21fbGF5ZXIgYW5jaG9yUG9pbnRdOworICAg ICAgICBDR1BvaW50IG5ld1Bvc2l0aW9uID0gbGF5ZXJQb3NpdGlvbiAtIG1fY29uc3RyYWludHMu YWxpZ25tZW50T2Zmc2V0KCkgKyBhbmNob3JQb2ludCAqIGxheWVyQm91bmRzLnNpemU7CisgICAg ICAgIFttX2xheWVyIHNldFBvc2l0aW9uOm5ld1Bvc2l0aW9uXTsKIAotICAgIENHUmVjdCBsYXll ckJvdW5kcyA9IFttX2xheWVyLmdldCgpIGJvdW5kc107Ci0gICAgQ0dQb2ludCBhbmNob3JQb2lu dCA9IFttX2xheWVyLmdldCgpIGFuY2hvclBvaW50XTsKLSAgICBDR1BvaW50IG5ld1Bvc2l0aW9u ID0gbGF5ZXJQb3NpdGlvbiAtIG1fY29uc3RyYWludHMuYWxpZ25tZW50T2Zmc2V0KCkgKyBhbmNo b3JQb2ludCAqIGxheWVyQm91bmRzLnNpemU7Ci0gICAgW21fbGF5ZXIuZ2V0KCkgc2V0UG9zaXRp b246bmV3UG9zaXRpb25dOworICAgICAgICBkZWx0YUZvckRlc2NlbmRhbnRzID0gbGF5ZXJQb3Np dGlvbiAtIG1fY29uc3RyYWludHMubGF5ZXJQb3NpdGlvbkF0TGFzdExheW91dCgpICsgY3VtdWxh dGl2ZURlbHRhOworICAgIH0KIAogICAgIGlmICghbV9jaGlsZHJlbikKICAgICAgICAgcmV0dXJu OwogCi0gICAgRmxvYXRTaXplIG5ld0RlbHRhID0gbGF5ZXJQb3NpdGlvbiAtIG1fY29uc3RyYWlu dHMubGF5ZXJQb3NpdGlvbkF0TGFzdExheW91dCgpICsgY3VtdWxhdGl2ZURlbHRhOwotCiAgICAg Zm9yIChhdXRvJiBjaGlsZCA6ICptX2NoaWxkcmVuKQotICAgICAgICBjaGlsZC0+dXBkYXRlTGF5 ZXJzQWZ0ZXJBbmNlc3RvckNoYW5nZShjaGFuZ2VkTm9kZSwgZml4ZWRQb3NpdGlvblJlY3QsIG5l d0RlbHRhKTsKKyAgICAgICAgY2hpbGQtPnVwZGF0ZUxheWVyc0FmdGVyQW5jZXN0b3JDaGFuZ2Uo Y2hhbmdlZE5vZGUsIGZpeGVkUG9zaXRpb25SZWN0LCBkZWx0YUZvckRlc2NlbmRhbnRzKTsKIH0K IAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1Njcm9sbGluZy9pb3MvU2Nyb2xsaW5nVHJlZU92ZXJmbG93U2Nyb2xsaW5nTm9kZUlP Uy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TY3JvbGxpbmcvaW9zL1Njcm9sbGluZ1Ry ZWVPdmVyZmxvd1Njcm9sbGluZ05vZGVJT1MubW0KaW5kZXggMWE1NDQwMGJiMGVhMmQ0MDYzOTg0 ZTAyNGRmYjgzZTE2MzU1NjNjMS4uZmY4NmEwMDJlOGVhNGViNjNmNTZhYzM3NGE4OWIyYTM1ZDFi ODM1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1Njcm9sbGluZy9pb3Mv U2Nyb2xsaW5nVHJlZU92ZXJmbG93U2Nyb2xsaW5nTm9kZUlPUy5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvU2Nyb2xsaW5nL2lvcy9TY3JvbGxpbmdUcmVlT3ZlcmZsb3dTY3JvbGxp bmdOb2RlSU9TLm1tCkBAIC0xODUsMTAgKzE4NSwxMSBAQCB2b2lkIFNjcm9sbGluZ1RyZWVPdmVy Zmxvd1Njcm9sbGluZ05vZGVJT1M6OnVwZGF0ZUNoaWxkTm9kZXNBZnRlclNjcm9sbChjb25zdCBG bAogICAgICAgICByZXR1cm47CiAKICAgICBGbG9hdFJlY3QgZml4ZWRQb3NpdGlvblJlY3QgPSBz Y3JvbGxpbmdUcmVlKCkuZml4ZWRQb3NpdGlvblJlY3QoKTsKKyAgICBGbG9hdFNpemUgc2Nyb2xs RGVsdGEgPSBsYXN0Q29tbWl0dGVkU2Nyb2xsUG9zaXRpb24oKSAtIHNjcm9sbFBvc2l0aW9uOwog CiAgICAgc2l6ZV90IHNpemUgPSBtX2NoaWxkcmVuLT5zaXplKCk7CiAgICAgZm9yIChzaXplX3Qg aSA9IDA7IGkgPCBzaXplOyArK2kpCi0gICAgICAgIG1fY2hpbGRyZW4tPmF0KGkpLT51cGRhdGVM YXllcnNBZnRlckFuY2VzdG9yQ2hhbmdlKCp0aGlzLCBmaXhlZFBvc2l0aW9uUmVjdCwgRmxvYXRT aXplKCkpOworICAgICAgICBtX2NoaWxkcmVuLT5hdChpKS0+dXBkYXRlTGF5ZXJzQWZ0ZXJBbmNl c3RvckNoYW5nZSgqdGhpcywgZml4ZWRQb3NpdGlvblJlY3QsIHNjcm9sbERlbHRhKTsKIH0KIAog dm9pZCBTY3JvbGxpbmdUcmVlT3ZlcmZsb3dTY3JvbGxpbmdOb2RlSU9TOjpzY3JvbGxWaWV3RGlk U2Nyb2xsKGNvbnN0IEZsb2F0UG9pbnQmIHNjcm9sbFBvc2l0aW9uLCBib29sIGluVXNlckludGVy YXRpb24pCg==