133331 2014-05-27 18:56:04 -0700 Use correct version of requiresFullscreenForVideoPlayback(). 2014-05-29 09:27:21 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk jeremyj-wk calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble jonlee philipj sergio webkit-bug-importer oldest_to_newest 1012109 0 jeremyj-wk 2014-05-27 18:56:04 -0700 Use correct version of requiresFullscreenForVideoPlayback(). 1012110 1 jeremyj-wk 2014-05-27 18:57:00 -0700 radar://16478742 1012111 2 232162 jeremyj-wk 2014-05-27 19:04:08 -0700 Created attachment 232162 Patch 1012195 3 232162 eric.carlson 2014-05-28 06:34:59 -0700 Comment on attachment 232162 Patch This should have a layout test. You can use video-fullscreeen-only-playback.html as a template, although a test for this will be much simpler. 1012316 4 232220 jeremyj-wk 2014-05-28 16:44:24 -0700 Created attachment 232220 Patch 1012342 5 232220 eric.carlson 2014-05-28 18:52:39 -0700 Comment on attachment 232220 Patch Thanks! 1012443 6 232220 commit-queue 2014-05-29 09:27:17 -0700 Comment on attachment 232220 Patch Clearing flags on attachment: 232220 Committed r169449: <http://trac.webkit.org/changeset/169449> 1012444 7 commit-queue 2014-05-29 09:27:21 -0700 All reviewed patches have been landed. Closing bug. 232162 2014-05-27 19:04:08 -0700 2014-05-28 16:44:21 -0700 Patch bug-133331-20140527190344.patch text/plain 1599 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGMzNjY2ZWEyMWY1ZmM0 MDg5OGU4YWYwMzE2NTIyYTRjODYzNTYyOC4uZjViZjNiNzQwNzYwNDNlYTYzMzZhZGY5N2ZiZGQ0 Y2E1N2FhOTMwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA1LTI3ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgY29ycmVjdCB2ZXJz aW9uIG9mIHJlcXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2soKS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzMzMQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSB0aGUgbGFzdCBwbGFj ZSBub3QgeWV0IHVzaW5nIG1fbWVkaWFTZXNzaW9uLT5yZXF1aXJlc0Z1bGxzY3JlZW5Gb3JWaWRl b1BsYXliYWNrLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKToKKyAgICAgICAg c3dpdGNoIHRvIG1lZGlhIHNlc3Npb24gdmVyc2lvbiBmb3IgcmVxdXJpZXNGdWxsc2NyZWVuRm9y VmlkZW9QbGF5YmFjay4KKwogMjAxNC0wNS0yNyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4Zmll bGRAYXBwbGUuY29tPgogCiAgICAgICAgIExpc3RzIHN0eWxlZCB3aXRoIFNWRyBmb250cyBhcmUg bm90IHJlbmRlcmVkIGFzIGV4cGVjdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcAppbmRleCAzYzVmNDBhNmJiMWMyNjM5YzM1NGZmNjcyM2E4MDhiYjZlZGY4MjBlLi5l NGNhM2JlNGRmZDAyNWQyZDA0Y2Y2ODRkZGQ4OGJlZmM5NzlmNGY4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTI5MzAsNyArMjkzMCw3IEBAIGJvb2wgSFRN TE1lZGlhRWxlbWVudDo6Y29udHJvbHMoKSBjb25zdAogICAgICAgICByZXR1cm4gdHJ1ZTsKIAog ICAgIC8vIGFsd2F5cyBzaG93IGNvbnRyb2xzIGZvciB2aWRlbyB3aGVuIGZ1bGxzY3JlZW4gcGxh eWJhY2sgaXMgcmVxdWlyZWQuCi0gICAgaWYgKGlzVmlkZW8oKSAmJiBkb2N1bWVudCgpLnBhZ2Uo KSAmJiBkb2N1bWVudCgpLnBhZ2UoKS0+Y2hyb21lKCkucmVxdWlyZXNGdWxsc2NyZWVuRm9yVmlk ZW9QbGF5YmFjaygpKQorICAgIGlmIChpc1ZpZGVvKCkgJiYgbV9tZWRpYVNlc3Npb24tPnJlcXVp cmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2soKnRoaXMpKQogICAgICAgICByZXR1cm4gdHJ1 ZTsKIAogICAgIC8vIEFsd2F5cyBzaG93IGNvbnRyb2xzIHdoZW4gaW4gZnVsbCBzY3JlZW4gbW9k ZS4K 232220 2014-05-28 16:44:24 -0700 2014-05-29 09:27:16 -0700 Patch bug-133331-20140528164400.patch text/plain 4974 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5NDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGMzNjY2ZWEyMWY1ZmM0 MDg5OGU4YWYwMzE2NTIyYTRjODYzNTYyOC4uMWNiOGJkMzNiOGM1YjM5NjUxZmM4Y2NmYmM5NTQ3 YzE0ZTM2ZWI3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA1LTI3ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgY29ycmVjdCB2ZXJz aW9uIG9mIHJlcXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2soKS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzMzMQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IG1lZGlhL3ZpZGVvLWZ1 bGxzY3JlZWVuLW9ubHktY29udHJvbHMuaHRtbAorCisgICAgICAgIFVwZGF0ZSB0aGUgbGFzdCBw bGFjZSBub3QgeWV0IHVzaW5nIG1fbWVkaWFTZXNzaW9uLT5yZXF1aXJlc0Z1bGxzY3JlZW5Gb3JW aWRlb1BsYXliYWNrLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKToKKyAgICAg ICAgc3dpdGNoIHRvIG1lZGlhIHNlc3Npb24gdmVyc2lvbiBmb3IgcmVxdXJpZXNGdWxsc2NyZWVu Rm9yVmlkZW9QbGF5YmFjay4KKwogMjAxNC0wNS0yNyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4 ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIExpc3RzIHN0eWxlZCB3aXRoIFNWRyBmb250cyBh cmUgbm90IHJlbmRlcmVkIGFzIGV4cGVjdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFF bGVtZW50LmNwcAppbmRleCAzYzVmNDBhNmJiMWMyNjM5YzM1NGZmNjcyM2E4MDhiYjZlZGY4MjBl Li5lNGNhM2JlNGRmZDAyNWQyZDA0Y2Y2ODRkZGQ4OGJlZmM5NzlmNGY4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTI5MzAsNyArMjkzMCw3IEBAIGJvb2wg SFRNTE1lZGlhRWxlbWVudDo6Y29udHJvbHMoKSBjb25zdAogICAgICAgICByZXR1cm4gdHJ1ZTsK IAogICAgIC8vIGFsd2F5cyBzaG93IGNvbnRyb2xzIGZvciB2aWRlbyB3aGVuIGZ1bGxzY3JlZW4g cGxheWJhY2sgaXMgcmVxdWlyZWQuCi0gICAgaWYgKGlzVmlkZW8oKSAmJiBkb2N1bWVudCgpLnBh Z2UoKSAmJiBkb2N1bWVudCgpLnBhZ2UoKS0+Y2hyb21lKCkucmVxdWlyZXNGdWxsc2NyZWVuRm9y VmlkZW9QbGF5YmFjaygpKQorICAgIGlmIChpc1ZpZGVvKCkgJiYgbV9tZWRpYVNlc3Npb24tPnJl cXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2soKnRoaXMpKQogICAgICAgICByZXR1cm4g dHJ1ZTsKIAogICAgIC8vIEFsd2F5cyBzaG93IGNvbnRyb2xzIHdoZW4gaW4gZnVsbCBzY3JlZW4g bW9kZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwppbmRleCA5NGMwYzYyMzM2MmJjY2FhNWI4NjRjNzMyNzFmZmJhMzczMjE0NDEzLi5l ZmJjNjBiZGQyZDFhODdjMDI2MmE2ZjFiNGVjNjA0ZGY3YWE4ZDRjIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTQgQEAKKzIwMTQtMDUtMjggIEplcmVteSBKb25lcyAgPGplcmVteWpAYXBwbGUuY29tPgorCisg ICAgICAgIFVzZSBjb3JyZWN0IHZlcnNpb24gb2YgcmVxdWlyZXNGdWxsc2NyZWVuRm9yVmlkZW9Q bGF5YmFjaygpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTMzMzMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBtZWRpYS92aWRlby1mdWxsc2NyZWVlbi1vbmx5LWNvbnRyb2xzLWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogbWVkaWEvdmlkZW8tZnVsbHNjcmVlZW4tb25seS1jb250cm9scy5o dG1sOiBBZGRlZC4gTWFrZSBzdXJlIHZpZGVvIGVsZW1lbnQKKyAgICAgICAgY29udHJvbHMgc2hv dyBldmVuIHdoZW4gbm90IHNwZWNpZmllZCBpZiBpbmxpbmUgcGxheWJhY2sgaXMgcmVzdHJpY3Rl ZC4KKwogMjAxNC0wNS0yNyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29t PgogCiAgICAgICAgIExpc3RzIHN0eWxlZCB3aXRoIFNWRyBmb250cyBhcmUgbm90IHJlbmRlcmVk IGFzIGV4cGVjdGVkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1mdWxsc2Ny ZWVlbi1vbmx5LWNvbnRyb2xzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVv LWZ1bGxzY3JlZWVuLW9ubHktY29udHJvbHMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjhmODYy ZDc4OWNkODEwYzMxNWUwMTkxOGNlYzg0NjUyNGE5NTdkZTIKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9tZWRpYS92aWRlby1mdWxsc2NyZWVlbi1vbmx5LWNvbnRyb2xzLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDExIEBACitUaGlzIHRlc3RzIHRoYXQgd2hlbiBpbmxpbmUtcGxheWJh Y2sgaXMgcmVzdHJpY3RlZCwgdGhlIHZpZGVvIGVsZW1lbnQncyAiY29udHJvbHMiIGFyZSBhbHdh eXMgc2hvd24gd2hpbGUgaW5saW5lLgorCisKK1JVTihpbnRlcm5hbHMuc2V0TWVkaWFTZXNzaW9u UmVzdHJpY3Rpb25zKCd2aWRlbycsICdJbmxpbmVWaWRlb1BsYXliYWNrUmVzdHJpY3RlZCcpKQor RVhQRUNURUQgKHNoYWRvd1Jvb3QgPSBpbnRlcm5hbHMuc2hhZG93Um9vdCh2aWRlbykgIT0gJ251 bGwnKSBPSworRVhQRUNURUQgKHBhbmVsID0gbWVkaWFDb250cm9sc0VsZW1lbnQoc2hhZG93Um9v dC5maXJzdENoaWxkLCAnLXdlYmtpdC1tZWRpYS1jb250cm9scy1wYW5lbCcpICE9ICdudWxsJykg T0sKK0VYUEVDVEVEIChpbnRlcm5hbHMuc2hhZG93UHNldWRvSWQocGFuZWwpID09ICctd2Via2l0 LW1lZGlhLWNvbnRyb2xzLXBhbmVsJykgT0sKK0VYUEVDVEVEIChkb2N1bWVudC5kZWZhdWx0Vmll dy5nZXRDb21wdXRlZFN0eWxlKHBhbmVsKVsnZGlzcGxheSddICE9ICdub25lJykgT0sKK0VYUEVD VEVEIChkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKHBhbmVsKVsnaGVpZ2h0 J10gPj0gJzIwcHgnKSBPSworRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv bWVkaWEvdmlkZW8tZnVsbHNjcmVlZW4tb25seS1jb250cm9scy5odG1sIGIvTGF5b3V0VGVzdHMv bWVkaWEvdmlkZW8tZnVsbHNjcmVlZW4tb25seS1jb250cm9scy5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdl NzUzZTM1NzUyN2Y1ZGJmZGNlZGU2OTczZmMxNmE0MTljNGUzNmMKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1mdWxsc2NyZWVlbi1vbmx5LWNvbnRyb2xzLmh0bWwK QEAgLTAsMCArMSwyOSBAQAorPGJvZHk+CisgICAgPHA+VGhpcyB0ZXN0cyB0aGF0IHdoZW4gaW5s aW5lLXBsYXliYWNrIGlzIHJlc3RyaWN0ZWQsIHRoZSB2aWRlbyBlbGVtZW50J3MgImNvbnRyb2xz IiBhcmUgYWx3YXlzIHNob3duIHdoaWxlIGlubGluZS48L3A+CisgICAgPHZpZGVvIGlkPSJ2aWRl byIgd2lkdGg9IjMwMCI+PC92aWRlbz4KKyAgICA8c2NyaXB0IHNyYz1tZWRpYS1maWxlLmpzPjwv c2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+CisgICAgPHNj cmlwdCBzcmM9bWVkaWEtY29udHJvbHMuanM+PC9zY3JpcHQ+CisgICAgPHNjcmlwdD4KKworICAg IHZhciBzaGFkb3dSb290OworICAgIHZhciBwYW5lbDsKKworICAgIHJ1bigiaW50ZXJuYWxzLnNl dE1lZGlhU2Vzc2lvblJlc3RyaWN0aW9ucygndmlkZW8nLCAnSW5saW5lVmlkZW9QbGF5YmFja1Jl c3RyaWN0ZWQnKSIpOworCisgICAgdmFyIHZpZGVvID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J3ZpZGVvJyk7CisgICAgdmlkZW8uc3JjID0gZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiY29udGVu dC90ZXN0Iik7CisKKyAgICBpZiAod2luZG93LmludGVybmFscykgeworICAgICAgICB0ZXN0RXhw ZWN0ZWQoInNoYWRvd1Jvb3QgPSBpbnRlcm5hbHMuc2hhZG93Um9vdCh2aWRlbykiLCBudWxsLCAi IT0iKTsKKyAgICAgICAgdGVzdEV4cGVjdGVkKCJwYW5lbCA9IG1lZGlhQ29udHJvbHNFbGVtZW50 KHNoYWRvd1Jvb3QuZmlyc3RDaGlsZCwgJy13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwnKSIs IG51bGwsICIhPSIpOworICAgICAgICB0ZXN0RXhwZWN0ZWQoImludGVybmFscy5zaGFkb3dQc2V1 ZG9JZChwYW5lbCkiLCAiLXdlYmtpdC1tZWRpYS1jb250cm9scy1wYW5lbCIpOworICAgICAgICB0 ZXN0RXhwZWN0ZWQoImRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUocGFuZWwp WydkaXNwbGF5J10iLCAnbm9uZScsICIhPSIpOworICAgICAgICB0ZXN0RXhwZWN0ZWQoImRvY3Vt ZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUocGFuZWwpWydoZWlnaHQnXSIsICcyMHB4 JywgIj49Iik7CisgICAgfQorICAgIGVsc2UKKyAgICAgICAgbG9nUmVzdWx0KGZhbHNlLCAid2lu ZG93LmludGVybmFscyA9PSB1bmRlZmluZWQiKTsKKworICAgIGVuZFRlc3QoKTsKKyAgICA8L3Nj cmlwdD4KKzwvYm9keT4K