133329 2014-05-27 18:25:17 -0700 Prepare for position:sticky support inside accelerated overflow-scroll with WK2 2014-05-27 21:45:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1012102 0 simon.fraser 2014-05-27 18:25:17 -0700 Prepare for position:sticky support inside accelerated overflow-scroll with WK2 1012103 1 232161 simon.fraser 2014-05-27 18:26:53 -0700 Created attachment 232161 Patch 1012106 2 232161 thorton 2014-05-27 18:35:32 -0700 Comment on attachment 232161 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232161&action=review > Source/WebCore/rendering/RenderBoxModelObject.cpp:455 > + float scale = view().frameView().frame().frameScaleFactor(); RenderObject has frame(), maybe use that? (it just does what you're doing) 1012126 3 simon.fraser 2014-05-27 21:45:43 -0700 https://trac.webkit.org/r169408 232161 2014-05-27 18:26:53 -0700 2014-05-27 18:35:31 -0700 Patch bug-133329-20140527182629.patch text/plain 5779 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5Mzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWIzNDUzODkxMmU5MTkx MTUzNTMyNTk3ZTY4YzIxZWFiM2NjYmNkZi4uYTRjMTQ4OTVkM2RkYTU0YjdhMmRiMTQzOGQ4YTgx MmRjMDZlMGNkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA1LTI3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFByZXBhcmUgZm9y IHBvc2l0aW9uOnN0aWNreSBzdXBwb3J0IGluc2lkZSBhY2NlbGVyYXRlZCBvdmVyZmxvdy1zY3Jv bGwgd2l0aCBXSzIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMzMyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6Y29tcHV0ZVN0aWNreVZpZXdwb3J0Q29uc3RyYWlu dHMoKSB3YXMgYWx3YXlzIHVzaW5nCisgICAgICAgIHRoZSB2aWV3cG9ydCByZWN0IGFzIHRoZSBj b25zdHJhaW5pbmcgcmVjdCBmb3Igc3RpY2t5IHBvc2l0aW9uLiBUaGlzIGlzIG5vdAorICAgICAg ICBjb3JyZWN0IHdoZW4gaW5zaWRlIG92ZXJmbG93OnNjcm9sbC4KKyAgICAgICAgCisgICAgICAg IFJlZmFjdG9yIGNvZGUgaW4gUmVuZGVyQm94TW9kZWxPYmplY3QgdG8gbWFrZSBnZXR0aW5nIHRo ZSByZWN0IGVhc3ksIGFuZCB1c2UKKyAgICAgICAgaXQgdG8gY29tcHV0ZSB0aGUgY29uc3RyYWlu dHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6OmNvbnN0cmFpbmluZ1JlY3RGb3JT dGlja3lQb3NpdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3hNb2RlbE9iamVjdDo6 c3RpY2t5UG9zaXRpb25PZmZzZXQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3hNb2Rl bE9iamVjdC5oOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpjb21wdXRlU3RpY2t5 Vmlld3BvcnRDb25zdHJhaW50cyk6CisKIDIwMTQtMDUtMjcgIFRpbW90aHkgSG9ydG9uICA8dGlt b3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFR1cm4gb24gdGhlIExheWVyUG9vbCBm b3IgaU9TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9k ZWxPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2Jq ZWN0LmNwcAppbmRleCAwM2ZlOWExOTRmNGNlYTZjNTYyN2MyN2MwYzk4OTg3NWU1MTU2NGM4Li4x NWIyYmIwODhkMGU4YjgxOTU0M2MzYjczYWFlOWRiODlkYWI1Y2QwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKQEAgLTQzNSwyOCAr NDM1LDMzIEBAIHZvaWQgUmVuZGVyQm94TW9kZWxPYmplY3Q6OmNvbXB1dGVTdGlja3lQb3NpdGlv bkNvbnN0cmFpbnRzKFN0aWNreVBvc2l0aW9uVmlld3BvCiAgICAgfQogfQogCi1MYXlvdXRTaXpl IFJlbmRlckJveE1vZGVsT2JqZWN0OjpzdGlja3lQb3NpdGlvbk9mZnNldCgpIGNvbnN0CitGbG9h dFJlY3QgUmVuZGVyQm94TW9kZWxPYmplY3Q6OmNvbnN0cmFpbmluZ1JlY3RGb3JTdGlja3lQb3Np dGlvbigpIGNvbnN0CiB7Ci0gICAgRmxvYXRSZWN0IGNvbnN0cmFpbmluZ1JlY3Q7Ci0KLSAgICBB U1NFUlQoaGFzTGF5ZXIoKSk7CiAgICAgUmVuZGVyTGF5ZXIqIGVuY2xvc2luZ0NsaXBwaW5nTGF5 ZXIgPSBsYXllcigpLT5lbmNsb3NpbmdPdmVyZmxvd0NsaXBMYXllcihFeGNsdWRlU2VsZik7CiAg ICAgaWYgKGVuY2xvc2luZ0NsaXBwaW5nTGF5ZXIpIHsKICAgICAgICAgUmVuZGVyQm94JiBlbmNs b3NpbmdDbGlwcGluZ0JveCA9IHRvUmVuZGVyQm94KGVuY2xvc2luZ0NsaXBwaW5nTGF5ZXItPnJl bmRlcmVyKCkpOwogICAgICAgICBMYXlvdXRSZWN0IGNsaXBSZWN0ID0gZW5jbG9zaW5nQ2xpcHBp bmdCb3gub3ZlcmZsb3dDbGlwUmVjdChMYXlvdXRQb2ludCgpLCAwKTsgLy8gRklYTUU6IG1ha2Ug dGhpcyB3b3JrIGluIHJlZ2lvbnMuCiAgICAgICAgIGNsaXBSZWN0LmNvbnRyYWN0KExheW91dFNp emUoZW5jbG9zaW5nQ2xpcHBpbmdCb3gucGFkZGluZ0xlZnQoKSArIGVuY2xvc2luZ0NsaXBwaW5n Qm94LnBhZGRpbmdSaWdodCgpLAogICAgICAgICAgICAgZW5jbG9zaW5nQ2xpcHBpbmdCb3gucGFk ZGluZ1RvcCgpICsgZW5jbG9zaW5nQ2xpcHBpbmdCb3gucGFkZGluZ0JvdHRvbSgpKSk7Ci0gICAg ICAgIGNvbnN0cmFpbmluZ1JlY3QgPSBlbmNsb3NpbmdDbGlwcGluZ0JveC5sb2NhbFRvQ29udGFp bmVyUXVhZChGbG9hdFJlY3QoY2xpcFJlY3QpLCAmdmlldygpKS5ib3VuZGluZ0JveCgpOworCisg ICAgICAgIEZsb2F0UmVjdCBjb25zdHJhaW5pbmdSZWN0ID0gZW5jbG9zaW5nQ2xpcHBpbmdCb3gu bG9jYWxUb0NvbnRhaW5lclF1YWQoRmxvYXRSZWN0KGNsaXBSZWN0KSwgJnZpZXcoKSkuYm91bmRp bmdCb3goKTsKIAogICAgICAgICBGbG9hdFBvaW50IHNjcm9sbE9mZnNldCA9IEZsb2F0UG9pbnQo KSArIGVuY2xvc2luZ0NsaXBwaW5nTGF5ZXItPnNjcm9sbE9mZnNldCgpOwogICAgICAgICBjb25z dHJhaW5pbmdSZWN0LnNldExvY2F0aW9uKHNjcm9sbE9mZnNldCk7Ci0gICAgfSBlbHNlIHsKLSAg ICAgICAgTGF5b3V0UmVjdCB2aWV3cG9ydFJlY3QgPSB2aWV3KCkuZnJhbWVWaWV3KCkudmlld3Bv cnRDb25zdHJhaW5lZFZpc2libGVDb250ZW50UmVjdCgpOwotICAgICAgICBmbG9hdCBzY2FsZSA9 IHZpZXcoKS5mcmFtZVZpZXcoKS5mcmFtZSgpLmZyYW1lU2NhbGVGYWN0b3IoKTsKLSAgICAgICAg dmlld3BvcnRSZWN0LnNjYWxlKDEgLyBzY2FsZSk7Ci0gICAgICAgIGNvbnN0cmFpbmluZ1JlY3Qg PSB2aWV3cG9ydFJlY3Q7CisgICAgICAgIHJldHVybiBjb25zdHJhaW5pbmdSZWN0OwogICAgIH0K ICAgICAKKyAgICBMYXlvdXRSZWN0IHZpZXdwb3J0UmVjdCA9IHZpZXcoKS5mcmFtZVZpZXcoKS52 aWV3cG9ydENvbnN0cmFpbmVkVmlzaWJsZUNvbnRlbnRSZWN0KCk7CisgICAgZmxvYXQgc2NhbGUg PSB2aWV3KCkuZnJhbWVWaWV3KCkuZnJhbWUoKS5mcmFtZVNjYWxlRmFjdG9yKCk7CisgICAgdmll d3BvcnRSZWN0LnNjYWxlKDEgLyBzY2FsZSk7CisgICAgcmV0dXJuIHZpZXdwb3J0UmVjdDsKK30K KworTGF5b3V0U2l6ZSBSZW5kZXJCb3hNb2RlbE9iamVjdDo6c3RpY2t5UG9zaXRpb25PZmZzZXQo KSBjb25zdAoreworICAgIEFTU0VSVChoYXNMYXllcigpKTsKKyAgICAKKyAgICBGbG9hdFJlY3Qg Y29uc3RyYWluaW5nUmVjdCA9IGNvbnN0cmFpbmluZ1JlY3RGb3JTdGlja3lQb3NpdGlvbigpOwog ICAgIFN0aWNreVBvc2l0aW9uVmlld3BvcnRDb25zdHJhaW50cyBjb25zdHJhaW50czsKICAgICBj b21wdXRlU3RpY2t5UG9zaXRpb25Db25zdHJhaW50cyhjb25zdHJhaW50cywgY29uc3RyYWluaW5n UmVjdCk7CiAgICAgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Qm94TW9kZWxPYmplY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2Rl bE9iamVjdC5oCmluZGV4IGRhYzkwZDA1MWJlYzk1ODFlYjlmNTZjMGVjNjFiMGIwODM1NmFmMDUu LjA5NmI4YjkyNzFjZjFiZWYxNzUzZGQxZDFlMzQ2NTI3NTc1NTFiZWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oCkBAIC02OSw3ICs2OSw4 IEBAIHB1YmxpYzoKICAgICBMYXlvdXRTaXplIHJlbGF0aXZlUG9zaXRpb25PZmZzZXQoKSBjb25z dDsKICAgICBMYXlvdXRTaXplIHJlbGF0aXZlUG9zaXRpb25Mb2dpY2FsT2Zmc2V0KCkgY29uc3Qg eyByZXR1cm4gc3R5bGUoKS5pc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8gcmVsYXRpdmVQb3Np dGlvbk9mZnNldCgpIDogcmVsYXRpdmVQb3NpdGlvbk9mZnNldCgpLnRyYW5zcG9zZWRTaXplKCk7 IH0KIAotICAgIHZvaWQgY29tcHV0ZVN0aWNreVBvc2l0aW9uQ29uc3RyYWludHMoU3RpY2t5UG9z aXRpb25WaWV3cG9ydENvbnN0cmFpbnRzJiwgY29uc3QgRmxvYXRSZWN0JiB2aWV3cG9ydFJlY3Qp IGNvbnN0OworICAgIEZsb2F0UmVjdCBjb25zdHJhaW5pbmdSZWN0Rm9yU3RpY2t5UG9zaXRpb24o KSBjb25zdDsKKyAgICB2b2lkIGNvbXB1dGVTdGlja3lQb3NpdGlvbkNvbnN0cmFpbnRzKFN0aWNr eVBvc2l0aW9uVmlld3BvcnRDb25zdHJhaW50cyYsIGNvbnN0IEZsb2F0UmVjdCYgY29uc3RyYWlu aW5nUmVjdCkgY29uc3Q7CiAgICAgTGF5b3V0U2l6ZSBzdGlja3lQb3NpdGlvbk9mZnNldCgpIGNv bnN0OwogICAgIExheW91dFNpemUgc3RpY2t5UG9zaXRpb25Mb2dpY2FsT2Zmc2V0KCkgY29uc3Qg eyByZXR1cm4gc3R5bGUoKS5pc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8gc3RpY2t5UG9zaXRp b25PZmZzZXQoKSA6IHN0aWNreVBvc2l0aW9uT2Zmc2V0KCkudHJhbnNwb3NlZFNpemUoKTsgfQog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu Y3BwCmluZGV4IDc1NWQ2MjRjMzg4YWFkZjU5ZDkyZmRlNjgyMTc5MDU2ZThjNDllMjEuLjczZDBh NjI3NmNjNmRiMTMzZjAzY2I2MTM1YWFiMzM2YWQ5NjA4ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCkBAIC0zNTU4LDExICsz NTU4LDEwIEBAIFN0aWNreVBvc2l0aW9uVmlld3BvcnRDb25zdHJhaW50cyBSZW5kZXJMYXllckNv bXBvc2l0b3I6OmNvbXB1dGVTdGlja3lWaWV3cG9ydENvCiAgICAgQVNTRVJUKCFsYXllci5lbmNs b3NpbmdPdmVyZmxvd0NsaXBMYXllcihFeGNsdWRlU2VsZikpOwogI2VuZGlmCiAKLSAgICBMYXlv dXRSZWN0IHZpZXdwb3J0UmVjdCA9IG1fcmVuZGVyVmlldy5mcmFtZVZpZXcoKS52aWV3cG9ydENv bnN0cmFpbmVkVmlzaWJsZUNvbnRlbnRSZWN0KCk7CiAgICAgUmVuZGVyQm94TW9kZWxPYmplY3Qm IHJlbmRlcmVyID0gdG9SZW5kZXJCb3hNb2RlbE9iamVjdChsYXllci5yZW5kZXJlcigpKTsKIAog ICAgIFN0aWNreVBvc2l0aW9uVmlld3BvcnRDb25zdHJhaW50cyBjb25zdHJhaW50czsKLSAgICBy ZW5kZXJlci5jb21wdXRlU3RpY2t5UG9zaXRpb25Db25zdHJhaW50cyhjb25zdHJhaW50cywgdmll d3BvcnRSZWN0KTsKKyAgICByZW5kZXJlci5jb21wdXRlU3RpY2t5UG9zaXRpb25Db25zdHJhaW50 cyhjb25zdHJhaW50cywgcmVuZGVyZXIuY29uc3RyYWluaW5nUmVjdEZvclN0aWNreVBvc2l0aW9u KCkpOwogCiAgICAgR3JhcGhpY3NMYXllciogZ3JhcGhpY3NMYXllciA9IGxheWVyLmJhY2tpbmco KS0+Z3JhcGhpY3NMYXllcigpOwogCg==