133327 2014-05-27 15:56:55 -0700 run web timing tests 2014-05-27 16:34:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen webkit-unassigned rniwa oldest_to_newest 1012083 0 achristensen 2014-05-27 15:56:55 -0700 We should run the web timing tests if web timing is enabled. 1012087 1 232158 achristensen 2014-05-27 16:00:40 -0700 Created attachment 232158 Patch 1012088 2 232158 rniwa 2014-05-27 16:18:56 -0700 Comment on attachment 232158 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232158&action=review > LayoutTests/fast/dom/script-tests/webtiming-document-open.js:34 > + for (var key in timing) { > + keys.push(key); > + } No curly brackets for single line statements. > LayoutTests/fast/dom/script-tests/webtiming-navigate-within-document.js:11 > + for (var property in timing) { > + properties.push(property); > + } Ditto. > LayoutTests/platform/mac/TestExpectations:193 > +# Resource Timing is not enabled. > +# https://bugs.webkit.org/show_bug.cgi?id=133321 > http/tests/w3c/webperf Shouldn't we also disable this on ML and Mavericks? 1012089 3 achristensen 2014-05-27 16:34:04 -0700 (In reply to comment #2) > (From update of attachment 232158 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232158&action=review > > > LayoutTests/fast/dom/script-tests/webtiming-document-open.js:34 > > + for (var key in timing) { > > + keys.push(key); > > + } > > No curly brackets for single line statements. Done. > > > LayoutTests/fast/dom/script-tests/webtiming-navigate-within-document.js:11 > > + for (var property in timing) { > > + properties.push(property); > > + } > > Ditto. Done. > > > LayoutTests/platform/mac/TestExpectations:193 > > +# Resource Timing is not enabled. > > +# https://bugs.webkit.org/show_bug.cgi?id=133321 > > http/tests/w3c/webperf > > Shouldn't we also disable this on ML and Mavericks? This needs to stay disabled until RESOURCE_TIMING is enabled and tested. http://trac.webkit.org/changeset/169403 232158 2014-05-27 16:00:40 -0700 2014-05-27 16:18:55 -0700 Patch bug-133327-20140527160015.patch text/plain 5596 achristensen SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE2OTQwMSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA1LTI3ICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUnVuIHdlYiB0aW1pbmcgdGVz dHMgaWYgd2ViIHRpbWluZyBpcyBlbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMzI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS9zY3JpcHQtdGVzdHMvd2VidGltaW5nLWRv Y3VtZW50LW9wZW4uanM6CisgICAgICAgIChmaW5pc2hUZXN0KToKKyAgICAgICAgKiBmYXN0L2Rv bS9zY3JpcHQtdGVzdHMvd2VidGltaW5nLW5hdmlnYXRlLXdpdGhpbi1kb2N1bWVudC5qczoKKyAg ICAgICAgKGNoZWNrVGltaW5nTm90Q2hhbmdlZCk6CisgICAgICAgIFVzZSBmb3IgaW4gbG9vcCBp bnN0ZWFkIG9mIE9iamVjdC5rZXlzIGJlY2F1c2UgcHJvcGVydGllcyBhcmUgaW4gcHJvdG90eXBl IGNoYWluLgorICAgICAgICAqIGZhc3QvZG9tL3NjcmlwdC10ZXN0cy93ZWJ0aW1pbmcuanM6Cisg ICAgICAgIFVzZSBwZXJmb3JtYW5jZS5ub3cgaW5zdGVhZCBvZiAwLgorICAgICAgICAqIHBsYXRm b3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICBNYWRlIHdlYiB0aW1pbmcgdGVzdHMg c2tpcHBlZCBvbiBNb3VudGFpbiBMaW9uIGFuZCBNYXZlcmlja3MuCisKIDIwMTQtMDUtMjcgIE15 bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBMaXN0cyBz dHlsZWQgd2l0aCBTVkcgZm9udHMgYXJlIG5vdCByZW5kZXJlZCBhcyBleHBlY3RlZApJbmRleDog TGF5b3V0VGVzdHMvZmFzdC9kb20vc2NyaXB0LXRlc3RzL3dlYnRpbWluZy1kb2N1bWVudC1vcGVu LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL3NjcmlwdC10ZXN0cy93ZWJ0 aW1pbmctZG9jdW1lbnQtb3Blbi5qcwkocmV2aXNpb24gMTY5Mzg5KQorKysgTGF5b3V0VGVzdHMv ZmFzdC9kb20vc2NyaXB0LXRlc3RzL3dlYnRpbWluZy1kb2N1bWVudC1vcGVuLmpzCSh3b3JraW5n IGNvcHkpCkBAIC0yOCw3ICsyOCwxMiBAQCBmdW5jdGlvbiB0ZXN0VGltaW5nV2l0aERvY3VtZW50 T3BlbigpCiB9CiAKIGZ1bmN0aW9uIGZpbmlzaFRlc3QoKSB7Ci0gICAga2V5cyA9IE9iamVjdC5r ZXlzKHRpbWluZykuc29ydCgpOworICAgIHZhciBrZXlzID0gW107CisgICAgZm9yICh2YXIga2V5 IGluIHRpbWluZykgeworICAgICAgICBrZXlzLnB1c2goa2V5KTsKKyAgICB9CisgICAga2V5cy5z b3J0KCk7CisKICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGtleXMubGVuZ3RoOyArK2kpIHsKICAg ICAgICAgc2hvdWxkQmUoInRpbWluZy4iICsga2V5c1tpXSwgIm9yaWdpbmFsVGltaW5nLiIgKyBr ZXlzW2ldKTsKICAgICB9CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9zY3JpcHQtdGVzdHMv d2VidGltaW5nLW5hdmlnYXRlLXdpdGhpbi1kb2N1bWVudC5qcwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2RvbS9zY3JpcHQtdGVzdHMvd2VidGltaW5nLW5hdmlnYXRlLXdpdGhpbi1k b2N1bWVudC5qcwkocmV2aXNpb24gMTY5Mzg5KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vc2Ny aXB0LXRlc3RzL3dlYnRpbWluZy1uYXZpZ2F0ZS13aXRoaW4tZG9jdW1lbnQuanMJKHdvcmtpbmcg Y29weSkKQEAgLTUsNyArNSwxMSBAQCB2YXIgdGltaW5nID0gcGVyZm9ybWFuY2UudGltaW5nIHx8 IHt9OwogCiBmdW5jdGlvbiBjaGVja1RpbWluZ05vdENoYW5nZWQoKQogewotICAgIHByb3BlcnRp ZXMgPSBPYmplY3Qua2V5cyh0aW1pbmcpLnNvcnQoKTsKKyAgICB2YXIgcHJvcGVydGllcyA9IFtd OworICAgIGZvciAodmFyIHByb3BlcnR5IGluIHRpbWluZykgeworICAgICAgICBwcm9wZXJ0aWVz LnB1c2gocHJvcGVydHkpOworICAgIH0KKyAgICBwcm9wZXJ0aWVzLnNvcnQoKTsKICAgICBmb3Ig KHZhciBpID0gMDsgaSA8IHByb3BlcnRpZXMubGVuZ3RoOyArK2kpIHsKICAgICAgICAgcHJvcGVy dHkgPSBwcm9wZXJ0aWVzW2ldOwogICAgICAgICBpZiAodGltaW5nW3Byb3BlcnR5XSA9PT0gaW5p dGlhbFRpbWluZ1twcm9wZXJ0eV0pCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9zY3JpcHQt dGVzdHMvd2VidGltaW5nLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL3Nj cmlwdC10ZXN0cy93ZWJ0aW1pbmcuanMJKHJldmlzaW9uIDE2OTM4OSkKKysrIExheW91dFRlc3Rz L2Zhc3QvZG9tL3NjcmlwdC10ZXN0cy93ZWJ0aW1pbmcuanMJKHdvcmtpbmcgY29weSkKQEAgLTYs NyArNiw3IEBAIHZhciB0aW1pbmcgPSBwZXJmb3JtYW5jZS50aW1pbmcgfHwge307CiAKIC8vIEdl dCB0aGUgb3JkZXIgb2YgbWFnbml0dWRlIGNvcnJlY3Qgd2l0aG91dCBhIGNoYW5jZSBmb3IgZmxh a2luZXNzLgogdmFyIG9uZUhvdXJNaWxsaXNlY29uZHMgPSA2MCAqIDYwICogMTAwMDsKLXZhciBj dXJyZW50VVRDID0gMDsgIC8vIEZJWE1FOiBVc2UgcGVyZm9ybWFuY2Uubm93KCkgd2hlbiBhdmFp bGFibGUuCit2YXIgY3VycmVudFVUQyA9IHBlcmZvcm1hbmNlLm5vdygpOwogdmFyIG9uZUhvdXJB Z29VVEMgPSBjdXJyZW50VVRDIC0gb25lSG91ck1pbGxpc2Vjb25kczsKIAogZnVuY3Rpb24gc2xl ZXBGaWZ0eU1pbGxpc2Vjb25kcygpIHsKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxNjkzODkpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvVGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtMTg4LDIzICsxODgsOSBA QCBmYXN0L2ltYWdlcy9sYXJnZS1zaXplLWltYWdlLWNyYXNoLmh0bWwKICMgRGlyZWN0b3J5IHVw bG9hZCBpcyBub3QgZW5hYmxlZC4KIGZhc3QvZm9ybXMvZmlsZS9pbnB1dC1maWxlLWRpcmVjdG9y eS11cGxvYWQuaHRtbAogCi0jIFdlYiBUaW1pbmcgaXMgbm90IGVuYWJsZWQuCi0jIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQzNAotZmFzdC9kb20vV2luZG93L3dp bmRvdy1wcm9wZXJ0aWVzLXBlcmZvcm1hbmNlLmh0bWwKLWZhc3QvZG9tL1dpbmRvdy93ZWItdGlt aW5nLW1pbmltYWwtcGVyZm9ybWFuY2Utbm93Lmh0bWwKLWZhc3QvZG9tL25hdmlnYXRpb24tdHlw ZS1iYWNrLWZvcndhcmQuaHRtbAotZmFzdC9kb20vbmF2aWdhdGlvbi10eXBlLW5hdmlnYXRlLmh0 bWwKLWZhc3QvZG9tL25hdmlnYXRpb24tdHlwZS1yZWxvYWQuaHRtbAotZmFzdC9kb20vd2VidGlt aW5nLmh0bWwKLWZhc3QvZG9tL3dlYnRpbWluZy1kb2N1bWVudC1vcGVuLmh0bWwKLWZhc3QvZG9t L3dlYnRpbWluZy1uYXZpZ2F0ZS13aXRoaW4tZG9jdW1lbnQuaHRtbAotaHR0cC90ZXN0cy9taXNj L3dlYnRpbWluZy1vcmlnaW5zLmh0bWwKLWh0dHAvdGVzdHMvbWlzYy93ZWJ0aW1pbmctb25lLXJl ZGlyZWN0LnBocAotaHR0cC90ZXN0cy9taXNjL3dlYnRpbWluZy1zbG93LWxvYWQucGhwCi1odHRw L3Rlc3RzL21pc2Mvd2VidGltaW5nLXNzbC5waHAKLWh0dHAvdGVzdHMvbWlzYy93ZWJ0aW1pbmct dHdvLXJlZGlyZWN0cy5waHAKKyMgUmVzb3VyY2UgVGltaW5nIGlzIG5vdCBlbmFibGVkLgorIyBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMzIxCiBodHRwL3Rlc3Rz L3czYy93ZWJwZXJmCi1mYXN0L3BlcmZvcm1hbmNlLwogCiAjIENvbnRlbnQgU2VjdXJpdHkgUG9s aWN5IDEuMSAoRU5BQkxFX0NTUF9ORVhUKSBpcyBub3QgZW5hYmxlZAogd2Via2l0Lm9yZy9iLzg1 NTU4IGh0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5LzEuMQpAQCAtMTM3 MCwzICsxMzU2LDE4IEBAIHdlYmtpdC5vcmcvYi8xMzIzODUgY29tcG9zaXRpbmcvcmVwYWludC8K IHdlYmtpdC5vcmcvYi8xMzI0OTEgWyBNb3VudGFpbkxpb24gXSBodHRwL3Rlc3RzL21lZGlhL2hs cy92aWRlby1jb250cm9scy1saXZlLXN0cmVhbS5odG1sIFsgV29udEZpeCBdCiAKIFsgTW91bnRh aW5MaW9uIE1hdmVyaWNrcyBdIG1lZGlhL21lZGlhLXNvdXJjZSBbIFdvbnRGaXggXQorCisjIE1h dmVyaWNrcyBhbmQgcHJpb3IgZG8gbm90IHN1cHBvcnQgd2ViIHRpbWluZy4KK1sgTW91bnRhaW5M aW9uIE1hdmVyaWNrcyBdIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydGllcy1wZXJmb3Jt YW5jZS5odG1sIFsgU2tpcCBdCitbIE1vdW50YWluTGlvbiBNYXZlcmlja3MgXSBmYXN0L2RvbS9X aW5kb3cvd2ViLXRpbWluZy1taW5pbWFsLXBlcmZvcm1hbmNlLW5vdy5odG1sIFsgU2tpcCBdCitb IE1vdW50YWluTGlvbiBNYXZlcmlja3MgXSBmYXN0L2RvbS9uYXZpZ2F0aW9uLXR5cGUtYmFjay1m b3J3YXJkLmh0bWwgWyBTa2lwIF0KK1sgTW91bnRhaW5MaW9uIE1hdmVyaWNrcyBdIGZhc3QvZG9t L25hdmlnYXRpb24tdHlwZS1uYXZpZ2F0ZS5odG1sIFsgU2tpcCBdCitbIE1vdW50YWluTGlvbiBN YXZlcmlja3MgXSBmYXN0L2RvbS9uYXZpZ2F0aW9uLXR5cGUtcmVsb2FkLmh0bWwgWyBTa2lwIF0K K1sgTW91bnRhaW5MaW9uIE1hdmVyaWNrcyBdIGZhc3QvZG9tL3dlYnRpbWluZy5odG1sIFsgU2tp cCBdCitbIE1vdW50YWluTGlvbiBNYXZlcmlja3MgXSBmYXN0L2RvbS93ZWJ0aW1pbmctZG9jdW1l bnQtb3Blbi5odG1sIFsgU2tpcCBdCitbIE1vdW50YWluTGlvbiBNYXZlcmlja3MgXSBmYXN0L2Rv bS93ZWJ0aW1pbmctbmF2aWdhdGUtd2l0aGluLWRvY3VtZW50Lmh0bWwgWyBTa2lwIF0KK1sgTW91 bnRhaW5MaW9uIE1hdmVyaWNrcyBdIGh0dHAvdGVzdHMvbWlzYy93ZWJ0aW1pbmctb3JpZ2lucy5o dG1sIFsgU2tpcCBdCitbIE1vdW50YWluTGlvbiBNYXZlcmlja3MgXSBodHRwL3Rlc3RzL21pc2Mv d2VidGltaW5nLW9uZS1yZWRpcmVjdC5waHAgWyBTa2lwIF0KK1sgTW91bnRhaW5MaW9uIE1hdmVy aWNrcyBdIGh0dHAvdGVzdHMvbWlzYy93ZWJ0aW1pbmctc2xvdy1sb2FkLnBocCBbIFNraXAgXQor WyBNb3VudGFpbkxpb24gTWF2ZXJpY2tzIF0gaHR0cC90ZXN0cy9taXNjL3dlYnRpbWluZy1zc2wu cGhwIFsgU2tpcCBdCitbIE1vdW50YWluTGlvbiBNYXZlcmlja3MgXSBmYXN0L3BlcmZvcm1hbmNl IFsgU2tpcCBdCg==