133297 2014-05-26 21:38:32 -0700 Fix test failures on python test 2014-05-26 23:47:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue glenn oldest_to_newest 1011879 0 gyuyoung.kim 2014-05-26 21:38:32 -0700 There are 2 fails on python test because of unbounded local variable reference as below, [1214/1422] webkitpy.w3c.test_importer_unittest.TestImporterTest.test_import_dir_with_no_tests_and_no_hg erred: Traceback (most recent call last): File "/home/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py", line 62, in test_import_dir_with_no_tests_and_no_hg importer.do_import() File "/home/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Tools/Scripts/webkitpy/w3c/test_importer.py", line 197, in do_import self.import_tests() File "/home/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Tools/Scripts/webkitpy/w3c/test_importer.py", line 377, in import_tests if len(failed_conversion_files): UnboundLocalError: local variable 'failed_conversion_files' referenced before assignment 1011880 1 232109 gyuyoung.kim 2014-05-26 21:41:11 -0700 Created attachment 232109 Patch 1011885 2 232109 krit 2014-05-26 22:36:33 -0700 Comment on attachment 232109 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232109&action=review > Tools/ChangeLog:8 > + 2 tests are failed because of unbounded local variable reference in test_importer.py. s/failed/failing/ or the other way around and remove "are". 1011886 3 gyuyoung.kim 2014-05-26 22:39:11 -0700 Committed r169369: <http://trac.webkit.org/changeset/169369> 1011887 4 gyuyoung.kim 2014-05-26 22:39:54 -0700 (In reply to comment #2) > (From update of attachment 232109 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232109&action=review > > > Tools/ChangeLog:8 > > + 2 tests are failed because of unbounded local variable reference in test_importer.py. > > s/failed/failing/ or the other way around and remove "are". Patch is landed after fixing it. Thanks. 1011895 5 gyuyoung.kim 2014-05-26 23:47:35 -0700 For the record, this problem came from http://trac.webkit.org/changeset/169347. 232109 2014-05-26 21:41:11 -0700 2014-05-26 22:36:32 -0700 Patch bug-133297-20140527134047.patch text/plain 1723 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MzY1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTE2ZjdmNzQyNGY3ZTIwMjAwNDdhNTJhZTZiOGJkOWNi MTA5YjBlOS4uYTM2NjY4OTE0YTJhNGM2YTBkMWJkNWM4NjVmMGEwOGMxYjdjMzg1YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTA1LTI2ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+ CisKKyAgICAgICAgRml4IHRlc3QgZmFpbHVyZXMgb24gcHl0aG9uIHRlc3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzI5NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIDIgdGVzdHMgYXJlIGZhaWxlZCBi ZWNhdXNlIG9mIHVuYm91bmRlZCBsb2NhbCB2YXJpYWJsZSByZWZlcmVuY2UgaW4gdGVzdF9pbXBv cnRlci5weS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIu cHk6IE1vdmUgbG9jYWwgdmFyaWFibGUgZGVjbGFyYXRpb24gdG8gdG9wLgorICAgICAgICAoVGVz dEltcG9ydGVyLmltcG9ydF90ZXN0cyk6CisKIDIwMTQtMDUtMjYgIENhcmxvcyBBbGJlcnRvIExv cGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gR09iamVjdCBE T00gYmluZGluZ3MgQVBJIGJyZWFrIHRlc3QgZmFpbHMgaW4gdGhlIHRlc3RzIGJvdHMKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2ltcG9ydGVyLnB5CmluZGV4IDFlMzgzYTllZDQy NjI5OTdmYWVkYmU5MWYxMWJlZWI1MTMyOWIzYWQuLjc0ZGZiMzYxMzliYmVkOGNiOGJiMTQ5MDcx MDg1YTgyOGZkOTU1ZGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rl c3RfaW1wb3J0ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9pbXBv cnRlci5weQpAQCAtMjkxLDYgKzI5MSw4IEBAIGNsYXNzIFRlc3RJbXBvcnRlcihvYmplY3QpOgog ICAgICAgICB0b3RhbF9pbXBvcnRlZF9qc3Rlc3RzID0gMAogICAgICAgICB0b3RhbF9wcmVmaXhl ZF9wcm9wZXJ0aWVzID0ge30KIAorICAgICAgICBmYWlsZWRfY29udmVyc2lvbl9maWxlcyA9IFtd CisKICAgICAgICAgZm9yIGRpcl90b19jb3B5IGluIHNlbGYuaW1wb3J0X2xpc3Q6CiAgICAgICAg ICAgICB0b3RhbF9pbXBvcnRlZF90ZXN0cyArPSBkaXJfdG9fY29weVsndG90YWxfdGVzdHMnXQog ICAgICAgICAgICAgdG90YWxfaW1wb3J0ZWRfcmVmdGVzdHMgKz0gZGlyX3RvX2NvcHlbJ3JlZnRl c3RzJ10KQEAgLTMxMCw3ICszMTIsNiBAQCBjbGFzcyBUZXN0SW1wb3J0ZXIob2JqZWN0KToKICAg ICAgICAgICAgICAgICBvcy5tYWtlZGlycyhuZXdfcGF0aCkKIAogICAgICAgICAgICAgY29waWVk X2ZpbGVzID0gW10KLSAgICAgICAgICAgIGZhaWxlZF9jb252ZXJzaW9uX2ZpbGVzID0gW10KIAog ICAgICAgICAgICAgZm9yIGZpbGVfdG9fY29weSBpbiBkaXJfdG9fY29weVsnY29weV9saXN0J106 CiAgICAgICAgICAgICAgICAgIyBGSVhNRTogU3BsaXQgdGhpcyBibG9jayBpbnRvIGEgc2VwYXJh dGUgZnVuY3Rpb24uCg==